485ccba189
Fixes #5323 : Show a snackbar while browsing data is deleting. ( #6105 )
2019-10-21 09:57:06 -07:00
9995199caa
fixed alignment of open tabs header for RTL languages ( #6138 )
2019-10-21 09:53:21 -07:00
b785fc41bf
Import l10n.
2019-10-19 17:40:27 +00:00
b963a3eab5
Merge #6102 #6106
...
6102: For #6018 Re-add Search Shortcuts Button r=boek a=BranescuMihai
6106: For #5872 & #6075 : Set TabHeader buttons to invisible instead of gone. r=boek a=mcarare
At least one button has to be invisible instead of gone to keep layout height.
Tabs overflow button kept gone to avoid empty space on view end in private mode.
Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com>
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-18 18:59:20 +00:00
6b1bfcc079
For #6100 : Mirror ETP graphic in RTL
2019-10-18 15:24:49 +03:00
2be4d08228
For #6018 - Added back shortcuts button in awesomebar
...
Refactored logic for adding providers, since shortcut providers should
be alone in the list, while all others can be as list
2019-10-18 14:48:58 +03:00
aa1a5f3d32
Merge #6026
...
6026: For #5709 : Align ETP onboarding popup implementation with original mocks r=ekager a=mcarare
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-16 17:49:16 +00:00
b82a794908
For #5709 : Align ETP onboarding popup implementation with original mocks
2019-10-15 17:07:47 +03:00
1490c0178f
For #5749 - Update string for ETP onboarding popup
2019-10-15 15:56:59 +03:00
e1d05f55fc
Merge #5949
...
5949: Import strings from android-l10n r=liuche a=mozilla-l10n-automation-bot
n/t
Co-authored-by: Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
2019-10-15 03:53:27 +00:00
b1dcc69e52
For #5709 : Align ETP Settings Screen implementation with original mocks
2019-10-14 15:59:43 +03:00
f189636c90
Import l10n.
2019-10-13 20:01:13 +00:00
bb22fb3092
Merge #5507 #5846
...
5507: For #1383 Added tab title to close button content description r=ekager a=mcarare
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
5846: For #3604 Snackbar messages for closing tabs use closed instead of deleted r=sblatz a=mcarare
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-11 16:28:36 +00:00
f66b9f3e8f
Merge #5633
...
5633: Add fxa/sync integration tests r=csadilek a=isabelrios
Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [-] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [-] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
This PR tries to add new tests, sync integration tests, to check the sync process Desktop<->Fenix, first for Bookmarks and in the future for more.
Co-authored-by: Isabel Rios <isabelrios@mackbookirios.home>
Co-authored-by: isabelrios <isabelrios@gmail.com>
2019-10-11 14:43:39 +00:00
8cf54f773b
Merge #5882
...
5882: For #5873 Added on/off indicator for delete browsing data on exit pref r=sblatz a=mcarare
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-11 13:22:33 +00:00
5a73d2f6c5
Import l10n.
2019-10-10 22:54:54 -07:00
b0d796ccee
For #5898 : Default browser toggle sends user to SUMO on Android 5&6 ( #5918 )
2019-10-10 11:16:21 -07:00
788e52be0c
For #5873 Added on/off indicator for delete browsing data on exit pref
2019-10-09 11:55:37 +03:00
a9cfc83154
Import l10n.
2019-10-08 21:38:24 -07:00
78bc829735
Closes #778 - Progressive Web Apps! ( #4914 )
2019-10-08 16:50:15 -07:00
1c6aefd82b
For #3604 Snackbar messages for closing tabs use closed instead of deleted
2019-10-08 17:06:02 +03:00
18a130b38e
For #5798 : Fix info icon pixelation ( #5841 )
2019-10-08 09:30:32 -04:00
44f4cedefd
Add fxa/sync integration tests
...
fixing Jenkins path to tests and clean tests
commenting future tests and adding doc with info about the tests
2019-10-08 09:56:29 +02:00
31ae5709c2
Closes #5573 : fix radio-button spacing in settings
2019-10-07 13:07:53 -07:00
d5c3433041
Use the new fragment constructor
2019-10-07 11:07:48 -07:00
f4be12227f
Fix the incognito icon looks out of place/misaligned
2019-10-07 10:15:11 -07:00
d028c97112
For #5213 - Use support library attributes
2019-10-06 16:17:00 -07:00
371e2ac3d8
For #514 & #5742 : Updates "launch links in private tab" functionality ( #5721 )
...
* For #514 & #5742 : Updates "launch links in private tab" functionality
* Fixes comments
2019-10-03 12:43:33 -07:00
4a0917ba32
Fix too much space under the address bar
2019-10-03 11:30:03 -07:00
097d7c2038
For #5742 : Adds strings ( #5743 )
2019-10-03 09:32:50 -07:00
785b8b9519
For #5567 : Removes search shortcuts button ( #5739 )
...
* For #5567 : Removes search shortcut button
* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
2896b36d14
No issue: Updates naming of launch links privately var ( #5701 )
...
The previous name was pretty confusing
2019-10-02 12:11:21 -07:00
eb3c9f86e2
No issue: Removes feature flags for delete data ( #5738 )
2019-10-02 10:43:37 -07:00
2f0d8d8243
For #5712 : Updates text color for fill link from clipboard
2019-10-01 16:29:39 -07:00
214ca421f7
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@10559d774c
2019-09-30 16:10:08 -07:00
c8af16bd47
For #5679 : Hides autoplay behind feature flag ( #5685 )
2019-09-30 12:01:04 -07:00
a4097cd380
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-30 10:33:56 -07:00
64923978e6
For #1071 Added Desktop Mode icon
2019-09-27 09:47:10 -07:00
7f328a6dc4
For #1298 : Adds adjustCampaignId to core ping ( #5579 )
2019-09-27 08:56:33 -07:00
5e8798e89c
Issue #4513 : add ProgressBar to bookmark component layout
2019-09-26 16:29:14 -07:00
de93b05cac
For #2754 Add tab cards to share sheet ( #5493 )
...
* For #2754 Add tab cards to share sheet
* For #2754 : Fix background near rounded corners and ShareButtonAppearanceTest
* Add license to share_tab_item
2019-09-26 14:25:34 -07:00
c5330c6880
For 5092 - Show a Snackbar with retry option if sharing to devices fails ( #5158 )
...
* For #5092 - Show a Snackbar with retry option if sharing to devices fails
ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.
* For #5092 - Refactor ShareControllerTest
* For #5092 : Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
59e2c124cb
No issue: Update long-press shortcut strings ( #5284 )
...
* No issue: Update long-press shortcut strings
* Updates identifiers
2019-09-26 11:57:37 -07:00
b0b60aa27d
For #5281 - Use TrackerLog for reporting ETP categories ( #5556 )
2019-09-25 10:48:06 -07:00
b6e6e36ccd
For #561 : Fix stutter of search icon & text when animating
2019-09-25 10:06:38 -07:00
32c506121e
For #561 - Fixes visual inconsistencies with the search bar
2019-09-25 10:06:38 -07:00
5c092c1ef1
For #561 - Adds shadow/highlightto the bottom bar
2019-09-25 10:06:38 -07:00
b16754d78a
For #561 - Adds add tab and menu button to bottom bar
...
- Adds space between wordmark and session control component
2019-09-25 10:06:38 -07:00
abbb310ce3
For #561 - Removes the toolbar from the home screen
...
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
2019-09-25 10:06:38 -07:00
2829235651
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@97355ffcdc
2019-09-25 09:02:42 -07:00
bfe8bf4663
For #1383 Added tab title to close button content description
2019-09-25 10:34:02 +03:00
25e2a7abfc
For #2765 - Run places maintenance daily ( #5466 )
2019-09-24 10:50:11 -07:00
c7c752cabb
For #5356 Improves private browsing "common myths" link accessibility ( #5479 )
...
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
2019-09-24 10:46:34 -07:00
7c55aff1be
Import strings from android-l10n ( #5482 )
...
State: mozilla-l10n/android-l10n@d10506f569
2019-09-23 19:53:57 -07:00
72eed21bfc
For https://github.com/mozilla-mobile/fenix/issues/5474 - Adapt Autoplay icon to theme
2019-09-23 08:56:09 -07:00
f02603be37
For #5460 : Fixes styling of fill link from clipboard ( #5464 )
2019-09-20 15:29:16 -07:00
77ce658033
For #5383 Refactored ETP layout to keep appearance for larger font size.
...
Added paddingTop to layout to maintain similar space above title.
Added image's bottom colour as background color to fill space below image.
Refactored TextViews alignment to chain.
Changed guideline to percent instead of dp for wider screens including tablets.
2019-09-20 14:01:30 -07:00
6c30a94081
Move settings classes to packages
2019-09-20 12:36:15 -07:00
47064a68e0
For #5141 Changed "learn more" link to be accessible to Talkback users
2019-09-20 12:29:02 -07:00
172a9cf06c
Extract and test crash reporter code
2019-09-20 11:04:11 -07:00
95a7aa9223
For #4526 Prevent automatic theme summary being cutoff with long text
2019-09-20 09:20:57 -07:00
6f3d7b4ee8
For #5396 : Adds "always launch in private mode" to settings
2019-09-20 08:33:07 -07:00
9591172ee9
No issue: Make Shortcut dialog buttons match other dialogs
2019-09-20 08:04:55 -07:00
1aa4f5a519
For #255 : Toggle Media Autoplay
2019-09-19 15:13:04 -07:00
e961a9d63d
For #1744 : Adds clipboard provider to search engine screen
2019-09-19 08:24:27 -07:00
976c840047
For #3077 - Replaces connect another device dialog with a scree
2019-09-18 17:24:43 -07:00
956f4f0534
For #5411 : Fixes delete button turning red ( #5412 )
2019-09-18 15:20:05 -07:00
50cd2920d3
For #5371 : Updates search engine settings string ( #5393 )
2019-09-18 11:26:44 -07:00
a68fabd3a7
For #1749 - Update to new ETP Settings Strings ( #5395 )
2019-09-18 10:36:09 -07:00
95e4f2d754
No issue: Land strings for login management
2019-09-18 08:06:20 -07:00
c2fb99a73f
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-16 19:44:13 -07:00
7214f40008
For #5368 - Make every blocking category gone by default
2019-09-16 15:01:29 -07:00
140da0dd0f
For #5359 , #5360 - Update ETP Vectors for Android 5+6
2019-09-16 15:01:29 -07:00
0eca317d03
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@f0d82028ce
2019-09-16 12:54:44 -07:00
b6f2e8da35
For #5296 : Fix long-press shortcuts to work across build variants
2019-09-16 12:31:20 -07:00
90ef5ec9bb
Closes #5338 - Use padding instead of margin for delete browsing item
2019-09-15 19:46:50 -07:00
8cd0d8faf3
For #5304 - Align ETP Onboarding Tool Tip PopupWindow
2019-09-13 18:25:26 -07:00
8a371191b7
Import strings from android-l10n ( #5300 )
...
State: mozilla-l10n/android-l10n@e78d5868c7
2019-09-13 12:15:08 -07:00
e247870b9f
For #5277 : Updates string for delete browsing data ( #5309 )
2019-09-13 10:18:25 -07:00
93ba506722
No issue: Slightly changes margin on play/pause button
2019-09-12 13:37:49 -07:00
f698bdfcb5
For #5270 - Adds state list color for delete browsing checkboxes
2019-09-12 13:27:27 -07:00
96f0ec829b
No issue: Remove recommended from standard ETP option
2019-09-12 12:34:28 -07:00
0d1c19d017
For #3106 : Improve granular data deletion margins
2019-09-12 10:25:14 -07:00
bc16061939
For #3371 : Show snackbar message when share fails with crash ( #5210 )
2019-09-12 09:26:24 -07:00
4461230e9b
For #5229 , #5228 - Dismiss ETP panel on back press, don't truncate text
2019-09-12 07:40:49 -07:00
a5859e0028
For #5178 - Polish delete browsing data item layout
2019-09-11 18:11:26 -07:00
80d8c76453
No issue: Land new ETP Strings
2019-09-11 16:11:42 -07:00
e092dfd684
For #5047 - Addresses nits
...
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
2019-09-11 16:10:54 -07:00
d18ec49704
For #5047 - Wires up dialog to webAppUseCases
2019-09-11 16:10:54 -07:00
faff73b9b3
For #5047 - Creates dialog ui for naming a shortcut
2019-09-11 16:10:54 -07:00
e3209dcc84
For #3700 - Add Setting to Delete Data on "Quit" menu action
2019-09-11 16:06:18 -07:00
418b1ba890
For #1749 - Use Strict ETP by default, use Feature Flag for Settings
2019-09-11 16:03:01 -07:00
999d3cb963
For #1114 : Show playing tab
2019-09-11 15:45:22 -07:00
bafbea1512
No issue: Set color for toolbar divider ( #5221 )
2019-09-11 11:46:00 -07:00
9a4610f068
For #2897 - Add Action States To Share Sheet
2019-09-11 11:32:26 -07:00
2e2bac4ccd
For #419 : Create launch icon for private browsing ( #4948 )
2019-09-11 10:52:33 -07:00
53b3f105ca
For #4155 : Sets pastedText default value
2019-09-11 09:03:17 -07:00
9d30d7bb03
For #4155 : Restyle to custom menu
2019-09-11 09:03:17 -07:00
52fd327bc0
For #4155 : Adds tests for browser toolbar popup menu
2019-09-11 09:03:17 -07:00
fdd2b59fb8
For #4155 : Adds popup menu for browser toolbar
2019-09-11 09:03:17 -07:00
4485b7f647
Add Tracking Protection Info Panel
2019-09-11 07:47:13 -07:00
9dd9400600
For #5178 - Do not truncate delete browsing text
2019-09-10 10:44:14 -07:00
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
2019-09-10 09:04:05 -07:00
8d363d68b1
For #4517 : Keep Bookmarks fragment when navigating to browser
...
Removed popUp when navigating from bookmarks to browser
2019-09-09 20:52:36 -07:00
2b9efccfca
For #3106 : Granular options for clearing user data
2019-09-09 12:32:28 -07:00
b86a32fa17
No issue: Top aligns close button for tab in collection ( #5161 )
...
See https://github.com/mozilla-mobile/fenix/pull/4442#issuecomment-528580904 for more info
2019-09-09 11:08:30 -07:00
ed0b6bd5ef
For #4193 - Makes close button for tabs more accessible ( #4442 )
...
* fixes #4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
2019-09-06 10:33:55 -07:00
c8d622c43d
For #5142 Removed RadioButton from accessibility keeping one option for Talkback
...
Set android:importantForAccessibility = "no" for RadioButton
2019-09-06 14:09:58 +02:00
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
23095ae274
For #4155 : Adds strings for long press popup ( #5112 )
2019-09-04 17:15:06 -07:00
fd1c512b2e
No issue: Land strings for delete browsing data on quit
2019-09-04 15:45:10 -07:00
fba37ee6e6
For #419 : Add strings for "Add private browsing shortcut" feature ( #5109 )
2019-09-04 15:44:22 -07:00
c9a8eae031
For i5047 - Adds strings for the add to homescreen dialog
2019-09-04 15:18:44 -07:00
2e544145b7
For #5095 : Changed search engine text color from default to ?primaryText
2019-09-04 07:57:17 -07:00
0fc42a8a09
For #4892 : Replaced straight single quote with curly apostrophe in contractions
2019-09-04 14:10:05 +02:00
0bddeb4da5
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@6d2fe8331a
2019-09-04 14:08:15 +02:00
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
fc8fc2b33d
Fixes #4997 : Changed navigation to ShareFragment
...
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
2019-09-03 07:08:08 -10:00
095870145f
For #4007 - Refactor AppShareView in standalone Share Views
...
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
2019-08-29 18:12:50 -07:00
5e19741ddd
For #4007 - Use camelCase for views referenced from code
...
As per #4341 .
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
2019-08-29 18:12:50 -07:00
9b911f3276
Fixes #4894 : added workaround for SDK<24 vector drawable with gradient color ( #4944 )
...
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
2019-08-29 12:55:51 -07:00
f740d4382a
Closes #773 - Add shortcuts to homescreen ( #4925 )
2019-08-29 14:45:11 -05:00
cc5408d717
For #2053 : Add persistent notification to close all private browsing tabs ( #4913 )
2019-08-28 12:55:24 -07:00
bcabe422a6
Closes #4718 - Update site permissions layout ( #4953 )
2019-08-27 14:07:51 -07:00
1cf8a40059
For #4295 - Adds Experiments Pref to Data Collection Settings ( #4915 )
2019-08-27 12:56:16 -07:00
594569164d
Fixes #4211 changed SeekBar height to wrap_content to prevent misaligned dot ( #4832 )
...
Changed height from match_constrained to wrap_content.
2019-08-27 12:50:00 -07:00
5d13c53706
Fixes #4440 changed padding for account_preference ( #4830 )
...
Changed padding to default value in @android:style/Preference.Material.Category.
Also changed paddingEnd value to default value.
2019-08-27 10:26:32 -07:00
dc9fdd9db3
Fixes #4067 besides snackbar ( #4777 )
...
* Fixes #4067 besides snackbar
Makes layout hierarchy more shallow to increase performance.
* Fix #4067 Feedback
Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
2019-08-27 10:09:55 -07:00
1621229a7f
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@349efdbc8f
2019-08-27 08:22:42 -07:00
66e14959ba
Add custom tab fragment
2019-08-23 16:12:19 -04:00
b07df9698a
For #4868 - Update content description of tabs button with number of tabs
2019-08-23 09:21:32 -07:00
c236c3e34c
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@90a28fd458
2019-08-23 14:36:01 +02:00
44421392bf
Adds experiments preferences strings
2019-08-21 19:55:26 -07:00
a6483c528b
No issue: Land strings for Delete Browsing Data on Quit
2019-08-21 19:55:26 -07:00
1b2757be98
No issue: Land new string for delete browsing data prompt ( #4859 )
2019-08-21 11:17:34 -07:00
aab357845b
No issue: Clean up preferences code ( #4699 )
2019-08-21 08:38:14 -07:00
aa4ed36e46
No issue: Land new strings for ETP and delete browsing data
2019-08-21 10:59:12 +02:00
26c9d5d297
For #2834 : Add contentDescription to tabs button icons
2019-08-20 16:34:05 -07:00
6f899c7fb5
For #2834 : Delete all Private Tabs redesign ( #4787 )
2019-08-20 13:10:08 -07:00
115833c78a
Update strings.xml
...
Remove space in placeholder for es (temp for release)
2019-08-19 19:14:22 -07:00
5e444eccff
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@413e05dba4
2019-08-19 19:14:22 -07:00
a632d8f1dc
For #4744 - Move search bar icon padding to dimens ( #4814 )
2019-08-19 16:22:51 -07:00
bf42abb21c
fixes #4179 removed control highlight from disconnect button ( #4806 )
...
set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
2019-08-19 16:16:06 -07:00
73e3db8fe0
For #4804 : Resolves issue with crash reporter stack
2019-08-19 16:40:41 -04:00
727457f0ed
No issue: fixes click failures on search widget icon
2019-08-16 13:58:29 -07:00
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
3f820366a6
Closes #4680 - Align collection creation text center vertical
2019-08-14 20:17:01 -04:00
a680d733c8
For #4384 : Hide mic icon if speech-to-text is unavailable ( #4701 )
2019-08-14 16:40:21 -07:00
2441592ef2
For #4516 : Use full width for large search widgets ( #4659 )
2019-08-14 16:00:13 -07:00
b7ca520787
For #4421 : Adds Leanplum events and attributes ( #4626 )
...
* For #4421 : Adds Leanplum events and attributes
* For #4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
67f3b63ae5
For #4421 : Add search widget attribute to Leanplum ( #4694 )
2019-08-14 12:00:29 -07:00
1a4ef1535c
For #4434 - made close button for collections more accessible. ( #4443 )
...
* fixes #4434 - made close button for collections more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for #4193 - close button for tabs
* fixes #4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button
set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
2019-08-14 10:12:39 -07:00
5b4a441bcb
For #1667 : Screen reader can't reach other UI items when QAB expanded ( #4695 )
2019-08-14 09:56:29 -07:00
337ad1e88e
For #3424 - Make talkback ignore ImageButton in Collection Sele… ( #3792 )
...
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
2019-08-12 11:49:25 -04:00
faf0ecbcc0
For #4125 : Migrate Sign in to Sync to Libstate
2019-08-09 13:39:51 -07:00
65de521ccf
Import strings from android-l10n ( #4643 )
...
State: mozilla-l10n/android-l10n@ab580f757c
2019-08-09 14:55:05 -05:00
23f5ac0fb9
For #4066 : Create InflationAwareFeature for lazy inflation
2019-08-09 11:48:55 -04:00
519c3bde5d
For #4066 : Provide lazy inflation of Find In Page View
2019-08-09 11:48:55 -04:00
63d50d9827
Fixes #4323 : Modified UI of component_collection_creation.
...
To fix the overlapping issue I used Guideline and
layout_constraintWidth_default property. I also used the
layout_constraintHorizontal_bias property to make the back_button to
lean to the left and the select_all_button to lean to the right.
2019-08-08 12:57:19 -07:00
4566bd6fba
Fixes feedback
2019-08-07 16:41:29 -07:00
8698ade699
Minify the fenix
2019-08-07 14:24:32 -07:00
a514cb3f8c
No issue: Add OSS licenses link to About page
2019-08-07 12:40:10 -07:00
cf169da2fc
For #4557 #3860 - Add string for collection empty state
2019-08-06 21:36:54 -07:00
0604e9858d
Closes #3939 - Adds strings for delete browsing history
2019-08-06 16:06:56 -07:00
b20c381af9
For #1749 - Land ETP Strings
2019-08-06 14:55:47 -07:00
0320efee84
No issue: Removes focusableInTouchMode from home searchbar view
2019-08-05 15:42:21 -07:00
6f962d3376
For #1744 : Open search shortcuts when entering search mode ( #4536 )
2019-08-05 15:07:03 -07:00
6f7ae227a8
Closes #4540 - Set correct tint for select bookmark folder icon ( #4541 )
2019-08-05 14:54:39 -07:00
ad448b37ae
Closes #4537 - Adds description for onboarding placeholder string ( #4542 )
2019-08-05 14:51:11 -07:00
5edc9d0b4e
For #2021 - Update custom preferences' views with email/account changes
2019-08-05 09:53:27 -07:00
a526e0fad3
For #4455 - Rename history headers by hours and days ( #4478 )
2019-08-05 11:12:22 -05:00
d0071d0177
For #4495 - Clean up homescreen toolbar focus and content descriptions
2019-08-05 08:58:03 -07:00
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
6e2ea0750e
Issue #2379 - Use LibrarySiteItemView in history
2019-08-02 17:15:41 -07:00
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
2019-08-02 17:09:24 -07:00
3a262a429b
For #3907 : Hide 'Go back' button for bad websites from new tabs
2019-08-02 17:00:48 -07:00
015922ddd2
No issue: Fix Crash lower API by setting gradient drawables in onBind
2019-08-02 16:18:34 -07:00
79160255c8
No issue: Just use TextView, not AppCompatTextView
2019-08-02 13:23:55 -07:00
83ceec6289
For #201 : Search Widget
2019-08-02 11:26:48 -07:00
29f089c414
For #2203 : Polishes BrowserToolbarMenu
2019-08-02 13:40:50 -04:00
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
ae33234bbc
Closes #2593 : FxA automatic sign-in integration
2019-08-01 17:03:45 -07:00
ccae66c08a
Issue #2379 - Use LibraryPageView in history
2019-08-01 15:59:55 -04:00
fa8199f429
fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small
...
changed size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
2019-07-31 14:42:43 -07:00
30ecbc6000
fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small
...
changes size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
2019-07-31 14:42:43 -07:00
4494e40dbc
For #4137 - Adds pagination to the history view
2019-07-31 14:35:33 -07:00
95208c84a9
Closes #4265 - Do not pop after all exceptions are removed ( #4392 )
2019-07-31 11:43:15 -07:00
093b76593d
Closes #3419 : Use better accessibility strings for tab collections
2019-07-30 16:37:49 -04:00
3fb20aea6a
Closes #4040 - Remove NestedScrollView from Bookmark Layout
2019-07-30 16:29:12 -04:00
4ee8a890a8
fixes #3843 - (L10N) regression: alignment issue when saving tabs to collection
...
changed height to match_constraints instead of wrap_content - this makes for a better calculation of space, avoids setting textView on two lines, with blank line below.
2019-07-30 13:41:23 -04:00
8ff77b90f3
For #3886 - Change default device name to show the app name. ( #3916 )
...
* Fix default device name to show the app name.
* Add string resource with placeholders.
* Wrap line that triggers MaxLineLength lint issue.
2019-07-30 10:28:19 -07:00
7ab4498771
For #3548 - Fix close tab button visibility. ( #3801 )
...
* For #3548 - Fix close tab button visibility.
* Switch to 'wrap_content' instead of fixed values.
* Align close tab button with settings button.
* Change margin top
2019-07-30 10:25:44 -07:00
ecc743a1f9
Minify logo path ( #4276 )
2019-07-30 09:56:11 -07:00
d1651ecf71
Closes #4012 - Animate quick settings ( #4047 )
2019-07-30 09:50:50 -07:00
2467588c4a
Create shared custom view for library items
2019-07-30 12:26:15 -04:00
ed60bdf470
fixes #3905 - "Go back" button too low on high risk error pages ( #4378 )
...
added to border-box value to box-sizing property for tablets so that the height property includes content and padding
2019-07-30 09:24:10 -07:00
437ecfbca8
For #1750 : Adds gradient to private BrowserToolbar ( #4361 )
...
Also updates the color of quickActionSheet ot be "above" attribute
2019-07-30 09:19:48 -07:00
be66e00303
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@1412258878
2019-07-30 15:35:41 +02:00
88c05a5f43
Use glide-like image loading function
2019-07-29 10:22:23 -07:00
d5eeadda66
Closes #2142 : Enable private browsing button is focused instead of Search or address
2019-07-29 09:26:33 -07:00
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
4747f2c165
Fixes #4161 : Modified style of bookmark_folders_sign_in button. ( #4291 )
...
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
2019-07-25 14:10:11 -05:00
9db0d88346
For #4262 : Updates color and text of buttons ( #4250 )
2019-07-25 11:01:25 -07:00
28eb5c541a
For #1944 & #1750 : Updates private & night mode colors ( #4232 )
2019-07-23 09:35:24 -07:00
9b5baa2358
For #3360 - Adds empty state for TP Exceptions
2019-07-22 17:21:06 -04:00
7588251f8b
Closes #3986 & Closes #3661 : Migrate QuickActionSheet to LibState & add tests ( #4058 )
...
* Closes #3986 : Migrate QuickActionSheet to LibState
* Closes #3661 : Add tests for QuickActionSheet
Co-authored-by: boek <jeff@jeffboek.com>
* For #3986 : Fix feedback
2019-07-22 10:31:31 -07:00
5630904f93
For#3278 - Updates strings in preferences ( #4184 )
2019-07-19 12:31:55 -07:00
e25ceafd1f
No issue: Removes unnecessary fragment transitions from accounts
...
Co-authored-by: ekager <emilykager@gmail.com>
2019-07-18 19:56:25 -04:00
becdb88f4b
Revert "For #1944 & #1750 : Updates private & night mode colors ( #4162 )"
...
This reverts commit 2c95bb614a
2019-07-18 19:55:56 -04:00
709a2652b5
Import strings from android-l10n ( #4110 )
...
State: mozilla-l10n/android-l10n@e521a2aab2
2019-07-18 16:07:01 -07:00
62850430b7
Closes AC#3695 - Add UI to open current page in external app
2019-07-18 15:33:31 -04:00
6da6ddb095
Use StateListDrawable & resources w/ TabCollection
2019-07-18 15:29:06 -04:00
451093fd9e
Closes #2560 - Updates Private Browsing explanation string
2019-07-18 15:27:59 -04:00
2c95bb614a
For #1944 & #1750 : Updates private & night mode colors ( #4162 )
2019-07-18 11:22:07 -07:00
8daaa6378d
Closes #4038 - Adds margin before close icon in tab item
2019-07-16 14:14:08 -07:00
3143227692
For #3998 - Make Turn On Sync Fragment scrollable in landscape
2019-07-16 12:56:07 -07:00
447123367a
Remove unused sessions resources
2019-07-16 09:15:50 -07:00
13b7e64c9b
For #3134 - Add confirmation dialog to sign out of FxA ( #3959 )
2019-07-15 16:21:13 -07:00
7747d5c240
Use tools:text to avoid inflating strings twice ( #3619 )
2019-07-15 17:01:37 -05:00
42cbe50a5a
Import strings from android-l10n ( #4054 )
...
State: mozilla-l10n/android-l10n@64a8eca673
2019-07-15 16:09:44 -05:00
706f7d5961
For #3554 - Add DiffUtil to HistoryAdapter
2019-07-15 13:46:21 -07:00
cf9ae87d50
For #3015 : Add push support for send tab
2019-07-15 16:38:49 -04:00
5de1678e65
No issue: Use putCompoundDrawables helper ( #3982 )
2019-07-15 08:24:59 -07:00
89a500beaf
For #4039 - Set angle of progress bar gradient
2019-07-15 08:02:06 -07:00
a9bfb303f7
For #3997 - Use ScrollView so landscape mode displays entire view
2019-07-12 11:49:12 -07:00
867067537a
For #3568 - Use correct styling for QR and Share Alert Dialogs
2019-07-12 11:40:33 -07:00
5b10badc00
No issue: Remove rounded QAB corners to avoid overlapping web content
2019-07-12 09:59:19 -07:00
7cea2ed048
For #3997 - Use srcCompat for sign in ImageView
2019-07-11 13:29:24 -04:00
1f108f3c88
For #3806 - Adds corner radius to QAB and dialogs
2019-07-11 12:57:27 -04:00
c81dd0a4a8
For #3772 - Update FXA sign in UI ( #3933 )
2019-07-10 21:20:06 -05:00
547c5d7bbe
For #3906 - Add backgrounds to Permissions Buttons ( #3958 )
2019-07-10 20:59:47 -05:00
9e7282cf18
For #1949 - Fixes bookmark separator appearance, removes menu ( #3957 )
2019-07-10 14:23:35 -05:00
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
2019-07-10 14:13:10 -04:00
c6c9818751
For #3240 - Create AuthCustomTabActivity to fix dead end on auth
2019-07-10 12:23:01 -04:00
41ace512ec
No issue: Adds new strings for sync, fxa, and settings
2019-07-09 18:52:36 -04:00
0bf8b96790
Fix #3425 - Use Share header text as contentDescription ( #3822 )
2019-07-08 14:35:53 -05:00
c92eabdd64
Modify the order of Privacy Policy and About in Settings ( #2760 )
2019-07-08 12:16:18 -05:00
45cfeb858b
Import strings from android-l10n ( #3923 )
...
State: mozilla-l10n/android-l10n@5d8852d69a
2019-07-08 12:11:44 -05:00
d168d52516
For #3772 - Remove Create an Account Option on TurnOnSyncFragment ( #3928 )
2019-07-08 12:07:09 -05:00
f7cf8473b5
For #2357 : Removes snapping threshold on home fragment ( #3878 )
2019-07-08 09:11:22 -07:00
eaa9df7018
For #3547 - Use MaterialButton for Share Component Close Button
2019-07-08 08:59:58 -07:00
cad6345c89
For #3715 - Update menu corner radius to 8dp to match tabs
2019-07-03 11:13:23 -07:00
29402a297e
For #3317 : Prepopulate FxA device name field with existing name ( #3733 )
2019-07-03 08:38:09 -07:00
ba34b7b69f
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@63a524065c
2019-07-03 17:07:45 +02:00
9e9c2c65c8
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@1a1047c59e
2019-07-03 13:42:22 +02:00
7b9f24edfe
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@4c73402212
2019-07-03 13:42:22 +02:00
bed926c317
For #3834 - Initialize job in init
2019-07-01 16:26:46 -07:00
eb1ea882cf
For #2425 - QAB showed wrong text for bookmarked pages ( #3794 )
...
* For #2425 - QAB showed wrong text for bookmarked pages
* fixed linting issue
2019-07-01 11:45:52 -05:00
887102d215
For #3645 : Fix search engine selection ( #3665 )
...
* Remove RadioButton drawable applied in runtime
* Add default RadioButton layout
2019-07-01 11:08:58 -05:00
d42052079a
No issue: Remove duplicate wordmark and update about page ( #3590 )
2019-07-01 08:54:16 -07:00
c477c781a5
For #3355 - Allow multilines on bottom bar in Collection Creation ( #3782 )
2019-06-28 19:10:54 -05:00
4ccd19a585
For #2210 : Improves UI of search fragment ( #3773 )
2019-06-28 19:03:04 -05:00
073b0ae103
Fixed Issue #3741 - %s in Japanese version + A few typos ( #3749 )
...
* Typo in README
* Fixed Issue #3741 - %s in Japanese version
* Fixed various typos
2019-06-28 18:56:25 -05:00
9142e2279c
For #1968 - Adds menu option to add new folder in BookmarkFragment menu
2019-06-27 15:17:00 -07:00
606e66219c
No issue: Use chains for bookmark items ( #3696 )
...
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-27 13:47:42 -07:00
a36f2a7288
For #3244 : Updates account icon in settings ( #3692 )
2019-06-27 11:28:42 -07:00
77edb7afe1
For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list
2019-06-26 18:59:13 -07:00
eb54d7c97f
For #3690 - Gives defined size to pill_wrapper
2019-06-26 16:44:35 -07:00
e8bd090a8e
No issue: Use ImageView rather than rebuilding drawable ( #3616 )
...
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
a1ddf17364
Closes #3569 - Uses primary text attr for bookmark folder icon ( #3675 )
2019-06-26 15:29:21 -05:00
a78d36354a
Switch RadioButtonPreference to ConstraintLayout
...
Also ensure that RTL works properly.
2019-06-26 09:45:55 -07:00
e1e4c7c1f9
No issue - reduce margin between favicon and title/url in library
2019-06-24 16:16:32 -07:00
2ebe0a2a48
Fixes #3529 - Display "Edit folder" title when editing a bookmark folder ( #3549 )
2019-06-24 13:34:15 -07:00
03a5cb2fb4
For #3620 - Adds automatic theme onboarding content description ( #3629 )
2019-06-24 13:15:38 -07:00
ab6101b0f4
Fixes #3539 - vectordrawablecompat for gradients ( #3541 )
2019-06-18 16:38:56 -07:00
b70dced16e
Fixes #3538 - Fix ic_tabs icon path ( #3540 )
2019-06-18 16:38:42 -07:00
6bd9b82385
No issue: Remove flash of tab adapter updating data in create collection
2019-06-14 11:01:54 -07:00
1de63df01f
Closes #3080 - Update constraints so first collection visible by default
2019-06-14 11:01:54 -07:00
9009d16ac6
Closes #3452 Closes #3553 - Implement one button style for all themes
2019-06-14 09:38:17 -07:00
f0f5374a57
Minify vector drawables
2019-06-14 09:37:35 -07:00
22f39fbebf
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@60fcf55878
2019-06-14 14:19:01 +02:00
a941b875b4
For #3439 - Clean up where accent colors didn't work with dark theming
2019-06-13 22:39:00 -07:00
7abf135c89
For #2896 - Update Checkbox color on tab in collection creation
2019-06-13 22:38:08 -07:00
c48d7fb0c3
For #3447 : Fixes folder icon color
2019-06-13 16:40:42 -07:00
ce33054173
Closes #3454 - Update Collections Icon in Delete Browsing Data
2019-06-13 15:23:08 -07:00
2868e376a6
Replace notification icon ( #3395 )
2019-06-12 14:07:20 -05:00
d70b6418b4
Issue 3334 - Fix icons alignment in Collections cards ( #3382 )
2019-06-12 10:26:13 -05:00
94556cceda
For #3278 - Fixes property order in search_engine_radio_button.xml
2019-06-11 16:24:28 -07:00
a86ec60f8f
For #3278 - Fixes search engine selector layout
2019-06-11 16:24:28 -07:00
811fbfc5fd
For #3278 - Removes icon and preference item
2019-06-11 16:24:28 -07:00
68fe93b420
For #3369 - Assign dark mode new collection icon colors ( #3370 )
2019-06-11 17:38:05 -05:00
c73ba83f45
Minify drawable assets
2019-06-11 15:11:33 -07:00
ccc7c70967
For #3252 : Reader mode appearance buttons are not visible in PB
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-11 18:02:29 -04:00
a2f2a23a15
Fixes #3281 - Fix Report and onboarding lint errors and issues ( #3339 )
2019-06-11 12:33:12 -05:00
2e0a0ab65a
Fix round icon ( #3353 )
2019-06-11 12:26:08 -05:00
7c37f77cfc
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@53a583feb6
2019-06-11 09:49:26 -07:00
e57e7b50ee
For #2899 - Scroll to Collections on change, animate new collections ( #3279 )
...
* For #2899 - Scroll to Collections on change, animate new collections
* For #2899 - Scroll to tabs when tabs opened from collection
2019-06-11 09:01:00 -05:00
64229f6f34
Minify launcher icon ( #3309 )
2019-06-10 09:10:29 -05:00
b42b4df024
No Issue - Moves string to static string until next export ( #3274 )
2019-06-07 19:38:45 -05:00
5dfde74376
For #1881 - Uses flex box to pin button to the bottom
2019-06-07 13:15:26 -07:00
ada0c4da28
Import strings from android-l10n ( #3253 )
...
State: mozilla-l10n/android-l10n@8a22efc7b2
2019-06-07 09:44:17 -05:00
ed39b7828b
For #3234 - Updates labels of fragments in the nav graph to avoid flash ( #3235 )
2019-06-06 16:52:25 -05:00
01ef0d5ac2
No issue: Use 'Turn on Sync' instead of 'Sign In'
...
Seems like we've started using a wrong string at some point.
Thankfully, the correct one is already in the tree.
2019-06-06 14:11:54 -07:00
c197d055b3
For #3047 : Fix blank space for system edit text controls ( #3227 )
2019-06-06 14:22:58 -05:00
33eb26861d
For #3141 For #3142 Do not try to fade BrowserFragment in transitions ( #3195 )
2019-06-05 20:37:58 -05:00
9624964bc3
For #3087 - Adds disabled color attr ( #3192 )
...
* For #3087 - Adds disabled color attr
* Change alpha to 40%
2019-06-05 20:37:16 -05:00
883afe9bd4
No issue: Update dependencies
2019-06-05 16:30:01 -07:00
704f1e6a3d
For #3004 - Restore MotionLayout on Home View only in onCreateView
2019-06-05 14:46:38 -07:00
fe3c163a20
Fix how we reflect FxA state in preference
...
This cleans up how we're displaying account state in the main preference UI.
Before when it worked, it worked mostly accidentally.
'launch' wrapper around "update ui" methods would trigger a race condition
between binding the account pref view holder and actually updating that view
with values. Sometimes the "update view with values" would happen after view
was bound, and the UI will be correct. Most of the time it would happen before,
and so there will be nothing to update and we'd get into an inconsistent state.
This also splits up the "accountpreference" into two: account is good,
and account needs re-auth. This greatly simplifies their management.
2019-06-05 14:38:06 -07:00
47c14b07dd
For #1190 : Removes syncing items from FxA telemetry
2019-06-05 13:57:18 -07:00
ValentinTimisica