blallo
/
fenix
1
0
Fork 0
Code Releases Activity

No issue: Use chains for bookmark items (#3696) 

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
master
Tiger Oakes 2019-06-27 16:47:42 -04:00 committed by Sawyer Blatz
parent c9962a7ad0
commit 606e66219c
2 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkAdapter.kt
View File

@ -8,7 +8,6 @@ import android.util.TypedValue
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.constraintlayout.widget.ConstraintSet
import androidx.core.content.ContextCompat
import androidx.recyclerview.widget.RecyclerView
import io.reactivex.Observer
@ -241,13 +240,6 @@ class BookmarkAdapter(val emptyView: View, val actionEmitter: Observer<BookmarkA
override fun bind(item: BookmarkNode, mode: BookmarkState.Mode, selected: Boolean) {
val constraintSet = ConstraintSet()
constraintSet.clone(bookmark_layout)
constraintSet.connect(
bookmark_title.id, ConstraintSet.BOTTOM, ConstraintSet.PARENT_ID, ConstraintSet.BOTTOM
)
constraintSet.applyTo(bookmark_layout)
bookmark_favicon.setImageResource(R.drawable.ic_folder_icon)
bookmark_favicon.visibility = View.VISIBLE
bookmark_title.visibility = View.VISIBLE

6
app/src/main/res/layout/bookmark_row.xml
View File

@ -42,6 +42,8 @@
app:layout_constraintEnd_toStartOf="@id/bookmark_overflow"
app:layout_constraintStart_toEndOf="@id/bookmark_favicon"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintBottom_toTopOf="@+id/bookmark_url"
app:layout_constraintVertical_chainStyle="packed"
tools:text="Internet" />
<TextView
@ -56,7 +58,9 @@
android:textSize="12sp"
app:layout_constraintEnd_toStartOf="@id/bookmark_overflow"
app:layout_constraintStart_toEndOf="@id/bookmark_favicon"
app:layout_constraintTop_toBottomOf="@id/bookmark_title" />
app:layout_constraintTop_toBottomOf="@id/bookmark_title"
tools:text="https://github.com/mozilla-mobile/fenix"
app:layout_constraintBottom_toBottomOf="parent" />
<ImageButton
android:id="@+id/bookmark_overflow"