blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #3886 - Change default device name to show the app name. (#3916) 

* Fix default device name to show the app name.

* Add string resource with placeholders.

* Wrap line that triggers MaxLineLength lint issue.
master
bloslo 2019-07-30 19:28:19 +02:00 committed by Sawyer Blatz
parent 7ab4498771
commit 8ff77b90f3
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/org/mozilla/fenix/components/BackgroundServices.kt
View File

@ -148,6 +148,13 @@ class BackgroundServices(
}
}
private val defaultDeviceName = context.getString(
R.string.default_device_name,
context.getString(R.string.app_name),
Build.MANUFACTURER,
Build.MODEL
)
/**
* We add an observer to the AccountManager so that we can control when the Firebase service
* will start/stop. This is only needed when landing the push service to ensure Firebase works
@ -161,7 +168,6 @@ class BackgroundServices(
*/
private val accountObserver = object : AccountObserver {
override fun onAuthenticationProblems() {}
override fun onProfileUpdated(profile: Profile) {}
override fun onLoggedOut() {

4
app/src/main/res/values/strings.xml
View File

@ -171,6 +171,10 @@
<string name="sync_last_synced_summary">Last synced: %s</string>
<!-- Label summary showing never synced -->
<string name="sync_never_synced_summary">Last synced: never</string>
<!-- Text for displaying the default device name.
The first parameter is the application name, the second is the device manufacturer name
and the third is the device model. -->
<string name="default_device_name">%s on %s %s</string>
<!-- Send Tab -->
<!-- Name of the "receive tabs" notification channel. Displayed in the "App notifications" system settings for the app -->