blallo
/
fenix
1
0
Fork 0
Code Releases Activity

Closes #3419: Use better accessibility strings for tab collections

master
Maurya Talisetti 2019-07-24 20:06:59 +05:30 committed by Emily Kager
parent 3fb20aea6a
commit 093b76593d
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/res/layout/collection_home_list_row.xml
View File

@ -88,7 +88,7 @@
android:layout_marginStart="16dp"
android:layout_marginEnd="30dp"
android:background="?android:attr/selectableItemBackgroundBorderless"
android:contentDescription="@string/share_header"
android:contentDescription="@string/share_button_content_description"
android:src="@drawable/ic_hollow_share"
app:layout_constraintEnd_toStartOf="@id/collection_overflow_button"
app:layout_constraintTop_toTopOf="@id/collection_icon" />
@ -100,7 +100,7 @@
android:layout_marginTop="16dp"
android:layout_marginEnd="4.5dp"
android:background="?android:attr/selectableItemBackgroundBorderless"
android:contentDescription="@string/tab_menu"
android:contentDescription="@string/collection_menu_button_content_description"
android:src="@drawable/ic_menu"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent" />

5
app/src/main/res/values/strings.xml
View File

@ -492,6 +492,8 @@
<!-- Collections -->
<!-- Collections header on home fragment -->
<string name="collections_header">Collections</string>
<!-- Content description (not visible, for screen readers etc.): Opens the collection menu when pressed -->
<string name="collection_menu_button_content_description">Collection menu</string>
<!-- No Open Tabs Message Header -->
<string name="no_collections_header">No collections</string>
<!-- No Open Tabs Message Description -->
@ -531,6 +533,9 @@
<!-- Share -->
<!-- Share screen header -->
<string name="share_header">Send and Share</string>
<!-- Content description (not visible, for screen readers etc.):
"Share" button. Opens the share menu when pressed. -->
<string name="share_button_content_description">Share</string>
<!-- Sub-header in the dialog to share a link to another app -->
<string name="share_link_subheader">Share a link</string>
<!-- Sub-header in the dialog to share a link to another sync device -->