For #1744: Open search shortcuts when entering search mode (#4536)

app/src/main/java/org/mozilla/fenix/HomeActivity.kt

@@ -196,7 +196,7 @@ open class HomeActivity : AppCompatActivity(), ShareFragment.TabsSharedCallback
             return
         } else if (intent?.extras?.getBoolean(OPEN_TO_SEARCH) == true) {
             this.intent.putExtra(OPEN_TO_SEARCH, false)
-            navHost.navController.nav(null, NavGraphDirections.actionGlobalSearch(null, true))
+            navHost.navController.nav(null, NavGraphDirections.actionGlobalSearch(null))
             return
         }
 

app/src/main/java/org/mozilla/fenix/search/SearchFragment.kt

@@ -65,11 +65,6 @@ class SearchFragment : Fragment(), BackHandler {
             ?.let { it.sessionId }
             ?.let(requireComponents.core.sessionManager::findSessionById)
 
-        val displaySearchShortcuts = arguments
-            ?.let(SearchFragmentArgs.Companion::fromBundle)
-            ?.let { it.displaySearchShortcuts }
-            ?: false
-
         val view = inflater.inflate(R.layout.fragment_search, container, false)
         val url = session?.url ?: ""
 
@@ -77,7 +72,7 @@ class SearchFragment : Fragment(), BackHandler {
             SearchStore(
                 SearchState(
                     query = url,
-                    showShortcutEnginePicker = displaySearchShortcuts,
+                    showShortcutEnginePicker = true,
                     searchEngineSource = SearchEngineSource.Default(
                         requireComponents.search.searchEngineManager.getDefaultSearchEngine(requireContext())
                     ),

app/src/main/res/navigation/nav_graph.xml

@@ -72,11 +72,6 @@
             android:name="session_id"
             app:argType="string"
             app:nullable="true" />
-        <argument
-            android:name="displaySearchShortcuts"
-            android:defaultValue="false"
-            app:argType="boolean"
-            app:nullable="false" />
         <action
             android:id="@+id/action_searchFragment_to_searchEngineFragment"
             app:destination="@id/searchEngineFragment"