blallo
/
fenix
1
0
Fork 0
Code Releases Activity

No issue: Remove flash of tab adapter updating data in create collection

master
Emily Kager 2019-06-13 18:07:22 -07:00 committed by Emily Kager
parent 1de63df01f
commit 6bd9b82385
4 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/main/java/org/mozilla/fenix/collections/CollectionCreationUIView.kt
View File

@ -104,6 +104,7 @@ class CollectionCreationUIView(
view.tab_list.run {
adapter = collectionCreationTabListAdapter
itemAnimator = null
layoutManager = LinearLayoutManager(container.context, RecyclerView.VERTICAL, true)
}

12
app/src/main/res/layout/component_collection_creation.xml
View File

@ -43,9 +43,9 @@
android:id="@+id/collections_list"
android:layout_width="0dp"
android:layout_height="0dp"
android:layout_marginStart="16dp"
android:layout_marginTop="16dp"
android:layout_marginEnd="16dp"
android:layout_marginStart="@dimen/component_collection_creation_list_margin"
android:layout_marginTop="@dimen/component_collection_creation_list_margin"
android:layout_marginEnd="@dimen/component_collection_creation_list_margin"
android:visibility="gone"
app:layout_constraintBottom_toTopOf="@id/bottom_button_bar_layout"
app:layout_constraintEnd_toEndOf="parent"
@ -78,9 +78,9 @@
android:id="@+id/tab_list"
android:layout_width="0dp"
android:layout_height="0dp"
android:layout_marginStart="16dp"
android:layout_marginTop="16dp"
android:layout_marginEnd="16dp"
android:layout_marginStart="@dimen/component_collection_creation_list_margin"
android:layout_marginTop="@dimen/component_collection_creation_list_margin"
android:layout_marginEnd="@dimen/component_collection_creation_list_margin"
app:layout_constraintBottom_toTopOf="@id/bottom_button_bar_layout"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"

12
app/src/main/res/layout/component_collection_creation_select_collection.xml
View File

@ -45,9 +45,9 @@
android:id="@+id/collections_list"
android:layout_width="0dp"
android:layout_height="0dp"
android:layout_marginStart="16dp"
android:layout_marginTop="16dp"
android:layout_marginEnd="16dp"
android:layout_marginStart="@dimen/component_collection_creation_list_margin"
android:layout_marginTop="@dimen/component_collection_creation_list_margin"
android:layout_marginEnd="@dimen/component_collection_creation_list_margin"
app:layout_constraintBottom_toTopOf="@id/bottom_button_bar_layout"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
@ -80,9 +80,9 @@
android:id="@+id/tab_list"
android:layout_width="0dp"
android:layout_height="0dp"
android:layout_marginStart="16dp"
android:layout_marginTop="16dp"
android:layout_marginEnd="16dp"
android:layout_marginStart="@dimen/component_collection_creation_list_margin"
android:layout_marginTop="@dimen/component_collection_creation_list_margin"
android:layout_marginEnd="@dimen/component_collection_creation_list_margin"
android:fadingEdgeLength="30dp"
android:requiresFadingEdge="vertical"
android:visibility="gone"

1
app/src/main/res/values/dimens.xml
View File

@ -29,6 +29,7 @@
<dimen name="phone_feature_label_recommended_text_size">14sp</dimen>
<dimen name="site_permissions_exceptions_item_text_size">18sp</dimen>
<dimen name="site_permissions_exceptions_item_height">56dp</dimen>
<dimen name="component_collection_creation_list_margin">16dp</dimen>
<!--Quick Settings-->
<dimen name="quicksettings_item_height">46dp</dimen>