blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #3620 - Adds automatic theme onboarding content description (#3629)

master
Emily Kager 2019-06-24 13:15:38 -07:00 committed by Colin Lee
parent 1d57e77cea
commit 03a5cb2fb4
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingThemePickerViewHolder.kt
View File

@ -52,6 +52,10 @@ class OnboardingThemePickerViewHolder(private val view: View) : RecyclerView.Vie
radioLightTheme.performClick()
}
val automaticTitle = view.context.getString(R.string.onboarding_theme_automatic_title)
val automaticSummary = view.context.getString(R.string.onboarding_theme_automatic_summary)
view.clickable_region_automatic.contentDescription = "$automaticTitle $automaticSummary"
view.clickable_region_automatic.setOnClickListener {
radioFollowDeviceTheme.performClick()
}

2
app/src/main/res/layout/onboarding_theme_picker.xml
View File

@ -60,7 +60,6 @@
app:layout_constraintTop_toBottomOf="@+id/description_text"
app:onboardingKey="@string/pref_key_light_theme" />
<ImageButton
android:id="@+id/theme_light_image"
android:layout_width="wrap_content"
@ -144,6 +143,7 @@
android:layout_marginStart="16dp"
android:layout_marginTop="16dp"
android:layout_marginBottom="16dp"
android:contentDescription="@string/onboarding_theme_automatic_title"
android:paddingStart="0dp"
android:paddingEnd="8dp"
app:layout_constraintBottom_toBottomOf="parent"