1
0
Fork 0

For #2203: Polishes BrowserToolbarMenu

master
Sawyer Blatz 2019-08-01 09:25:46 -07:00 committed by Jonathan Almeida
parent 33e881ca8a
commit 29f089c414
4 changed files with 11 additions and 2 deletions

View File

@ -116,7 +116,8 @@ class DefaultToolbarMenu(
highlight = if (hasAccountProblem) {
BrowserMenuHighlightableItem.Highlight(
imageResource = R.drawable.ic_alert,
backgroundResource = R.color.sync_error_background_color
backgroundResource = R.drawable.sync_error_background_with_ripple,
colorResource = R.color.sync_error_background_color
)
} else null
) {

View File

@ -0,0 +1,7 @@
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<ripple xmlns:android="http://schemas.android.com/apk/res/android"
android:color="?colorControlHighlight">
<item android:drawable="@color/sync_error_background_color" />
</ripple>

View File

@ -39,6 +39,7 @@
android:background="?foundation"
android:clickable="true"
android:visibility="gone"
android:elevation="5dp"
app:findInPageNoMatchesTextColor="?attr/destructive"
mozac:findInPageButtonsTint="?primaryText"
mozac:findInPageResultCountTextColor="?primaryText" />

View File

@ -41,7 +41,7 @@
<dimen name="bottom_sheet_top_padding">8dp</dimen>
<!-- Browser Toolbar -->
<dimen name="browser_toolbar_height">56dp</dimen>
<dimen name="browser_toolbar_height">57dp</dimen>
<dimen name="toolbar_and_qab_height">67dp</dimen>
<!-- SignIn Component -->