1
0
Fork 0
Commit Graph

3103 Commits (7e3795242cc6ff201d9d0809bcc57c8a72bf36ed)

Author SHA1 Message Date
Mozilla L10n Automation Bot a50aa839f3 Import l10n. 2020-05-26 08:47:03 +03:00
mcarare 6e325d6242 For #6198: Update copy and position of pair QR code scan message. 2020-05-25 17:53:20 -04:00
mcarare 44d9dc9237 For #10705: Update copy of auto font sizing preference. 2020-05-25 17:50:35 -04:00
mcarare a62f4b2caa For #10851: Add end constraint for text view. 2020-05-25 17:49:39 -04:00
mcarare ce46a96742 For #10706: Update copy of deleting open tabs preference. 2020-05-25 17:37:29 -04:00
Sebastian Kaspari b666fbe3fe CrashReporter: Set release channel specific sentry project URL. 2020-05-25 16:13:54 +03:00
Mugurell 2dfd833941 For #10844 - Fennec page shortcuts will open in normal tabs
This comes to resolve a small regression in which they were opened in new
custom tab.
2020-05-25 14:37:00 +03:00
Mozilla L10n Automation Bot 7c7d860293 Import l10n. 2020-05-25 09:51:40 +03:00
Jonathan Almeida 8d7c911202 For #10885: Don't add migration activity to history stack 2020-05-25 09:48:52 +03:00
Grisha Kruglov b26ac51e90 For #10494: Process HomeMenu builder changes on the main thread
Problem was that we were trying to process menu changes (in response to account manager events) on some background thread as that's what account manager emits them on, so some code internally in PopupWindow's dismiss handling (i think, didn't dig very deeply here) was silently giving up and we'd get into a bad state.

The reason this seemingly only happened if you quickly opened a menu on startup is because account manager isn't initialized until sometime after the startup finished. So the trick was to open the menu (and register account manager state callbacks) before it got initialized, so that the callbacks are invoked.

This should also reproduce in other, much more obscure ways, e.g. if you open the menu right before sync is scheduled to run in the background, change FxA password on another connected client, and then eventually receive a onAuthenticationProblem callback.
2020-05-22 13:50:57 -07:00
David Walsh ebb562a789 For #10859 - Use dark or light mode colors for tab tray in private mode 2020-05-22 13:34:30 -07:00
Sawyer Blatz 7067e5c000
For #8125: Add default top site telemetry (#10752) 2020-05-22 13:10:09 -07:00
Mozilla L10n Automation Bot e21352144b Import l10n. 2020-05-22 16:48:52 +03:00
sraturi 29d1893430 for #7032 add scroll listener to make the keyboard disappear on scroll.
touch listener was blocking the scroll
2020-05-21 18:54:50 -07:00
sraturi 4ee65755dc for #7032 fixed issue where pressing back button exited the application 2020-05-21 18:54:50 -07:00
sraturi 2c85a62a5e for #7032 removed recyclerview scroll listener from Awesomebarview 2020-05-21 18:54:50 -07:00
sraturi c8ec25fde9 fixed lint issues 2020-05-21 18:54:50 -07:00
sraturi 703a8ed565 added a onTouch listener to scrollview in search fragment to make it disappear on scroll 2020-05-21 18:54:50 -07:00
Jeff Boek 601aedda46 For #10504 - Removes "old" TabTrayFragment 2020-05-21 15:17:20 -07:00
Jeff Boek c32904a1d0 For #10504 - opens the tab tray and filters the tab based on the browser mode 2020-05-21 15:17:20 -07:00
Jeff Boek a674c5dfe7 For #10504 - cleans up tabLayout colors 2020-05-21 15:17:20 -07:00
Jeff Boek 4e499e7a48 For #10504 - Adds tabTrayDialogInteractor to browserfragment 2020-05-21 15:17:20 -07:00
Jeff Boek cc6a380d45 For #10504 - Show tab dialog on browserfragment 2020-05-21 15:17:20 -07:00
Jeff Boek 90cef752b0 For #10504 - Fixes up tab tray dialog styles 2020-05-21 15:17:20 -07:00
Jeff Boek 0b9484a172 For #10504 - Adds padding fto account for navigation bar in landscape 2020-05-21 15:17:20 -07:00
Jeff Boek dd2a26fc7c For #10504 - Added the tab tray to the TabTrayDialogFragment and wired up dismiss actions 2020-05-21 15:17:20 -07:00
Jeff Boek 34ac9df481 For 10504 - Adds dialog style and fab 2020-05-21 15:17:20 -07:00
Jeff Boek 97d66cce56 For #10504 - Creates the TabTrayDialogFragment 2020-05-21 15:17:20 -07:00
ekager 516a6fe9f7 For #6832 - Only emit session changes if fragment is attached 2020-05-21 10:11:50 -07:00
ekager 83ab7646c1 For #7602 - Integrate media fullscreen orientation feature 2020-05-21 10:11:39 -07:00
Christian Sadilek 4e25f41a41 For #1824: Prevent extremely long URLs from locking up HomeFragment 2020-05-21 13:11:07 -04:00
codrut.topliceanu 7feae98944 For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view
- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
2020-05-21 10:02:51 -04:00
David Walsh 346b4aa3fd
For #10321: Wire up play and pause buttons in tab tray (#10422) 2020-05-20 16:50:58 -05:00
Sawyer Blatz 477493e197
For #10465: Add telemetry for voice search (#10785) 2020-05-20 14:35:57 -07:00
Mozilla L10n Automation Bot 3b866d4da4 Import l10n. 2020-05-20 10:14:19 -07:00
David Walsh 2795a34b0b For 10731 - Don't show tab tray menu if there are no tabs 2020-05-19 13:30:18 -07:00
Sawyer Blatz 535e020683 For #1216: Put voice search behind a nightly & debug flag 2020-05-19 13:04:11 -07:00
Sawyer Blatz d33edd8841 No issue: Clean up SearchFragment a bit 2020-05-19 13:04:11 -07:00
Sawyer Blatz 011a9e7d96 For #1216: Add voice search 2020-05-19 13:04:11 -07:00
Mozilla L10n Automation Bot fe3a67ac68 Import l10n. 2020-05-18 20:22:37 -07:00
ekager d46369696f For #10718 - Finish activity after removing external session 2020-05-18 15:32:29 -07:00
ekager 28a6b1f9d5 For #10691 - Turn on LeakCanary by default for debug builds 2020-05-18 15:08:09 -07:00
Mozilla L10n Automation Bot dc92ddb0e5 Import l10n. 2020-05-18 14:04:23 -07:00
Tiger Oakes cd64647a4d For #9286 - Add isDefault to topsites 2020-05-18 14:04:10 -07:00
Juan Goncalves ee62297b4c For #7854 - Update the views only if the bookmark node has changed
As the bookmark node data is loaded from storage every time the fragment's view is created, when the user navigates to the SelectFolderFragment and returns, the bookmark is loaded once again from storage, replacing the EditText's content (title and URL) which causes the loss of user input.

Validating that the loaded bookmark is different from the one that is already referenced in the fragment avoids unnecessarily replacing the `EditText`s values.
2020-05-18 13:05:12 -07:00
Emily Kager 32e74aae61 Revert "For #6313 - On first load, hides engineView until firstContentfulPaint"
This reverts commit d66762910f.
2020-05-18 10:33:11 -07:00
Emily Kager 9b16017d1d Revert "For #7032: Add scroll to dismiss keyboard in search fragment"
This reverts commit 536921bcea.
2020-05-15 21:14:55 -07:00
ekager d66762910f For #6313 - On first load, hides engineView until firstContentfulPaint 2020-05-15 10:55:38 -07:00
partha2000 124b21d209 For #10632 - Update Content Description for X icon in collection 2020-05-15 10:31:05 -07:00
Sachin 536921bcea
For #7032: Add scroll to dismiss keyboard in search fragment
* added a onTouch listener to scrollview in search fragment to make it disappear on scroll

* fixed lint issues
2020-05-15 10:30:00 -07:00
mcarare b244fd53ac For #10656: Adjust etp checkbox dimensions for a11y. 2020-05-15 17:39:51 +03:00
Mozilla L10n Automation Bot a3c6492d5f Import l10n. 2020-05-14 22:11:38 -07:00
Grisha Kruglov d37529e416 Perf telemetry for awesomebar suggestion provider durations
See mozilla-mobile/android-components#6802 for details; requires that PR.
2020-05-14 14:13:53 -07:00
Mihai Branescu 750ae4a340 For #10393 and #10469 - browser fragment now observes collection changes
Useful for links from other apps + adding a page to multiple collections
2020-05-14 10:14:06 +03:00
Mozilla L10n Automation Bot 62e68c579a Import l10n. 2020-05-13 18:54:28 -07:00
Christian Sadilek 7993f1017d Migrate feature-accounts to browser-state 2020-05-13 14:24:56 -04:00
sraturi 372bb421cc created kotlin doc for FenixApplication 2020-05-13 11:01:12 -07:00
Vishwa Patel 06aada251d
Issue 7266 fenix remove line (#10630) 2020-05-13 10:36:58 -07:00
Simon Chae 7cc4816618
For #10398: Add AddonInstallationDialogFragment support (#10608) 2020-05-13 12:25:34 -04:00
Mozilla L10n Automation Bot 7fc006a5a8 Import l10n. 2020-05-13 10:58:48 +03:00
Elise Richards edc75c3ad0
Fixes #9504: Edit logins (#9693)
* Create editable view and fragment. Update login info page to display options menu with edit and delete.

* Create feature flag for edit. Check flag in the login detail fragment and default to just delete.

* Add three-dot kebab options menu in login detail fragment. Add title to the login item.

* Nav to and from edit view on save and back pressed.

* Save login through AC login manager. Clear text in editable field on button click.

* Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields.

* Refactoring logins fragments. Using component Login object for consistency.

Fetch login list when saved logins are opened. Fetch login details when detail view is opened.

Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened."

This reverts commit 44fe17166c3332b330229258b2e8982832672e3b.

* Using parcelable login and Login component class to pass ids and items between fragments

* Retrieve login from storage when viewing login details.

Rename login logic for consistency.

Ktlint cleanup

Fix nits and naming consistency.

* UX consistency for login detail and edit login pages

* Rebasing with logins sort - updating logins store.

* Rebasing with logins sort - merging fragments and controllers.

* Lint and removing unused files.

* UX cleanup.

* Update string description
2020-05-12 17:32:01 -05:00
Tiger Oakes f7b4f1c959
Cache findViewById calls in session control (#10575) 2020-05-12 14:05:08 -07:00
David Walsh 86dabe09c8
For 10503 - Update save to collection flow in tab tray (#10523) 2020-05-12 10:02:29 -05:00
mcarare 58df38105b For #10453: Use TabsTray API to set divider, avoiding related crashes. 2020-05-12 17:21:26 +03:00
Sebastian Kaspari d58c022619 Integrate activity for showing past crashes. 2020-05-12 09:14:20 +02:00
mcarare a7ff8cafc7 For #7887: Increase touch target height for learn more link. 2020-05-11 22:50:41 -07:00
mcarare ff6447b755 No issue: Fix xml indentations. 2020-05-11 22:50:41 -07:00
Mozilla L10n Automation Bot 65f30c75e8 Import l10n. 2020-05-11 17:34:32 -07:00
Jeff Boek a249334976
🎲 For #10332 - Adds undo snackbar when closing tabs in the tab tray (#10456) 2020-05-11 17:18:09 -05:00
Simon Chae 5ba9cc6ec9
For #10253: Add disableFirstTimePWAPopup for performance testing (#10442) 2020-05-11 16:31:31 -04:00
ValentinTimisica 15dfe0811d For #10343: Updates metrics accordingly to 'Library' removal 2020-05-11 10:22:19 -07:00
ValentinTimisica b2e5820364 For #10343: Remove 'Library' functionality from the app
Also adds Bookmarks and History items to browser menu.
2020-05-11 10:22:19 -07:00
Simon Chae ca7695854a
For #10552: Set initial add-on details fragment visibility to false (#10565) 2020-05-11 12:44:18 -04:00
Mihai Branescu dd843b4989 For #10501 - use theme instead of tint to support older APIs 2020-05-11 19:22:00 +03:00
Mozilla L10n Automation Bot 55a8bf7ff9 Import l10n. 2020-05-10 19:42:20 -07:00
Sawyer Blatz 17fb7c1df7
For #10426: Removes installation ping GAID (#10532) 2020-05-09 10:35:57 -07:00
Simon Chae d58e7d3138 For #10473: Fetch the addon from addon manager instead of the store 2020-05-08 16:03:22 -07:00
Sawyer Blatz b87c40d42f
For #10426: Sends GAID to Installation instead of Activation ping. (#10529) 2020-05-08 12:04:15 -07:00
codrut.topliceanu d1005dd236 For #8589 - Fix for accessibility navigation in ETP panel 2020-05-08 09:57:59 -07:00
Mozilla L10n Automation Bot 824022c28d Import l10n. 2020-05-08 08:44:39 -07:00
Arturo Mejia ca01965f90 Fix PictureInPictureFeature breaking change 2020-05-08 11:42:06 -04:00
ekager 7fe6f68e00 For #10485 - Restore block video/audio on cellular data radio button 2020-05-08 14:00:09 +03:00
ValentinTimisica f63cb4e09f For #10244: Creates drawable for add-ons private browsing label.
The drawable is sent to AddonsManagerAdapter.Style constructor and is displayed
near the add-on name if it is allowed to run in private browsing
2020-05-07 17:27:46 -07:00
Sawyer Blatz a01881067f For #8643: Updates colors of onboarding accents 2020-05-07 17:24:54 -07:00
Sawyer Blatz 5f11c5e648 For #9857: Updates onboarding button styles 2020-05-07 17:24:54 -07:00
Jeff Boek 58ca5d0e3a For #10341 - Always show collections placeholder with new tab tray enabled 2020-05-07 15:38:17 -07:00
Mihai Branescu eef5cf3469 For #10482 - made SVG gradient compatible with API < 22 2020-05-07 10:39:58 -07:00
ekager 138d8e647d No issue - Use ViewLifecycleOwner lifecycleScope for Bookmark deletion scope 2020-05-07 10:17:42 -07:00
Sawyer Blatz 02f6e6868e
For #10426: Adds identifier to Glean for 24 hours (#10446) 2020-05-07 08:57:20 -07:00
Jonathan Almeida 57eb2b9549 For #10453: Do not set item decoration when creating ViewHolder 2020-05-07 11:44:19 -04:00
ValentinTimisica 24ba9f2fc8 For #9505: Adds possibility to sort saved logins
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
2020-05-07 08:43:59 -07:00
mcarare 9177871edc For #10408: Check current destination before navigating. 2020-05-07 09:35:10 +03:00
ekager 9fd835de0f For #10433 - Pass in viewLifecycleScope to BrowserAnimator 2020-05-06 23:24:46 -07:00
ekager 9ec1f8e2d8 For #8981 - Sort devices in share list by last access time 2020-05-07 09:20:49 +03:00
Mozilla L10n Automation Bot c8d8a700fe Import l10n. 2020-05-06 18:14:28 -07:00
Michael Comella 4cf7280916 No issue: add clarifying kdoc for BookmarkFragment. 2020-05-06 17:27:58 -07:00
David Walsh 8b27a48635 For #10329 - Implement tab tray divider 2020-05-06 14:13:39 -07:00
Simon Chae 609936d632
For #10196: Remove clickable locks for enable and private-browsing UI (#10445) 2020-05-06 13:58:42 -04:00
Simon Chae a851b76ea3
Update Android Components version to 41.0.20200506130132 (#10443) 2020-05-06 13:17:17 -04:00
Mihai Branescu 6f97e75579 For #8643 and #7606 - illustrations are now connected to their radio buttons 2020-05-06 09:18:27 +03:00
Mihai Branescu cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu 16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu 4c0af91b7b For #8643 and #7606 - Changed tint for onboarding icons 2020-05-06 09:18:27 +03:00
Mihai Branescu 03726384de For #8643 and #7606 - Changed styles for most onboarding cards 2020-05-06 09:18:27 +03:00
Mihai Branescu 048d22dbcf For #8643 and #7606 - added styles and new colors 2020-05-06 09:18:27 +03:00
Mihai Branescu 18b6c29b4a For #8643 and #7606 - added new svgs for onboarding illustrations
RTL for toolbar are still missing
2020-05-06 09:18:27 +03:00
Mihai Branescu fab52c9702 For #8643 - removed all onboarding-related PNGs 2020-05-06 09:18:27 +03:00
Mihai Branescu 77912b29fb For #8643 - Replaced onboarding theme/toolbar assets 2020-05-06 09:18:27 +03:00
Mozilla L10n Automation Bot 0b82f8e996 Import l10n. 2020-05-05 17:34:05 -07:00
Arturo Mejia 398b516fb7 No issue: Add Fingerprinters to the standard trancking protection policy 2020-05-05 17:33:42 -07:00
Christian Sadilek fee09c3092 No issue: Show article/page url instead of reader extension url 2020-05-05 17:52:27 -04:00
Jeff Boek d72e455c0d No Issue - Update to AC 41.0.20200505190119 2020-05-05 17:52:27 -04:00
Mihai Adrian 43d30793f5
For #9794: Announce installing state for screen readers (#10111) 2020-05-05 11:22:15 -07:00
David Walsh 5087bcf9f6
For #10395 - Improve alignment of close buttons with menu in tab tray (#10405) 2020-05-05 11:16:47 -07:00
David Walsh 249e0cd4e8
For #10159 - Tab tray bottom toolbar colors (#10326) 2020-05-05 11:16:09 -07:00
Mihai Adrian 5106134786
For #10408: Dismiss menu when navigating away. (#10415)
The menu is dismissed when toolbar view is detached from window.
2020-05-05 11:15:30 -07:00
Mozilla L10n Automation Bot d2a3613b73 Import l10n. 2020-05-05 09:11:03 +03:00
David Walsh 542f31f970
For #10392 - Don't provide a "Save to collection" button in private mode for the tabs tray (#10399) 2020-05-04 22:51:07 -04:00
Michael Comella 2773a9e0a9 No issue: losslessly compress image assets.
Using ImageOptim. Results: 110 KB out of 1.9 MB (5.7%).
2020-05-04 14:54:46 -07:00
Jeff Boek 81d0db76e9
For #10395 - Fixes tab tray bar dimensions to better align with the browser toolbar (#10400) 2020-05-04 12:44:37 -05:00
Mozilla L10n Automation Bot 34f2350ada Import l10n. 2020-05-04 10:31:35 +03:00
Mozilla L10n Automation Bot 5abe3ac877 Import l10n. 2020-05-01 18:34:10 -07:00
Sören Hentzschel 10d07912da no issue - removed unused feature flag 2020-05-01 15:14:46 -07:00
Jeff Boek 94cd195dc7
Adds swipe to delete tab (#10355)
* No Issue - Increases tap area of close button

* For #10331 - Adds swipe to delete to the tab tray
2020-05-01 15:45:51 -05:00
Simon Chae 3dcd52ef7a For #10195, #10196: Allow private browsing mode switch to sync with enable state 2020-05-01 15:14:08 -04:00
Jeff Boek 5c7e9b98cd
Fix home navigation (#10350) 2020-05-01 12:46:02 -05:00
Mozilla L10n Automation Bot 95b29f2f60 Import l10n. 2020-04-30 17:38:35 -07:00
Jeff Boek a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313)
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
2020-04-30 15:53:10 -05:00
Sawyer Blatz f7dcb9f7b3 For #9208: Make slight modifications to tip layout 2020-04-30 11:57:43 -07:00
David Walsh 7ec4bc9d76 For #10159 - Implement new tab tray colors 2020-04-30 08:56:40 -07:00
Chenxia Liu 390c5a0189 Issue #7996: fix lint issues 2020-04-30 13:38:52 +03:00
Jovan Gerodetti 4a12f1b6aa For #7996: Private mode doesn't play nicely with sites added to home screen
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
2020-04-30 13:38:52 +03:00
David Walsh 688c377197 For 10296 - Implement tab tray dimension changes 2020-04-29 21:28:36 -07:00
Arturo Mejia 56bb3e38ec For issue #10142 Update sitePermissions state when toggling its value 2020-04-29 18:33:34 -07:00
ekager 2e27bbd15d No issue - Remove unused data class TopSiteItem 2020-04-29 18:06:02 -07:00
Mozilla L10n Automation Bot 6d1a2ca797 Import l10n. 2020-04-29 17:55:53 -07:00
Sawyer Blatz 38e9b34659
For #10071: Fixes PWA showing toolbar onPause (#10306) 2020-04-29 14:03:59 -07:00
mcarare 4006501d41 For #9728: Add actionbar search for language list. 2020-04-29 11:20:18 -07:00
mcarare 80f74ac611 For #9728: Change SearchView hint color inside app. 2020-04-29 11:20:18 -07:00
ekager 52d09930a6 No issue - Update new strings for quarantine 2020-04-29 11:15:21 -07:00
Mihai Eduard Badea 02bd0cc203 For issue #8648 2020-04-29 09:48:42 -07:00
Mozilla L10n Automation Bot cdbaa52cab Import l10n. 2020-04-28 17:33:33 -07:00
Jonathan Almeida 76002c5987 Fix breaking API changes in CrashReporter 2020-04-28 15:20:12 -04:00
Sören Hentzschel f0e659bfdb For #9880 - fixed sync settings style 2020-04-28 09:06:36 +03:00
Falaye Iyanuoluwa c86209ff98 Closes #9694 Bug when user denies permission 2020-04-27 22:42:02 -07:00
Mozilla L10n Automation Bot b7ea583250 Import l10n. 2020-04-28 08:35:44 +03:00
mcarare 7409dc2bae For #10083: Do not cut off thumb when it is in pressed state 2020-04-27 21:19:44 -07:00
mcarare 3c5d8d31ea For #10083: Adjust thumb offset to thumb circumference to avoid cutoff 2020-04-27 21:19:44 -07:00
David Walsh 6afcd2cee6 For #10201 - Provide proper button padding and no tabs message visibility in tabs tray 2020-04-27 20:36:08 -07:00
Mozilla L10n Automation Bot 88f4e5f217 Import l10n. 2020-04-28 00:28:46 +03:00
Arturo Mejia e55a4fd274 No issue: Partially update the add-on manager list 2020-04-27 16:43:05 -04:00
mcarare 1aa473b112 For #9913, For #9914: Remove touch delegate when button is disabled. 2020-04-27 11:57:51 -07:00
ekager a9692d9bce For #10204 - Address viewLifecycleOwner IllegalStateException crashes 2020-04-24 17:12:08 -07:00
Mihai Branescu a16bfb27ef For #6557 - added unit tests 2020-04-24 15:47:48 -07:00
Mihai Branescu 0c2d22f595 For #6557 - add in_content telemetry class 2020-04-24 15:47:48 -07:00
Mihai Branescu 28496fecc0 For #6557 - split base extension functionality from ads 2020-04-24 15:47:48 -07:00
Mihai Branescu f09bc4566c For #6557 - added metric for in_content 2020-04-24 15:47:48 -07:00
Mihai Branescu f10e202a1e For #6557 - added web-extension for cookies 2020-04-24 15:47:48 -07:00
mcarare 996dabae8b For #10188: Fix layout constraints. 2020-04-24 13:28:53 -07:00
mcarare 0f3d4e4cbe For #10188: Fix xml indentations and properties order. 2020-04-24 13:28:53 -07:00
mcarare e830da59b7 For #10180: Remove touch delegate when button is disabled.
Also refactored multiple if's into a when.
2020-04-24 13:28:29 -07:00
mcarare 3e13927c25 For #10180: Add extension to remove touch delegate from parent. 2020-04-24 13:28:29 -07:00
ekager 59484208d6 No issue: Update Private Browsing placeholder string 2020-04-24 11:39:14 -07:00
Mihai Branescu 8a80fbe14c For #6558 - change from modifying event to event listener
The initial design replaced the onload method, which was used by others such as Bing.
With listeners it's additive, we do not replace anything.
2020-04-24 09:28:40 -07:00
Mihai Branescu 8e66e19dbb For #6558 - remove baidu and yahoo from monitored pages
These two do not contain ad servers, so we don't need to unnecessarily monitor them
2020-04-24 09:28:40 -07:00
Mihai Branescu c4d76dce5a For #6558 - cleanup + added unit tests 2020-04-24 09:28:40 -07:00
Mihai Branescu f03d65b13d For #6558 - added logic for ad_clicked metric 2020-04-24 09:28:40 -07:00
Mihai Branescu 93ca1f6d9f For #6558 - added handling of web extension + sending metric for has_ads 2020-04-24 09:28:40 -07:00
Mihai Branescu c4f7972f2b For #6558 - added web extension for extracting document urls 2020-04-24 09:28:40 -07:00
Simon Chae f1559ed2da
For #10162: Set switch back to prev state when failed to enable/disable addon (#10164) 2020-04-24 11:54:16 -04:00
mcarare 2edd4b39a4 For #9913, For #9914: Remove button when disabling it.
Setting visibility to GONE allows clicks to parent view in that space.
2020-04-24 16:42:47 +03:00
Arturo Mejia 956bf01cd5 For issue #9493: Reload after cleaning individual site permissions exceptions 2020-04-24 06:16:32 -04:00
David Walsh 6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app (#9934) 2020-04-23 15:38:35 -05:00
Vlad Filippov e51e1c878b Add 'useEmail' and 'useEmailProblem' metrics event
Fixes #9834
2020-04-23 10:33:36 -07:00
Simon Chae b3248ec769 For #6123: Expose WebExtensions in private browsing control 2020-04-23 12:28:57 -04:00
mcarare cc67de29bf For #10091 Also disable play/pause button when hiding it. 2020-04-23 09:22:01 -07:00
mcarare 9dd8314d14 For #10091 Add extension to remove and disable button 2020-04-23 09:22:01 -07:00
mcarare 932fd44823 For #7387: Change ETP onboarding from popup to a dialog.
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
2020-04-23 08:17:42 -07:00
mcarare 72fe52fcb8 For #9987: Set FLAG_SECURE to dialog when flag set in activity. 2020-04-23 08:16:25 -07:00
ValentinTimisica da3fca0f29 Fixes #10109: Adds content description for browse privately card content 2020-04-23 16:59:42 +03:00
JLRoberts 26e8d9bcca For #9550 - Don't overlap search with shortcuts text
Private mode search with suggestion onboarding was overlapping "This time, search with: " text. Adjust constraints to allow it to show under onboarding when present.
2020-04-23 11:21:53 +03:00
mcarare e11f1b62dc For #10027: Make toolbar context menu popup dismissible on SDK<23 2020-04-22 22:47:46 -07:00
ekager c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 2020-04-22 20:56:35 -07:00
ekager 6457a02a82 For #2818 - Enable PiP for all builds 2020-04-22 20:55:00 -07:00
Roger Yang 0227e953ae Close #9760: Add external app links context menu candidate 2020-04-22 14:45:49 -07:00
Sawyer Blatz dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 2020-04-22 14:29:43 -07:00
Arturo Mejia 0a23d66756 For issue #7566 Handle deny & don't ask again for site permissions 2020-04-22 11:33:32 -04:00
Arturo Mejia 995da59fa8 For issue #9493: Reload after cleaning all site permissions exceptions 2020-04-22 08:53:07 -04:00
ekager 70755adf6e For #10036 - Workaround for System Theme changes with config change 2020-04-22 00:01:54 -07:00
Michael 1f8b7ff962 Closes #8541: Hide find bar when entering fullscreen 2020-04-22 00:01:35 -07:00
Jeff Boek 164e6cd079 For #9816 - Adds SessionObserver to session on selection 2020-04-21 14:08:58 -07:00
Jonathan Almeida 6ad046714d Close #9338: Enable WebPush engine integration in all builds 2020-04-21 09:38:13 -04:00
ekager f3847d0d7c For #8735 - Adjust fontInflation engine setting when toggling useAutoSize 2020-04-21 09:05:25 +03:00
Mozilla L10n Automation Bot c702de05f9 Import l10n. 2020-04-21 09:04:12 +03:00
ekager a1554834f9 Adds destructive colors for private theme 2020-04-20 23:00:41 -07:00
codrut.topliceanu d80005235f For #8546 - Overrides for new TextInputLayout colors 2020-04-20 23:00:41 -07:00
ekager 66d9a24b28 Closes #9928 - Updates private browsing text description 2020-04-21 09:00:06 +03:00
ekager 5d51c4f059 Don't use ProcessLifecycleOwner for view-tied consume 2020-04-20 12:07:37 -07:00
ekager f801f32027 No issue: Fix leaks in BookmarkFragment 2020-04-20 12:07:37 -07:00
ekager 5014cd78ec No issue: Fix leaking sessionControlInteractor 2020-04-20 12:07:37 -07:00
Grisha Kruglov 853a0acab4 Closes #4046: Always display 'Desktop' bookmarks folder
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.

In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
2020-04-17 23:57:43 -07:00
Jonathan Almeida c16283a923 For #9932: Fix navigation icon theme missing from migration UI
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
2020-04-17 22:45:30 -07:00
Sawyer Blatz 89cfa3ea9a For #9808: Fix scrolling cutoff on homescreen 2020-04-17 19:58:22 -07:00
Sawyer Blatz a8e624959e
For #6940: Fixes top dynamic toolbar behavior (#9900) 2020-04-17 13:32:20 -07:00
Roger Yang 40550e88de
Close #9960: Launch URI in Fenix if failed to launch in custom tab (#9964) 2020-04-17 16:24:20 -04:00
Christian Sadilek ec1d4e8fca For #8399: Hide keyboard to prevent content resizes
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
2020-04-17 12:07:44 -07:00
Emily Kager d3093e4afe
For #8428 - move about text from static_strings.xml to strings.xml and fix comment (#10009)
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
2020-04-17 11:50:56 -07:00
Jonathan Almeida cab0bfc073 For #8422: Add more misc migration UI fixes 2020-04-17 14:22:25 -04:00
Michael Comella f3ed207bdb For #8803 - review: Add clarifying comments to onAppInit capture methods. 2020-04-17 09:11:58 -07:00
Michael Comella f49fc6dad2 For #8803: hook up frameworkStart metric. 2020-04-17 09:11:58 -07:00
Michael Comella dbf733d70a For #8803: add StartupFrameworkStartMeasurement.
This class controls the central logic around the metrics we want to
record.
2020-04-17 09:11:58 -07:00
Michael Comella 7f618a6a7c For #8803: add Stat and test.
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
2020-04-17 09:11:58 -07:00
Emily Kager 39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected (#10016)
* For #9703 - Call fullScreenChanged in onPause

* For #10015 - Exit full screen if new session selected
2020-04-17 08:57:36 -07:00
ekager 6f77ec5951 Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver 2020-04-16 21:00:27 -07:00
Grisha Kruglov 0ec6d266e8 Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
2020-04-16 21:00:27 -07:00
Mihai Adrian 72fe9fad0c
For #9987: Set FLAG_SECURE to dialog when flag set in activity. (#9998)
* For #9987: Add extension to secures dialog if parent activity is secured

* For #9987: Set FLAG_SECURE to dialog when flag set in activity
2020-04-16 20:33:57 -07:00
mozilla-l10n-automation-bot dbbd048b6c
Import l10n. (#10011) 2020-04-16 20:32:21 -07:00
Emily Kager 1df9c53b9f
Fix: Set correct height for EditText (#10014)
Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.

Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
2020-04-16 20:31:25 -07:00
Mihai Eduard Badea 725ba1e856 For #9951 - Removed the extra empty spaces that were causing the spacing issue 2020-04-16 20:12:18 -07:00
mcarare 5a2a779ef5 For #9565: Adjust padding and height to allow longer text 2020-04-16 20:10:45 -07:00
mcarare 83d2208c6b For #9536: Open report issue tab depending on current browsing mode.
Checking if session is private uses the new browser state API.
2020-04-16 19:50:25 -07:00
mcarare 8440f1867a For #9989: Add start & end margin to button. 2020-04-16 19:43:34 -07:00
Sawyer Blatz 1f8f69548a For #7158: Fixes browser to search animation fade 2020-04-16 14:03:26 -07:00
ekager 6df11619fd No issue: Uses NeutralButton for Migration Activity 2020-04-16 13:14:34 -07:00
Jonathan Almeida 2bb1b6edad For #8422: Add misc migration UI fixes 2020-04-16 12:02:02 -07:00
Jonathan Almeida 25d5b0d31c For #8422: Add spacing between migration items 2020-04-16 12:02:02 -07:00
ekager 4a06a228f3 For #9981 - Make Bookmark Menu UI respond to session selection 2020-04-16 10:49:16 -07:00
mcarare 25e12e2f77 For #9984: Update addon before settings visibility check 2020-04-16 10:25:37 -04:00
Mozilla L10n Automation Bot 3e8836f71a Import l10n. 2020-04-16 10:13:30 +03:00
ekager 688a33522b For #9516 - Adds selectable background to dialog and snackbar buttons 2020-04-16 10:13:08 +03:00
Sawyer Blatz 8185ba793e
For #9857: Create button style (#9858)
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
2020-04-15 15:49:02 -07:00
Jonathan Almeida 997f6c72d6 For #9409: Add app icon to Leanplum push notifications 2020-04-15 17:55:12 -04:00
Jonathan Almeida e97904662c Remove duplicate FirebasePushService
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
2020-04-15 17:55:12 -04:00
Mihai Branescu bded28a017
For #9420 - relaxed custom engine rules (#9967)
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
2020-04-15 13:20:06 -07:00
ValentinTimisica c7b123cfea
Fixes #9710: Vertically aligns users_count with rating (#9950) 2020-04-15 10:51:55 -07:00
ekager aef827e607 For #9887 - Respect screenshot setting when resetting window flags in logins 2020-04-15 09:03:26 -07:00
Jeff Boek 06f1b6c992
No Issue - Fixes nav_graph issues (#9926) 2020-04-15 08:34:45 -07:00
Arturo Mejia 37a277febb For issue #9930 Do not assume all add-ons have a settings page 2020-04-15 06:20:34 -04:00
Mozilla L10n Automation Bot 9a298ea6ba Import l10n. 2020-04-15 03:50:48 +03:00
Arturo Mejia 8872baef39 Update Android Components version 2020-04-14 11:34:55 -07:00
Arturo Mejia 7c279b6e1f No issue: Fix add-on translate() breaking change 2020-04-14 11:34:55 -07:00
ekager 5b1cdbd8bf For #3194 - Pause media while undo snackbar appears 2020-04-14 09:55:39 +03:00
ekager 9c56a8b387 For #204 - Remove PWA Feature Flag 2020-04-14 09:55:14 +03:00
Mozilla L10n Automation Bot 69c7196e77 Import l10n. 2020-04-14 09:54:30 +03:00
Jeff Boek 4cbb9aebaf
Cleans up nav_graph.xml (#9829)
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
2020-04-13 21:43:45 -07:00
Arturo Mejia eace991859 For issue #8520: Improve add-ons UI 2020-04-13 19:01:58 -04:00
ekager b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 2020-04-13 14:56:51 -07:00
ekager ac3a557ddf For #9703 - Exit full screen on pause if pip not entered 2020-04-13 14:31:57 -07:00
Sawyer Blatz 7c3394ea7c
For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (#9893) 2020-04-13 13:08:08 -07:00
ekager 8c238402e2 For #9692 - Fix "Install" PWA menu item labeling 2020-04-13 10:09:37 -07:00