blallo
/
fenix
1
0
Fork 0
Code Releases Activity

Fix: Set correct height for EditText (#10014) 

Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.

Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
master
Emily Kager 2020-04-16 20:31:25 -07:00 committed by GitHub
parent 725ba1e856
commit 1df9c53b9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/res/layout/fragment_edit_bookmark.xml
View File

@ -36,7 +36,7 @@
<org.mozilla.fenix.utils.ClearableEditText
android:id="@+id/bookmarkNameEdit"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="@dimen/bookmark_edit_text_height"
android:layout_marginBottom="8dp"
android:drawablePadding="8dp"
android:ellipsize="none"
@ -62,7 +62,7 @@
<org.mozilla.fenix.utils.ClearableEditText
android:id="@+id/bookmarkUrlEdit"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="@dimen/bookmark_edit_text_height"
android:layout_marginBottom="8dp"
android:drawablePadding="8dp"
android:ellipsize="none"

3
app/src/main/res/values/dimens.xml
View File

@ -67,6 +67,9 @@
<!-- ETP Onboarding Popup -->
<dimen name="etp_onboarding_popup_width">256dp</dimen>
<!-- Edit Fragment -->
<dimen name="bookmark_edit_text_height">48dp</dimen>
<!-- Search Fragment -->
<dimen name="search_fragment_clipboard_item_height">56dp</dimen>
<dimen name="search_fragment_clipboard_item_horizontal_margin">12dp</dimen>