For issue #9930 Do not assume all add-ons have a settings page
parent
9a298ea6ba
commit
37a277febb
|
@ -99,7 +99,7 @@ class InstalledAddonDetailsFragment : Fragment() {
|
|||
runIfFragmentIsAttached {
|
||||
switch.isClickable = true
|
||||
switch.setText(R.string.mozac_feature_addons_enabled)
|
||||
view.settings.isVisible = true
|
||||
view.settings.isVisible = shouldSettingsBeVisible()
|
||||
view.remove_add_on.isEnabled = true
|
||||
this.addon = it
|
||||
showSnackBar(
|
||||
|
@ -164,8 +164,7 @@ class InstalledAddonDetailsFragment : Fragment() {
|
|||
|
||||
private fun bindSettings(view: View) {
|
||||
view.settings.apply {
|
||||
val optionsPageUrl = addon.installedState?.optionsPageUrl
|
||||
isVisible = !optionsPageUrl.isNullOrEmpty()
|
||||
isVisible = shouldSettingsBeVisible()
|
||||
setOnClickListener {
|
||||
val settingUrl = addon.installedState?.optionsPageUrl ?: return@setOnClickListener
|
||||
val directions = if (addon.installedState?.openOptionsPageInTab == true) {
|
||||
|
@ -263,4 +262,6 @@ class InstalledAddonDetailsFragment : Fragment() {
|
|||
setText(text)
|
||||
isChecked = checked
|
||||
}
|
||||
|
||||
private fun shouldSettingsBeVisible() = !addon.installedState?.optionsPageUrl.isNullOrEmpty()
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue