1
0
Fork 0
Commit Graph

3990 Commits (69a9aeebae193107ba122bf60e5b60386666d85b)

Author SHA1 Message Date
ValentinTimisica 4a93a41bb2 For #11763: Fixes unit tests 2020-07-06 17:06:10 -04:00
ValentinTimisica e39d5b6de7 For #11763: Shows confirmation dialog when deleting last tab from collection 2020-07-06 17:06:10 -04:00
ValentinTimisica c3acde438a For #11889: Changes collection creation confirmation snackbar strings
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
2020-07-06 17:02:02 -04:00
Tiger Oakes 1ab5fe3eb9
Add method to test fragments in roboletric (#12261) 2020-07-06 13:04:43 -07:00
Hakkı Kaan Çalışkan 426a1ba57d For #12078: Follow ux mock on Settings --> Language screen 2020-07-06 15:47:42 -04:00
mcarare 9bc4f443f5 For #9775: Increase touch target of elements in add search engine screen 2020-07-06 15:47:25 -04:00
ekager 170ae1aa33 For #12263 - Adds end margin to synced tabs header 2020-07-06 15:37:53 -04:00
Hakkı Kaan Çalışkan 331090d1e6 For #12007: Fix add search engine items using wrap content for height 2020-07-06 15:37:28 -04:00
Hakkı Kaan Çalışkan 296bdc5967 For #12016: Follow ux mock on Settings --> Data Collection 2020-07-06 15:27:46 -04:00
Emily Kager 90f43bf350
For #12086: Follow ux mock on Settings --> Customize screen (#12324)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-06 12:25:54 -07:00
MickeyMoz da39a7e671 Update Android Components version to 49.0.20200705130154. 2020-07-06 15:21:40 -04:00
mcarare 94273bc274 For #12125: Handle visibility updates for add to collection button. 2020-07-06 14:37:39 -04:00
Mozilla L10n Automation Bot 2668a68678 Import l10n. 2020-07-06 14:06:24 -04:00
ekager 822d50192a For #12316 - Allow text wrap on buttons 2020-07-06 20:56:54 +03:00
Tiger Oakes fd18687ac9 Switch to any calls 2020-07-06 20:38:08 +03:00
Tiger Oakes 41452e945b Move SearchProviderModel extension to class 2020-07-06 20:38:08 +03:00
Oana Horvath 836199ff16 For #11764: doubles long-press delay UI test 2020-07-06 19:13:53 +03:00
Aaron Train 3351a02885
For #12309: Disable verifyContextSaveImage and verifyContextMixedVariations (#12314) 2020-07-06 11:51:06 -04:00
Mugurell 0fb6bbc175 For #10401 - Hide Shortcuts if just one search engine is installed
Otherwise, the Shortcuts option which allows to choose with what search engines
to search would be redundant.
2020-07-06 14:36:04 +03:00
Sebastian Kaspari 388c144a62 SearchFragmentStore: Remove Session reference from state and read values from BrowserStore. 2020-07-03 21:01:59 +02:00
Sebastian Kaspari 942b901b81
Closes #12171: (fenixProduction) Add vector image for full Nightly logo. (#12254) 2020-07-03 10:55:26 -07:00
isabelrios 84324f52ae
For #12018 - Sync Int tests fixes (#12252) 2020-07-03 13:49:40 -04:00
Aaron Train 0a4f92a5d0
No issue: Re-enable Context Menu UI tests (#12250) 2020-07-03 13:48:46 -04:00
Aaron Train 901a90643f
Closes #8714: Re-enable toggleShowVisitedSitesAndBookmarks (#12251) 2020-07-03 13:20:39 -04:00
isabelrios 4dc3a00ed0
For #12224 - Fix UI testAboutFirefoxPreview (#12233) 2020-07-03 12:31:47 -04:00
ekager f863c341e8 Updates AC to 49.0.20200702190156 and fixes breaking changes 2020-07-03 06:40:06 -04:00
ekager 8533d96ee2 For #11320 - Expose login autofill setting to beta dimension 2020-07-03 06:40:06 -04:00
liuche 6ec0aeb843
Issue #12207 - Update "new nightly" link to point to org.mozilla.fenix (#12209) 2020-07-02 12:39:44 -07:00
Sawyer Blatz 8583cac8f8 Revert "For #11183: Redirect user to homescreen after widget added"
This reverts commit a8ed913654.
2020-07-02 11:22:18 -07:00
Sawyer Blatz 3cbab45566 For #12157: Don't show two search widget dialogs 2020-07-02 11:22:18 -07:00
mozilla-l10n-automation-bot 321ba02832
Import l10n. (#12175) 2020-07-02 08:29:18 -07:00
liuche ad8e28ae02
For #12007: Follow ux mock on Settings --> Search screen (#12177)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-02 00:48:31 -07:00
Tiger Oakes ed3a80a756
For #12095: Remove TWA feature flag (#12096) 2020-07-01 19:14:41 -07:00
Mihai Adrian Carare daecbd348b
For #11996: Open all links from add-on details in Fenix. (#12080)
* For #11996: Open add-on homepage link in Fenix.

* For #11996: Open add-on details links in Fenix.
2020-07-01 19:13:23 -07:00
Johan Lorenzo d51faea6c5
Bug 1649400 - part 2: Make fennecProduction use the Firefox Nightly b… (#12173)
* Bug 1649400 - part 2: Make fennecProduction use the Firefox Nightly branding

* try nightly

* Revert "try nightly"

This reverts commit d2b288b440eb4739b053bdfa4d1f5a9a2cc1df68.
2020-07-01 18:00:44 -07:00
Sawyer Blatz 306505fee0
No issue: Remove feature flag for tips (#12172) 2020-07-01 14:47:40 -07:00
Richard Pappalardo 11aea321ed
Fixes #11642 - Re-enable disabled UI-tests (#12142) 2020-07-01 09:15:57 -07:00
liuche ba55243ed8 Revert "For #9946: Update FennecBeta branding (#10066)" to push to Firefox Beta (#11872)
* Revert "For #9946: Update FennecBeta branding (#10066)" to push to Firefox Beta.

This reverts commit 95f26f1fdc.
2020-07-01 09:04:35 -07:00
Johan Lorenzo 4bc1cb94c5
Bug 1649400 - part 1: ship org.mozilla.fenix as a nightly product (#12127) 2020-07-01 11:03:10 +02:00
Mozilla L10n Automation Bot d17e91cc2e Import l10n. 2020-07-01 08:48:18 +03:00
Jeff Boek fb4822498f For #12081 - Properly installs searchengines when MLS completes 2020-06-30 13:35:08 -07:00
Mozilla L10n Automation Bot 7b3fe9bab4 Import l10n. 2020-06-30 10:25:21 +03:00
Tiger Oakes 50c3c9a9dd
Fix ignored XML lint issues (#12094) 2020-06-29 16:36:52 -07:00
ekager 70f90e71e8 For #11991 - Show tab count during onboarding 2020-06-29 17:59:19 -04:00
Tiger Oakes 6bde0378a2
Add tests for StrictModeManager (#12013) 2020-06-29 08:17:07 -07:00
Mozilla L10n Automation Bot f77bfdc2f2 Import l10n. 2020-06-28 20:41:02 -04:00
Mozilla L10n Automation Bot a07f31375e Import l10n. 2020-06-28 09:59:49 -04:00
ekager 60069395eb Update AC to 48.0.20200627130132 and fix breaking changes 2020-06-27 20:11:31 -04:00
Mihai Eduard Badea e0fa1c0db4 For issue #11835 - Update text fonts
Updated the fonts and colors for several texts throughout the application.
2020-06-26 23:18:52 -04:00
Tiger Oakes ed334788e8 For #11903: Enforce private theme in custom tabs 2020-06-26 22:59:43 -04:00
Jeff Boek b1a8c0f483 For #9935 - Use the searchengine deferred 2020-06-26 19:07:36 -07:00
Jeff Boek 40977a93a0 For #9935 - Fallback region selection on first load 2020-06-26 19:07:36 -07:00
Michael Comella 5ef6b49aa1
For #8795: remove redundant ConstraintLayout around BrowserToolbar. (#12014)
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.

The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.

Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
2020-06-26 21:31:02 -04:00
David Walsh c4a4beb6b9 For 11468 - Show tab tray after opening links from history and bookmarks 2020-06-26 18:28:31 -07:00
Kate Glazko 2ac8496315 For #12025: Set Search Shortcuts Off By Default 2020-06-26 18:21:58 -07:00
Jeff Boek a18c1befd1
For #11044 - Sets the anchorView of the snackbar to be the new tab fab (#11930) 2020-06-26 17:56:56 -07:00
Jonathan Almeida f89b157c23
For #12002: Show default tab background when thumbnail not available (#12041) 2020-06-26 20:46:23 -04:00
Sachin 4b9cc954fa
for #11830 added new metric for collecting startup method from all startup phases (#11940)
* for #11830 added new metric for collecting startup method

move all source startup telemetry into its own logic and added an UNKOWN state

* switched back to onNewIntent solution

* renamed the metric
2020-06-26 17:38:08 -07:00
Sawyer Blatz 61b1b5a895
No issue: update experiments when experiments updated (#12032) 2020-06-26 17:19:58 -07:00
Sawyer Blatz 8a08cb941e
For #11479: Record open tabs count in metrics ping (#12024) 2020-06-26 17:15:43 -07:00
MarcLeclair c6415ce18f
For 11616: removed black flicker with placeholder animation (#11796)
Increasing duration removed second "light" flicker
2020-06-26 20:10:22 -04:00
Jonathan Almeida b7d989a588 Fix breaking API in WebNotificationFeature 2020-06-26 19:59:57 -04:00
Marc Leclair ff5d00362b Added A-C version 48.0.20200626213814 2020-06-26 19:59:57 -04:00
Sawyer Blatz 101ecfbf66
For #11273: Add tabs tray telemetry (#12036) 2020-06-26 16:37:07 -07:00
Tiger Oakes 7287b5579f
Test settings about/advanced (#12023) 2020-06-26 15:53:30 -07:00
mozilla-l10n-automation-bot e71e7fb9c6
Import l10n. (#12022) 2020-06-26 15:44:57 -07:00
Tiger Oakes 4f6f0785c5
For #11943: Fix intermittent coroutine failure (#12027) 2020-06-26 15:42:53 -07:00
ekager df49db6adb For #11294 - Enable Synced Tabs for all builds 2020-06-26 18:36:37 -04:00
Hakkı Kaan Çalışkan 2cbd969e34 For #11641: Update synced tabs view 2020-06-26 18:11:13 -04:00
Gabriel Luong e6a56aec36
For #12026 - Update default top sites for new users (#12028) 2020-06-26 17:51:18 -04:00
Grisha Kruglov f8cb1d6b48 Closes #11909: Metrics for recording number of recently used PWAs 2020-06-26 14:13:41 -07:00
Elise Richards eeabcb10ff
Fix illegal arguments for onboarding keys (#12033) 2020-06-26 16:12:18 -05:00
Tiger Oakes bcb2ef10ac
Add tests for PhoneFeature (#12021) 2020-06-26 12:12:52 -07:00
MarcLeclair f3b44c06e4
For #11841: Removed topsite bug on private browsing (#12020) 2020-06-26 14:54:20 -04:00
Gabriel Luong 005ad6ff2a
Update Android Components version to 48.0.20200626130049. (#12006)
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-06-26 14:16:57 -04:00
Tiger Oakes 80de3851f3
Add tests for OnSharedPreferenceChangeListener (#12019) 2020-06-26 11:04:46 -07:00
mcarare 64947a8686 For #10285: Swap TextView for a LinkTextView to improve links a11y 2020-06-26 18:11:11 +03:00
ValentinTimisica 9f5c8819d3 For #11892: Remove dynamic calls to setupNavigationToolbar
This is a speculative fix for 11892 crash.
The side effect is that the back button will be visible in bookmarks root.
2020-06-26 07:54:11 -04:00
Mihai Branescu 93247e0b2f For #9425 - SearchFragment now reacts to undo operation for base engines 2020-06-26 13:21:00 +03:00
Mihai Branescu e6e3166d2d For #9425 - SearchFragment now reacts to undo operation for custom engines
When you remove a search engine from our list, an undo snackbar that outlives the fragment is shown. If you go back to the search fragment and press undo, now the shortcut list gets updated
2020-06-26 13:21:00 +03:00
Mihai Branescu 46c1c130da For #9425 - Handle undo for custom search engines
On undo, get the template that the user entered for that engine and then
re-add it to the `CustomSearchEngineStore`
2020-06-26 13:21:00 +03:00
Sawyer Blatz c5034fa770 No issue: Allow us to run experiments on nightly if needed 2020-06-26 09:16:38 +03:00
mcarare 0626384baf For #10285: Swap TextView for a LinkTextView to improve a11y. 2020-06-26 09:15:44 +03:00
mcarare 216da0c64b For #10285: Add a custom TextView for links with a11y improvements. 2020-06-26 09:15:44 +03:00
mozilla-l10n-automation-bot ebd9efc769
Import l10n. (#11981) 2020-06-25 18:03:19 -07:00
Kainalu Hagiwara b84f55c980 For #11677 - Adjust tab counter menu item order. 2020-06-25 15:48:10 -07:00
person808 ad90625b48 For #2165 - Add swipe to refresh gesture to bookmarks view. 2020-06-25 14:50:24 -07:00
Christian Sadilek 64440409b0 For #9100: Follow-up to fix memory leak in NotificationSessionObserver
The observer was moved and is now bound to the activity and its
context. If the activity is re-created we leak the observer and
therefore the activity itself.

With this we make sure to stop the observer and also don't use
the activity context to begin with.
2020-06-25 16:17:38 -04:00
ekager c77ddd8d26 For #11866 - Update back press logic for SearchFragment 2020-06-25 14:40:31 -04:00
Christian Sadilek 7be56ce4fa For #11798: Allow sharing of reader view pages 2020-06-25 14:39:21 -04:00
Sawyer Blatz 04aee11d82
For #9625: Add telemetry for Tracking Protection CFR (#11923) 2020-06-25 11:24:55 -07:00
Oana Horvath 45bc42f92d
For #11764: delay single-click duration to avoid long-clicks (#11949) 2020-06-25 14:21:51 -04:00
Elise Richards 665fb8d60c
#10824: Onboarding telemetry (#11867)
* Onboarding events and tracking

* Rename metrics for consistency

* Add reference to PR for the data review

* Add default values to onboarding events
2020-06-25 13:21:31 -05:00
Oana Horvath 932a032772
Closes #11947: fix and enable closePrivateTabsNotificationTest (#11951) 2020-06-25 14:17:04 -04:00
Sawyer Blatz 2d65faf232
For #11392: Rename Installation ping to FirstSession (#11869) 2020-06-25 10:06:26 -07:00
ekager d3de9e517e Remove ThumbnailsUseCases 2020-06-25 12:51:18 -04:00
Tiger Oakes c958cc048a Update customtabs service 2020-06-24 23:26:49 -04:00
Sawyer Blatz 13c8abe3dc For #11613: Expand toolbar onUrlChanged 2020-06-24 21:50:06 -04:00
Mihai Branescu be5213e944 For #11727 - added content description 2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan 9068c96ab3 don't animate unnecessarily
Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily

don't animate unnecessarily

Fixes #11739: Fix flicker

Update TabCounter.kt

squash commits

don't animate unnecessarily

Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily
2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan 3dc6c438f4 Fixes #11739: Fix flicker 2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan b95804c33b Fixes #11672, #11727: Empty default tab text and add padding to infinite character 2020-06-24 21:42:38 -04:00
Sawyer Blatz a8ed913654 For #11183: Redirect user to homescreen after widget added
Co-authored-by:  hakkikaancaliskan <caliskanhkaan@gmail.com>
2020-06-24 21:41:42 -04:00
David Walsh 77ed670558 For #11860 - Conditionally show add to collection button on Home screen 2020-06-24 21:41:19 -04:00
mcarare 7b20bb9976 For #11562: Align overflow menu button with close buttons. 2020-06-24 21:40:57 -04:00
mcarare 4aaa54c994 For #11880: Provide default text color for errors in a TextInputLayout 2020-06-24 21:40:10 -04:00
Sawyer Blatz 872c179cf4 For #11825: Removing the last pretty animation 😞
Goodbye, sweet summer child.
2020-06-24 21:38:28 -04:00
mcarare a056e86e4f For #8080: Dismiss menu when swiping away from its anchor. 2020-06-24 21:37:57 -04:00
mcarare b961fdcf02 For #11901: Use safe call for collection item info. 2020-06-24 21:37:24 -04:00
Mihai Branescu 49b617c999
For #9100 - Private browsing notification fixes
Co-authored-by: Seef <Saif Dara>
2020-06-24 21:35:11 -04:00
Mihai Branescu 632b64971f For #10467 - removed unused tests and resources related to blue dot notification 2020-06-24 21:33:32 -04:00
Mihai Branescu 3c2c7f705c For #10467 - blue dot doesn't disappear on menu dismiss 2020-06-24 21:33:32 -04:00
Tiger Oakes 0b781ae3b7 Add tests for collection creation controller 2020-06-24 21:21:02 -04:00
Jeff Boek 177e7a400f For #11406 - Scrolls to selected tab when switching modes 2020-06-24 21:16:48 -04:00
Jeff Boek 2c39d3ebca For #11430 - Gives enough padding to the tab tray give adequate space for the fab 2020-06-24 21:16:24 -04:00
Mozilla L10n Automation Bot fe023e1a74 Import l10n. 2020-06-24 21:16:07 -04:00
Tiger Oakes 4415702fa8 Add tests for share sheet 2020-06-24 20:33:47 -04:00
Tiger Oakes 183ba1bce0 For #11903: fix custom tab private gradient 2020-06-24 20:33:16 -04:00
ekager f39313d908 For #8374 - On external session removed, handle back press 2020-06-24 20:17:26 -04:00
Tiger Oakes ce31a620d5 Minify XML path 2020-06-24 14:05:44 -04:00
person808 5f7e0e4dd6 Followup for #11442 - Add tab counter menu metrics to home fragment. 2020-06-24 10:20:51 -07:00
mozilla-l10n-automation-bot 673507d9b3
Import l10n. (#11870) 2020-06-23 19:02:50 -07:00
Tiger Oakes 9a8b800a76 For #8621 - fix intermittent test failures 2020-06-23 17:43:24 -04:00
Jeff Boek 621da0c4c1
For #9935 - Adds fallback searchengine provider for long MLS lookups (#11863) 2020-06-23 14:00:18 -07:00
mcarare fe97dc9d2e For #11542: Update tabs positions in tab tray reported by screen readers 2020-06-23 11:28:24 -07:00
ekager 06e6cfa696 For #5636 - Unregisters wifiConnectedListener when setting changes, sets default blocked 2020-06-23 12:28:52 -04:00
Jeff Boek 8ce7cf59c8
For #11261 - Dismisses menu when rotating to landscape (#11845) 2020-06-23 10:50:20 -05:00
Jeff Boek 1cc259169d For #11042 - Make it slightly harder to accidently dismiss the tabs tray 2020-06-23 08:19:00 -07:00
Jeff Boek 2861421312 For #11112 - Adds save tabs to collection button to the no collections message 2020-06-23 08:17:55 -07:00
Mihai Branescu 55a3b6a622 For #8278 - added production branding 2020-06-23 12:27:58 +03:00
Mihai Branescu 9e91388337 For #8278 - added horizontal wordmark 2020-06-23 12:27:58 +03:00
Mozilla L10n Automation Bot dc36c9a6b5 Import l10n. 2020-06-22 22:08:59 -04:00
Tiger Oakes ccb532bb77
For #11534 - Don't check lastUsed mode for screenshots (#11827) 2020-06-22 17:38:58 -07:00
ekager 761d253f59 For #8649 - Fixes overlapping bookmark sign in button 2020-06-22 18:19:47 -04:00
Jeff Boek c7b1f215c8
No Issue - Fixes flash when toggling tab tray (#11826) 2020-06-22 16:49:07 -05:00
Tiger Oakes 18cc4c95c1
Add tests for ContextKt (#11824)
Migrated from an old branch by Kate

Co-authored-by: Kate Glazko <katglazko@gmail.com>
2020-06-22 14:00:43 -07:00
Hakkı Kaan Çalışkan c8d36ddc36 For #8649: No bookmarks here strings are close to the top 2020-06-22 16:04:20 -04:00
ekager 88765c348b Update A-C version, add synced tabs empty state 2020-06-22 15:13:13 -04:00
mcarare 721e290734 For #10049: Provide correct seek bar value to screen readers. 2020-06-22 13:58:33 -04:00
mcarare 00862708ae For #10551: Increase touch target for link. 2020-06-22 13:58:02 -04:00
ValentinTimisica c75ab3f720
For #10462: Removes back button from bookmarks and history fragments (#11721) 2020-06-22 13:15:33 -04:00
ekager 635c30510d No issue: refactor tabs tray to use interactor/controller, add tests 2020-06-22 13:01:35 -04:00
Mugurell 0ba1d266b3 For #9144 - Ignore previous Intent if activity is started from Recents
We'll now clearly differentiate between cold / hot starts of HomeActivity.kt.
This is needed because Android will resend the original Intent which initially
started the Activity whenever it is restarted from the Recents Screen if the
activity is already destroyed at that time. So in the event that the activity
was before started with an Intent to open a webpage for example whenever the
activity is restarted from Recents it will receive the same Intent to open a
webpage even though that Intent has already been consumed.

Activity's onCreate() will only use the intent processors when the activity is
cold started so that we'll only initially act upon Intents configured for
different behaviors inside the app.
If the activity is destroyed while in background and opened from Recents it
will not act upon the original Intent which is now resent by Android.

Activity's onNewIntent() will be called to act upon a new Intent if the
activity is hot started since we are declared as singleTask and it now has the
responsibility to delegate various intent processors to consume that Intent.
2020-06-22 12:08:24 -04:00
Oana Horvath 79f231b80d
Fixes #11797 defaultDesktopBookmarksFoldersTest intermittent failure (#11803) 2020-06-22 11:03:22 -04:00
ValentinTimisica 0b57f5e71b Fixes #10551: Removes the increased touch target for learn more link 2020-06-22 16:40:15 +03:00
Mihai Eduard Badea eb45b37207 For issue #10727 - Hide saved logins details
Removed the clearFlags call from the HomeActivity that was causing this issue and removed the now redundant call to update the flag from the redirectToReAuth method
2020-06-22 13:19:02 +03:00
ValentinTimisica e9bb11e22d Fixes #9205: Changes add-ons and 'Open links in apps' icons from menus 2020-06-22 12:09:19 +03:00
Mozilla L10n Automation Bot b635af8244 Import l10n. 2020-06-21 21:40:24 -04:00
Sachin 988513aa89
for #10568 moved awesomebar and toolbar into fragment_search (#11744) 2020-06-21 14:56:49 -07:00
Sachin 9269a53b21
for #11615 allowed strictMode disk read for violations made by the OS. (#11658) 2020-06-21 14:54:49 -07:00
Mozilla L10n Automation Bot 56ff4e4797 Import l10n. 2020-06-20 08:57:51 +03:00
Antti Vainikka cb129231ae Closes #11500: Remove wrong activity title 2020-06-19 18:17:35 +03:00
ValentinTimisica 3ad7795a2d Fixes #11134: Removes margin to allow collection title to expand 2020-06-19 17:27:57 +03:00
Oana Horvath 76266c84c2
For #11642: disables UI test privateModeScreenItemsTest (#11768) 2020-06-19 16:14:33 +03:00
Oana Horvath 268c4f25d8
No issue: re-enables tests ignoring the verifyPageContent step (#11765) 2020-06-19 15:51:50 +03:00
mcarare a0fe1a452a For #11756: Fix bottom toolbar preference reference. 2020-06-19 11:20:08 +03:00
mcarare f4ebe39311 For #11665: Update UI tests. 2020-06-19 09:32:37 +03:00
mcarare 4bebc56c50 For #9229: Remember options for delete browsing data. 2020-06-19 09:32:37 +03:00
mcarare e7bc266578 For #11665: Adjust visual design for delete browsing data screens. 2020-06-19 09:32:37 +03:00
mozilla-l10n-automation-bot 99f1f6732a
Import l10n. (#11752) 2020-06-18 19:49:18 -07:00
MarcLeclair b52091ed34
For #11660: added prefetch for topsites and update in onCreateView() (#11668)
* For #11660:added prefetch for topsites

TopSites will be prefetched with observerOnce (wrapper around observerForever).
Also, the SessionControlView.update() is called right away instead of waiting from consumeFrom
in the HomeFragment.onCreateView() which will allow the UI to render all at once on its first
perform traversal

* Removed the submitList(null) since it retriggered a drawing on lower end device
2020-06-18 19:43:20 -04:00
Emily Kager 44ff29bdc0 Revert "For issue #9949 - Bookmarks/History deletion inconsistencies"
This reverts commit 3feab90b19.
2020-06-18 19:31:49 -04:00
Aaron Train 4270c837be
For #10642: Comment out verifyPageContent calls (#11748)
fix: expectedText not called warning
2020-06-18 15:25:14 -07:00
ekager df63c5a4bc For #11708 - Remove setMargins in CustomTabsIntegration 2020-06-18 17:02:34 -04:00
Jeff Boek 82cbafabaf
For #11625 - Fixes tab tray staying open when opening from another app (#11740) 2020-06-18 12:32:14 -05:00
mcarare 5f1c9449f3 For #8114: Restore normal UI when a library fragment is detached. 2020-06-18 17:42:06 +03:00
Tiger Oakes c503798cd6 Replace PhoneFeature.getPreferenceKey 2020-06-18 09:02:58 -04:00
Tiger Oakes 596c579bbb Replace nullable findPreference 2020-06-18 09:02:58 -04:00
Tiger Oakes 45ef88f6b9 Replace requireNotNull(findPreference()) 2020-06-18 09:02:58 -04:00
Tiger Oakes 3e03439259 Add requirePreference helper 2020-06-18 09:02:58 -04:00
codrut.topliceanu 0eb2f328dc For #11371 - Fix for Dynamic Download Dialog 2020-06-18 09:00:55 -04:00
Oana Horvath ed41c97be0
For #11642 & #10642: Disable intermittent tests (#11724)
* for #11642: disables tests crashing

* for #10642: disables frequently failing  tests
2020-06-18 11:59:36 +03:00
Mozilla L10n Automation Bot d009b106dc Import l10n. 2020-06-18 11:18:34 +03:00
Mihai Eduard Badea 0ce4aa1e60 For issue #10764 - Onboarding toggle color
- Removed the theme from the toggle so that the default colors from the themes are used instead
2020-06-18 10:16:36 +03:00
MarcLeclair 5f7bb68a51
For #11666: TopSites layout from Constraint to Linear (#11669) 2020-06-17 19:18:14 -04:00
Hakkı Kaan Çalışkan 56b00d0625 For #11456: AddonDetailsFragment should use ConstraintLayout, not RelativeLayout 2020-06-17 15:51:29 -04:00
David Walsh 3feab90b19 For issue #9949 - Bookmarks/History deletion inconsistencies
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648.
2020-06-17 14:42:51 -04:00
Tiger Oakes f6efb386d6 Add tests for addon details 2020-06-17 14:38:50 -04:00
Mugurell fb505ed0d4 For #1871 - BrowserMenu minWidth will be 112dp.
Following user requests and UX recommendations we'll have all menus have a
dynamic width between 112dp and 314dp, automatically wrapping the widest
element.
2020-06-17 12:17:59 +03:00
Mozilla L10n Automation Bot 7e3795242c Import l10n. 2020-06-17 11:10:19 +03:00
Hakkı Kaan Çalışkan 8cbdce58e6 Update FxaServer.kt 2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan 670e03c3b2 Update app/src/main/java/org/mozilla/fenix/components/FxaServer.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan bd85a9c399 remove suppress and unnecessary otherwise = private 2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan 87a65d2445 For #9782: Clean up unused FeatureFlags
I've currently found out this ones unused.
webPushIntegration removed because looks like all fatal bugs solved as it said from note.
2020-06-16 23:30:57 -04:00
Kainalu Hagiwara 291a29b334
For #11651 - Fix top site favicon size and dark theme border color. (#11652) 2020-06-16 14:10:15 -07:00
ekager 37ccc52d35 For #11558 - Fix double click required for tabs tray 2020-06-16 15:59:38 -04:00
Sören Hentzschel 396cd61efa For #9712 - show "AC: " before AC version on "About" screen 2020-06-16 15:29:00 -04:00
Sachin 36b1c710e7
for #11617 added a resetPoliciesAfter ext function for StrictMode, and replaced all existing calls to "resetAfter" with "resetPoliciesAfter" (#11619) 2020-06-16 11:12:18 -07:00
Oana Horvath 4e590bf7f8
For #10909: Fix flaky navigateBookmarksFoldersTest (#11592) 2020-06-16 12:06:47 -04:00
Aaron Train 0eae3129ac
No issue: Disable verifyBasicNavigationToolbarFunctionality (#11643) 2020-06-16 11:40:15 -04:00
Mozilla L10n Automation Bot 6b4c46fdfb Import l10n. 2020-06-16 10:58:13 +03:00
Tiger Oakes d81aa62683 Fix PIP toolbar 2020-06-15 15:34:06 -04:00
Tiger Oakes d3d5c8934f Cleanup tests for toolbar controller 2020-06-15 15:25:33 -04:00
person808 9e3e95e351 For #11442 - Telemetry for tab counter menu. 2020-06-15 11:48:12 -07:00
Mozilla L10n Automation Bot af64d93832 Import l10n. 2020-06-15 09:53:06 +03:00
Mihai Branescu 4f870e9251 For #6126 - moved the sessionObserver init to the onCreate
This helps because we will always need the observer to be initiated, not only when the `openToBrowser` method gets called. Example: Opening a tab from the tab tray had it's own method for opening the browser, causing this to not be called.
2020-06-15 08:01:32 +03:00
Jonathan Almeida e6da2bd910 Fix breaking APIs in TabsAdapter and ViewHolder 2020-06-13 16:02:31 -04:00
TejaswiKarasani 576558818e
For #116 #173: UI test for verifying the nav toolbar buttons (#10976) 2020-06-13 09:51:40 -04:00
Tiger Oakes 704fc6f983 Use updated webapphidetoolbarfeature 2020-06-12 19:21:34 -04:00
Tiger Oakes fc96e188ab Convert flow from AC to livedata 2020-06-12 19:21:34 -04:00
David Walsh 149efc1683
For 9640 - Focus on last selected tab in tab tray with a11y turned on (#11487) 2020-06-12 18:15:13 -05:00
David Walsh 8b24cdec42
For 11428 - Focus on home screen address bar when tab tray new tab is tapped (#11429) 2020-06-12 17:55:07 -05:00
David Walsh 063cf457ba
For #11291 - Provide New Tab button when accessibility enabled (#11441) 2020-06-12 17:52:06 -05:00
liuche 35fa445165
Issue #11112 - Update empty collections string + tests. (#11538) 2020-06-12 18:01:38 -04:00
Arturo Mejia a36ec7279e No issue: Decrease the frequency for checking for new supported add-ons 2020-06-12 17:19:07 -04:00
ekager e71ed31ed9 For #11498 #11499 - preland new synced tabs strings 2020-06-12 16:04:19 -04:00
Tiger Oakes 2fdebada11 Add tests for about viewholder 2020-06-12 15:30:50 -04:00
Tiger Oakes 294f29768d Test logins settings 2020-06-12 15:30:50 -04:00
Tiger Oakes 0d4ceb186c Add test for SearchStringValidator 2020-06-12 15:29:58 -04:00
Sawyer Blatz 0a9afbed42 For #11380: Update migration tip text 2020-06-12 15:17:53 -04:00
Gabriel Luong a2f087b816 For #8312 - Land strings for limiting how many top sites you can add 2020-06-12 15:15:34 -04:00
Sawyer Blatz fffbadbfca
For #11118: Add browsing history suggestion in metrics (#11525) 2020-06-12 11:40:04 -07:00
Sawyer Blatz 13d077eb66
For #11269: Telemetry for new reader mode position (#11385) 2020-06-12 11:39:35 -07:00
Sawyer Blatz d1cd877374 For #11118: Add missing telemetry 2020-06-12 10:29:05 -07:00
Elise Richards 68017e5a00 Edit saved login duplicate error. 2020-06-12 12:12:37 -04:00
person808 a937bae2e9 Followup for #11081 - Fix top site colors for light theme. 2020-06-12 12:10:36 -04:00
mcarare eb3e4fc415 For #11504: Rectify action bar button descriptions in bookmarks screen. 2020-06-12 09:33:20 -04:00
mcarare 724ca2fca9 For #10281: Reduce logo margin to compensate top site padding increase. 2020-06-12 09:31:23 -04:00
mcarare 852720f8c6 For #10281: Change margin with padding to allow flexbox to stretch. 2020-06-12 09:31:23 -04:00
mcarare 0ebfa4f947 For #11497: Disable pull to refresh in error states. 2020-06-12 14:09:16 +03:00
mozilla-l10n-automation-bot 0c514f5f1c
Import l10n. (#11495) 2020-06-11 17:30:11 -07:00
Jeff Boek 1639b1d3a1 For #11342 - Fixes missing space for the FAB 2020-06-11 18:25:57 -04:00
Tiger Oakes 651b2831fe Fix tests in toolbar controller 2020-06-11 18:15:09 -04:00
Sachin cd26ba9a9c
for #11364 added a exception list for manufacturers violating strict mode policies on startup (#11407)
for #11364 changed blackList -> exceptionList, added one plus to the list

change magic strings into const Val
2020-06-11 11:50:07 -07:00
person808 d14b39a56e For #2165 - Implement pull-to-refresh gesture to sync history. 2020-06-11 10:23:27 -07:00
Mugurell f163861b47 For #11177 - Load all share targets in the horizontal share menu
This was previously regressed by having the RecyclerViews for "recent" and
"all" items put inside a HorizontalScrollView which would then prevent the
RecyclerViews from actually scrolling, recycling, showing new items.

As a quick solution that would keep the desired behavior the "all" items list
is now a child of a RelativeLayout which will allow it to load all items at
once and so all the share targets will be available to the user but which also
means no recycling.

The RecyclerView for the "recent" items uses a `RECENT_APPS_LIMIT = 6` so this
does not need the same "fix" as all the items would fit the screen without
any issue.
2020-06-11 15:08:36 +03:00
mcarare 4b04a140fc For #11229: Update etp strict option title content description. 2020-06-11 10:20:01 +03:00
Sawyer Blatz 932a2f3703 For #11063: Update telemetry for etp settings 2020-06-10 22:51:21 -04:00
person808 3ff20c0b25 For #11081 - Add dark theme colors for top sites. 2020-06-10 19:42:34 -07:00
Mozilla L10n Automation Bot 53e984ec7a Import l10n. 2020-06-10 21:20:10 -04:00
Tiger Oakes f0295048fa Remove Mockito 2020-06-10 21:19:50 -04:00
Jeff Boek cd3b6181b3 For #10374 - Adds quick contextual menu to tab switcher
Co-authored-by: person808 <kainaluh808@gmail.com>
2020-06-10 16:50:28 -07:00
Elise Richards 137d66a511
For 10172: Set edit text listeners (#11196)
* Set edit text listeners

* Set clearable icons and change with error states

* Clear text buttons show and hide

* Move error checks to afterTextChanged. Refactor. Remove unused color.
2020-06-10 16:52:47 -05:00
Tiger Oakes 31edbc924c
Fixes #9056 - Start Fenix activity on search in external app (#10932) 2020-06-10 10:25:53 -07:00
Tiger Oakes 4b064afb81
Add tests for ext package (#11334) 2020-06-10 09:14:18 -07:00
Christian Sadilek d16c70d8be Wire up UI to make add-on installation cancelable 2020-06-10 18:52:06 +03:00
ValentinTimisica ce0d5a1a28 For #11365: Fixes UI tests for Settings 2020-06-10 11:09:03 +03:00
ValentinTimisica bc53296603 For #11365: Reorganizes 'SettingsFragment' items
Moved all the functionality form 'DefaultBrowserSettingsFragment' to
'SettingsFragment'.
2020-06-10 11:09:03 +03:00
ekager 11697c1363 For #11390 - Removes redundant session observer init for ETP overlay 2020-06-10 08:37:49 +03:00
Sawyer Blatz 27c7ef5ad4 For #8775: Removes feature flag for dynamic bottom toolbar 2020-06-09 20:58:17 -07:00
ValentinTimisica 5200e00c4c For #5148: Adds tests for OpenSpecificTabIntentProcessor 2020-06-09 22:39:39 -04:00
ValentinTimisica f937c96c12 For #5148: Switch to the correct tab on media notification clicked
Processing the intent in OpenSpecificTabIntentProcessor to be able to switch
to the tab where audio/video is playing
2020-06-09 22:39:39 -04:00
David Walsh 1356b3e426 For 11271 - Provide useful tab counter message for accessibility 2020-06-09 22:37:46 -04:00
Tiger Oakes 96d2307df0 Add tests for widget 2020-06-09 22:31:12 -04:00
Tiger Oakes 434a737abf Add tests for tips 2020-06-09 22:30:30 -04:00
Tiger Oakes c270a5c6f7 Fixes #8725 - Allow for async execution order 2020-06-09 22:22:47 -04:00
ValentinTimisica 3a28704fa6 For #11132: Replaces wrong icons from menus 2020-06-09 22:19:43 -04:00
ValentinTimisica dc37baff0b For #11132: Rearranges home menu items 2020-06-09 22:19:43 -04:00
Jeff Boek f41ca2f424 No Issue - Moves from being a tabstray observer to overriding tab use cases 2020-06-09 19:13:08 -07:00
Mozilla L10n Automation Bot 2c418de0a3 Import l10n. 2020-06-09 17:30:35 -07:00
Christian Sadilek 05496faa66 Clear speculative session on engine settings change 2020-06-09 18:55:43 -04:00
ValentinTimisica 32bfba5b36 For #11201: Updates 'synced tabs' and account settings 'tabs' strings 2020-06-09 18:05:51 -04:00
Sawyer Blatz 5445d34ac4 For #11357: Use AppCompatResources for reader mode icon 2020-06-09 18:04:13 -04:00
Jeff Boek 4ee1cd6716 For #11361 - Nulls out tabsFeature in the correct spot 2020-06-09 15:34:00 -04:00
Jeff Boek d8ef0722e3 For #11175 - Moves tab tray strings to be translated, fixes description of the fab string 2020-06-09 13:06:02 -04:00
ekager 6d4a673c6f For #8967 - Expose autofill logins setting in nightly 2020-06-09 12:21:48 -04:00
ekager 29e1a9c670 For #7911 - Updates ETP shield assets with new size 2020-06-09 11:57:40 -04:00
Mozilla L10n Automation Bot 5373a75f57 For #10502 - Show snackbar after adding tabs to collection from tab tray 2020-06-09 08:29:06 -07:00
Mozilla L10n Automation Bot eebc1f936a Import l10n. 2020-06-08 22:43:25 -04:00
Grisha Kruglov 8769d98e71 Pass crashReporter instance to RustLog 2020-06-08 17:38:30 -07:00
Sachin 8fdc28010d
for #10839 added IO coroutine to check onboarding stat from sharedpref (#11338)
changed coroutine scope to fragments lifecycle
2020-06-08 15:52:10 -07:00
Jeff Boek e4e7cc5108 For #11260 - Fixes lifecycle issues with the tabs tray
- Also check to make sure the fragment manager is still valid before trying to show the tabs tray

Co-authored-by: Emily Kager <emilykager@gmail.com>
2020-06-08 18:42:46 -04:00
Sawyer Blatz e9189dc089 For #11045: Add reader mode to urlView 2020-06-08 15:12:03 -07:00
Tiger Oakes 1a19b06227
Simplify `PhoneFeature` code (#10810) 2020-06-08 13:02:42 -07:00
Sachin 74948cb3f1
for #7225, Changed strictMode thread penalty to dialog on startup and back to logs after startup is done. (#10831)
for #7225, refactored and cleanup the branch.

for #7225, change strict mode policy only on main process.

for #7225, setting thread policy inside a seperate thread to keep it from getting overridden in activities.

for #7225 removed Handler().postAtFrontOfQueue as a solution due to unknown side effects. moved the enableStrictMode function to be static so we can reuse it.

for #7225 lint check

for #7225 created strict mode manager and moved enabledStrictMode function inside it.

for #7225 removed penalty death on network

for #7225 added allow disk access on thread for already existing violation


strict mode running in main process to see if it passes the gitlab check, will revert it if it doesnt

allowed diskread for super.onCreate for home activity

added comments for disk violation oncreate homeactivity

added fragment manager inside strictmode manager

allowed disk read for onboarding

allowed disk read for cachedTopSites
2020-06-08 10:45:33 -07:00
Mozilla L10n Automation Bot 04a436d30e Import l10n. 2020-06-07 20:44:39 -04:00
Mozilla L10n Automation Bot 01ade6e62a Import l10n. 2020-06-07 12:57:03 -04:00
Mozilla L10n Automation Bot e28f9d49d1 Import l10n. 2020-06-05 21:03:20 -04:00
David Walsh d33080571b
For #11267 - Announce "Your open tabs will be shown here (#11272) 2020-06-05 17:27:45 -05:00
mcarare c8b40fa617 For #11246: Align text to viewStart to support RTL layouts. 2020-06-05 14:29:00 -04:00
person808 d66ccb8631 For #11277 - Set textAlignment to viewStart to fix RTL layout in empty ETP exceptions screen. 2020-06-05 14:27:54 -04:00
person808 a57d76eb4f For #6180 - Set textAlignment to viewStart to fix RTL layouts. 2020-06-05 14:27:26 -04:00
mcarare 512aa46224 For #11229: Update ETP cfr string and behaviour. 2020-06-05 14:18:25 -04:00
mcarare 91c27a023e For #11229: Update settings ETP copy. 2020-06-05 14:18:25 -04:00
mcarare a0d9189321 For #11229: Update onboarding ETP copy. 2020-06-05 14:18:25 -04:00
Jeff Boek 52c2fdb310
Remove tab tray feature flag (#11176)
* For #11171 - Removes feature flag for the new tab tray

* For #11171 - Removes all tab references from homeFragment

* For #11171 - Fixes unit tests

* For #11171 - Gets UI tests to compile and HomeScreenTest to pass

* For #11171 - Fixes `deleteMultipleSelectionTest`

* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`

* For #11171 - Fixes `openHistoryInPrivateTabTest`

* For #11171 - Fixes `openHistoryInNewTabTest`

* For #11171 - Fixes `openNewPrivateTabTest`

* For #11171 - Fixes tabbedBrowsingTests

* For #11171 - Fixes SettingsPrivacyTest

* For #11171 - Fixes TopSitesTest

* For #11171 - Fixes lint errors

* Ignore
2020-06-05 12:59:08 -05:00
Beatriz Rizental 41a7d6e058
For #10652: Fix validateBaselinePing test (#11254)
* Stop ignoring validateBaselinePing test

* Remove spacing between package and imports

* Add functionality to decompress gzipped ping body
2020-06-05 12:48:33 -04:00
mcarare 741fa799ad For #7752, #7753: Adjust touch targets for elements in crash reporter. 2020-06-05 12:04:58 +03:00
mcarare f47c80d10b No issue: Fix xml indentations. 2020-06-05 12:04:58 +03:00
mcarare 2d24369362 For #7725: Increase info button touch target while keeping size.
Also removed unnecessary touch delegate.
2020-06-05 11:57:17 +03:00
mcarare 8f3274eba9 For #9590: Increase widget elements touch target while keeping size. 2020-06-05 11:49:35 +03:00
person808 8c47b988b8 For #10525 - Remove tab tray item dividers. 2020-06-04 23:17:16 -07:00
ekager 094f3d0c97 Closes #10629 - Update Content Description of Edit Login Menu Item 2020-06-05 08:12:43 +03:00
Jeff Boek bc53b94feb For #10989 - Fixes memory leak caused by retaining the TabTrayView and TabsFeature 2020-06-04 23:29:14 -04:00
Mozilla L10n Automation Bot 06d9133cb9 Import l10n. 2020-06-04 20:59:50 -04:00
Sawyer Blatz 1be2ec2cbf For #9488: Init widgetExperiment after Experimenter init 2020-06-04 16:22:52 -07:00
mcarare 886c1882c5 For #11230: Set default to false for allow screenshots in private setting 2020-06-04 18:24:26 -04:00
Dennis Schubert e41fc7841a Bug 1643132 - Add WebCompat Reporter feature. 2020-06-04 18:23:11 -04:00
Dennis Schubert d046d908fc Bug 1643132 - Remove native "Report site issue" functionality.
This will be replaced by the WebCompat team's system extension that ships as an android-component.
2020-06-04 18:23:11 -04:00
Sawyer Blatz 42f58a1984 For #9488: Add experimentation support 2020-06-04 14:10:22 -07:00
ekager 54df729fb3 For #8374 - Don't recreate ExternalAppBrowserActivity or finishing activities 2020-06-04 16:44:07 -04:00
mcarare efae61d593 For #9771, #9768: Adjust touch target for buttons in error pages 2020-06-04 20:39:43 +03:00
Sawyer Blatz 9302d07d13 For #11118: Add toggle states to metrics ping 2020-06-04 10:08:23 -07:00
mcarare 5a23fb33f8 For #11182: Fix back button text update according to save step. 2020-06-04 11:50:29 -04:00
mcarare a910698007 For #11182: Set click listener also to icon button. 2020-06-04 11:50:29 -04:00
Gabriel Luong 9520c9dd32 For #8920 - [Telemetry] Send add-on ids in a metrics ping 2020-06-04 08:15:39 -07:00
mcarare a7039b15e9 For #11182: Update unit tests to reflect click listener update. 2020-06-03 23:01:44 -04:00
mcarare 29f1800021 For #11182: Explicitly clone select tabs on updating SaveCollectionStep. 2020-06-03 23:01:44 -04:00
mcarare 68286d263a For #11182: Set click listener to full layout instead of just icon. 2020-06-03 23:01:44 -04:00
Mozilla L10n Automation Bot cda6995ca7 Import l10n. 2020-06-03 21:37:44 -04:00
person808 9272026b7e For #10193 - Remove page title when sharing links 2020-06-03 15:54:23 -07:00
Tiger Oakes a7e74e308b
Migrate some SessionManager usage to BrowserStore (#10789) 2020-06-03 11:18:44 -07:00
mcarare 138c12696f For #11153:Add FLAG_SECURE on pause and clear on resume for private session. 2020-06-03 08:56:16 -04:00
David Walsh 7013e8198b For 11114 - Correct landscape tab tray buttons 2020-06-02 23:09:05 -07:00
David Walsh d862d58051 Scroll to the top of home when using the tab tray 2020-06-02 23:08:20 -07:00
Jonathan Almeida 803ed6cde3 For #11154: Fix button color on migration UI 2020-06-02 18:08:45 -07:00
mcarare 2090b11c97 For #10434: Handle cases when proc/$pid/stat is not accessible. 2020-06-02 17:57:39 -07:00
Mozilla L10n Automation Bot 0df27742a3 Import l10n. 2020-06-02 17:50:39 -07:00
ekager ead3194d86 For #8759 - Allow recently used in share fragment to scroll 2020-06-02 16:46:08 -04:00
Jeff Boek 2dd0a3cb9e
Implement tab tray design improvements and fix close functionality. 2020-06-02 15:03:58 -05:00
Aaron Train b39e0c7b42
For #10798: Disable testDownloadPrompt (#11147) 2020-06-02 12:40:08 -04:00
mcarare 7d50834a90 For #11139:Constrain title to start of checkbox and ellipsize. 2020-06-02 12:08:05 -04:00
Tiger Oakes 2a0e2f2878 Fix failing CollectionCreationBottomBarViewTest 2020-06-02 12:07:53 -04:00
Tiger Oakes 6317eea690 Add tests for some of collection creation 2020-06-02 10:06:17 -04:00
Tiger Oakes b5d03ff62d Close #10571 - Add dark mode for error pages 2020-06-02 09:55:55 -04:00
mcarare ad829115ef For #9545: Split button to allow distinct focus for a11y services. 2020-06-02 09:33:32 -04:00
ValentinTimisica 591e2c9a6f Fixes #9696: Adds Add-ons menu item to the home menu 2020-06-02 09:32:30 -04:00
ValentinTimisica 1c367080a5 Fixes #10113: Changes login prompt editText cursor color
This patch uses `mozacPromptLoginEditTextCursorColor` attribute defined in AC.
Check PR: https://github.com/mozilla-mobile/android-components/pull/7056
2020-06-02 09:29:59 -04:00
mcarare 7562e06b25 For #9595: Increase search pill touch target height to container height.
Adjust background to fit new dimensions.
2020-06-02 09:27:23 -04:00
mcarare c4f7a32eae For #9583: Increase touch targets for onboarding elements. 2020-06-02 09:26:38 -04:00
mcarare 713b004488 For #9805: Increase touch target for build date. 2020-06-02 09:26:07 -04:00
mcarare 0aeb89400b For #9805: Increase touch target for etp panel switch. 2020-06-02 09:25:51 -04:00
mcarare 7b6e1e1d69 For #11136:Move voice search preference above search suggestions. 2020-06-02 09:25:28 -04:00
Jeff Boek 5fe007b723 For #10577 - Adds elevation for the browser toolbar popup 2020-06-02 11:26:46 +03:00
Mozilla L10n Automation Bot e396f35a7b Import l10n. 2020-06-02 00:26:45 -04:00
Tiger Oakes 50441e28f1 Tests and cleanup for tracking protection 2020-06-01 22:08:52 -04:00
ekager 9ef4d9bdae For #10968 - Don't show ETP CFR if toolbar doesn't have window focus 2020-06-01 15:35:00 -07:00
Vishwa Patel 4da22c605a For #10834 - Adding Sync Tabs Feature in Fenix 2020-06-01 16:52:40 -04:00
Gabriel Luong 0300f15df1
Fix crash from TabThumbnailView where drawable is null (#11121) 2020-06-01 16:08:35 -04:00
Gabriel Luong 60b68a265a
For #10921 - Integrate BrowserThumbnails feature into the tabs tray (#11093) 2020-06-01 14:36:44 -04:00
Sawyer Blatz 82facbfa00 For #1216: Remove feature flag for voice search 2020-06-01 13:53:52 -04:00
Mozilla L10n Automation Bot ef40710404 Import l10n. 2020-06-01 10:11:13 -04:00
David Walsh 84d9e5b1fb
For 11031 - Fix landscape mode for tab tray (#11084) 2020-05-30 19:27:59 -05:00
Jeff Boek a6e77e3e8f For #10848 - Fixes unit tests 2020-05-30 10:38:48 -07:00
Jeff Boek c8e8566668 For #10848 - Fixes navigationbar colors on tab dialog fragment 2020-05-30 10:38:48 -07:00
Jeff Boek f05890efec For #10848 - Fixes bug where selected index wouldnt be properly calculated in private mode 2020-05-30 10:38:48 -07:00
Jeff Boek d5c20bc0d0 For #10848 - Fixes menu background color 2020-05-30 10:38:48 -07:00
Jeff Boek 917609aa36 For #10848 - Fixes FAB color when in private mode 2020-05-30 10:38:48 -07:00
Jeff Boek 19a709a04d For #10848 - Fixes tab tray colors 2020-05-30 10:38:48 -07:00
Jeff Boek 91402f9b38 For #10848 - Fixes icon colors and missing divider 2020-05-30 10:38:48 -07:00
Jeff Boek 8b24970aaf For #10848 - Fixes 3 dot menu color in tab tray 2020-05-30 10:38:48 -07:00
David Walsh 56de4c4c65 reduce opacity of inactive non-private/private icon in light mode 2020-05-30 10:38:48 -07:00
David Walsh b9370640a2 Update multi-task, private, 3-dot icon and hairline in light mode to ink_20 (#312A65) and in dark mode to violet_50 (#9059FF) 2020-05-30 10:38:48 -07:00
David Walsh 51ea68f4bd For 10848 - Add divider under tab headings 2020-05-30 10:38:48 -07:00
Jonathan Almeida 9f95cff6c4 Close #7749: Fix broken IntentReceiverActivity tests 2020-05-30 00:30:35 -04:00
Jonathan Almeida e995a98819 Revert "Disable failing intent handling unit tests"
This reverts commit c956f8b2afc988444771d86072adc94598c602c3.
2020-05-30 00:30:35 -04:00
Jonathan Almeida ce15763cc4 Use new AuotPushFeature.getSubscription API 2020-05-29 22:21:31 -04:00
Mozilla L10n Automation Bot 2e4766dfa2 Import l10n. 2020-05-29 17:44:35 -07:00
Tiger Oakes 221792c074
Add tests for FenixOnboarding (#11057) 2020-05-29 17:26:07 -07:00
Gabriel Luong 63e529ac2b Added BrowserThumbnails dependencies 2020-05-29 18:19:06 -04:00
Jeff Boek 8662164b8a
Refactors the TabTrayDialogFragment to ditch that weird interactor (#11061)
* For #11056 - Removes unused argument when navigating to the collection creation fragment

* For #11056 - Moved the collection creation navigation logic to the TabTrayDialogFragment

* For #11056 - Moves navigating to the share screen from home/browser to the TabTrayDialogFragment

* For #11056 - We moved tab selection logic from home/browser to the tab tray dialog

* For #11056 - Moved new tab tapped logic to the tab tray dialog fragment

* For #11056 - Removes all interactor logic for the TabTrayDialogFragment

* For #11056 - Migrates the presentation / navigation around the TabTrayDialog to the androidx navigation library
2020-05-29 17:17:56 -05:00
Jeff Boek 3946ec11de
Polish homescreen (#11065)
* For #10505 - Adjusts wordmark margins

* For #10505 - Removes topsite header, fixes collections header size and removes divider

* For #10505 - Restyle the top site items on the homescreen
2020-05-29 17:09:12 -05:00
ekager 20e358228e For #11015 - Switch Default ETP Setting to Standard 2020-05-29 16:39:47 -04:00
Tiger Oakes 749c95e0f0
Add tests for ReaderModeController (#11049) 2020-05-29 11:46:31 -07:00
Mihai Eduard Badea 11df3aaca1 For issue#10727 - Logins auth redirect
Added an extension function that pops the backstack of the fragment so the user is redirected to the Logins and passwords screen.
This is done to force the user to re-authenticate if he wants to re-enter the saved logins flow.

Additionally, some UI elements are being hidden on each Fragment since they were remained visible on the Logins and passwords screen's UI.
2020-05-29 12:57:28 -04:00
Jeff Boek 58a42828a1 For #10496 - Fully expand bottom sheet when loaded 2020-05-29 08:31:32 -07:00
Jeff Boek 0566790257 For #10496 - Automatically scroll to the selected tab when you open the tab tray 2020-05-29 08:31:32 -07:00
Aaron Train 507ccaec7e
Closes 10927: Improve wait on session loaded for UI tests (#10928) 2020-05-29 10:13:57 -04:00
ValentinTimisica 29be9e4b9f Fixes #10064: Updates UI tests for About Page 2020-05-29 09:26:46 +03:00
ValentinTimisica 9f265fd62f Fixes #10064: Open help articles in normal tab instead of custom tab 2020-05-29 09:26:46 +03:00
mcarare 906d72c894 For #9594: Increase touch target for snackbar action button button. 2020-05-28 19:41:28 -07:00
David Walsh 267cf35edb For 11001 - Show close all tabs above tab tray 2020-05-28 19:39:56 -07:00
David Walsh a70ba76cc9 Provided unique no tabs message per mode 2020-05-28 19:38:41 -07:00
Mozilla L10n Automation Bot c9722c65a2 Import l10n. 2020-05-28 18:18:20 -07:00
apoorv9990 3469eeed9e removed auto play permissions while determining isVisible for WebsitePermissionsState 2020-05-28 16:08:07 -07:00
apoorv9990 97704bfdbd Closes #9529: changed styling for permissions dialog to set proper padding
- Changed the visibility check to check just for the permissions shown instead of all the permissions in WebsitePermissionsState
- Added bottom padding to the permissions root view so there is balanced padding on top and bottom
2020-05-28 16:08:07 -07:00
Sawyer Blatz b06be1fcde For #9488 Add telemetry for search widget CFR 2020-05-28 15:15:25 -07:00
Sawyer Blatz 94d741864e For #9488: Add search widget CFR 2020-05-28 15:15:25 -07:00
Sawyer Blatz 27a85d86dc
For #10803: Hide voice icon in search if not available (#11005) 2020-05-28 14:34:44 -07:00
Christian Sadilek 7b5661ed10 Update Android Components version to 44.0.20200528190114
Pass store to download manager and service to address API changes.
2020-05-28 17:26:38 -04:00
Jonathan Almeida 63b4fcd4c4 For #11004: Fix invisible text on migration UI
For some text and colors, we were using the default styling where
possible. These styles contain references that react to theme changes
like dark mode. Since the migration UI does not respect these changes,
we should not use them.
2020-05-28 15:48:42 -04:00
David Walsh c0c895af33
For 10665 - Show the most recent tabs at the top of the tab tray (#10687) 2020-05-28 11:17:52 -05:00
ValentinTimisica 03284e2da0 Fixes #10674: Add SignInView only once 2020-05-28 08:38:24 -07:00
David Walsh 4fdac4d608
For 10734 - Open tab tray when collection is opened from Home (#10751)
* For 10734 - Open tab tray when collection is opened from Home

* Update to work with tab tray drawer
2020-05-28 10:22:12 -05:00
David Walsh ea4c342797
For #10877 - Show 'no tabs' message when no tabs are open (#10960) 2020-05-28 10:17:55 -05:00
Oana Horvath 43a78c4fd6
For #10761: Updates UI test tracking test page asset (#10945) 2020-05-28 10:57:10 -04:00
Roger Yang 6cef0edd5e
Closes #10980: Stop sending native crashes to Sentry (#10982) 2020-05-28 10:42:05 -04:00
ValentinTimisica 7974a5c77c Fixes #10815: Sort login items on initial load 2020-05-28 13:42:50 +03:00
Mihai Eduard Badea 610409862b For issue #10725 - Truncated account details
- Set the textview's height to "wrap_content" and added top/bottom padding to account for the size difference and maintain the original height
2020-05-28 13:41:29 +03:00
mcarare 9ec6ebc92a For #10969: Fix and clarify logic for checking showing PWA dialog. 2020-05-28 13:18:25 +03:00
Mozilla L10n Automation Bot aa487bf4c3 Import l10n. 2020-05-28 08:31:41 +03:00
David Walsh 424598946a For #10962 - Remove tab tray tab text labels 2020-05-27 16:40:49 -07:00
David Walsh 58a7e63105 For 10965 - Implement content description and fix border for add button 2020-05-27 16:40:26 -07:00
David Walsh 248237290e
For #10865 - Implement 3 dot menu for tab tray (#10869) 2020-05-27 13:07:03 -05:00
David Walsh 54cb8f0194 Remove unused import 2020-05-27 08:45:15 -07:00
David Walsh 5e4fd460f8 Remove onTabClosed from interactor 2020-05-27 08:45:15 -07:00
David Walsh 8b843ac9e5 Fix elevation for snackbar and fab 2020-05-27 08:45:15 -07:00
David Walsh e9bcc9bb1e Move snackbar to TabTrayDialogFragment 2020-05-27 08:45:15 -07:00
David Walsh f653964ee1 For #10864 - Display snack bar to undo closing tabs 2020-05-27 08:45:15 -07:00
mcarare a59917cdc0 For #9626: Swap margin for padding and remove use of touch delegate.
Also remove text margin to maintain visual appearance.
2020-05-27 08:43:43 -07:00
mcarare d706b085a9 For #9626: Delay cloning ConstraintSet to only when needed for updating. 2020-05-27 08:43:43 -07:00
Mugurell d0e2d02b34 For #10948 - Avoid PWA onboarding if user already has them on screen
It is possible that after migration users would already have Firefox PWAs on
their screen.
Since they already know about this functionality, we should not promote it to
them with the one-off `FirstTimePwaFragment`.

To query installed PWAs we'll use an API available only on Android >= 26 which
means that we will probably have half of users with PWAs still see the
onboarding but half which will not.
2020-05-27 08:42:56 -07:00
Sebastian Kaspari 21bd379438 Issue #9815: Allow Intents to set HomeActivity.OPEN_TO_BROWSER. 2020-05-27 10:55:44 +02:00
Mozilla L10n Automation Bot d54dbce7ba Import l10n. 2020-05-26 18:32:04 -07:00
Roger Yang 538a7917e4
Closes #10906: Add Open in app option in custom tab (#10929) 2020-05-26 14:37:53 -04:00
Tiger Oakes 2397695fe5
For #10596 - Redirect moz://a URL (#10688) 2020-05-26 11:06:01 -07:00
Simon Chae 422cf74731 For #8319: Integrate nest WebExtensionBrowserMenu support 2020-05-26 14:02:22 -04:00
Mozilla L10n Automation Bot a50aa839f3 Import l10n. 2020-05-26 08:47:03 +03:00
Grisha Kruglov e3f0df0118 Update Settings About test to account for debug builds 2020-05-25 22:13:05 -07:00
Jonathan Almeida aa0b8f65b1 For #10915: Disabled failing UI tests in SettingsPrivacyTest 2020-05-25 23:05:45 -04:00
mcarare 6e325d6242 For #6198: Update copy and position of pair QR code scan message. 2020-05-25 17:53:20 -04:00
mcarare 44d9dc9237 For #10705: Update copy of auto font sizing preference. 2020-05-25 17:50:35 -04:00
mcarare a62f4b2caa For #10851: Add end constraint for text view. 2020-05-25 17:49:39 -04:00
mcarare ce46a96742 For #10706: Update copy of deleting open tabs preference. 2020-05-25 17:37:29 -04:00
Sebastian Kaspari b666fbe3fe CrashReporter: Set release channel specific sentry project URL. 2020-05-25 16:13:54 +03:00
Mugurell 2dfd833941 For #10844 - Fennec page shortcuts will open in normal tabs
This comes to resolve a small regression in which they were opened in new
custom tab.
2020-05-25 14:37:00 +03:00
Oana Horvath d3672880a3
for #10690: disable editBookmarkTest (#10891) 2020-05-25 12:37:21 +03:00
Mozilla L10n Automation Bot 7c7d860293 Import l10n. 2020-05-25 09:51:40 +03:00
Jonathan Almeida 8d7c911202 For #10885: Don't add migration activity to history stack 2020-05-25 09:48:52 +03:00
Grisha Kruglov b26ac51e90 For #10494: Process HomeMenu builder changes on the main thread
Problem was that we were trying to process menu changes (in response to account manager events) on some background thread as that's what account manager emits them on, so some code internally in PopupWindow's dismiss handling (i think, didn't dig very deeply here) was silently giving up and we'd get into a bad state.

The reason this seemingly only happened if you quickly opened a menu on startup is because account manager isn't initialized until sometime after the startup finished. So the trick was to open the menu (and register account manager state callbacks) before it got initialized, so that the callbacks are invoked.

This should also reproduce in other, much more obscure ways, e.g. if you open the menu right before sync is scheduled to run in the background, change FxA password on another connected client, and then eventually receive a onAuthenticationProblem callback.
2020-05-22 13:50:57 -07:00
David Walsh ebb562a789 For #10859 - Use dark or light mode colors for tab tray in private mode 2020-05-22 13:34:30 -07:00
Sawyer Blatz 7067e5c000
For #8125: Add default top site telemetry (#10752) 2020-05-22 13:10:09 -07:00
Justin Wood 4bf04142ba Bug 1638073 - Update conftest for 'tps' to use current (firefoxci) api urls 2020-05-22 11:16:33 -07:00
Oana Horvath b2673bc654
for #10753: improves the clickAddBookmarkButton method in flaky tests (#10842) 2020-05-22 21:06:24 +03:00
Mozilla L10n Automation Bot e21352144b Import l10n. 2020-05-22 16:48:52 +03:00
sraturi 29d1893430 for #7032 add scroll listener to make the keyboard disappear on scroll.
touch listener was blocking the scroll
2020-05-21 18:54:50 -07:00
sraturi 4ee65755dc for #7032 fixed issue where pressing back button exited the application 2020-05-21 18:54:50 -07:00
sraturi 2c85a62a5e for #7032 removed recyclerview scroll listener from Awesomebarview 2020-05-21 18:54:50 -07:00
sraturi c8ec25fde9 fixed lint issues 2020-05-21 18:54:50 -07:00
sraturi 703a8ed565 added a onTouch listener to scrollview in search fragment to make it disappear on scroll 2020-05-21 18:54:50 -07:00
Jeff Boek 601aedda46 For #10504 - Removes "old" TabTrayFragment 2020-05-21 15:17:20 -07:00
Jeff Boek c32904a1d0 For #10504 - opens the tab tray and filters the tab based on the browser mode 2020-05-21 15:17:20 -07:00
Jeff Boek a674c5dfe7 For #10504 - cleans up tabLayout colors 2020-05-21 15:17:20 -07:00
Jeff Boek 4e499e7a48 For #10504 - Adds tabTrayDialogInteractor to browserfragment 2020-05-21 15:17:20 -07:00
Jeff Boek cc6a380d45 For #10504 - Show tab dialog on browserfragment 2020-05-21 15:17:20 -07:00
Jeff Boek 90cef752b0 For #10504 - Fixes up tab tray dialog styles 2020-05-21 15:17:20 -07:00
Jeff Boek 0b9484a172 For #10504 - Adds padding fto account for navigation bar in landscape 2020-05-21 15:17:20 -07:00
Jeff Boek dd2a26fc7c For #10504 - Added the tab tray to the TabTrayDialogFragment and wired up dismiss actions 2020-05-21 15:17:20 -07:00
Jeff Boek 34ac9df481 For 10504 - Adds dialog style and fab 2020-05-21 15:17:20 -07:00
Jeff Boek 97d66cce56 For #10504 - Creates the TabTrayDialogFragment 2020-05-21 15:17:20 -07:00
ekager 516a6fe9f7 For #6832 - Only emit session changes if fragment is attached 2020-05-21 10:11:50 -07:00
ekager 83ab7646c1 For #7602 - Integrate media fullscreen orientation feature 2020-05-21 10:11:39 -07:00
Christian Sadilek 4e25f41a41 For #1824: Prevent extremely long URLs from locking up HomeFragment 2020-05-21 13:11:07 -04:00
Oana Horvath fed3f2fe91
for #10759: close notification shade if still open (#10819) 2020-05-21 18:41:00 +03:00
codrut.topliceanu 7feae98944 For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view
- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
2020-05-21 10:02:51 -04:00
David Walsh 346b4aa3fd
For #10321: Wire up play and pause buttons in tab tray (#10422) 2020-05-20 16:50:58 -05:00
Sawyer Blatz 477493e197
For #10465: Add telemetry for voice search (#10785) 2020-05-20 14:35:57 -07:00
Mozilla L10n Automation Bot 3b866d4da4 Import l10n. 2020-05-20 10:14:19 -07:00
isabelrios 1b8a990edb
For #10756 - UI intermittent media playback failures (#10775) 2020-05-20 10:41:31 -04:00
David Walsh 2795a34b0b For 10731 - Don't show tab tray menu if there are no tabs 2020-05-19 13:30:18 -07:00
Sawyer Blatz 535e020683 For #1216: Put voice search behind a nightly & debug flag 2020-05-19 13:04:11 -07:00
Sawyer Blatz d33edd8841 No issue: Clean up SearchFragment a bit 2020-05-19 13:04:11 -07:00
Sawyer Blatz 011a9e7d96 For #1216: Add voice search 2020-05-19 13:04:11 -07:00
Aaron Train c0e4056c16
No issue: Disable validateBaselinePing UI test (#10772) 2020-05-19 10:59:55 -04:00
Mozilla L10n Automation Bot fe3a67ac68 Import l10n. 2020-05-18 20:22:37 -07:00
Michael Comella b0b2f87ab4 For #10757: remove no-op Experiments code and dependency.
We were supposed to have removed Experiments for performance purposes.
However, I find some code dangling in the tree.

Experiments.initialize is no longer called so I suspect
Experiments.withExperiment is a no-op. I verified that the lambda
function provided to it never ran in my local geckoBetaDebug on startup.
Assuming experiments behavior doesn't change in other build types, this
change appears safe.
2020-05-18 15:38:38 -07:00
ekager d46369696f For #10718 - Finish activity after removing external session 2020-05-18 15:32:29 -07:00
ekager 28a6b1f9d5 For #10691 - Turn on LeakCanary by default for debug builds 2020-05-18 15:08:09 -07:00
Mozilla L10n Automation Bot dc92ddb0e5 Import l10n. 2020-05-18 14:04:23 -07:00
Tiger Oakes cd64647a4d For #9286 - Add isDefault to topsites 2020-05-18 14:04:10 -07:00