1afc0eacd8
For #4399 : Create LibState Controller for Search ( #4673 )
...
* For #4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
ab6e7dc52b
Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
2019-08-20 13:45:55 +02:00
b8c93107c0
For #4744 - Extract TransitionPreDrawListener ( #4812 )
2019-08-19 16:27:43 -07:00
a632d8f1dc
For #4744 - Move search bar icon padding to dimens ( #4814 )
2019-08-19 16:22:51 -07:00
fb1d655d96
Closes #4822 - Update Bookmark State in onResume ( #4823 )
2019-08-19 16:22:20 -07:00
0d4eceed56
For #2706 : Refactor Glean to reduce errors ( #4753 )
...
* For #2706 : Adds recording for untracked events
* For #2706 : Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
4731977f5d
For #4421 : Fixes issues with new glean events ( #4816 )
2019-08-19 14:49:48 -07:00
73e3db8fe0
For #4804 : Resolves issue with crash reporter stack
2019-08-19 16:40:41 -04:00
210868f5bc
Use Mozilla Android Components 9.0.0-SNAPSHOT. ( #4750 )
2019-08-19 10:29:10 -07:00
806961094b
Fixes #4704 ( #4728 )
...
* Fixes #4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
2019-08-19 09:23:12 -07:00
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
de14962e3f
Extract quick action sheet observer code ( #4368 )
2019-08-19 08:28:33 -07:00
7d02354f4f
For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController ( #4800 )
2019-08-18 20:36:40 -05:00
d1aed157dd
For #4686 : Fix potential security issue ( #4764 )
2019-08-16 16:50:54 -05:00
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
a680d733c8
For #4384 : Hide mic icon if speech-to-text is unavailable ( #4701 )
2019-08-14 16:40:21 -07:00
2441592ef2
For #4516 : Use full width for large search widgets ( #4659 )
2019-08-14 16:00:13 -07:00
f71106cb51
Closes #3860 - Update description text for collections
2019-08-14 17:13:52 -04:00
b7ca520787
For #4421 : Adds Leanplum events and attributes ( #4626 )
...
* For #4421 : Adds Leanplum events and attributes
* For #4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
67f3b63ae5
For #4421 : Add search widget attribute to Leanplum ( #4694 )
2019-08-14 12:00:29 -07:00
f5ffe3734c
For #4457 : Adds telemetry for search widget actions ( #4714 )
2019-08-14 11:39:54 -07:00
2f265eccbd
For #4732 : Fix search engine display issue ( #4735 )
2019-08-14 11:03:14 -07:00
12371ca9c1
Add no-op experiment to test service-experiments integration ( #4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
2019-08-14 12:07:41 -05:00
3acabeb6c3
Use global navigation action for browser fragment ( #4691 )
2019-08-14 11:58:29 -05:00
5b4a441bcb
For #1667 : Screen reader can't reach other UI items when QAB expanded ( #4695 )
2019-08-14 09:56:29 -07:00
1328d686aa
No issue - Autoformatting ( #4715 )
2019-08-14 09:40:46 -05:00
42e3b2771e
fix #4633 : show toast only on first login ( #4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
2019-08-13 16:28:34 -05:00
5aac05859d
Fix #4436 : hide onboarding before navigating to settings ( #4675 )
...
* Fix #4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
2019-08-13 15:49:42 -05:00
d03c15d15c
Issue #4431 : Integrate feature-media component (Nightly and debug builds only). ( #4683 )
2019-08-13 15:02:20 -05:00
0c8bcd39be
For #4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
2019-08-12 15:51:49 -04:00
337ad1e88e
For #3424 - Make talkback ignore ImageButton in Collection Sele… ( #3792 )
...
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
2019-08-12 11:49:25 -04:00
b38b94ed79
Closes #4671 : Fix a potential NPE in BookmarkFragment
2019-08-12 11:16:28 -04:00
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
2019-08-09 17:27:58 -07:00
f323105163
No issue: reduce code duplication in BookmarkFragmentInteractor
2019-08-09 17:27:58 -07:00
5fe05e919a
For #4125 : Suppress coroutine warning to fix release build
2019-08-09 17:30:27 -04:00
0ec92d716f
For #4123 : Adds telemetry for quick action open in app ( #4629 )
2019-08-09 13:51:12 -07:00
6c9ce784b1
Fix, add some tests
2019-08-09 13:39:51 -07:00
2a6069bfb7
Fix rest of issues
2019-08-09 13:39:51 -07:00
69434a765f
Fix most issues
2019-08-09 13:39:51 -07:00
faf0ecbcc0
For #4125 : Migrate Sign in to Sync to Libstate
2019-08-09 13:39:51 -07:00
7f07eabbd8
For #4652 : Crash "Can not perform this action after onSaveInstanceState" ( #4654 )
2019-08-09 14:46:40 -05:00
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
23f5ac0fb9
For #4066 : Create InflationAwareFeature for lazy inflation
2019-08-09 11:48:55 -04:00
519c3bde5d
For #4066 : Provide lazy inflation of Find In Page View
2019-08-09 11:48:55 -04:00
c9c43260c9
For #4529 : Handle crash initializing CreateCollectionViewModel late ( #4628 )
2019-08-08 17:40:55 -05:00
e26570054a
Suppress warning in LeanplumMetricsService to fix release builds
2019-08-08 15:17:12 -04:00
04daf21437
Fix #4612 : Fetch experiments from Remote Settings CDN
2019-08-08 10:15:01 -07:00
ef97173cd9
For #4529 , #4427 : Resuming after restoring instance state breaks UI ( #4571 )
...
* For #4529 , #4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
2019-08-08 11:05:01 -05:00
ff6e9bccb7
For #4451 : Adds tests for DefaultBrowserToolbarController ( #4493 )
...
* For #4451 : Adds tests for DefaultBrowserToolbarController
* Continue working
* Large refactoring of test
* Mock analytics
* Fix merge conflicts
2019-08-08 09:02:42 -07:00
0ea595743d
Fixes #4562 : Add a-c git hash to about page
2019-08-07 16:59:11 -07:00
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
4566bd6fba
Fixes feedback
2019-08-07 16:41:29 -07:00
4d14735935
For #3060 : Adds Leanplum attributes for fxa syncing
2019-08-07 16:41:29 -07:00
9d65e665e5
No issue: Removes deprecated usage of ViewModelProviders
2019-08-07 19:21:41 -04:00
ec4d62c895
Fix ktlint
2019-08-07 19:17:56 -04:00
00bd26abe3
Remove task flags
2019-08-07 19:17:56 -04:00
f952234c57
Keep CLEAR_TASK
2019-08-07 19:17:56 -04:00
c87468d031
Remove popBackStack
2019-08-07 19:17:56 -04:00
a8526a0606
For #4438 : Fix crash when opening any URL from URL bar w/ long press
2019-08-07 19:17:56 -04:00
969d17b4a9
For #969 : Adds more telemetry for collections ( #4539 )
2019-08-07 16:05:20 -07:00
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
f23f3b7489
Closes #4467 : Use a-c version of FirefoxAccountsAuthFeature
2019-08-07 13:42:39 -07:00
59c60ef189
Fixes #4354 : Updated SearchFragment state after returning from SearchEngineFragment.
...
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
2019-08-07 13:19:53 -07:00
a514cb3f8c
No issue: Add OSS licenses link to About page
2019-08-07 12:40:10 -07:00
f9288c7fbd
For #969 : Finalizes collections telemetry ( #4592 )
2019-08-07 10:26:52 -07:00
8194e0778e
For #4026 - Update BookmarkDiffUtil to update on Title or URL change
2019-08-07 00:37:16 -04:00
0604e9858d
Closes #3939 - Adds strings for delete browsing history
2019-08-06 16:06:56 -07:00
71aedc79fe
Fixes #3922 : Added accessibility announcement for history empty state.
...
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
2019-08-06 12:32:59 -07:00
631b7ba7cb
Issue #1000 - Split out common browser functions
2019-08-06 12:31:25 -07:00
23bc8f4320
Fro #4563 - Update delete button alpha when history mode changes
2019-08-06 12:26:25 -07:00
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
6f962d3376
For #1744 : Open search shortcuts when entering search mode ( #4536 )
2019-08-05 15:07:03 -07:00
6f7ae227a8
Closes #4540 - Set correct tint for select bookmark folder icon ( #4541 )
2019-08-05 14:54:39 -07:00
5edc9d0b4e
For #2021 - Update custom preferences' views with email/account changes
2019-08-05 09:53:27 -07:00
51218bc93e
Integrate service-experiments component ( #4098 )
2019-08-05 11:14:42 -05:00
a526e0fad3
For #4455 - Rename history headers by hours and days ( #4478 )
2019-08-05 11:12:22 -05:00
8aecc2b850
For #4530 Reduce build warnings ( #4531 )
2019-08-05 11:10:57 -05:00
d0071d0177
For #4495 - Clean up homescreen toolbar focus and content descriptions
2019-08-05 08:58:03 -07:00
bfd4849064
For #1427 - enter multi select mode with single click on favicon in library
2019-08-03 16:43:51 -07:00
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
1cb9f88787
For #4199 make checkbox disabled when there is no data ( #4200 )
...
* For #4199 make checkbox unclickable when there is no data
2019-08-02 17:42:39 -07:00
1e4399ee38
Use auto pause with BrowserFragment observers
2019-08-02 17:32:58 -07:00
cbd811dcfb
Closes #1657 - Use Gecko for downloads ( #4296 )
2019-08-02 17:28:30 -07:00
6e2ea0750e
Issue #2379 - Use LibrarySiteItemView in history
2019-08-02 17:15:41 -07:00
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
2019-08-02 17:09:24 -07:00
015922ddd2
No issue: Fix Crash lower API by setting gradient drawables in onBind
2019-08-02 16:18:34 -07:00
83ceec6289
For #201 : Search Widget
2019-08-02 11:26:48 -07:00
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
29f089c414
For #2203 : Polishes BrowserToolbarMenu
2019-08-02 13:40:50 -04:00
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
da59e36c1b
Fixes #4410 : Modified visibility of 'Add Tab' button.
...
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
2019-08-02 08:49:50 -07:00
ae33234bbc
Closes #2593 : FxA automatic sign-in integration
2019-08-01 17:03:45 -07:00
210864186b
Reflect current sync status when opening account settings
2019-08-01 17:03:45 -07:00
c342a680d8
Fix crash for bookmarks
2019-08-01 18:57:35 -04:00
d42e72fd8b
Closes #4462 - Adjust layout params of select bookmark folder view
2019-08-01 13:31:13 -07:00
a1adb2e57f
Update fenix for new megazord setup
2019-08-01 13:10:20 -07:00
ccae66c08a
Issue #2379 - Use LibraryPageView in history
2019-08-01 15:59:55 -04:00
2813a3cff7
For #4441 - Keeps the ID 0 based for the recyclerview
2019-08-01 10:45:23 -07:00
9887945296
For #4412 : Only consume state change when UI initialized
2019-08-01 11:51:32 -04:00
b646e87d9e
No issue: Add engine warmup call
2019-08-01 10:53:55 -04:00
e4700f76c6
For #3886 - Uses `defaultDeviceName` for the `DeviceConfig` device name
2019-07-31 21:34:21 -07:00
a75c2f7cfb
No Issue - Fixes the offset key to prevent endless history bug
2019-07-31 17:58:56 -07:00
97f7d5ba87
For #2267 : Fixes telemetry for reader view ( #4328 )
2019-07-31 17:58:37 -07:00
2e7a61860a
For #969 : Adds more telemetry for collections ( #4358 )
2019-07-31 17:07:41 -07:00
4922e5d09d
No issue: Move PublicSuffixList to root component
...
With the PublicSuffixList class in Utilities, the first instantiation
of it (prefetching in onCreate), causes the Utilities to instantiate
and thus slowing down startup by needing the SearchEngineManager from
instantiating as well.
Moving this back to the root component fixes the immediate perf issue.
Co-authored-by: Will Hawkins <whh8b@obs.cr>
2019-07-31 17:01:14 -07:00
59c0005979
For #4412 : SiteSecurityClickedListener set incorrectly
2019-07-31 19:52:53 -04:00
ed31d990a4
No Issue: Move notification manager to member of background services
...
Instead of taking notification manager as a parameter
(from the utils class), create one private to the
BackgroundServices class. This means that we do not need
to create the entirety of utilities just to use
the notification manager.
2019-07-31 16:11:46 -07:00
af449c84d5
For #4137 - Fixes HistoryInteractorTest
2019-07-31 14:35:33 -07:00
4494e40dbc
For #4137 - Adds pagination to the history view
2019-07-31 14:35:33 -07:00
0773069dad
For #3829 - Ignore Intents Launched From History
2019-07-31 17:07:54 -04:00
46de06d132
For #4339 reduce build warnings ( #4340 )
2019-07-31 11:43:49 -07:00
95208c84a9
Closes #4265 - Do not pop after all exceptions are removed ( #4392 )
2019-07-31 11:43:15 -07:00
76ed07bd5d
Closes #4412 : BrowserInteractor has not been initialized ( #4414 )
2019-07-31 09:14:05 -07:00
8946bf20c4
Closes #3341 - Remove UserAgentRewriter
2019-07-31 11:05:42 -04:00
ec0bd85f6d
For #4198 - Include Intent.ACTION_SEND to open to browser
2019-07-31 01:11:39 -04:00
026dcb01f5
No issue: Enable Send Tab and Push in production
2019-07-30 22:32:59 -04:00
90b1e5c262
Closes #4355 : unsubscribe FxA subscription on logout
2019-07-30 22:27:12 -04:00
458632f4bf
fixes #4237 - Cannot edit the default name of a collection, only replace it
...
changed setting of text to be done before transition, preventing transition to make textView unclickable;
added renaming situation to showKeyboard in onResume();
changed title text when renaming, from: "Name collection" to "Rename collection".
2019-07-30 16:26:10 -04:00
ef3c813aee
fixes #4237 - Cannot edit the default name of a collection, only replace it
...
changed setting of text to be done before transition, preventing transition to make textView unclickable;
added renaming situation to showKeyboard in onResume();
changed title text when renaming, from: "Name collection" to "Rename collection".
2019-07-30 16:26:10 -04:00
2e300fc8cf
fixes #4237 - Cannot edit the default name of a collection, only replace it
...
made name_collection_edittext field clickable
2019-07-30 16:26:10 -04:00
385dfd2f15
For #4376 : Removes usage of selectedSessionOrThrow ( #4381 )
2019-07-30 12:39:58 -07:00
0703fdc91f
Closes #4240 - Exclude custom tabs from displayed tab count
2019-07-30 13:28:50 -04:00
8ff77b90f3
For #3886 - Change default device name to show the app name. ( #3916 )
...
* Fix default device name to show the app name.
* Add string resource with placeholders.
* Wrap line that triggers MaxLineLength lint issue.
2019-07-30 10:28:19 -07:00
d1651ecf71
Closes #4012 - Animate quick settings ( #4047 )
2019-07-30 09:50:50 -07:00
2467588c4a
Create shared custom view for library items
2019-07-30 12:26:15 -04:00
bf44c50dfd
Fix #4372 - Set SitePermissionsDetailsExceptionsFragment toolbar title in onResume
...
The flow we are currently using involves setting a new title for the containing
Activity when the user navigates to a new Fragment.
This happened for SitePermissionsDetailsExceptionsFragment in it's onCreate().
Opening a permission (SitePermissionsManageExceptionsPhoneFeatureFragment) will
set a new title in it's onCreate() but going back from this new Fragment will
not create again a new SitePermissionsDetailsExceptionsFragment.
As a workaround I moved the call to set Activity's title in onResume().
2019-07-30 11:56:44 -04:00
5e52fc46b8
For #3443 - convert textPercentageSeekBar to Kotlin ( #4081 )
...
* convert textPercentageSeekBar to Kotlin
* fix test
* fix test again
* fix test again
* conflicts resolved
* merge multiple kdocs into one
2019-07-30 10:17:41 -05:00
9bc0122ce3
For #4359 : findBookmarkedUrl blocks the main thread ( #4362 )
2019-07-29 17:01:02 -05:00
4c13f45e9e
Fixes #4192 : Private keyboard in private browsing ( #4345 )
...
Sets compliant keyboards to private mode when in private browsing.
2019-07-29 18:00:48 -04:00
ac359f6970
Closes #1331 - Filter consecutive history items using simplified URL
2019-07-29 17:22:19 -04:00
6fa022c2f8
For #4124 : Migrate BrowserToolbar to Libstate ( #4279 )
...
* For #4124 : Migrate BrowserToolbar to Libstate
* Restores QuickActionSheetReducer
* Improve tests
* Make QuickActionSheetController
* Finalize tests
* Breaks out QuickActionSheetState
* Fix comments
* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
87d8f3b037
Remove redundant super calls
2019-07-29 10:22:53 -07:00
88c05a5f43
Use glide-like image loading function
2019-07-29 10:22:23 -07:00
ccfaa3826b
For #2142 : Added accessibility focus
2019-07-29 09:26:33 -07:00
d5eeadda66
Closes #2142 : Enable private browsing button is focused instead of Search or address
2019-07-29 09:26:33 -07:00
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
c8148e61d5
No issue: Reset push subscriptions
2019-07-26 13:50:57 -04:00
48aeb19db1
For #3695 : Make SessionSuggestionProvider link to existing tab ( #4280 )
2019-07-26 09:49:25 -05:00
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
4747f2c165
Fixes #4161 : Modified style of bookmark_folders_sign_in button. ( #4291 )
...
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
2019-07-25 14:10:11 -05:00
9bbd14a542
removed unused import.
2019-07-25 14:36:36 -04:00
945b1ee274
[ #4089 ] Moved PublicSuffixList to a sub-component(Utilities) class.
2019-07-25 14:36:36 -04:00
1026a92f32
Update to use Mozilla Android Components 6.0.0
2019-07-23 17:55:39 -04:00
2531e9dd62
No issue: Use correct server host and force subscribe for push
2019-07-23 17:55:39 -04:00
28eb5c541a
For #1944 & #1750 : Updates private & night mode colors ( #4232 )
2019-07-23 09:35:24 -07:00
3c99c8540f
Switch to new intent processors
2019-07-23 12:33:02 -04:00
be10d427e8
For #4127 - Converts Exceptions to LibState and adds tests
2019-07-22 17:21:06 -04:00
9b5baa2358
For #3360 - Adds empty state for TP Exceptions
2019-07-22 17:21:06 -04:00
7588251f8b
Closes #3986 & Closes #3661 : Migrate QuickActionSheet to LibState & add tests ( #4058 )
...
* Closes #3986 : Migrate QuickActionSheet to LibState
* Closes #3661 : Add tests for QuickActionSheet
Co-authored-by: boek <jeff@jeffboek.com>
* For #3986 : Fix feedback
2019-07-22 10:31:31 -07:00
9d9685625a
For #4201 fix app crash on renaming a collection ( #4202 )
...
* For #4201 fix app crash on renaming a collection
* update
2019-07-22 10:31:00 -07:00
5ecdce6ba6
Closes #4171 : Do not pause deviceEventObserver on lifecycle events
2019-07-19 14:00:26 -07:00
f110ba2861
use synthetic binding instead of findviewbyid
2019-07-19 16:51:26 -04:00
5630904f93
For#3278 - Updates strings in preferences ( #4184 )
2019-07-19 12:31:55 -07:00
c74cb61455
fixes #4176 ( #4175 )
...
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
2019-07-19 14:23:10 -05:00
fc2bff0fde
For #4145 - Remove anchor view from fullscreen snackbar ( #4160 )
2019-07-19 11:18:47 -07:00
9f40c25c75
For #4143 - Allow user to rotate to other landscape orientation
2019-07-19 14:12:33 -04:00
d298b5f2f5
Closes #4075 : Add Feature Flag class ( #4077 )
2019-07-18 17:20:12 -07:00
e25ceafd1f
No issue: Removes unnecessary fragment transitions from accounts
...
Co-authored-by: ekager <emilykager@gmail.com>
2019-07-18 19:56:25 -04:00
13198f56df
For #969 : Adds telemetry for collections ( #3935 )
2019-07-18 16:05:42 -07:00
e544827e83
For #2267 : Adds telemetry for reader mode ( #3941 )
2019-07-18 15:17:15 -07:00
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
e294521c92
Fix search metrics ( #4150 )
...
* For #4082 - Changes lifecycles for metrics
* For #4082 - Replaces the SearchEngine name with the identifier for
countLabel
2019-07-18 14:35:34 -07:00
9251597e84
For #2362 : Fixes telemetry for history ( #4156 )
2019-07-18 13:36:52 -07:00
981b6b5b02
For #4124 - Remove browser toolbar editing code
2019-07-18 15:40:33 -04:00
62850430b7
Closes AC#3695 - Add UI to open current page in external app
2019-07-18 15:33:31 -04:00
6da6ddb095
Use StateListDrawable & resources w/ TabCollection
2019-07-18 15:29:06 -04:00
451093fd9e
Closes #2560 - Updates Private Browsing explanation string
2019-07-18 15:27:59 -04:00
ae3d187909
For #3987 - Convert History to Lib-State and add tests
2019-07-17 17:23:09 -07:00
9ab67557cf
For #4078 - Request landscape mode when entering fullscreen
2019-07-17 16:06:37 -07:00
c04dcec03f
Closes #4096 : IllegalStateException in SearchFragment ( #4131 )
2019-07-17 15:10:24 -05:00
90dd0ab469
Closes #4114 - Re-enable app-links
2019-07-17 10:39:17 -07:00
95367c2b50
For #3521 - Show Quick Settings Dialog Entirely in Landscape
2019-07-17 09:52:01 -07:00
8381025ac5
For #2160 - Hide Keyboard in onPause from EditBookmarkFragment
2019-07-17 09:20:28 -07:00
68dae52fd1
Closes #3332 - Do not alter text of hosts of tabs in collection
2019-07-17 09:02:30 -07:00
11d36b5a00
For #2362 : Adds telemetry for history ( #3940 )
2019-07-16 12:21:03 -07:00
8855af2234
For #3615 : Long pressing the address bar should not copy link ( #4083 )
2019-07-16 13:42:05 -05:00
6b4c160d18
Closes #4080 - Trim New Bookmark Folder Title Text
2019-07-16 11:02:36 -07:00
52d4c43916
Merge some library UIView code for toolbar
2019-07-16 09:27:30 -07:00
447123367a
Remove unused sessions resources
2019-07-16 09:15:50 -07:00
13b7e64c9b
For #3134 - Add confirmation dialog to sign out of FxA ( #3959 )
2019-07-15 16:21:13 -07:00
ec099a6e11
For #3633 - Creates generic store provider ( #4060 )
2019-07-15 15:54:13 -07:00
7747d5c240
Use tools:text to avoid inflating strings twice ( #3619 )
2019-07-15 17:01:37 -05:00
fd7ff58ab8
No issue: Add comments on the push flag state
2019-07-15 17:42:58 -04:00
706f7d5961
For #3554 - Add DiffUtil to HistoryAdapter
2019-07-15 13:46:21 -07:00
cf9ae87d50
For #3015 : Add push support for send tab
2019-07-15 16:38:49 -04:00
9b1e63224c
Closes #4052 : Remove pending intent workaround. ( #4059 )
...
Previously we needed to set a static launch function to be invoked when the find in page
integration should be launched. Now we can access the integration class directly and
can avoid the static property that caused issues when used by multiple activities.
2019-07-15 14:15:59 -05:00
e91a2e61a2
For #3633 : Add unit tests for SearchStore
2019-07-15 13:47:01 -04:00
f8ef0225e1
Use updated feature-tab-collections API. ( #4056 )
2019-07-15 09:58:33 -07:00
b91895a81c
Closes #1350 : Use GeckoView fetch client for service-fretboard / kinto
2019-07-15 11:26:40 -04:00
5de1678e65
No issue: Use putCompoundDrawables helper ( #3982 )
2019-07-15 08:24:59 -07:00
e4e0d45c1b
Closes #3996 : Remove workaround for opening custom tab in browser.
...
`EngineView` now allows releasing the `Session` so that it can be rendered by an
other `EngineView` instance.
2019-07-15 10:52:57 +02:00
e4ff70c542
For #3633 - Refactors the search screen to use lib-state
...
* For #3633 - Adds SearchStore
* For #3633 - Refactors AwesomeBarUIView
* For #3633 - Refactors ToolbarUIView to use lib-state
* For #3633 - Fixes a couple of state bugs
* For #3633 - Moves all user interaction to SearchInteractor
* For #3633 - Adds kdocs to SearchStore and SearchInteractor
* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property
* For #3633 - Creates `StateViewModel` to handle state restoration
* For #3633 - Adds a test for onTextChanged
* For #3633 - Adds tests for SearchInteractor
* For #3633 - Fixes bugs and adds documentation
2019-07-12 16:32:00 -07:00
867067537a
For #3568 - Use correct styling for QR and Share Alert Dialogs
2019-07-12 11:40:33 -07:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
2feddc9bd6
No issue: Enable Strict Mode in Debug Builds ( #4014 )
2019-07-12 00:23:28 -05:00
1f108f3c88
For #3806 - Adds corner radius to QAB and dialogs
2019-07-11 12:57:27 -04:00
fe51bbcf7b
Update FxA integration to new APIs
2019-07-11 13:19:37 +02:00
c81dd0a4a8
For #3772 - Update FXA sign in UI ( #3933 )
2019-07-10 21:20:06 -05:00
9e7282cf18
For #1949 - Fixes bookmark separator appearance, removes menu ( #3957 )
2019-07-10 14:23:35 -05:00
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
2019-07-10 14:13:10 -04:00
c6c9818751
For #3240 - Create AuthCustomTabActivity to fix dead end on auth
2019-07-10 12:23:01 -04:00
5a204f0bbc
For #3818 : Handle crashes accessing view after onDestroyView ( #3942 )
2019-07-08 18:42:17 -05:00
83312b38aa
For #3175 : Correctly grabs focus in search fragment ( #3938 )
2019-07-08 14:44:30 -07:00
9901514766
Replace deprecated pxToDp ( #3932 )
2019-07-08 14:45:07 -05:00
15d887e41f
For #2251 - Add bookmark adapter diffutil ( #3936 )
...
* For #2251 - Add bookmark adapter diffutil
* For #2251 - Fix unit tests for bookmark adapter diffutil
2019-07-08 14:00:25 -05:00
c92eabdd64
Modify the order of Privacy Policy and About in Settings ( #2760 )
2019-07-08 12:16:18 -05:00
d168d52516
For #3772 - Remove Create an Account Option on TurnOnSyncFragment ( #3928 )
2019-07-08 12:07:09 -05:00
003837eb4f
Closes #3879 - Remove attributeSetId from AccountPreference
2019-07-07 18:06:17 -07:00
57ca75139b
For #3201 - Update bookmark state when session selected
2019-07-03 11:38:14 -07:00
f60536b13c
For #3829 - Add pop up to nav_graph to browser to home nav
2019-07-03 11:29:49 -07:00
6bb67a9de7
For #3364 : Set bookmark root titles onResume ( #3828 )
2019-07-03 13:13:53 -05:00
20993462e9
For #3869 - Creates a SearchLocalizationProvider that sets the region to get the correct default search engine based on a locale
2019-07-03 08:57:59 -07:00
29402a297e
For #3317 : Prepopulate FxA device name field with existing name ( #3733 )
2019-07-03 08:38:09 -07:00
7a51ee3915
For #3734 - Don't SwipeToDelete RecyclerView without windowfocus ( #3839 )
2019-07-02 14:42:50 -07:00
99209aa9da
Closes #3268 - Change Tab Favicon Border Radius to 4 ( #3856 )
2019-07-02 14:42:20 -07:00
ce2d597af3
For #203 - Adds find in page and request desktop site to custom tab menu ( #3835 )
2019-07-02 14:41:29 -07:00
eedb0fa3b2
For #2945 : Launches to blank screen and hangs on Nexus 10 ( #3854 )
2019-07-02 14:58:28 -05:00
aebcc92080
Re-enables pushing nightly to org.mozilla.fenix ( #3823 )
...
* Re-enables pushing nightly to org.mozilla.fenix
* Publishes org.mozilla.fenix.nightly releases on internal track
2019-07-02 11:34:04 -07:00
dbe29ebbda
For #3174 : Adds telemetry for bookmarks ( #3724 )
2019-07-02 08:41:20 -07:00
ece0e30655
For #2054 : Collapses quick action bar when opening find in page ( #3837 )
2019-07-02 08:22:34 -07:00
bed926c317
For #3834 - Initialize job in init
2019-07-01 16:26:46 -07:00
50052c9b9b
For #3551 : Tapping a bookmark/history from Library should open new tab ( #3832 )
2019-07-01 16:31:30 -05:00
161e7b3b57
No issue: Fix master builds ( #3825 )
2019-07-01 14:15:54 -05:00
8cd1a0cb38
Move adapter Job setup code to helper class ( #3407 )
2019-07-01 13:34:25 -05:00
eb1ea882cf
For #2425 - QAB showed wrong text for bookmarked pages ( #3794 )
...
* For #2425 - QAB showed wrong text for bookmarked pages
* fixed linting issue
2019-07-01 11:45:52 -05:00
7e46e71d00
For #3005 : Closes tabs when saving to collection ( #3723 )
2019-07-01 11:39:48 -05:00
887102d215
For #3645 : Fix search engine selection ( #3665 )
...
* Remove RadioButton drawable applied in runtime
* Add default RadioButton layout
2019-07-01 11:08:58 -05:00
654c2b12df
No issue: Remove attributeSetId from DefaultBrowserPreference ( #3712 )
2019-07-01 09:02:40 -07:00
7473126f7c
For #3784 : Crash loading bookmarks while detached ( #3787 )
2019-07-01 10:57:31 -05:00
386a3f3acc
For #3785 : Crash onDestroy of BookmarkFragment when detached ( #3786 )
2019-07-01 10:57:16 -05:00
d42052079a
No issue: Remove duplicate wordmark and update about page ( #3590 )
2019-07-01 08:54:16 -07:00
219b5f3d01
For #3381 : Fix 'Remove account' returning app to home screen ( #3778 )
...
* For #3381 : Fix 'Remove account' returning app to home screen
* Remove unused import
* Move popBackStack() outside lifecycleScope instead
2019-07-01 08:32:06 -07:00
b82340bf1f
For #3750 : Crash when tapping "Blocked" on Google Maps after disabling
...
location requests.
2019-06-29 18:39:19 -07:00
7fa4cf4487
Use sessionId in FIP Integration, use pendingIntent for startActivity
2019-06-28 14:00:59 -07:00
6d0a4fdb4d
Revert "For #3609 - Remove FIP Integration, Use FIP Feature"
...
This reverts commit 428643d598e938f58a2fe4abfee417c46edec167.
2019-06-28 14:00:59 -07:00
2d6ebb986d
Revert "For #3135 - Reduce swipe to delete sensitivity"
...
This reverts commit 94881f8241
2019-06-28 12:47:36 -07:00
f375eac6bd
For #3732 : Race Condition Crash in HomeFragment onPreDraw ( #3737 )
2019-06-27 20:33:21 -05:00
9142e2279c
For #1968 - Adds menu option to add new folder in BookmarkFragment menu
2019-06-27 15:17:00 -07:00
606e66219c
No issue: Use chains for bookmark items ( #3696 )
...
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-27 13:47:42 -07:00
c9962a7ad0
Closes #3701 - When deleted use bookmark title if url is null in snackbar ( #3716 )
2019-06-27 13:39:00 -05:00
13df8d7ddd
For #3711 : Fixes save to collection from browser crash ( #3714 )
2019-06-27 11:29:00 -07:00
66eb4fd03b
No issue: Fixes master compilation
2019-06-27 09:05:57 -07:00
7481d52c4b
For #3505 : Opening a sent tab crashes Fenix ( #3507 )
2019-06-27 10:47:54 -05:00
6ccd32f093
For #3496 : dismiss share fragment when clicking outside content ( #3513 )
...
* dismiss share fragment when clicking outside content
* add logic in view layer
2019-06-27 10:43:13 -05:00
77edb7afe1
For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list
2019-06-26 18:59:13 -07:00
61a8795576
For #1211 - Hide keyboard on fling suggestions list
2019-06-26 16:44:35 -07:00
e8bd090a8e
No issue: Use ImageView rather than rebuilding drawable ( #3616 )
...
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
4994554576
No issue: Adds lint exception for when statement ( #3685 )
2019-06-26 15:52:24 -07:00
309014139d
For #3488 : Cleans up edit mode calls ( #3689 )
2019-06-26 15:40:07 -05:00
Sourabh