blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #3785: Crash onDestroy of BookmarkFragment when detached (#3786)

master
Colin Lee 2019-07-01 10:57:16 -05:00 committed by GitHub
parent d42052079a
commit 386a3f3acc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt
View File

@ -23,7 +23,7 @@ import androidx.fragment.app.Fragment
import androidx.lifecycle.ViewModelProviders
import androidx.lifecycle.lifecycleScope
import androidx.navigation.NavController
import androidx.navigation.Navigation
import androidx.navigation.fragment.findNavController
import kotlinx.android.synthetic.main.fragment_bookmark.view.*
import kotlinx.coroutines.Dispatchers.IO
import kotlinx.coroutines.Dispatchers.Main
@ -62,7 +62,7 @@ class BookmarkFragment : Fragment(), BackHandler, AccountObserver {
private lateinit var bookmarkComponent: BookmarkComponent
private lateinit var signInComponent: SignInComponent
var currentRoot: BookmarkNode? = null
private val navigation by lazy { Navigation.findNavController(requireView()) }
private val navigation by lazy { findNavController() }
private val onDestinationChangedListener =
NavController.OnDestinationChangedListener { _, destination, args ->
if (destination.id != R.id.bookmarkFragment ||
@ -144,8 +144,8 @@ class BookmarkFragment : Fragment(), BackHandler, AccountObserver {
}
}
override fun onDestroy() {
super.onDestroy()
override fun onDestroyView() {
super.onDestroyView()
navigation.removeOnDestinationChangedListener(onDestinationChangedListener)
}