blallo
/
fenix
1
0
Fork 0
Code Releases Activity

Fix #4372 - Set SitePermissionsDetailsExceptionsFragment toolbar title in onResume 

The flow we are currently using involves setting a new title for the containing
Activity when the user navigates to a new Fragment.
This happened for SitePermissionsDetailsExceptionsFragment in it's onCreate().
Opening a permission (SitePermissionsManageExceptionsPhoneFeatureFragment) will
set a new title in it's onCreate() but going back from this new Fragment will
not create again a new SitePermissionsDetailsExceptionsFragment.
As a workaround I moved the call to set Activity's title in onResume().
master
Mugurell 2019-07-30 16:02:50 +03:00 committed by Emily Kager
parent 5e52fc46b8
commit bf44c50dfd
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/main/java/org/mozilla/fenix/settings/SitePermissionsDetailsExceptionsFragment.kt
View File

@ -30,13 +30,10 @@ class SitePermissionsDetailsExceptionsFragment : PreferenceFragmentCompat() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
(activity as AppCompatActivity).supportActionBar?.show()
sitePermissions = SitePermissionsDetailsExceptionsFragmentArgs
.fromBundle(requireArguments())
.sitePermissions
(activity as AppCompatActivity).title = sitePermissions.origin
}
override fun onCreatePreferences(savedInstanceState: Bundle?, rootKey: String?) {
@ -45,6 +42,10 @@ class SitePermissionsDetailsExceptionsFragment : PreferenceFragmentCompat() {
override fun onResume() {
super.onResume()
(activity as AppCompatActivity).apply {
title = sitePermissions.origin
supportActionBar?.show()
}
lifecycleScope.launch(IO) {
val context = requireContext()
sitePermissions =