blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #4652: Crash "Can not perform this action after onSaveInstanceState" (#4654)

master
Colin Lee 2019-08-09 14:46:40 -05:00 committed by GitHub
parent 353ecab44e
commit 7f07eabbd8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/build.gradle
View File

@ -364,7 +364,6 @@ dependencies {
implementation Deps.androidx_recyclerview
implementation Deps.androidx_lifecycle_runtime
implementation Deps.androidx_lifecycle_viewmodel
implementation Deps.androidx_lifecycle_viewmodel_ss
implementation Deps.androidx_core
implementation Deps.androidx_core_ktx
implementation Deps.androidx_transition

5
app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt
View File

@ -16,6 +16,7 @@ import androidx.coordinatorlayout.widget.CoordinatorLayout
import androidx.core.net.toUri
import androidx.fragment.app.Fragment
import androidx.fragment.app.activityViewModels
import androidx.lifecycle.ViewModelProvider
import androidx.lifecycle.lifecycleScope
import androidx.navigation.fragment.findNavController
import com.google.android.material.bottomsheet.BottomSheetBehavior
@ -101,7 +102,9 @@ abstract class BaseBrowserFragment : Fragment(), BackHandler, SessionManager.Obs
private var browserInitialized: Boolean = false
private var initUIJob: Job? = null
val viewModel: CreateCollectionViewModel by activityViewModels()
val viewModel: CreateCollectionViewModel by activityViewModels {
ViewModelProvider.NewInstanceFactory() // this is a workaround for #4652
}
@CallSuper
override fun onCreateView(

1
architecture/build.gradle
View File

@ -33,7 +33,6 @@ dependencies {
implementation Deps.androidx_annotation
implementation Deps.androidx_lifecycle_extensions
implementation Deps.androidx_lifecycle_viewmodel_ss
implementation Deps.mozilla_support_base
implementation Deps.rxAndroid

2
buildSrc/src/main/java/Dependencies.kt
View File

@ -26,7 +26,6 @@ object Versions {
const val androidx_fragment = "1.2.0-alpha02"
const val androidx_navigation = "2.2.0-alpha01"
const val androidx_recyclerview = "1.1.0-beta01"
const val androidx_lifecycle_savedstate = "1.0.0-alpha01"
const val androidx_testing = "1.2.1-alpha02"
const val androidx_test_ext = "1.0.0"
const val androidx_core = "1.2.0-alpha03"
@ -165,7 +164,6 @@ object Deps {
const val androidx_lifecycle_extensions = "androidx.lifecycle:lifecycle-extensions:${Versions.androidx_lifecycle}"
const val androidx_lifecycle_viewmodel = "androidx.lifecycle:lifecycle-viewmodel-ktx:${Versions.androidx_lifecycle}"
const val androidx_lifecycle_runtime = "androidx.lifecycle:lifecycle-runtime-ktx:${Versions.androidx_lifecycle}"
const val androidx_lifecycle_viewmodel_ss = "androidx.lifecycle:lifecycle-viewmodel-savedstate:${Versions.androidx_lifecycle_savedstate}"
const val androidx_paging = "androidx.paging:paging-runtime-ktx:${Versions.androidx_paging}"
const val androidx_preference = "androidx.preference:preference-ktx:${Versions.androidx_preference}"
const val androidx_safeargs = "androidx.navigation:navigation-safe-args-gradle-plugin:${Versions.androidx_navigation}"