4a12f1b6aa
For #7996 : Private mode doesn't play nicely with sites added to home screen
...
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
2020-04-30 13:38:52 +03:00
688c377197
For 10296 - Implement tab tray dimension changes
2020-04-29 21:28:36 -07:00
56bb3e38ec
For issue #10142 Update sitePermissions state when toggling its value
2020-04-29 18:33:34 -07:00
2e27bbd15d
No issue - Remove unused data class TopSiteItem
2020-04-29 18:06:02 -07:00
6d1a2ca797
Import l10n.
2020-04-29 17:55:53 -07:00
38e9b34659
For #10071 : Fixes PWA showing toolbar onPause ( #10306 )
2020-04-29 14:03:59 -07:00
4006501d41
For #9728 : Add actionbar search for language list.
2020-04-29 11:20:18 -07:00
80f74ac611
For #9728 : Change SearchView hint color inside app.
2020-04-29 11:20:18 -07:00
52d09930a6
No issue - Update new strings for quarantine
2020-04-29 11:15:21 -07:00
02bd0cc203
For issue #8648
2020-04-29 09:48:42 -07:00
cdbaa52cab
Import l10n.
2020-04-28 17:33:33 -07:00
76002c5987
Fix breaking API changes in CrashReporter
2020-04-28 15:20:12 -04:00
2c18c255da
For #9783 : bring app in focus with sendSingleTapToScreen for UI test ( #10136 )
2020-04-28 10:46:42 -04:00
f0e659bfdb
For #9880 - fixed sync settings style
2020-04-28 09:06:36 +03:00
c86209ff98
Closes #9694 Bug when user denies permission
2020-04-27 22:42:02 -07:00
b7ea583250
Import l10n.
2020-04-28 08:35:44 +03:00
7409dc2bae
For #10083 : Do not cut off thumb when it is in pressed state
2020-04-27 21:19:44 -07:00
3c5d8d31ea
For #10083 : Adjust thumb offset to thumb circumference to avoid cutoff
2020-04-27 21:19:44 -07:00
6afcd2cee6
For #10201 - Provide proper button padding and no tabs message visibility in tabs tray
2020-04-27 20:36:08 -07:00
88f4e5f217
Import l10n.
2020-04-28 00:28:46 +03:00
a8843def6c
Fix CrashReporterService breaking changes
2020-04-27 16:43:05 -04:00
e55a4fd274
No issue: Partially update the add-on manager list
2020-04-27 16:43:05 -04:00
1aa473b112
For #9913 , For #9914 : Remove touch delegate when button is disabled.
2020-04-27 11:57:51 -07:00
21894a3cea
Added new bookmarks tests ( #9878 )
...
Fix for #7417 : Fix and re-enable disabled tests
2020-04-27 18:15:27 +03:00
a9692d9bce
For #10204 - Address viewLifecycleOwner IllegalStateException crashes
2020-04-24 17:12:08 -07:00
a16bfb27ef
For #6557 - added unit tests
2020-04-24 15:47:48 -07:00
0c2d22f595
For #6557 - add in_content telemetry class
2020-04-24 15:47:48 -07:00
28496fecc0
For #6557 - split base extension functionality from ads
2020-04-24 15:47:48 -07:00
f09bc4566c
For #6557 - added metric for in_content
2020-04-24 15:47:48 -07:00
f10e202a1e
For #6557 - added web-extension for cookies
2020-04-24 15:47:48 -07:00
996dabae8b
For #10188 : Fix layout constraints.
2020-04-24 13:28:53 -07:00
0f3d4e4cbe
For #10188 : Fix xml indentations and properties order.
2020-04-24 13:28:53 -07:00
e830da59b7
For #10180 : Remove touch delegate when button is disabled.
...
Also refactored multiple if's into a when.
2020-04-24 13:28:29 -07:00
3e13927c25
For #10180 : Add extension to remove touch delegate from parent.
2020-04-24 13:28:29 -07:00
59484208d6
No issue: Update Private Browsing placeholder string
2020-04-24 11:39:14 -07:00
8a80fbe14c
For #6558 - change from modifying event to event listener
...
The initial design replaced the onload method, which was used by others such as Bing.
With listeners it's additive, we do not replace anything.
2020-04-24 09:28:40 -07:00
8e66e19dbb
For #6558 - remove baidu and yahoo from monitored pages
...
These two do not contain ad servers, so we don't need to unnecessarily monitor them
2020-04-24 09:28:40 -07:00
c4d76dce5a
For #6558 - cleanup + added unit tests
2020-04-24 09:28:40 -07:00
f03d65b13d
For #6558 - added logic for ad_clicked metric
2020-04-24 09:28:40 -07:00
93ca1f6d9f
For #6558 - added handling of web extension + sending metric for has_ads
2020-04-24 09:28:40 -07:00
c4f7972f2b
For #6558 - added web extension for extracting document urls
2020-04-24 09:28:40 -07:00
f1559ed2da
For #10162 : Set switch back to prev state when failed to enable/disable addon ( #10164 )
2020-04-24 11:54:16 -04:00
e4764592fd
fix private notification text ( #10192 )
2020-04-24 17:55:46 +03:00
2edd4b39a4
For #9913 , For #9914 : Remove button when disabling it.
...
Setting visibility to GONE allows clicks to parent view in that space.
2020-04-24 16:42:47 +03:00
956bf01cd5
For issue #9493 : Reload after cleaning individual site permissions exceptions
2020-04-24 06:16:32 -04:00
6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app ( #9934 )
2020-04-23 15:38:35 -05:00
e51e1c878b
Add 'useEmail' and 'useEmailProblem' metrics event
...
Fixes #9834
2020-04-23 10:33:36 -07:00
b3248ec769
For #6123 : Expose WebExtensions in private browsing control
2020-04-23 12:28:57 -04:00
cc67de29bf
For #10091 Also disable play/pause button when hiding it.
2020-04-23 09:22:01 -07:00
9dd8314d14
For #10091 Add extension to remove and disable button
2020-04-23 09:22:01 -07:00
932fd44823
For #7387 : Change ETP onboarding from popup to a dialog.
...
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
2020-04-23 08:17:42 -07:00
72fe52fcb8
For #9987 : Set FLAG_SECURE to dialog when flag set in activity.
2020-04-23 08:16:25 -07:00
da3fca0f29
Fixes #10109 : Adds content description for browse privately card content
2020-04-23 16:59:42 +03:00
26e8d9bcca
For #9550 - Don't overlap search with shortcuts text
...
Private mode search with suggestion onboarding was overlapping "This time, search with: " text. Adjust constraints to allow it to show under onboarding when present.
2020-04-23 11:21:53 +03:00
e11f1b62dc
For #10027 : Make toolbar context menu popup dismissible on SDK<23
2020-04-22 22:47:46 -07:00
c4e83367f6
For #6832 - Fix various fragment not attached to a context crashes
2020-04-22 20:56:35 -07:00
6457a02a82
For #2818 - Enable PiP for all builds
2020-04-22 20:55:00 -07:00
95f26f1fdc
For #9946 : Update FennecBeta branding ( #10066 )
2020-04-22 15:19:24 -07:00
0227e953ae
Close #9760 : Add external app links context menu candidate
2020-04-22 14:45:49 -07:00
dce16964c0
For #9208 : Adds in-product prompt to homescreen ( #9836 )
2020-04-22 14:29:43 -07:00
0a23d66756
For issue #7566 Handle deny & don't ask again for site permissions
2020-04-22 11:33:32 -04:00
995da59fa8
For issue #9493 : Reload after cleaning all site permissions exceptions
2020-04-22 08:53:07 -04:00
70755adf6e
For #10036 - Workaround for System Theme changes with config change
2020-04-22 00:01:54 -07:00
1f8b7ff962
Closes #8541 : Hide find bar when entering fullscreen
2020-04-22 00:01:35 -07:00
164e6cd079
For #9816 - Adds SessionObserver to session on selection
2020-04-21 14:08:58 -07:00
6ad046714d
Close #9338 : Enable WebPush engine integration in all builds
2020-04-21 09:38:13 -04:00
f3847d0d7c
For #8735 - Adjust fontInflation engine setting when toggling useAutoSize
2020-04-21 09:05:25 +03:00
c702de05f9
Import l10n.
2020-04-21 09:04:12 +03:00
a1554834f9
Adds destructive colors for private theme
2020-04-20 23:00:41 -07:00
d80005235f
For #8546 - Overrides for new TextInputLayout colors
2020-04-20 23:00:41 -07:00
66d9a24b28
Closes #9928 - Updates private browsing text description
2020-04-21 09:00:06 +03:00
5d51c4f059
Don't use ProcessLifecycleOwner for view-tied consume
2020-04-20 12:07:37 -07:00
f801f32027
No issue: Fix leaks in BookmarkFragment
2020-04-20 12:07:37 -07:00
5014cd78ec
No issue: Fix leaking sessionControlInteractor
2020-04-20 12:07:37 -07:00
587bdfbd7b
For #8081 - UI screenshots tests update ( #10023 )
2020-04-20 10:39:56 -04:00
8ebb891bf8
Some cleanups for running the sync integration tests
2020-04-18 02:30:44 -07:00
853a0acab4
Closes #4046 : Always display 'Desktop' bookmarks folder
...
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.
In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
2020-04-17 23:57:43 -07:00
c16283a923
For #9932 : Fix navigation icon theme missing from migration UI
...
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
2020-04-17 22:45:30 -07:00
89cfa3ea9a
For #9808 : Fix scrolling cutoff on homescreen
2020-04-17 19:58:22 -07:00
a8e624959e
For #6940 : Fixes top dynamic toolbar behavior ( #9900 )
2020-04-17 13:32:20 -07:00
40550e88de
Close #9960 : Launch URI in Fenix if failed to launch in custom tab ( #9964 )
2020-04-17 16:24:20 -04:00
ec1d4e8fca
For #8399 : Hide keyboard to prevent content resizes
...
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
2020-04-17 12:07:44 -07:00
d3093e4afe
For #8428 - move about text from static_strings.xml to strings.xml and fix comment ( #10009 )
...
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
2020-04-17 11:50:56 -07:00
cab0bfc073
For #8422 : Add more misc migration UI fixes
2020-04-17 14:22:25 -04:00
f3ed207bdb
For #8803 - review: Add clarifying comments to onAppInit capture methods.
2020-04-17 09:11:58 -07:00
f49fc6dad2
For #8803 : hook up frameworkStart metric.
2020-04-17 09:11:58 -07:00
dbf733d70a
For #8803 : add StartupFrameworkStartMeasurement.
...
This class controls the central logic around the metrics we want to
record.
2020-04-17 09:11:58 -07:00
7f618a6a7c
For #8803 : add Stat and test.
...
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
2020-04-17 09:11:58 -07:00
39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected ( #10016 )
...
* For #9703 - Call fullScreenChanged in onPause
* For #10015 - Exit full screen if new session selected
2020-04-17 08:57:36 -07:00
6f77ec5951
Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver
2020-04-16 21:00:27 -07:00
0ec6d266e8
Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
...
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
2020-04-16 21:00:27 -07:00
72fe9fad0c
For #9987 : Set FLAG_SECURE to dialog when flag set in activity. ( #9998 )
...
* For #9987 : Add extension to secures dialog if parent activity is secured
* For #9987 : Set FLAG_SECURE to dialog when flag set in activity
2020-04-16 20:33:57 -07:00
dbbd048b6c
Import l10n. ( #10011 )
2020-04-16 20:32:21 -07:00
1df9c53b9f
Fix: Set correct height for EditText ( #10014 )
...
Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.
Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
2020-04-16 20:31:25 -07:00
725ba1e856
For #9951 - Removed the extra empty spaces that were causing the spacing issue
2020-04-16 20:12:18 -07:00
5a2a779ef5
For #9565 : Adjust padding and height to allow longer text
2020-04-16 20:10:45 -07:00
e87ea301ab
For #9536 : Update tests to check opened tab is in same browsing mode
2020-04-16 19:50:25 -07:00
83d2208c6b
For #9536 : Open report issue tab depending on current browsing mode.
...
Checking if session is private uses the new browser state API.
2020-04-16 19:50:25 -07:00
8440f1867a
For #9989 : Add start & end margin to button.
2020-04-16 19:43:34 -07:00
1f8f69548a
For #7158 : Fixes browser to search animation fade
2020-04-16 14:03:26 -07:00
6df11619fd
No issue: Uses NeutralButton for Migration Activity
2020-04-16 13:14:34 -07:00
2bb1b6edad
For #8422 : Add misc migration UI fixes
2020-04-16 12:02:02 -07:00
25d5b0d31c
For #8422 : Add spacing between migration items
2020-04-16 12:02:02 -07:00
4a06a228f3
For #9981 - Make Bookmark Menu UI respond to session selection
2020-04-16 10:49:16 -07:00
25e12e2f77
For #9984 : Update addon before settings visibility check
2020-04-16 10:25:37 -04:00
3e8836f71a
Import l10n.
2020-04-16 10:13:30 +03:00
688a33522b
For #9516 - Adds selectable background to dialog and snackbar buttons
2020-04-16 10:13:08 +03:00
8185ba793e
For #9857 : Create button style ( #9858 )
...
* For #9857 : Creates text button style
* Adds lint check
* Fixes onboarding cards
2020-04-15 15:49:02 -07:00
997f6c72d6
For #9409 : Add app icon to Leanplum push notifications
2020-04-15 17:55:12 -04:00
e97904662c
Remove duplicate FirebasePushService
...
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
2020-04-15 17:55:12 -04:00
bded28a017
For #9420 - relaxed custom engine rules ( #9967 )
...
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
2020-04-15 13:20:06 -07:00
c7b123cfea
Fixes #9710 : Vertically aligns users_count with rating ( #9950 )
2020-04-15 10:51:55 -07:00
aef827e607
For #9887 - Respect screenshot setting when resetting window flags in logins
2020-04-15 09:03:26 -07:00
06f1b6c992
No Issue - Fixes nav_graph issues ( #9926 )
2020-04-15 08:34:45 -07:00
37a277febb
For issue #9930 Do not assume all add-ons have a settings page
2020-04-15 06:20:34 -04:00
9a298ea6ba
Import l10n.
2020-04-15 03:50:48 +03:00
2056b6f2ff
Update UI test to match Support Page title
2020-04-14 11:34:55 -07:00
55b04b9885
Update Server.dev to Server.stage to fix A-S upgrade breaking change
2020-04-14 11:34:55 -07:00
8872baef39
Update Android Components version
2020-04-14 11:34:55 -07:00
7c279b6e1f
No issue: Fix add-on translate() breaking change
2020-04-14 11:34:55 -07:00
5b1cdbd8bf
For #3194 - Pause media while undo snackbar appears
2020-04-14 09:55:39 +03:00
9c56a8b387
For #204 - Remove PWA Feature Flag
2020-04-14 09:55:14 +03:00
69c7196e77
Import l10n.
2020-04-14 09:54:30 +03:00
4cbb9aebaf
Cleans up nav_graph.xml ( #9829 )
...
* For #9751 - Cleans up homeFragment directions
* For #9751 - Uses global actions for fragments not owned by homeFragment
* For #9751 - Cleans up SearchFragment directions
* For #9751 - Removes settings action from DeleteBrowsingDataFragment
* For #9751 - Removes browser action from SettingsFragment
* For #9751 - Adds ManagePhoneFeature global action
* For #9751 - Clean up unused deletebrowsingfragment actions
* For #9751 - Cleans Up HistoryFragment actions
* For #9751 - Removes Home -> Search action
* For #9751 - Removes the Bookmark -> Browser action
* For #9751 - Cleans up bookmark fragment actions
* For #9751 - Cleans up actions from ShareController
* For #9751 - Removes defaultBrowserFragment to browserFragment action
* For #9751 - Removes about -> browser action
* For #9751 - Adds global action to TrackingProtectionFragment
* For #9751 - Removes exception -> browser action
* For #9751 - Removes login -> browser action
* For #9751 - Fixes LoginFragment directions
* For #9751 - Removes ExternalAppBrowser directions
* for #9751 - Cleans up actions
* For #9751 - Fixes unit tests
* For #9751 - Addresses nits in PR
2020-04-13 21:43:45 -07:00
eace991859
For issue #8520 : Improve add-ons UI
2020-04-13 19:01:58 -04:00
b8fba63be4
For #9890 - Do not display full screen snackbar with toolbar padding
2020-04-13 14:56:51 -07:00
ac3a557ddf
For #9703 - Exit full screen on pause if pip not entered
2020-04-13 14:31:57 -07:00
7c3394ea7c
For #9892 : Set dynamicToolbarMaxHeigtht to 0 for PWAs ( #9893 )
2020-04-13 13:08:08 -07:00
8c238402e2
For #9692 - Fix "Install" PWA menu item labeling
2020-04-13 10:09:37 -07:00
5039546dc5
For #7208 For #7212 - Update parameterized strings
2020-04-13 09:40:47 -07:00
52857b09d7
fix #9670 intermittent tests ( #9767 )
...
also disabled intermittent closePrivateTabsNotification
2020-04-13 13:17:35 +03:00
8cdc523de9
For #9698 : Add unit tests for Context extension getStringWithArgSafe
2020-04-13 09:40:00 +03:00
a214f04b4a
For #9698 : Use extension to ensure fallback to English and avoid crash
2020-04-13 09:40:00 +03:00
4a1a875233
For #9698 : Add Context extension to avoid format IllegalArgumentException
2020-04-13 09:40:00 +03:00
e1bc8dc190
Import l10n.
2020-04-13 09:38:41 +03:00
b72c223244
For #7157 - Set BrowserMenu width to be max 314 dp ( #9731 )
...
Instead of having a fixed width of 250dp the BrowserMenu will now have a
dynamic width between 250dp and 314dp allowing for a better fit for the menu
items it could display.
2020-04-10 10:17:07 -07:00
1881975a31
For #9793 : Adjust relative positions to provide correct a11y traversal
2020-04-10 14:35:58 +03:00
c31c198d54
Import l10n.
2020-04-09 17:38:37 -07:00
177baf58a8
For #9798 : Disable buttons on hiding and enable on showing.
...
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
2020-04-09 16:06:11 -07:00
de311aef85
Update not yet unavailable add-on string ( #9677 )
2020-04-09 15:25:08 -04:00
c9141c9ae5
Close #9827 : Support display cutouts
2020-04-09 10:13:37 -07:00
7f1ef17d8b
No issue: Re-use existing usecases for addons
2020-04-09 12:53:47 -04:00
56eb2ec1d7
For #2818 - Adds Picture-in-Picture feature
2020-04-09 08:56:48 -07:00
ed466d34f7
Import l10n.
2020-04-09 08:20:41 +03:00
4437ddd536
No issue: Move Do and OpenClass to utils pkg.
...
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
2020-04-08 12:39:22 -07:00
413af92bc5
For #9797 : Set min height of dialog edit text to 48dp.
2020-04-08 10:12:20 -04:00
1c65bb8255
Closes #9495 : Dismiss the ShareFragment in onPause()
2020-04-08 13:10:37 +03:00
12d486bf02
Issue #9682 : Reduces size of branding ( #9784 )
2020-04-07 14:05:07 -07:00
0f1bff7402
No issue: Refactor readerview to use browser-state
2020-04-07 16:31:03 -04:00
e94af334fc
No issue: Add more settings animations ( #9750 )
2020-04-07 10:44:23 -07:00
d66da53c9a
For #2768 - Prevent screenshots in private mode
...
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.
This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.
The setting is by default set to true (screenshots are allowed to be taken)
2020-04-07 17:23:06 +03:00
29539c458e
For #9770 - Disable pull to refresh pending changes
2020-04-07 17:06:43 +03:00
a12cb5b0c3
Import l10n.
2020-04-07 10:30:26 +03:00
376740cd2c
For #9631 : replace assertk assertions with junit.
...
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
2020-04-06 16:56:40 -07:00
c632b93ee7
For #220 - Removes feature flag for language picker ( #9191 )
...
* For #220 - Removes feature flag for language picker
* For #220 - Updates Android Components
2020-04-06 14:29:52 -07:00
dfded8e69c
For #9687 : Refactor onboarding cards to follow app architecture ( #9743 )
...
* For #9687 : Refactor onboarding cards to follow app architecture
* For #9687 : Update unit test to new controller parameters
2020-04-06 11:00:47 -07:00
025656d8fd
For issue #9647 Crash when tapping settings after quickly
...
enabling/disabling add-on
2020-04-06 13:47:21 -04:00
3789f50423
Fix errors in top_sites_count metric
...
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.
[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
2020-04-06 10:34:52 -07:00
2d55b07935
Import l10n.
2020-04-06 12:20:41 +03:00
cac8115e55
For #9663 : Allow more than one line for onboarding card header
2020-04-03 17:47:11 -07:00
9e470c93ca
Import l10n.
2020-04-03 17:38:26 -07:00
b35704beed
Closes #9688 : Disable ReaderViewTest for intermittent investigation in detection issues
2020-04-03 22:04:43 +03:00
b2da0bd922
For #9670 : Disabled intermittent tabMediaControlButton test ( #9679 )
...
and removed file created by mistake -e
added reason for disabled tests
2020-04-03 20:39:33 +03:00
904bfc9ebe
For #3262 - Enable pull down to refresh in Nightly
2020-04-03 19:40:08 +03:00
51a76651d6
For #9605 - review: clarify comments in new test runner.
2020-04-03 09:27:49 -07:00
efef8eaba0
For #9605 : TestApplication -> FenixRobolectricTestApplication.
...
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
2020-04-03 09:27:49 -07:00
8df49473c0
For #9605 : move TestApplication to the helpers package.
...
The helpers/ package is created to separate the test support code from
the code under test.
2020-04-03 09:27:49 -07:00
6e0d851da3
For #9605 : replace unit test runners with FenixRobolectricTestRunner.
...
This is how we can apply the new test runner to remove duplication.
This commit was generated programmatically with the following commands:
```
// Replace test runners with new one.
find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
// Replace imports of old test runners with new one
find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
// Remove unused imports
find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```
Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
2020-04-03 09:27:49 -07:00
b0cfa3ee5c
For #9605 : add FenixRobolectricTestRunner.
...
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.
This class is adapted from Firefox for Fire TV:
https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
2020-04-03 09:27:49 -07:00
392dda5eda
For #9605 : remove unnecessary @RunWith(Robolectric in unit tests.
...
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.
Between this change and the last one, the unit test runtime was reduced
by ~10s.
2020-04-03 09:27:49 -07:00
f2acef66b5
For #9605 : remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
...
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
2020-04-03 09:27:49 -07:00
cb009f915c
No issue: re-enable libraryMenuItemsTest and backButtonTest ( #9639 )
2020-04-03 10:37:03 -04:00
f46cfc2ad2
Update Android Components version to 38.0.20200403130109.
2020-04-03 16:15:31 +02:00
8413b8133d
Import l10n.
2020-04-03 16:19:33 +03:00
4a8dc5b54f
No issue: add kdoc to HomeActivity.
...
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
2020-04-02 16:27:00 -07:00
e3ed7ed268
Issue #9128 & #9222 & #9499 : Refactors snackbar creation and fixes placement ( #9628 )
2020-04-02 12:30:13 -07:00
8c43935ba3
For #7978 - Put views above button in scrollView ( #8819 )
2020-04-02 10:13:32 -07:00
dc6d479da3
For #6174 - Add telemetry for WebExtensions ( #8318 )
2020-04-02 10:12:31 -07:00
7043f9ee4e
For #9604 : Swap and adjust margin with padding to avoid text being cut ( #9617 )
2020-04-02 09:40:29 -07:00
c15a005ca8
No issue: remove unused FirefoxTestRunner.
...
It would be used for on device tests but it doesn't seem to hooked up
currently.
2020-04-02 07:57:09 -07:00
202172cd04
Import l10n.
2020-04-02 13:42:58 +03:00
fac61fbb41
For #9422 : Nit: Fix xml indenting
2020-04-02 09:11:31 +03:00
4d0b37a3b8
For #9422 : Align widget text to viewStart to support RTL layouts
2020-04-02 09:11:31 +03:00
327009efc4
For #768 : Add first time PWA dialog ( #9308 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-04-01 22:56:12 -04:00
26137f63a2
Prevent favicons from flashing when items are selected in History ( #9233 )
2020-04-01 15:43:21 -07:00
8cd6d7460c
For #9336 Check current destination before navigating ( #9353 )
...
* For #9336 Check current destination before navigating
* For #9336 Update unit test to check for navigateSafe
2020-04-01 15:36:56 -07:00
90787cf630
For #9423 : Align preference title and summary to viewStart ( #9426 )
...
* For #9423 : Align preference title and summary to viewStart
* Update checkbox_left_preference_etp.xml
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2020-04-01 15:36:01 -07:00
fd60270da8
For #9533 - Switch to using enum for Library Item Selected Telemetry
2020-04-01 15:29:08 -07:00
8d3d030feb
Closes #9553 : Only update account UI state once when creating SettingsFragment
2020-04-01 15:28:39 -07:00
96c6401457
For #8125 - Send top sites count with metrics ping
2020-04-01 15:27:39 -07:00
8c398c86ef
For #9365 : Partially reverse menu items order when using top toolbar
2020-04-01 15:21:22 -07:00
b119700820
For #9365 : Update naming to reflect history item
2020-04-01 15:21:22 -07:00
cca3dae290
NoIssueFixMetropolisAccountPref
2020-04-01 15:13:03 -07:00
208a58bc58
Issue #9598 & #8697 : Fixes force expand crash ( #9599 )
2020-04-01 12:32:00 -07:00
3d1d146c94
For #9549 - Scrolling to top sites now includes header.
2020-04-01 10:28:04 -07:00
a2ea53d8f2
For #9574 : Remove category layout from LeakCanary SwitchPreference
2020-04-01 10:17:21 -07:00
4159cd3da7
Closes #9564 : Fixes cut off strings in ETP panel
2020-04-01 10:16:51 -07:00
24596fd3cd
For #9109 - remove the sync error highlight from three-dot menu
2020-04-01 10:42:00 +03:00
d9d5de98c9
For 3687 Use Metropolis Font for Header
2020-03-31 19:31:15 -07:00
9043120dd7
Import l10n.
2020-03-31 17:52:51 -07:00
54b7fd8834
Make sure reconnect item is displayed in HomeMenu in case of account problems
...
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
2020-03-31 16:07:35 -07:00
60943df6d9
Closes #9561 : Fix initialization order in HomeMenu
...
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.
Simply re-ordering initialization fixes the problem.
2020-03-31 16:07:35 -07:00
804eb0f5ba
For issue #8520 : Polish Add-on manager UIs
2020-03-31 17:20:20 -04:00
1a2b65d854
Issue #9472 : ForceExpand browser toolbar when navigating ( #9552 )
2020-03-31 11:16:40 -07:00
5f68d6cb29
Updated the method to verify system notifications and added new tests for media notifications ( #9330 )
2020-03-31 21:11:41 +03:00
cee34893ed
For #8412 : Passes error handling function to 'CustomTabWindowFeature' ( #8903 )
...
* For #8412 : Passes error handling function to 'CustomTabWindowFeature'
Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122
* Upgrade AC version
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2020-03-31 10:17:29 -07:00
f76acc5db1
Closes #9530 : Don't crash on failed avatar fetches
2020-03-31 09:17:17 -07:00
fd263d8329
Import l10n.
2020-03-30 22:00:19 -07:00
6c38b77315
Part 6: Kick-off account manager initialization after visual completeness
...
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.
Also, for signed-in users, this will establish background sync workers.
2020-03-30 21:43:38 -07:00
057e28d4e4
Part 5: Refactor HomeMenu<->HomeFragment interaction
...
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.
Once that's in place, we start observing account manager changes (once its ready)
for account problems.
This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
2020-03-30 21:43:38 -07:00
029fae4559
Part 4: Make sure 'sync is on' snackbar does not initialize account manager
2020-03-30 21:43:38 -07:00
eb98df4edd
Part 3: Mark accountManager as 'lazy' in Mode.kt
...
This is enough to cause it to be initialized only if we're going through onboarding.
2020-03-30 21:43:38 -07:00
3efaa516ca
Part 2: Do not eagerly initilize account manager within HomeActivity
...
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
2020-03-30 21:43:38 -07:00
0677fc35de
Part 1: Add 'accountManagerReady' queue to BackgroundServices
...
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
2020-03-30 21:43:38 -07:00
be1fa8df7d
Pre: introduce a RunWhenReadyQueue
...
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.
This ability to either execute or queue a task will be useful later on in the
commit series.
2020-03-30 21:43:38 -07:00
4d139d52c4
Closes #9189 : Fixes "static asset not found" error in doNotSaveLoginFromPromptTest, saveLoginFromPromptTest UI tests ( #9439 )
...
AndroidAssetDispatcher class dispatcher was attempting to open a local asset with a query suffix from the request. If query suffix is found, remove it. Re-enable saveLoginFromPromptTest() and doNotSaveLoginFromPromptTest()
2020-03-30 18:01:58 -04:00
9679b91e82
For #9525 - Add bottom margin to top sites header
2020-03-30 14:48:45 -07:00
4ac29530cd
Issue #9132 : Update to search animation for top toolbar ( #9524 )
...
* let animation in top toolbar mode play nicely.
* remove duplicate methods, make code readable.
* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.
* Update linting
Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
2020-03-30 12:07:00 -07:00
3d55578242
Use existing strings for announcement
2020-03-30 11:10:40 -07:00
c383d4225e
Closes #7720 :
...
- Increased atp switch size to be consistent with `dimen/tracking_protection_item_height`(48dp).
- Cut out redundant traversal of TextViews in SwitchWithTraversal as per https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md
- Reuse `QuickSettingsText.Icon` style on the switch component to be consistent with other items in the component_tracking_protection_panel.xml
- Added new string resources for textOff and textOn state to get appropriate screen reader description (unsure of the translation/localisation process here!)
2020-03-30 11:10:40 -07:00
e1187ebf31
For #7059 - Allow search engines to scroll
2020-03-30 10:31:39 -07:00
d989616f62
Add top sites heading to home screen
2020-03-30 10:29:40 -07:00
76f15a1f7f
For #9498 : Update unit tests with new constructor argument
2020-03-30 09:56:51 -07:00
f52fa44207
For #9498 : Replace navargs with viewModel to remember if scroll to tab
2020-03-30 09:56:51 -07:00
ab78951146
For #9496 : Vertically align collection name and icons to collection icon
2020-03-30 08:30:06 -07:00
e820a35f56
Update NotYetSupported add-ons copy
2020-03-30 10:36:49 -04:00
1e63d6ce76
For #9500 - Revert patch for 8568
...
The patch for 8568 introduced this regression.
Let's just revert it until we can come up with a better solution.
2020-03-30 07:20:13 -07:00
02aabea14a
Update to new feature-media API.
2020-03-29 23:13:13 -07:00
cd7c2c4bd5
Import l10n.
2020-03-29 12:32:40 -07:00
394f386ac3
Add secret debug menu to override FxA servers
2020-03-27 22:59:14 -07:00
18533d3434
For #8764 : Use list component for items in collections
2020-03-27 22:14:59 -07:00
62bbbd9e37
For #8764 : Update collection design, including list elements
2020-03-27 22:14:59 -07:00
38a97cd1e0
For #9252 : Add progress bar to saved logins view
2020-03-27 22:13:58 -07:00
f3bbcc4e17
For #9252 : Update views visibility ony when list has finished loading
2020-03-27 22:13:58 -07:00
f9cc2ccfe2
For issue #8017 enable SitePermissionsWifiIntegration
2020-03-27 20:44:16 -04:00
75aba7a2b4
Import l10n.
2020-03-27 17:33:26 -07:00
ba39a46b88
For #8568 - Refocus URL editText in SearchFragment onResume
2020-03-27 17:24:14 -07:00
3dcfed3761
AboutPageAdapter doesn't use notifyDataSetChanged()
...
We make the AboutPageAdapter inherit from a ListAdapter so that we don't use notifyDataSetChanged().
2020-03-27 17:23:27 -07:00
180652deab
No issue - Make fill link from clipboard divider stretch full screen
2020-03-28 02:10:18 +02:00
677a9da5ec
For #8485 Update UI tests after settings reorg
2020-03-27 17:05:49 -07:00
edabf9c865
For #8485 Move Remote debugging and LeakCanary to Advanced section
2020-03-27 17:05:49 -07:00
012e318724
For #8968 : Hide keyboard when navigating away from browser
2020-03-27 16:44:11 -07:00
3647606aae
Fixes #9280 : Remove tabs fade in animation when pressing on Add new collection
2020-03-27 15:54:24 -07:00
9f3bbf1fb7
For #8651 - Add HistoryInteractor/Controller unit/ui tests
2020-03-27 15:53:31 -07:00
fc0260d6ee
For #8651 - Ensure FenixSnackbar has a proper root for inflating into
...
FenixSnackbar, as the platform Snackbar can only be inflated in either a
`CoordinatorLayout` or a `FrameLayout`.
Ensure our HistoryFragment's layout uses one of these as it's root.
2020-03-27 15:53:31 -07:00
a1cdd31f0c
Fix #8651 - Add new menu actions for a history item
...
We'll now also support:
- Copy url
- Share to another FXA device
- Open in new tab
- Open in private tab
2020-03-27 15:53:31 -07:00
b77f92f9d1
For #9435 : Adjust margins and paddings to mirror correctly in RTL
2020-03-27 14:45:47 -07:00
3f12c1cdb9
Closes #9352 - changed capitalisation of 'Open in app'
2020-03-27 14:43:32 -07:00
28406eaf3d
No issue - Add content descriptions when missing
2020-03-27 14:41:51 -07:00
e8ad2389ac
For #7356 : Scroll to selected tab when pressing tab overview
2020-03-27 14:13:26 -07:00
Jovan Gerodetti