blallo
/
fenix
1
0
Fork 0
Code Releases Activity

No issue: Re-use existing usecases for addons

master
Christian Sadilek 2020-04-09 11:21:32 -04:00
parent 56eb2ec1d7
commit 7f1ef17d8b
3 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/org/mozilla/fenix/FenixApplication.kt
View File

@ -348,16 +348,16 @@ open class FenixApplication : LocaleAwareApplication() {
session.id
},
onCloseTabOverride = {
_, sessionId -> components.tabsUseCases.removeTab(sessionId)
_, sessionId -> components.useCases.tabsUseCases.removeTab(sessionId)
},
onSelectTabOverride = {
_, sessionId ->
val selected = components.core.sessionManager.findSessionById(sessionId)
selected?.let { components.tabsUseCases.selectTab(it) }
selected?.let { components.useCases.tabsUseCases.selectTab(it) }
},
onExtensionsLoaded = { extensions ->
components.addonUpdater.registerForFutureUpdates(extensions)
components.supportedAddChecker.registerForChecks()
components.supportedAddonsChecker.registerForChecks()
},
onUpdatePermissionRequest = components.addonUpdater::onUpdatePermissionRequest
)

4
app/src/main/java/org/mozilla/fenix/addons/InstalledAddonDetailsFragment.kt
View File

@ -177,9 +177,9 @@ class InstalledAddonDetailsFragment : Fragment() {
?: false
if (shouldCreatePrivateSession) {
components.tabsUseCases.addPrivateTab(settingUrl)
components.useCases.tabsUseCases.addPrivateTab(settingUrl)
} else {
components.tabsUseCases.addTab(settingUrl)
components.useCases.tabsUseCases.addTab(settingUrl)
}
InstalledAddonDetailsFragmentDirections

5
app/src/main/java/org/mozilla/fenix/components/Components.kt
View File

@ -14,7 +14,6 @@ import mozilla.components.feature.addons.update.AddonUpdater
import mozilla.components.feature.addons.update.DefaultAddonUpdater
import mozilla.components.feature.addons.migration.SupportedAddonsChecker
import mozilla.components.feature.addons.migration.DefaultSupportedAddonsChecker
import mozilla.components.feature.tabs.TabsUseCases
import mozilla.components.lib.publicsuffixlist.PublicSuffixList
import mozilla.components.support.migration.state.MigrationStore
import org.mozilla.fenix.BuildConfig
@ -86,7 +85,7 @@ class Components(private val context: Context) {
}
@Suppress("MagicNumber")
val supportedAddChecker by lazy {
val supportedAddonsChecker by lazy {
DefaultSupportedAddonsChecker(context, SupportedAddonsChecker.Frequency(16, TimeUnit.MINUTES),
onNotificationClickIntent = Intent(context, HomeActivity::class.java).apply {
action = Intent.ACTION_VIEW
@ -100,8 +99,6 @@ class Components(private val context: Context) {
AddonManager(core.store, core.engine, addonCollectionProvider, addonUpdater)
}
val tabsUseCases: TabsUseCases by lazy { TabsUseCases(core.sessionManager) }
val analytics by lazy { Analytics(context) }
val publicSuffixList by lazy { PublicSuffixList(context) }
val clipboardHandler by lazy { ClipboardHandler(context) }