1
0
Fork 0

No issue - Add content descriptions when missing

master
David Walsh 2020-03-24 11:40:01 -05:00 committed by liuche
parent e8ad2389ac
commit 28406eaf3d
5 changed files with 10 additions and 0 deletions

View File

@ -13,6 +13,7 @@
<ImageView
android:id="@+id/button_search_widget_new_tab_icon"
android:layout_width="50dp"
android:contentDescription="@string/browser_menu_new_tab"
android:layout_height="50dp"
android:layout_alignParentStart="true"
android:scaleType="centerInside" />
@ -33,6 +34,7 @@
android:id="@+id/button_search_widget_voice"
android:layout_width="32dp"
android:layout_height="32dp"
android:contentDescription="@string/search_widget_voice"
android:background="@drawable/ic_microphone_widget"
android:layout_alignParentEnd="true"
android:layout_alignTop="@id/button_search_widget_new_tab"

View File

@ -14,6 +14,7 @@
android:id="@+id/button_search_widget_new_tab_icon"
android:layout_width="50dp"
android:layout_height="50dp"
android:contentDescription="@string/browser_menu_new_tab"
android:layout_alignParentStart="true"
android:scaleType="centerInside" />
@ -34,6 +35,7 @@
android:layout_width="32dp"
android:layout_height="32dp"
android:background="@drawable/ic_microphone_widget"
android:contentDescription="@string/search_widget_voice"
android:layout_alignParentEnd="true"
android:layout_alignTop="@id/button_search_widget_new_tab"
android:layout_marginEnd="9dp"/>

View File

@ -84,6 +84,7 @@
android:layout_height="48dp"
android:alpha="0.8"
android:background="?android:attr/selectableItemBackgroundBorderless"
android:contentDescription="@string/close_tab"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:srcCompat="@drawable/ic_close" />

View File

@ -34,6 +34,7 @@
android:layout_marginEnd="8dp"
android:clickable="true"
android:focusable="true"
android:contentDescription="@string/onboarding_close"
app:srcCompat="@drawable/ic_close"
android:tint="@color/primary_text_dark_theme"
app:layout_constraintEnd_toEndOf="parent"

View File

@ -151,6 +151,8 @@
<string name="search_widget_text_short">Search</string>
<!-- Text preview for larger sized widgets -->
<string name="search_widget_text_long">Search the web</string>
<!-- Content description (not visible, for screen readers etc.): Voice search -->
<string name="search_widget_voice">Voice search</string>
<!-- Preferences -->
<!-- Title for the settings page-->
@ -889,6 +891,8 @@
</string>
<!-- Text for the button to read the privacy notice -->
<string name="onboarding_privacy_notice_read_button">Read our privacy notice</string>
<!-- Content description (not visible, for screen readers etc.): Close onboarding screen -->
<string name="onboarding_close">Close</string>
<!-- text for the button to finish onboarding -->
<string name="onboarding_finish">Start browsing</string>