blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #9798: Disable buttons on hiding and enable on showing. 

This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
master
mcarare 2020-04-08 15:37:40 +03:00 committed by Emily Kager
parent de311aef85
commit 177baf58a8
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CollectionViewHolder.kt
View File

@ -17,7 +17,9 @@ import mozilla.components.browser.menu.item.SimpleBrowserMenuItem
import mozilla.components.feature.tab.collections.TabCollection
import org.mozilla.fenix.R
import org.mozilla.fenix.ext.getIconColor
import org.mozilla.fenix.ext.hideAndDisable
import org.mozilla.fenix.ext.increaseTapArea
import org.mozilla.fenix.ext.showAndEnable
import org.mozilla.fenix.home.sessioncontrol.CollectionInteractor
import org.mozilla.fenix.theme.ThemeManager
@ -78,11 +80,11 @@ class CollectionViewHolder(
view.isActivated = expanded
if (expanded) {
view.collection_share_button.visibility = View.VISIBLE
view.collection_overflow_button.visibility = View.VISIBLE
view.collection_share_button.showAndEnable()
view.collection_overflow_button.showAndEnable()
} else {
view.collection_share_button.visibility = View.GONE
view.collection_overflow_button.visibility = View.GONE
view.collection_share_button.hideAndDisable()
view.collection_overflow_button.hideAndDisable()
}
view.collection_icon.colorFilter = createBlendModeColorFilterCompat(