da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
f23f3b7489
Closes #4467 : Use a-c version of FirefoxAccountsAuthFeature
2019-08-07 13:42:39 -07:00
59c60ef189
Fixes #4354 : Updated SearchFragment state after returning from SearchEngineFragment.
...
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
2019-08-07 13:19:53 -07:00
a514cb3f8c
No issue: Add OSS licenses link to About page
2019-08-07 12:40:10 -07:00
f9288c7fbd
For #969 : Finalizes collections telemetry ( #4592 )
2019-08-07 10:26:52 -07:00
422818c917
Stub out tabs tests ( #4573 )
2019-08-07 09:54:38 -07:00
8194e0778e
For #4026 - Update BookmarkDiffUtil to update on Title or URL change
2019-08-07 00:37:16 -04:00
cf169da2fc
For #4557 #3860 - Add string for collection empty state
2019-08-06 21:36:54 -07:00
0604e9858d
Closes #3939 - Adds strings for delete browsing history
2019-08-06 16:06:56 -07:00
b20c381af9
For #1749 - Land ETP Strings
2019-08-06 14:55:47 -07:00
71aedc79fe
Fixes #3922 : Added accessibility announcement for history empty state.
...
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
2019-08-06 12:32:59 -07:00
631b7ba7cb
Issue #1000 - Split out common browser functions
2019-08-06 12:31:25 -07:00
23bc8f4320
Fro #4563 - Update delete button alpha when history mode changes
2019-08-06 12:26:25 -07:00
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
4bbb291e8d
No issue: Update UI tests with new engine shortcuts behavior ( #4552 )
2019-08-06 08:30:15 -07:00
0320efee84
No issue: Removes focusableInTouchMode from home searchbar view
2019-08-05 15:42:21 -07:00
6f962d3376
For #1744 : Open search shortcuts when entering search mode ( #4536 )
2019-08-05 15:07:03 -07:00
6f7ae227a8
Closes #4540 - Set correct tint for select bookmark folder icon ( #4541 )
2019-08-05 14:54:39 -07:00
ad448b37ae
Closes #4537 - Adds description for onboarding placeholder string ( #4542 )
2019-08-05 14:51:11 -07:00
5edc9d0b4e
For #2021 - Update custom preferences' views with email/account changes
2019-08-05 09:53:27 -07:00
51218bc93e
Integrate service-experiments component ( #4098 )
2019-08-05 11:14:42 -05:00
a526e0fad3
For #4455 - Rename history headers by hours and days ( #4478 )
2019-08-05 11:12:22 -05:00
8aecc2b850
For #4530 Reduce build warnings ( #4531 )
2019-08-05 11:10:57 -05:00
d0071d0177
For #4495 - Clean up homescreen toolbar focus and content descriptions
2019-08-05 08:58:03 -07:00
890833d7ac
No issue: Fix failing UI tests because of renamed views ( #4527 )
2019-08-05 10:09:34 -05:00
bfd4849064
For #1427 - enter multi select mode with single click on favicon in library
2019-08-03 16:43:51 -07:00
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
1cb9f88787
For #4199 make checkbox disabled when there is no data ( #4200 )
...
* For #4199 make checkbox unclickable when there is no data
2019-08-02 17:42:39 -07:00
1e4399ee38
Use auto pause with BrowserFragment observers
2019-08-02 17:32:58 -07:00
cbd811dcfb
Closes #1657 - Use Gecko for downloads ( #4296 )
2019-08-02 17:28:30 -07:00
6e2ea0750e
Issue #2379 - Use LibrarySiteItemView in history
2019-08-02 17:15:41 -07:00
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
2019-08-02 17:09:24 -07:00
3a262a429b
For #3907 : Hide 'Go back' button for bad websites from new tabs
2019-08-02 17:00:48 -07:00
015922ddd2
No issue: Fix Crash lower API by setting gradient drawables in onBind
2019-08-02 16:18:34 -07:00
79160255c8
No issue: Just use TextView, not AppCompatTextView
2019-08-02 13:23:55 -07:00
83ceec6289
For #201 : Search Widget
2019-08-02 11:26:48 -07:00
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
29f089c414
For #2203 : Polishes BrowserToolbarMenu
2019-08-02 13:40:50 -04:00
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
da59e36c1b
Fixes #4410 : Modified visibility of 'Add Tab' button.
...
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
2019-08-02 08:49:50 -07:00
ae33234bbc
Closes #2593 : FxA automatic sign-in integration
2019-08-01 17:03:45 -07:00
210864186b
Reflect current sync status when opening account settings
2019-08-01 17:03:45 -07:00
f89cefe92c
No issue: Fixes failing UI test on master
2019-08-01 19:10:51 -04:00
c342a680d8
Fix crash for bookmarks
2019-08-01 18:57:35 -04:00
d42e72fd8b
Closes #4462 - Adjust layout params of select bookmark folder view
2019-08-01 13:31:13 -07:00
a1adb2e57f
Update fenix for new megazord setup
2019-08-01 13:10:20 -07:00
ccae66c08a
Issue #2379 - Use LibraryPageView in history
2019-08-01 15:59:55 -04:00
2813a3cff7
For #4441 - Keeps the ID 0 based for the recyclerview
2019-08-01 10:45:23 -07:00
9887945296
For #4412 : Only consume state change when UI initialized
2019-08-01 11:51:32 -04:00
f815ef1dd0
Fixes #4324 - Add more l10n screenshots tests ( #4350 )
...
* Fixes #4324 - l10n Add more screenshots tests
* change test name
* final changes
* fixing reviewer comments
2019-08-01 08:35:47 -07:00
b646e87d9e
No issue: Add engine warmup call
2019-08-01 10:53:55 -04:00
e4700f76c6
For #3886 - Uses `defaultDeviceName` for the `DeviceConfig` device name
2019-07-31 21:34:21 -07:00
a75c2f7cfb
No Issue - Fixes the offset key to prevent endless history bug
2019-07-31 17:58:56 -07:00
97f7d5ba87
For #2267 : Fixes telemetry for reader view ( #4328 )
2019-07-31 17:58:37 -07:00
2e7a61860a
For #969 : Adds more telemetry for collections ( #4358 )
2019-07-31 17:07:41 -07:00
4922e5d09d
No issue: Move PublicSuffixList to root component
...
With the PublicSuffixList class in Utilities, the first instantiation
of it (prefetching in onCreate), causes the Utilities to instantiate
and thus slowing down startup by needing the SearchEngineManager from
instantiating as well.
Moving this back to the root component fixes the immediate perf issue.
Co-authored-by: Will Hawkins <whh8b@obs.cr>
2019-07-31 17:01:14 -07:00
59c0005979
For #4412 : SiteSecurityClickedListener set incorrectly
2019-07-31 19:52:53 -04:00
ed31d990a4
No Issue: Move notification manager to member of background services
...
Instead of taking notification manager as a parameter
(from the utils class), create one private to the
BackgroundServices class. This means that we do not need
to create the entirety of utilities just to use
the notification manager.
2019-07-31 16:11:46 -07:00
fa8199f429
fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small
...
changed size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
2019-07-31 14:42:43 -07:00
30ecbc6000
fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small
...
changes size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
2019-07-31 14:42:43 -07:00
e7ec6246fd
For #4137 - Fixes HistoryStoreTest
2019-07-31 14:35:33 -07:00
af449c84d5
For #4137 - Fixes HistoryInteractorTest
2019-07-31 14:35:33 -07:00
4494e40dbc
For #4137 - Adds pagination to the history view
2019-07-31 14:35:33 -07:00
0773069dad
For #3829 - Ignore Intents Launched From History
2019-07-31 17:07:54 -04:00
46de06d132
For #4339 reduce build warnings ( #4340 )
2019-07-31 11:43:49 -07:00
95208c84a9
Closes #4265 - Do not pop after all exceptions are removed ( #4392 )
2019-07-31 11:43:15 -07:00
76ed07bd5d
Closes #4412 : BrowserInteractor has not been initialized ( #4414 )
2019-07-31 09:14:05 -07:00
8946bf20c4
Closes #3341 - Remove UserAgentRewriter
2019-07-31 11:05:42 -04:00
ec0bd85f6d
For #4198 - Include Intent.ACTION_SEND to open to browser
2019-07-31 01:11:39 -04:00
026dcb01f5
No issue: Enable Send Tab and Push in production
2019-07-30 22:32:59 -04:00
90b1e5c262
Closes #4355 : unsubscribe FxA subscription on logout
2019-07-30 22:27:12 -04:00
093b76593d
Closes #3419 : Use better accessibility strings for tab collections
2019-07-30 16:37:49 -04:00
3fb20aea6a
Closes #4040 - Remove NestedScrollView from Bookmark Layout
2019-07-30 16:29:12 -04:00
458632f4bf
fixes #4237 - Cannot edit the default name of a collection, only replace it
...
changed setting of text to be done before transition, preventing transition to make textView unclickable;
added renaming situation to showKeyboard in onResume();
changed title text when renaming, from: "Name collection" to "Rename collection".
2019-07-30 16:26:10 -04:00
ef3c813aee
fixes #4237 - Cannot edit the default name of a collection, only replace it
...
changed setting of text to be done before transition, preventing transition to make textView unclickable;
added renaming situation to showKeyboard in onResume();
changed title text when renaming, from: "Name collection" to "Rename collection".
2019-07-30 16:26:10 -04:00
2e300fc8cf
fixes #4237 - Cannot edit the default name of a collection, only replace it
...
made name_collection_edittext field clickable
2019-07-30 16:26:10 -04:00
385dfd2f15
For #4376 : Removes usage of selectedSessionOrThrow ( #4381 )
2019-07-30 12:39:58 -07:00
4ee8a890a8
fixes #3843 - (L10N) regression: alignment issue when saving tabs to collection
...
changed height to match_constraints instead of wrap_content - this makes for a better calculation of space, avoids setting textView on two lines, with blank line below.
2019-07-30 13:41:23 -04:00
0703fdc91f
Closes #4240 - Exclude custom tabs from displayed tab count
2019-07-30 13:28:50 -04:00
8ff77b90f3
For #3886 - Change default device name to show the app name. ( #3916 )
...
* Fix default device name to show the app name.
* Add string resource with placeholders.
* Wrap line that triggers MaxLineLength lint issue.
2019-07-30 10:28:19 -07:00
7ab4498771
For #3548 - Fix close tab button visibility. ( #3801 )
...
* For #3548 - Fix close tab button visibility.
* Switch to 'wrap_content' instead of fixed values.
* Align close tab button with settings button.
* Change margin top
2019-07-30 10:25:44 -07:00
ecc743a1f9
Minify logo path ( #4276 )
2019-07-30 09:56:11 -07:00
d1651ecf71
Closes #4012 - Animate quick settings ( #4047 )
2019-07-30 09:50:50 -07:00
2467588c4a
Create shared custom view for library items
2019-07-30 12:26:15 -04:00
ed60bdf470
fixes #3905 - "Go back" button too low on high risk error pages ( #4378 )
...
added to border-box value to box-sizing property for tablets so that the height property includes content and padding
2019-07-30 09:24:10 -07:00
437ecfbca8
For #1750 : Adds gradient to private BrowserToolbar ( #4361 )
...
Also updates the color of quickActionSheet ot be "above" attribute
2019-07-30 09:19:48 -07:00
bf44c50dfd
Fix #4372 - Set SitePermissionsDetailsExceptionsFragment toolbar title in onResume
...
The flow we are currently using involves setting a new title for the containing
Activity when the user navigates to a new Fragment.
This happened for SitePermissionsDetailsExceptionsFragment in it's onCreate().
Opening a permission (SitePermissionsManageExceptionsPhoneFeatureFragment) will
set a new title in it's onCreate() but going back from this new Fragment will
not create again a new SitePermissionsDetailsExceptionsFragment.
As a workaround I moved the call to set Activity's title in onResume().
2019-07-30 11:56:44 -04:00
5e52fc46b8
For #3443 - convert textPercentageSeekBar to Kotlin ( #4081 )
...
* convert textPercentageSeekBar to Kotlin
* fix test
* fix test again
* fix test again
* conflicts resolved
* merge multiple kdocs into one
2019-07-30 10:17:41 -05:00
be66e00303
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@1412258878
2019-07-30 15:35:41 +02:00
9bc0122ce3
For #4359 : findBookmarkedUrl blocks the main thread ( #4362 )
2019-07-29 17:01:02 -05:00
4c13f45e9e
Fixes #4192 : Private keyboard in private browsing ( #4345 )
...
Sets compliant keyboards to private mode when in private browsing.
2019-07-29 18:00:48 -04:00
ac359f6970
Closes #1331 - Filter consecutive history items using simplified URL
2019-07-29 17:22:19 -04:00
6fa022c2f8
For #4124 : Migrate BrowserToolbar to Libstate ( #4279 )
...
* For #4124 : Migrate BrowserToolbar to Libstate
* Restores QuickActionSheetReducer
* Improve tests
* Make QuickActionSheetController
* Finalize tests
* Breaks out QuickActionSheetState
* Fix comments
* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
87d8f3b037
Remove redundant super calls
2019-07-29 10:22:53 -07:00
88c05a5f43
Use glide-like image loading function
2019-07-29 10:22:23 -07:00
ccfaa3826b
For #2142 : Added accessibility focus
2019-07-29 09:26:33 -07:00
965d99a1c1
For #2142 : Added UI test assertion
2019-07-29 09:26:33 -07:00
d5eeadda66
Closes #2142 : Enable private browsing button is focused instead of Search or address
2019-07-29 09:26:33 -07:00
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
c8148e61d5
No issue: Reset push subscriptions
2019-07-26 13:50:57 -04:00
b39afe1548
Add taskcluster job for UI tests ( #4088 )
2019-07-26 08:08:01 -07:00
48aeb19db1
For #3695 : Make SessionSuggestionProvider link to existing tab ( #4280 )
2019-07-26 09:49:25 -05:00
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
4747f2c165
Fixes #4161 : Modified style of bookmark_folders_sign_in button. ( #4291 )
...
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
2019-07-25 14:10:11 -05:00
9bbd14a542
removed unused import.
2019-07-25 14:36:36 -04:00
945b1ee274
[ #4089 ] Moved PublicSuffixList to a sub-component(Utilities) class.
2019-07-25 14:36:36 -04:00
9db0d88346
For #4262 : Updates color and text of buttons ( #4250 )
2019-07-25 11:01:25 -07:00
a05d3e2aa0
For #4260 - UITests update data collection string ( #4261 )
2019-07-24 10:05:28 -07:00
1026a92f32
Update to use Mozilla Android Components 6.0.0
2019-07-23 17:55:39 -04:00
2531e9dd62
No issue: Use correct server host and force subscribe for push
2019-07-23 17:55:39 -04:00
28eb5c541a
For #1944 & #1750 : Updates private & night mode colors ( #4232 )
2019-07-23 09:35:24 -07:00
3c99c8540f
Switch to new intent processors
2019-07-23 12:33:02 -04:00
6480f405e2
Fixes #4091 & Fixes #4092 : Resolve issues with Search UI tests ( #4224 )
2019-07-23 09:30:57 -07:00
be10d427e8
For #4127 - Converts Exceptions to LibState and adds tests
2019-07-22 17:21:06 -04:00
9b5baa2358
For #3360 - Adds empty state for TP Exceptions
2019-07-22 17:21:06 -04:00
7588251f8b
Closes #3986 & Closes #3661 : Migrate QuickActionSheet to LibState & add tests ( #4058 )
...
* Closes #3986 : Migrate QuickActionSheet to LibState
* Closes #3661 : Add tests for QuickActionSheet
Co-authored-by: boek <jeff@jeffboek.com>
* For #3986 : Fix feedback
2019-07-22 10:31:31 -07:00
9d9685625a
For #4201 fix app crash on renaming a collection ( #4202 )
...
* For #4201 fix app crash on renaming a collection
* update
2019-07-22 10:31:00 -07:00
a984bb4799
For #4094 - Improved original PR to fix screenshots tests API21 ( #4144 )
...
use robot for three dot menu screenshot
2019-07-22 09:58:53 -07:00
5ecdce6ba6
Closes #4171 : Do not pause deviceEventObserver on lifecycle events
2019-07-19 14:00:26 -07:00
f110ba2861
use synthetic binding instead of findviewbyid
2019-07-19 16:51:26 -04:00
5630904f93
For#3278 - Updates strings in preferences ( #4184 )
2019-07-19 12:31:55 -07:00
c74cb61455
fixes #4176 ( #4175 )
...
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
2019-07-19 14:23:10 -05:00
fc2bff0fde
For #4145 - Remove anchor view from fullscreen snackbar ( #4160 )
2019-07-19 11:18:47 -07:00
9f40c25c75
For #4143 - Allow user to rotate to other landscape orientation
2019-07-19 14:12:33 -04:00
d298b5f2f5
Closes #4075 : Add Feature Flag class ( #4077 )
2019-07-18 17:20:12 -07:00
e25ceafd1f
No issue: Removes unnecessary fragment transitions from accounts
...
Co-authored-by: ekager <emilykager@gmail.com>
2019-07-18 19:56:25 -04:00
becdb88f4b
Revert "For #1944 & #1750 : Updates private & night mode colors ( #4162 )"
...
This reverts commit 2c95bb614a
2019-07-18 19:55:56 -04:00
709a2652b5
Import strings from android-l10n ( #4110 )
...
State: mozilla-l10n/android-l10n@e521a2aab2
2019-07-18 16:07:01 -07:00
13198f56df
For #969 : Adds telemetry for collections ( #3935 )
2019-07-18 16:05:42 -07:00
e544827e83
For #2267 : Adds telemetry for reader mode ( #3941 )
2019-07-18 15:17:15 -07:00
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
e294521c92
Fix search metrics ( #4150 )
...
* For #4082 - Changes lifecycles for metrics
* For #4082 - Replaces the SearchEngine name with the identifier for
countLabel
2019-07-18 14:35:34 -07:00
9251597e84
For #2362 : Fixes telemetry for history ( #4156 )
2019-07-18 13:36:52 -07:00
981b6b5b02
For #4124 - Remove browser toolbar editing code
2019-07-18 15:40:33 -04:00
62850430b7
Closes AC#3695 - Add UI to open current page in external app
2019-07-18 15:33:31 -04:00
6da6ddb095
Use StateListDrawable & resources w/ TabCollection
2019-07-18 15:29:06 -04:00
451093fd9e
Closes #2560 - Updates Private Browsing explanation string
2019-07-18 15:27:59 -04:00
2c95bb614a
For #1944 & #1750 : Updates private & night mode colors ( #4162 )
2019-07-18 11:22:07 -07:00
ae3d187909
For #3987 - Convert History to Lib-State and add tests
2019-07-17 17:23:09 -07:00
9ab67557cf
For #4078 - Request landscape mode when entering fullscreen
2019-07-17 16:06:37 -07:00
ac37d4971c
Revert "For #4094 - Fix screenshots tests on API 21 devices ( #4108 )" ( #4138 )
...
This reverts commit d8e45e55d4
2019-07-17 14:58:12 -07:00
d8e45e55d4
For #4094 - Fix screenshots tests on API 21 devices ( #4108 )
...
fix ktlint error
2019-07-17 14:27:59 -07:00
c04dcec03f
Closes #4096 : IllegalStateException in SearchFragment ( #4131 )
2019-07-17 15:10:24 -05:00
90dd0ab469
Closes #4114 - Re-enable app-links
2019-07-17 10:39:17 -07:00
95367c2b50
For #3521 - Show Quick Settings Dialog Entirely in Landscape
2019-07-17 09:52:01 -07:00
8381025ac5
For #2160 - Hide Keyboard in onPause from EditBookmarkFragment
2019-07-17 09:20:28 -07:00
68dae52fd1
Closes #3332 - Do not alter text of hosts of tabs in collection
2019-07-17 09:02:30 -07:00
8daaa6378d
Closes #4038 - Adds margin before close icon in tab item
2019-07-16 14:14:08 -07:00
6aa6cf8a99
Closes #3977 : Add basic navigational UI tests ( #3978 )
...
- Adds UI tests (and assets) for basic navigation
fix: review changes
fix: linter cleanup
fix: detekt cleanup
fix: adjust wait approaches
2019-07-16 13:02:12 -07:00
Sawyer Blatz