1
0
Fork 0
Commit Graph

1209 Commits (de6dcd59f4ff36c5ad659c308000194a89a47cc6)

Author SHA1 Message Date
Jeff Boek e294521c92
Fix search metrics (#4150)
* For #4082 - Changes lifecycles for metrics

* For #4082 - Replaces the SearchEngine name with the identifier for
countLabel
2019-07-18 14:35:34 -07:00
Sawyer Blatz 9251597e84 For #2362: Fixes telemetry for history (#4156) 2019-07-18 13:36:52 -07:00
Tiger Oakes 981b6b5b02 For #4124 - Remove browser toolbar editing code 2019-07-18 15:40:33 -04:00
James Hugman 62850430b7 Closes AC#3695 - Add UI to open current page in external app 2019-07-18 15:33:31 -04:00
Tiger Oakes 6da6ddb095 Use StateListDrawable & resources w/ TabCollection 2019-07-18 15:29:06 -04:00
Emily Kager 451093fd9e Closes #2560 - Updates Private Browsing explanation string 2019-07-18 15:27:59 -04:00
Emily Kager ae3d187909 For #3987 - Convert History to Lib-State and add tests 2019-07-17 17:23:09 -07:00
Emily Kager 9ab67557cf For #4078 - Request landscape mode when entering fullscreen 2019-07-17 16:06:37 -07:00
Christian Sadilek c04dcec03f Closes #4096: IllegalStateException in SearchFragment (#4131) 2019-07-17 15:10:24 -05:00
James Hugman 90dd0ab469 Closes #4114 - Re-enable app-links 2019-07-17 10:39:17 -07:00
Emily Kager 95367c2b50 For #3521 - Show Quick Settings Dialog Entirely in Landscape 2019-07-17 09:52:01 -07:00
Emily Kager 8381025ac5 For #2160 - Hide Keyboard in onPause from EditBookmarkFragment 2019-07-17 09:20:28 -07:00
Emily Kager 68dae52fd1 Closes #3332 - Do not alter text of hosts of tabs in collection 2019-07-17 09:02:30 -07:00
Sawyer Blatz 11d36b5a00
For #2362: Adds telemetry for history (#3940) 2019-07-16 12:21:03 -07:00
Colin Lee 8855af2234
For #3615: Long pressing the address bar should not copy link (#4083) 2019-07-16 13:42:05 -05:00
Emily Kager 6b4c160d18 Closes #4080 - Trim New Bookmark Folder Title Text 2019-07-16 11:02:36 -07:00
Tiger Oakes 52d4c43916 Merge some library UIView code for toolbar 2019-07-16 09:27:30 -07:00
Tiger Oakes 447123367a Remove unused sessions resources 2019-07-16 09:15:50 -07:00
Emily Kager 13b7e64c9b For #3134 - Add confirmation dialog to sign out of FxA (#3959) 2019-07-15 16:21:13 -07:00
Jeff Boek ec099a6e11
For #3633 - Creates generic store provider (#4060) 2019-07-15 15:54:13 -07:00
Tiger Oakes 7747d5c240 Use tools:text to avoid inflating strings twice (#3619) 2019-07-15 17:01:37 -05:00
Jonathan Almeida fd7ff58ab8 No issue: Add comments on the push flag state 2019-07-15 17:42:58 -04:00
ekager 706f7d5961 For #3554 - Add DiffUtil to HistoryAdapter 2019-07-15 13:46:21 -07:00
Jonathan Almeida cf9ae87d50 For #3015: Add push support for send tab 2019-07-15 16:38:49 -04:00
Sebastian Kaspari 9b1e63224c Closes #4052: Remove pending intent workaround. (#4059)
Previously we needed to set a static launch function to be invoked when the find in page
integration should be launched. Now we can access the integration class directly and
can avoid the static property that caused issues when used by multiple activities.
2019-07-15 14:15:59 -05:00
Christian Sadilek e91a2e61a2 For #3633: Add unit tests for SearchStore 2019-07-15 13:47:01 -04:00
Sebastian Kaspari f8ef0225e1 Use updated feature-tab-collections API. (#4056) 2019-07-15 09:58:33 -07:00
Christian Sadilek b91895a81c Closes #1350: Use GeckoView fetch client for service-fretboard / kinto 2019-07-15 11:26:40 -04:00
Tiger Oakes 5de1678e65 No issue: Use putCompoundDrawables helper (#3982) 2019-07-15 08:24:59 -07:00
Sebastian Kaspari e4e0d45c1b Closes #3996: Remove workaround for opening custom tab in browser.
`EngineView` now allows releasing the `Session` so that it can be rendered by an
other `EngineView` instance.
2019-07-15 10:52:57 +02:00
Jeff Boek e4ff70c542
For #3633 - Refactors the search screen to use lib-state
* For #3633 - Adds SearchStore

* For #3633 - Refactors AwesomeBarUIView

* For #3633 - Refactors ToolbarUIView to use lib-state

* For #3633 - Fixes a couple of state bugs

* For #3633 - Moves all user interaction to SearchInteractor

* For #3633 - Adds kdocs to SearchStore and SearchInteractor

* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property

* For #3633 - Creates `StateViewModel` to handle state restoration

* For #3633 - Adds a test for onTextChanged

* For #3633 - Adds tests for SearchInteractor

* For #3633 - Fixes bugs and adds documentation
2019-07-12 16:32:00 -07:00
Emily Kager 867067537a For #3568 - Use correct styling for QR and Share Alert Dialogs 2019-07-12 11:40:33 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Colin Lee 2feddc9bd6
No issue: Enable Strict Mode in Debug Builds (#4014) 2019-07-12 00:23:28 -05:00
Emily Kager 1f108f3c88 For #3806 - Adds corner radius to QAB and dialogs 2019-07-11 12:57:27 -04:00
Grisha Kruglov fe51bbcf7b Update FxA integration to new APIs 2019-07-11 13:19:37 +02:00
Emily Kager c81dd0a4a8 For #3772 - Update FXA sign in UI (#3933) 2019-07-10 21:20:06 -05:00
Emily Kager 9e7282cf18 For #1949 - Fixes bookmark separator appearance, removes menu (#3957) 2019-07-10 14:23:35 -05:00
Emily Kager 21c75ca1bb For #3478 - Add Tab sent snackbar confirmation for device sharing 2019-07-10 14:13:10 -04:00
ekager c6c9818751 For #3240 - Create AuthCustomTabActivity to fix dead end on auth 2019-07-10 12:23:01 -04:00
Colin Lee 5a204f0bbc
For #3818: Handle crashes accessing view after onDestroyView (#3942) 2019-07-08 18:42:17 -05:00
Sawyer Blatz 83312b38aa
For #3175: Correctly grabs focus in search fragment (#3938) 2019-07-08 14:44:30 -07:00
Tiger Oakes 9901514766 Replace deprecated pxToDp (#3932) 2019-07-08 14:45:07 -05:00
Colin Lee 15d887e41f
For #2251 - Add bookmark adapter diffutil (#3936)
* For #2251 - Add bookmark adapter diffutil

* For #2251 - Fix unit tests for bookmark adapter diffutil
2019-07-08 14:00:25 -05:00
afr30010 c92eabdd64 Modify the order of Privacy Policy and About in Settings (#2760) 2019-07-08 12:16:18 -05:00
Emily Kager d168d52516 For #3772 - Remove Create an Account Option on TurnOnSyncFragment (#3928) 2019-07-08 12:07:09 -05:00
ekager 003837eb4f Closes #3879 - Remove attributeSetId from AccountPreference 2019-07-07 18:06:17 -07:00
ekager 57ca75139b For #3201 - Update bookmark state when session selected 2019-07-03 11:38:14 -07:00
Emily Kager f60536b13c For #3829 - Add pop up to nav_graph to browser to home nav 2019-07-03 11:29:49 -07:00
Colin Lee 6bb67a9de7
For #3364: Set bookmark root titles onResume (#3828) 2019-07-03 13:13:53 -05:00
Jeff Boek 20993462e9 For #3869 - Creates a SearchLocalizationProvider that sets the region to get the correct default search engine based on a locale 2019-07-03 08:57:59 -07:00
Yeon Taek Jeong 29402a297e For #3317: Prepopulate FxA device name field with existing name (#3733) 2019-07-03 08:38:09 -07:00
Emily Kager 7a51ee3915 For #3734 - Don't SwipeToDelete RecyclerView without windowfocus (#3839) 2019-07-02 14:42:50 -07:00
Emily Kager 99209aa9da Closes #3268 - Change Tab Favicon Border Radius to 4 (#3856) 2019-07-02 14:42:20 -07:00
Emily Kager ce2d597af3 For #203 - Adds find in page and request desktop site to custom tab menu (#3835) 2019-07-02 14:41:29 -07:00
Colin Lee eedb0fa3b2
For #2945: Launches to blank screen and hangs on Nexus 10 (#3854) 2019-07-02 14:58:28 -05:00
Mitchell Hentges aebcc92080
Re-enables pushing nightly to org.mozilla.fenix (#3823)
* Re-enables pushing nightly to org.mozilla.fenix

* Publishes org.mozilla.fenix.nightly releases on internal track
2019-07-02 11:34:04 -07:00
Sawyer Blatz dbe29ebbda
For #3174: Adds telemetry for bookmarks (#3724) 2019-07-02 08:41:20 -07:00
Sawyer Blatz ece0e30655
For #2054: Collapses quick action bar when opening find in page (#3837) 2019-07-02 08:22:34 -07:00
Emily Kager bed926c317 For #3834 - Initialize job in init 2019-07-01 16:26:46 -07:00
Colin Lee 50052c9b9b
For #3551: Tapping a bookmark/history from Library should open new tab (#3832) 2019-07-01 16:31:30 -05:00
Colin Lee 161e7b3b57
No issue: Fix master builds (#3825) 2019-07-01 14:15:54 -05:00
Tiger Oakes 8cd1a0cb38 Move adapter Job setup code to helper class (#3407) 2019-07-01 13:34:25 -05:00
Sören Hentzschel eb1ea882cf For #2425 - QAB showed wrong text for bookmarked pages (#3794)
* For #2425 - QAB showed wrong text for bookmarked pages

* fixed linting issue
2019-07-01 11:45:52 -05:00
Sawyer Blatz 7e46e71d00 For #3005: Closes tabs when saving to collection (#3723) 2019-07-01 11:39:48 -05:00
Weverson Nascimento 887102d215 For #3645: Fix search engine selection (#3665)
* Remove RadioButton drawable applied in runtime

* Add default RadioButton layout
2019-07-01 11:08:58 -05:00
Emily Kager 654c2b12df No issue: Remove attributeSetId from DefaultBrowserPreference (#3712) 2019-07-01 09:02:40 -07:00
Colin Lee 7473126f7c
For #3784: Crash loading bookmarks while detached (#3787) 2019-07-01 10:57:31 -05:00
Colin Lee 386a3f3acc
For #3785: Crash onDestroy of BookmarkFragment when detached (#3786) 2019-07-01 10:57:16 -05:00
Tiger Oakes d42052079a No issue: Remove duplicate wordmark and update about page (#3590) 2019-07-01 08:54:16 -07:00
Yeon Taek Jeong 219b5f3d01 For #3381: Fix 'Remove account' returning app to home screen (#3778)
* For #3381: Fix 'Remove account' returning app to home screen

* Remove unused import

* Move popBackStack() outside lifecycleScope instead
2019-07-01 08:32:06 -07:00
Arturo Mejia b82340bf1f For #3750: Crash when tapping "Blocked" on Google Maps after disabling
location requests.
2019-06-29 18:39:19 -07:00
ekager 7fa4cf4487 Use sessionId in FIP Integration, use pendingIntent for startActivity 2019-06-28 14:00:59 -07:00
ekager 6d0a4fdb4d Revert "For #3609 - Remove FIP Integration, Use FIP Feature"
This reverts commit 428643d598e938f58a2fe4abfee417c46edec167.
2019-06-28 14:00:59 -07:00
Emily Kager 2d6ebb986d Revert "For #3135 - Reduce swipe to delete sensitivity"
This reverts commit 94881f8241.
2019-06-28 12:47:36 -07:00
Colin Lee f375eac6bd
For #3732: Race Condition Crash in HomeFragment onPreDraw (#3737) 2019-06-27 20:33:21 -05:00
Emily Kager 9142e2279c For #1968 - Adds menu option to add new folder in BookmarkFragment menu 2019-06-27 15:17:00 -07:00
Tiger Oakes 606e66219c No issue: Use chains for bookmark items (#3696)
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-27 13:47:42 -07:00
Emily Kager c9962a7ad0 Closes #3701 - When deleted use bookmark title if url is null in snackbar (#3716) 2019-06-27 13:39:00 -05:00
Sawyer Blatz 13df8d7ddd
For #3711: Fixes save to collection from browser crash (#3714) 2019-06-27 11:29:00 -07:00
Sawyer Blatz 66eb4fd03b No issue: Fixes master compilation 2019-06-27 09:05:57 -07:00
Colin Lee 7481d52c4b
For #3505: Opening a sent tab crashes Fenix (#3507) 2019-06-27 10:47:54 -05:00
Nikit Bhandari 6ccd32f093 For #3496: dismiss share fragment when clicking outside content (#3513)
* dismiss share fragment when clicking outside content

* add logic in view layer
2019-06-27 10:43:13 -05:00
Emily Kager 77edb7afe1 For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list 2019-06-26 18:59:13 -07:00
ekager 61a8795576 For #1211 - Hide keyboard on fling suggestions list 2019-06-26 16:44:35 -07:00
Tiger Oakes e8bd090a8e No issue: Use ImageView rather than rebuilding drawable (#3616)
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
Tiger Oakes 4994554576 No issue: Adds lint exception for when statement (#3685) 2019-06-26 15:52:24 -07:00
Sawyer Blatz 309014139d For #3488: Cleans up edit mode calls (#3689) 2019-06-26 15:40:07 -05:00
Yeon Taek Jeong 2cafd5bba6 For #3678: Fix crash when tapping on your account (#3688) 2019-06-26 13:33:27 -07:00
Emily Kager 427bc5c1e6 Revert "For #1211 - Hide keyboard on fling suggestions list"
This reverts commit cb6fd83c9879c268cb739fb768187d5276c5af66.
2019-06-26 11:19:09 -07:00
Tiger Oakes a78d36354a Switch RadioButtonPreference to ConstraintLayout
Also ensure that RTL works properly.
2019-06-26 09:45:55 -07:00
Sawyer Blatz d28168ac64 For #2940: Hides send tab header on FxA error 2019-06-25 17:08:46 -07:00
Tiger Oakes 30930cdc88 Import variables referred to by path 2019-06-25 13:57:34 -07:00
Tiger Oakes 55f5c5d049 Use lifecycleScope for settings fragments 2019-06-25 13:56:33 -07:00
Tiger Oakes d01bb8c442 Use lifecycleScope for collections fragments 2019-06-25 13:56:15 -07:00
Tiger Oakes 6bf8d6be34 Use @JvmOverloads instead of multiple constructors 2019-06-25 13:55:31 -07:00
Colin Lee 94e99cf877
For #3364: Edit bookmarks should show corrected bookmarks tree (#3446) 2019-06-25 14:19:33 -05:00
Emily Kager 74111c75de For #3639 - Remove fontInflationEnabled (#3640) 2019-06-25 10:24:32 -05:00
Emily Kager ddebc98718 No issue: Follow up on optional filter style 2019-06-24 17:03:38 -07:00
Colin Lee ea7841b8c5 No issue: Add Sentry breadcrumbs to ease crash investigations 2019-06-24 16:21:43 -07:00
Denys M 6d6b240e48 Add unit tests for `Settings`.
Add unit tests for `Settings`.
2019-06-24 16:02:34 -07:00
Emily Kager 718ac5612c For #3593 For #3581 - Pass sessions to delete to delete all with undo (#3594) 2019-06-24 15:41:38 -07:00
Emily Kager 084fab77d4 For #3609 - Remove FIP Integration, Use FIP Feature (#3637) 2019-06-24 15:31:32 -07:00
Emily Kager 6e3197f61c For #3622 - Add ID to engine shortcut suggestions (#3636) 2019-06-24 15:30:27 -07:00
royang51 e244aae104 For #3214 - History multi-selection aborted, the same item can't be selected again (#3607) 2019-06-24 15:27:06 -07:00
Sawyer Blatz 07516f47c3
For #3215: Adds collection restoration with unique IDs (#3635) 2019-06-24 14:12:51 -07:00
vmbaicu 021900e7ad Fixes #3527 - Set Collection name max length (#3531) 2019-06-24 13:58:04 -07:00
Nikit Bhandari cfefc5632b For #3489: Disables blank collection names (#3490) 2019-06-24 13:44:02 -07:00
Andrei Teslovan 2ebe0a2a48 Fixes #3529 - Display "Edit folder" title when editing a bookmark folder (#3549) 2019-06-24 13:34:15 -07:00
Emily Kager 03a5cb2fb4 For #3620 - Adds automatic theme onboarding content description (#3629) 2019-06-24 13:15:38 -07:00
Sawyer Blatz a5a518f4a5
For #2940: Hides send tab on FxA error (#3595) 2019-06-24 12:52:20 -07:00
Sawyer Blatz 721908ade6
For #3055: Adds android components version to about page (#3596) 2019-06-24 12:52:04 -07:00
Colin Lee 22bcd70edc
For #3213: Fix multi-select bookmarks on return to fragment (#3413) 2019-06-24 10:10:49 -07:00
Emily Kager afb59251c1 For #3588 - Preload the content process when starting Gecko (#3589) 2019-06-20 13:00:22 -07:00
Emily Kager b1102c2e76 For #3544 - Set SearchSuggestions preference value from settings 2019-06-18 16:56:34 -07:00
Tiger Oakes ab6101b0f4 Fixes #3539 - vectordrawablecompat for gradients (#3541) 2019-06-18 16:38:56 -07:00
Tiger Oakes b70dced16e Fixes #3538 - Fix ic_tabs icon path (#3540) 2019-06-18 16:38:42 -07:00
Colin Lee 0135424883 For #3508: "Send crash report" checkbox is ignored (#3512) 2019-06-18 16:38:29 -07:00
Grisha Kruglov 521312c6f8 Disable send tab for non-nightly, non-debug builds (#3542)
* Put deviceCapabilities list behind a SEND_TAB_ENABLED flag

* Disable SEND_TAB for non-debug, non-nightly builds
2019-06-18 16:37:50 -07:00
Mihai Tabara ccc5b91992 Import PR 3500 from ekager 2019-06-14 18:52:27 -07:00
Stefan Arentz 6e6e662c47 Update HomeFragment.kt 2019-06-14 18:34:58 -07:00
Jeff Boek 90bdbd04e0 No Issue - Capture session manager in scope before creating the delete operation 2019-06-14 18:34:58 -07:00
Emily Kager ac5c4a0f79 Closes #3493 - Show tab saved to collection snackbar in BrowserFragment 2019-06-14 15:49:56 -07:00
Jeff Boek 7ebdfcc87b For #1116 - Uses alias link for help 2019-06-14 15:33:34 -07:00
Jeff Boek 5540230e3d For #1116 - Changes help link (#3491) 2019-06-14 15:29:10 -05:00
Jeff Boek 3b848393f7 For #981 - Adds link to mma.md to telemetry.md 2019-06-14 13:27:50 -07:00
Jeff Boek 45b096c84f For #981 - mma docs 2019-06-14 13:27:50 -07:00
Jeff Boek f323c38be0 For #981 - Adds missing Leanplum events 2019-06-14 13:27:50 -07:00
Emily Kager 6bd9b82385 No issue: Remove flash of tab adapter updating data in create collection 2019-06-14 11:01:54 -07:00
Colin Lee d5c5587a0c
For #3209: Disable shared element animations for crash temporarily (#3482) 2019-06-14 12:13:13 -05:00
Sawyer Blatz 041eaa2a5c
For #3275: Cleans up feedback from James (#3398) 2019-06-14 08:59:57 -07:00
Emily Kager e28277693b Closes #3428 - Make + in collection creation selection stage clickable 2019-06-13 22:37:47 -07:00
Jonathan Almeida 986bc91347 For #3401: Update toolbar tab counter when view is attached
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-06-13 16:12:19 -07:00
vladikoff dfe181aa0a Add application-services fretboard feature flags 2019-06-13 15:29:59 -07:00
Emily Kager 8b4c2db4e4 For #3433 - Add checkbox hide changes to change payload 2019-06-13 13:01:44 -07:00
Emily Kager 1f1320920f For #3275 - Invoke pending single session delete job on close all (#3438) 2019-06-13 12:58:45 -05:00
Jeff Boek 1212887e08 For #1242 - properly record metrics (#3437) 2019-06-13 09:57:56 -07:00
Emily Kager 510b6f7373 For #2899 - Improve collections scroll and highlight animations 2019-06-13 09:21:12 -07:00
Andrei Teslovan e458d8b6a1 Fixes #3365 - Set selectedFolder to null if it's already selected (#3415) 2019-06-13 10:52:35 -05:00
Emily Kager 5eb2bc6d55 For #3138 - Sets height of toolbar in SearchFragment to match_parent (#3400) 2019-06-12 19:44:44 -05:00
Sawyer Blatz 381a5e6089 For #3403: Subscribes to tab collections in BrowserFragment 2019-06-12 16:44:35 -07:00
Jeff Boek 227a80957e For #382 - Include Marshmellow in the guard.. 2019-06-12 15:45:58 -07:00
Jeff Boek dad671ca3c For #382 - Hides default browser switch for older versions of Android 2019-06-12 15:07:58 -07:00
Jonathan Almeida 1b7a9817e2 For #2905: Remove device name during sync logout 2019-06-12 17:07:56 -04:00
Jonathan Almeida f71bdcfd10 For #3388: Set max length for device name (#3397) 2019-06-12 15:35:06 -05:00
Colin Lee f1088222b4
For #3203: Updates edit bookmarks to have user friendly names (#3372)
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
Emily Kager 186983b786 For #3275 - Adds PendingSessionDeletion data class to handle multiple emit session calls (#3393) 2019-06-12 10:49:20 -07:00
Jonathan Almeida 80e7868fd7 For #1134: Set UA to GeckoView 69.0 for whitelisted domains 2019-06-12 13:27:42 -04:00
Sawyer Blatz 7bcc8d576e For #2219: Inflates toolbar menu from bottom (#3389) 2019-06-12 11:17:33 -05:00
Colin Lee 66a836cf3a
For #3314: Toolbar and QAB unresponsive after Android 6 perms check (#3373) 2019-06-12 10:08:39 -05:00
Jeff Boek 332b4c4da5 For #3278 - makes the string a constant 2019-06-11 16:24:28 -07:00
Jeff Boek fc603e65a5 For #3278 - Removed redundant override 2019-06-11 16:24:28 -07:00
Jeff Boek fead5183c8 For #3278 - pin the default search engine to the top 2019-06-11 16:24:28 -07:00
Jeff Boek a86ec60f8f For #3278 - Fixes search engine selector layout 2019-06-11 16:24:28 -07:00
Emily Kager 71f2b0bdaa For #2253 - Use toolbar as anchorView with fullscreen snackbar 2019-06-11 15:09:07 -07:00
Christian Sadilek ccc7c70967 For #3252: Reader mode appearance buttons are not visible in PB
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-11 18:02:29 -04:00
a79014 d2c3427f1e Doesn't print gecko emoji on android ver < 7 (android N) (#3115)
* Doesnt print gecko emoji on android ver < 7

* fixed typo on maybeGecko variable

* Closes #3076: Lizard char now doesn't appear if not supported androidver

* Closes #3115: Prints string instead of gecko emoji in unsupported
android versions
2019-06-11 16:40:51 -05:00
Emily Kager edc1422b68 For #3288 - call setChecked after calling setOnCheckedChangeListener (#3357) 2019-06-11 16:38:32 -05:00
Colin Lee b498f5559b
For #3333: Only show desktop bookmarks if logged in (#3356) 2019-06-11 16:37:34 -05:00
jhugman 26d0ddda98 Fixes #3358 - disable feature-app-links (#3359) 2019-06-11 16:34:28 -05:00
Emily Kager de45dfd98a For #3131 - Add new task and clear task flags when opening intent (#3363) 2019-06-11 16:33:38 -05:00
Gabriel Luong f05eb032d4 For #2684: Add an extension function Session.toTab to map Session to Tab and clean up their usage 2019-06-11 13:14:23 -07:00
vmbaicu a2f2a23a15 Fixes #3281 - Fix Report and onboarding lint errors and issues (#3339) 2019-06-11 12:33:12 -05:00
Sawyer Blatz 3e5b6ca007 For #975: Removes leakcanary and default browser telemetry (#3350) 2019-06-11 12:30:25 -05:00
Emily Kager 82cf81242f For #3331 - Delay restoring layout while list restores (#3354) 2019-06-11 12:27:32 -05:00
Sawyer Blatz decacbfc97 For #3323 Runs PublicSuffixList synchronously 2019-06-11 09:19:51 -07:00
Grisha Kruglov a58a77317e Automatically close the 'auth-problems fragment' once we're through the auth flow (#3340) 2019-06-11 09:36:05 -05:00
Emily Kager e57e7b50ee For #2899 - Scroll to Collections on change, animate new collections (#3279)
* For #2899 - Scroll to Collections on change, animate new collections

* For #2899 - Scroll to tabs when tabs opened from collection
2019-06-11 09:01:00 -05:00
Emily Kager 975975e789 For #3326 - Remove open image in tab from context menu (#3327) 2019-06-11 08:59:00 -05:00
Sawyer Blatz c17d024452
For #975: Adds preferenceToggled event (#3316)
🤦🏼‍♂️
2019-06-10 13:56:12 -07:00
Sawyer Blatz ab000d2e51
For #3280: Revert "For #3215: Restores collections properly" (#3320)
This reverts commit 3e9ee79c00f4a6b34af74ce7c179e0cbe37decf5.
2019-06-10 13:54:03 -07:00
Arturo Mejia 5df726715f Revert "For #3008, For #2162 Add Simple Logic for Menu Orientation" (#3310)
#3114
2019-06-10 10:58:18 -05:00
Colin Lee f7b5fc3e18
For #3186: Add environment to Sentry reports (#3261) 2019-06-10 10:55:39 -05:00
Tiger Oakes 82d2a0661b Remove deprecatd support-ktx methods (#3305) 2019-06-10 09:12:11 -05:00
Denys M c9570fd6ff Use `Drawable.toBitmap()` from androidx-ktx. (#3286) 2019-06-10 08:50:37 -04:00
Nikit Bhandari d814e95794 fix crash on renaming a collection 2019-06-08 06:44:15 -07:00
Sawyer Blatz 86aac3e313 For #3176: Hides camera options on devices without cameras (#3273) 2019-06-07 19:37:43 -05:00
Emily Kager bf4916418a For #1998 - Removes stable flag in entering fullscreen navigation 2019-06-07 15:20:30 -07:00
Sawyer Blatz b2ca77269b
For #3251: Fixes shortcut typing (#3271) 2019-06-07 15:07:46 -07:00
Sawyer Blatz 054635735a
For #2750: Removes unecessary invalidate CollectionViewHolder call (#3264) 2019-06-07 13:38:18 -07:00
Sawyer Blatz 45c509fbce
For #2648: Updates trimming of url hostname (#3191)
* For #2648: Updates trimming of url hostname

* For #2648: Fix nits
2019-06-07 09:33:07 -07:00
Emily Kager 7368a95d29 No issue: Sets up observers for tab collection changes (#3248) 2019-06-07 09:45:38 -05:00
Jonathan Almeida f7bd39da77 For #3138: Fix white background on search bar 2019-06-06 17:11:06 -07:00
Colin Lee 1e6da54263 For #3238: fixes race condition crash, nav destination unknown 2019-06-06 15:46:34 -07:00
Jonathan Almeida 0a3b001abe For #3167: Show help page in browser menu (#3230) 2019-06-06 16:55:15 -05:00
Emily Kager acea0d5668 For #2785 - Adds back item animator session control (#3233) 2019-06-06 16:54:49 -05:00
Emily Kager ed39b7828b For #3234 - Updates labels of fragments in the nav graph to avoid flash (#3235) 2019-06-06 16:52:25 -05:00
Jeff Boek 0fefbbf5fb For #1809 - Restore all crashed tabs 2019-06-06 12:58:32 -07:00
Sawyer Blatz 8537ff10a8 For #3215: Restores collections properly (#3219) 2019-06-06 14:26:05 -05:00
Emily Kager 4954aadd84 For #3156 - If only one tab adding to collection make it selected (#3222) 2019-06-06 14:24:25 -05:00
Colin Lee 28ecf241f5
For #1301: Always observe sessions to keep uri_count (#3172) 2019-06-06 14:16:31 -05:00
Sawyer Blatz 6682386fc8 For #1242 & #975: Fixes camelcase of telemetry 2019-06-06 10:59:09 -07:00
Denys M 605a552f16 For #1366. Update toolbar search state when typing. (#2908) 2019-06-06 08:16:22 -07:00
Emily Kager 33eb26861d For #3141 For #3142 Do not try to fade BrowserFragment in transitions (#3195) 2019-06-05 20:37:58 -05:00
Emily Kager 9624964bc3 For #3087 - Adds disabled color attr (#3192)
* For #3087 - Adds disabled color attr

* Change alpha to 40%
2019-06-05 20:37:16 -05:00
Emily Kager 93a5456785 For #2253 - Shorten Fullscreen snackbar length (#3190) 2019-06-05 20:36:13 -05:00
Emily Kager 704f1e6a3d For #3004 - Restore MotionLayout on Home View only in onCreateView 2019-06-05 14:46:38 -07:00
Grisha Kruglov fe3c163a20 Fix how we reflect FxA state in preference
This cleans up how we're displaying account state in the main preference UI.
Before when it worked, it worked mostly accidentally.
'launch' wrapper around "update ui" methods would trigger a race condition
between binding the account pref view holder and actually updating that view
with values. Sometimes the "update view with values" would happen after view
was bound, and the UI will be correct. Most of the time it would happen before,
and so there will be nothing to update and we'd get into an inconsistent state.

This also splits up the "accountpreference" into two: account is good,
and account needs re-auth. This greatly simplifies their management.
2019-06-05 14:38:06 -07:00
Grisha Kruglov 0e1d81126d Make 'remove account' work on the "reconnect to sync" screen
This seems to have been copy-pasted and wasn't hooked up correctly.
2019-06-05 14:38:06 -07:00
Grisha Kruglov 7af61b1560 Navigate away from account settings after encountering auth problems 2019-06-05 14:38:06 -07:00
Sawyer Blatz 47c14b07dd For #1190: Removes syncing items from FxA telemetry 2019-06-05 13:57:18 -07:00
Sawyer Blatz c4c5d44430 For #975: Updates telemetry for settings (#3171) 2019-06-05 13:34:42 -05:00
Sebastian Kaspari b2d81aba43 Issue #2381: Add feature-media component and enable notification for recording devices. 2019-06-05 20:20:44 +02:00
Jeff Boek 27fdd9605b For #2395 - Adds an early return statement and documents why we copy a feature 2019-06-05 10:47:21 -07:00
Jeff Boek f26c402f0a For #2395 - Properly takes you back to where you start authentication on completion 2019-06-05 10:47:21 -07:00
Sawyer Blatz 12eabd5eb3 For #977: Listens to correct custom tab open menu fact 2019-06-05 09:34:50 -07:00
mythio 2daa75db2c Closes #3000: Replace deprecated method 2019-06-05 09:33:58 -07:00
Emily Kager 14c581c012 For #3004 - Do not restore motionlayout state in ReloadData 2019-06-05 09:33:07 -07:00
Emily Kager 94881f8241 For #3135 - Reduce swipe to delete sensitivity 2019-06-04 16:10:28 -07:00
Sawyer Blatz 0b3a8b7a54 For #2316: Adds confirmation dialog to delete bookmark 2019-06-04 14:47:11 -07:00
Sawyer Blatz 8e24feefc2 For #1192: Updates detection for Lockwise 2019-06-04 11:23:18 -07:00
ekager 87f6268816 For #3101 - Do not show tab selection screen for 1 tab 2019-06-04 10:08:43 -07:00
Emily Kager dc0d153580 For #3008, For #2162 Add Simple Logic for Menu Orientation (#3114)
* For #3008 - Adjust orientation of collections menu based on view location

* For #2162 - Add simple menu orientation logic to bookmark menu
2019-06-04 10:37:57 -05:00
Emily Kager ef0618a3d1 For #3103 - Exit fullscreen on pause (#3112) 2019-06-04 10:36:16 -05:00
Emily Kager ca186c8776 Closes #1618 - Add fade to awesome bar list instead of shadow (#3110)
* Closes #1618 - Add fade to awesome bar list instead of shadow

* For #1211 - Hide keyboard on fling suggestions list
2019-06-04 10:35:47 -05:00
Colin Lee 5fb100debd
For #1966: Up button should cancel multi-selection first (#3108) 2019-06-04 10:08:06 -05:00
Jeff Boek 40a3246c32 Adds dialog style for Firefox Accounts 2019-06-03 19:08:26 -07:00
Colin Lee 04a759f0b0
For #2693: Launching Fenix via adb with URL crashes (#3099) 2019-06-03 16:24:37 -05:00
Tiger Oakes 94c4013810 Closes #3091 - Hide Pull to Refresh under flag (#3092)
This was merged in after feature freeze so we're pulling it out for
now. Pull to refresh will continue to work in debug mode so that the
design can be iterated on easily.
2019-06-03 14:10:53 -05:00
Colin Lee 04bbeb5ae6 For #3073 'Open in Firefox Preview' no longer opens in app
Saving and restoring the custom tab session ID fixed one problem while causing another. I added code to only restore the ID if the session has a customTabConfig associated.
2019-06-03 10:04:17 -07:00
Mitchell Hentges 62473e5e86
Migrates "raptor" build type to work for chrome-perf-testing, too (#2926) 2019-06-03 16:32:38 +02:00
ekager d285e799b9 Clean up logic to return margin pairs for readability 2019-06-03 10:00:00 -04:00
ekager 14fe356d62 For #2794 - Adjust engine margins when enter/exit fullscreen 2019-06-03 10:00:00 -04:00
ekager 98a40aabd7 For #2223 , For #371 - Replace Toolbar with FIP when opened 2019-06-01 10:24:55 -07:00
ekager 388581f76f For #3056 - Filter sessions on invoke for pending delete all job 2019-05-31 18:52:02 -07:00
Jeff Boek e15ab3f958 For #1158 - Use a dot instead of an underscore to seperate values 2019-05-31 18:15:07 -07:00
Colin Lee 532483498a
No issue: Store the Custom Tab Session ID to avoid a crash (#3062) 2019-05-31 17:03:58 -05:00
Arturo Mejia 038aecc0ee For #1919- Websites' icons are not displayed on Site permissions (#3050)
Exceptions.
2019-05-31 16:27:12 -05:00
Emily Kager d5a9627273 For #2941 - Remove Delete Dialog, Theme Dialogs (#3052) 2019-05-31 16:26:34 -05:00
Emily Kager 0327b1146b For #2977 - Update add new collections flow (#2991)
* For #2977 - Update add new collections flow

* Rename shared elements to be more general

* Make tab list not clickable in other modes

* For #2577 - Stop Flickering in List

* Add extensions function for next step with collections list size
2019-05-31 12:59:51 -05:00
Emily Kager f48db90716 No issue: Always try to pop to browser when navigating to browser (#3043) 2019-05-31 12:57:34 -05:00
Jeff Boek 14f1d40e10 Fixes #3041 - Fixes the string that gets displayed in the FxA Onboarding card 2019-05-31 10:44:14 -07:00
James Hugman 060cd646c8 Fixes #1570 - Enable app-links feature 2019-05-31 10:39:47 -07:00
Sawyer Blatz 35a745d67d For #2836: Fixes custom tab close button color 2019-05-31 09:50:46 -07:00
Jeff Boek 301984733a For #225 - Adds completion snackbar 2019-05-31 09:42:44 -07:00
Jeff Boek eda70ab74c Fixes #3037 - Unchecks boxes after deletion 2019-05-31 09:42:44 -07:00
Jeff Boek 0036938312 For #225 - Fixes crash by moving GeckoView calls t othe main thread 2019-05-31 09:42:44 -07:00
Emily Kager 1bb4d72fd1 For #3027, For #2858 Pass in Fenix Snackbar for Context Menu Candidate (#3028) 2019-05-31 10:16:08 -05:00
Jonathan Almeida ab39a5088a For #2052: Fix BrowserToolbar overlapping web content 2019-05-30 20:40:56 -04:00
Jeff Boek 209b50016e For #2723 - Cleans up code formatting 2019-05-30 16:38:31 -07:00
Jeff Boek f9d70dbc92 For #2723 - Creates callbacks to wire up the mode and theme manager together 2019-05-30 16:38:31 -07:00
Jeff Boek a7d5cdcb9d For #2723 - Fixes theme manager 2019-05-30 16:38:31 -07:00
Emily Kager 18cd9e58f9 Fixes Crash: Pop up to Browser Fragment if exists when coming from Search 2019-05-30 16:30:06 -07:00
Emily Kager 8dbed67f7f No issue: Simplify and speed up shared element transitions 2019-05-30 16:30:06 -07:00
Emily Kager 43a961fe73 For #1973 - Toggle QR button on deny permissions, fix engineView crashes 2019-05-30 16:06:37 -07:00
Colin Lee 72c5cb304c
For #2893, #2673, #2916, #2314: Fix race condition navigating to browser (#3023)
Since the Navigation library restores the fragment after memory eviction, if we're already on the BrowserFragment and we deep link navigate to the BrowserFragment, we briefly get two of them. This crashes GeckoView.
2019-05-30 17:43:32 -05:00
Emily Kager 4c970a545d For #2230 - Fix theme selection radio button for Android 6 (#3019) 2019-05-30 17:06:46 -05:00
Tiger Oakes 74dd2a5f23 Issue #103 - Pull to refresh (#3020) 2019-05-30 17:05:49 -05:00
Sawyer Blatz cd19f36b96 For #2227: Fixes issue with bookmark selection (#3021) 2019-05-30 17:01:51 -05:00
Sawyer Blatz 9e0e5d95d9 For #2931: Show browser snackbar above quick action sheet 2019-05-30 14:52:09 -07:00