blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #3326 - Remove open image in tab from context menu (#3327)

master
Emily Kager 2019-06-11 06:59:00 -07:00 committed by Colin Lee
parent 4d82c29743
commit 975975e789
2 changed files with 45 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt
View File

@ -37,7 +37,6 @@ import mozilla.appservices.places.BookmarkRoot
import mozilla.components.browser.session.Session
import mozilla.components.browser.session.SessionManager
import mozilla.components.feature.app.links.AppLinksFeature
import mozilla.components.feature.contextmenu.ContextMenuCandidate
import mozilla.components.feature.contextmenu.ContextMenuFeature
import mozilla.components.feature.downloads.DownloadsFeature
import mozilla.components.feature.intent.IntentProcessor
@ -206,7 +205,7 @@ class BrowserFragment : Fragment(), BackHandler, CoroutineScope {
feature = ContextMenuFeature(
requireFragmentManager(),
sessionManager,
ContextMenuCandidate.defaultCandidates(
FenixContextMenuCandidate.defaultCandidates(
requireContext(),
requireComponents.useCases.tabsUseCases,
view,

44
app/src/main/java/org/mozilla/fenix/browser/FenixContextMenuCandidate.kt 100644
View File

@ -0,0 +1,44 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
License, v. 2.0. If a copy of the MPL was not distributed with this
file, You can obtain one at http://mozilla.org/MPL/2.0/. */
package org.mozilla.fenix.browser
import android.content.Context
import android.view.View
import mozilla.components.feature.contextmenu.ContextMenuCandidate
import mozilla.components.feature.contextmenu.DefaultSnackbarDelegate
import mozilla.components.feature.tabs.TabsUseCases
class FenixContextMenuCandidate {
companion object {
/**
* Returns the default list of context menu candidates.
*
* We are removing open image in new tab temporarily see https://github.com/mozilla-mobile/fenix/issues/2312
*/
fun defaultCandidates(
context: Context,
tabsUseCases: TabsUseCases,
snackBarParentView: View,
snackbarDelegate: ContextMenuCandidate.SnackbarDelegate = DefaultSnackbarDelegate()
): List<ContextMenuCandidate> = listOf(
ContextMenuCandidate.createOpenInNewTabCandidate(
context,
tabsUseCases,
snackBarParentView,
snackbarDelegate
),
ContextMenuCandidate.createOpenInPrivateTabCandidate(
context,
tabsUseCases,
snackBarParentView,
snackbarDelegate
),
ContextMenuCandidate.createCopyLinkCandidate(context, snackBarParentView, snackbarDelegate),
ContextMenuCandidate.createShareLinkCandidate(context),
ContextMenuCandidate.createSaveImageCandidate(context),
ContextMenuCandidate.createCopyImageLocationCandidate(context, snackBarParentView, snackbarDelegate)
)
}
}