1d28f63737
Closes #12522 : Reuse exceptions code ( #13047 )
2020-07-31 13:24:14 -07:00
8b923fc7a4
For #13135 - Replace about top header with Firefox Daylight
2020-07-31 16:21:39 -04:00
5e38ccc5e4
swapped deleted and save icon in bookmarks_edit menu. closes#11490
2020-07-31 16:19:02 -04:00
52e19ec743
For #12888 - Add highlight to current page in tab history.
2020-07-31 12:54:42 -07:00
ff50dae8e9
For #11498 - removed SignIn ViewHolder and unified with the Error one
2020-07-31 21:42:57 +03:00
5d1aeb5ea7
For #11499 - replaced string for no tabs available
2020-07-31 21:42:57 +03:00
bfc955cd40
For #11498 - add Sync tabs error view (including sign-in CTA)
2020-07-31 21:42:57 +03:00
29d07e8153
Import l10n.
2020-07-31 12:37:11 +03:00
5ddf8beea7
Fix suggestions, extract layout for tab history
2020-07-30 17:54:09 -07:00
d8ff6179fe
For #7992 : Use favicon style from AC ( #12608 )
2020-07-30 11:21:17 -07:00
ef4e865105
Import l10n.
2020-07-29 21:52:03 -04:00
d5b105097e
Import l10n. ( #13088 )
2020-07-29 13:51:01 -07:00
8bfc493568
For #12103 : Add ChangedDefaultBrowser event for leanplum
2020-07-29 13:35:16 -04:00
2c0511c92f
Import l10n.
2020-07-29 11:42:30 -04:00
ac870634ff
For #12533 : Align main settings categories according to specs. ( #12534 )
2020-07-29 10:08:00 -05:00
e2e684b4d4
Import l10n. ( #13048 )
2020-07-28 18:37:50 -07:00
bef98698cb
For #12904 - Conditionally inflate SwipeGestureLayout in BaseBrowserFragment.
...
Changing the root view of BaseBrowserFragment from a CoordinatorLayout
to a SwipeGestureLayout has caused some regressions, particularly in
snackbar behavior. Lets prevent those regressions from occuring in
builds where the feature flag for gestures is off by only adding the
SwipeGestureLayout when the feature flag is on.
2020-07-28 14:54:18 -07:00
0c8c87e56d
For #12755 - Replace @+id by @id when referencing already declared ids
...
When referencing an Android resource ID, you do not need the
plus-symbol if you declared before.
Caution: make sure that the resource you are referring to
is defined EARLIER and not LATER.
2020-07-28 14:46:09 -07:00
af020d0af1
For #12706 - Add vertical scrollbar to bookmarks screen
2020-07-28 16:47:18 -04:00
791eac50f3
For #12704 - Add vertical scrollbar to history screen
2020-07-28 16:47:09 -04:00
210f1ab898
For #12707 - Add vertical scrollbar to search suggestions
2020-07-28 16:46:51 -04:00
239e3de5e9
For #12856 : Add save to collections button to Tabs Tray
...
Using the ConcatAdapter, we're now able to insert multiple data sources
of information into one RecyclerView and preserve layout/scrolling in
addition to adding the 'Save to Collection' button.
2020-07-28 11:14:08 -07:00
12e68ac18d
For #12622 : Visually indicate different types of suggestions in the search screen
2020-07-28 11:08:35 -07:00
33db252797
Import l10n.
2020-07-27 21:05:00 -04:00
0657bf41d3
For #12991 - Set height to recommended touch target size for collect button
2020-07-27 20:17:48 -04:00
b7325a3833
For #12571 : Rename shortcuts to search engine on search screen ( #12839 )
...
* Rename shortcuts to search engine on search screen
* Remove deprecated pref key
* Re-add deprecated string
2020-07-27 17:19:31 -05:00
57ac6fc36d
Extract navigation subgraphs
2020-07-27 15:04:28 -04:00
b1e7e60665
For issue #12181 - Convert String to sentence case
...
Changed the string values capitalization to sentence case.
2020-07-27 12:31:13 -04:00
1cbc4eec52
For #7716 - modified xml to let 'Learn more' button have min 48dp for a11y
...
Added a margin top of 20dp as well on the buttons so as not to change UI
2020-07-27 10:16:31 +03:00
b3b7566fcf
For #12804 : Set min height for search engine radio button
2020-07-24 22:10:24 -04:00
46511d6f8e
For #10163 - Adds tab multiselect mode
2020-07-24 18:18:26 -04:00
d15b8381a6
For #10925 : Fix breaking APIs in tabs tray
2020-07-24 16:52:06 -04:00
7f829e1752
Import l10n.
2020-07-23 10:40:10 +03:00
58ccc64386
Fix UI tests.
...
We need to pass a CoordinatorLayout instead of a SwipeGestureLayout to
FenixSnackbar.make() in BaseBrowserFragment to prevent UI tests from
breaking. We also need to remove a few view IDs from the tab preview.
2020-07-22 11:26:15 -07:00
e7dc5580b2
For #3481 - Implement swipe on toolbar to switch tabs.
2020-07-22 11:26:15 -07:00
9a2da5bb0f
Import l10n.
2020-07-22 11:25:16 -07:00
921b16233b
For #1048 - Add ability to view tab history by long-pressing the back or forward button.
2020-07-22 11:20:47 -07:00
2a0a11f740
For #12571 : Rename 'Shortcuts' to 'Search engines'
...
Co-Authored-By: Khushraj Rathod <khushrajrathod@gmail.com>
2020-07-22 11:05:04 -07:00
99354174a9
For #12797 : Use measured height/width for loading a thumbnail
...
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.
The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-07-21 16:38:49 -04:00
8826f99ef7
For #9722 : Refactor onboarding buttons with text.
...
Add title and description to button text, remove extra Textviews.
2020-07-21 10:28:45 -07:00
9a7154e95e
For android-l10n #241 : Mark a11y link type as not translatable.
2020-07-21 17:59:17 +03:00
80b3b2dd82
Import l10n. ( #12766 )
2020-07-20 18:26:00 -07:00
284ec7b58f
For #12461 : Add tab count to tab tray
2020-07-20 19:16:47 -04:00
f73411b924
For #5499 - Unify CFR drawables and dimens ( #12749 )
2020-07-20 16:00:57 -07:00
aeabd3e91b
For #12532 : Quick fix for radio button alignment ( #12691 )
2020-07-20 15:33:32 -07:00
cd2532349d
For #12551 - Implement swipe to delete for bookmarks.
2020-07-20 14:54:20 -07:00
313e5abf6a
Rename tab_tray_background.xml
2020-07-20 14:54:20 -07:00
1121d844e6
For #12730 - Fix ripple for font size setting.
2020-07-20 13:00:59 -07:00
c66480d6dd
Import l10n. ( #12687 )
2020-07-19 21:30:11 -07:00
499f185fc0
Fix lint issues ( #12683 )
2020-07-17 16:20:08 -07:00
37af9df3ad
For #12532 : Align Settings -> Site permissions -> Sub-pages to 72dp keyline ( #12680 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-17 15:54:57 -05:00
1823fdb66d
For issue #9949 - Bookmarks/History deletion inconsistencies ( #12630 )
...
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.
- Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648 .
Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
2020-07-17 15:13:18 -05:00
aa7655f4d6
For #12509 : Set height of remove add on button to 36dp
2020-07-17 12:55:36 -07:00
e358f95eed
For #12364 - Only show PWA prompt the third time a user visits installable site
2020-07-17 12:37:03 -04:00
2fe17a6220
For #12531 : Align Settings -> Private browsing to 72dp keyline ( #12654 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 22:26:49 -07:00
023a4983fa
For #10173 : login duplicates and save ( #11208 )
...
* Extract controller into it's own class. Implement find dupes and filter based on username.
Create edit login controller. Add text watchers and check for duplicates.
Edit controller test
* Find duplicates and save to store
* Retrieve duplicates from AC and check list on username text changed
Move duplicates logic into the controller
* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.
* Use correct threads in controller. Enable save button when applicable.
Save enabled in datastore.
Move login data to datastore
Rebase with password error states
Update metrics to be more specific for edit
* Create logins controller for AC calls
* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.
Inflate view in edit fragment. Double layout showing up.
Edit view
Controller tests
Controller tests passing
Interactor tests
Lint and detekt cleanup
* Remove datastore and use storage controller for all logins calls to password storage.
Addressed comments
Lint
:
Rebase - 1
2020-07-16 17:08:04 -05:00
b997fba953
No issue: Move dp's to dimens.xml
2020-07-16 13:08:55 -04:00
cdd5d206fd
For #12105 : Follow ux mock on Settings --> Accessibility screen
2020-07-16 10:37:20 -04:00
8130aaa2cc
Add deep links for settings and home screens
2020-07-16 10:37:03 -04:00
9ed85510ae
For #7094 - Adds save login exceptions
2020-07-14 14:47:37 -04:00
f424656575
For #12107 : Follow ux mock on Settings --> Account screen
2020-07-14 12:25:21 +03:00
07e01c5b86
Import l10n.
2020-07-14 11:40:19 +03:00
88af736065
For #11099 For #12189 For #7532 - Clean up bottom navigation bar colors
2020-07-13 13:46:35 -04:00
ca30fef579
For #12106 : Follow ux mock on Settings --> Logins screen
2020-07-13 11:14:32 -04:00
ca352c555b
Import l10n.
2020-07-13 07:59:10 +03:00
0add94e353
For #11324 - Adds trash icon to swipe to delete
2020-07-10 20:16:57 -04:00
9aab1d1678
For issue #12339 - Collection delete dialog string update
...
Set the collection delete dialog title text to "Delete %1$s?"
2020-07-10 11:38:39 -04:00
c3b06374a1
Import l10n.
2020-07-09 21:39:49 -04:00
ad265be672
For #11303 - Change copy login origin to open in browser
2020-07-09 18:09:41 -04:00
63eb7b3e4e
For #12010 : Follow ux mock on Settings --> ETP --> Info screen ( #12429 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-09 09:47:09 -07:00
cba27a3883
Import l10n.
2020-07-09 11:29:38 -04:00
6f49e08725
Import l10n. ( #12404 )
2020-07-08 18:56:37 -07:00
d76d8d1881
For #11563 : Set ic_close.xml to use full width and height
2020-07-08 17:21:25 -04:00
bedd1d452c
Import l10n.
2020-07-07 21:27:37 -04:00
fab64229a5
Closes #11873 - Add scrollbar in tabs tray
2020-07-07 17:50:56 -04:00
f838049e97
Import l10n.
2020-07-07 11:12:02 -04:00
e39d5b6de7
For #11763 : Shows confirmation dialog when deleting last tab from collection
2020-07-06 17:06:10 -04:00
c3acde438a
For #11889 : Changes collection creation confirmation snackbar strings
...
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
2020-07-06 17:02:02 -04:00
426a1ba57d
For #12078 : Follow ux mock on Settings --> Language screen
2020-07-06 15:47:42 -04:00
9bc4f443f5
For #9775 : Increase touch target of elements in add search engine screen
2020-07-06 15:47:25 -04:00
170ae1aa33
For #12263 - Adds end margin to synced tabs header
2020-07-06 15:37:53 -04:00
331090d1e6
For #12007 : Fix add search engine items using wrap content for height
2020-07-06 15:37:28 -04:00
296bdc5967
For #12016 : Follow ux mock on Settings --> Data Collection
2020-07-06 15:27:46 -04:00
90f43bf350
For #12086 : Follow ux mock on Settings --> Customize screen ( #12324 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-06 12:25:54 -07:00
2668a68678
Import l10n.
2020-07-06 14:06:24 -04:00
822d50192a
For #12316 - Allow text wrap on buttons
2020-07-06 20:56:54 +03:00
8533d96ee2
For #11320 - Expose login autofill setting to beta dimension
2020-07-03 06:40:06 -04:00
321ba02832
Import l10n. ( #12175 )
2020-07-02 08:29:18 -07:00
ad8e28ae02
For #12007 : Follow ux mock on Settings --> Search screen ( #12177 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-02 00:48:31 -07:00
d17e91cc2e
Import l10n.
2020-07-01 08:48:18 +03:00
7b3fe9bab4
Import l10n.
2020-06-30 10:25:21 +03:00
50c3c9a9dd
Fix ignored XML lint issues ( #12094 )
2020-06-29 16:36:52 -07:00
f77bfdc2f2
Import l10n.
2020-06-28 20:41:02 -04:00
a07f31375e
Import l10n.
2020-06-28 09:59:49 -04:00
e0fa1c0db4
For issue #11835 - Update text fonts
...
Updated the fonts and colors for several texts throughout the application.
2020-06-26 23:18:52 -04:00
ed334788e8
For #11903 : Enforce private theme in custom tabs
2020-06-26 22:59:43 -04:00
5ef6b49aa1
For #8795 : remove redundant ConstraintLayout around BrowserToolbar. ( #12014 )
...
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.
The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.
Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
2020-06-26 21:31:02 -04:00
f89b157c23
For #12002 : Show default tab background when thumbnail not available ( #12041 )
2020-06-26 20:46:23 -04:00
8a08cb941e
For #11479 : Record open tabs count in metrics ping ( #12024 )
2020-06-26 17:15:43 -07:00
c6415ce18f
For 11616: removed black flicker with placeholder animation ( #11796 )
...
Increasing duration removed second "light" flicker
2020-06-26 20:10:22 -04:00
Tiger Oakes