a7e139da8e
Use new WindowFeature API after browser-state migration
2019-11-01 15:52:37 -04:00
e62407e766
For #5959 & #5958 : Integrates download feature into Fenix ( #6368 )
2019-10-31 14:37:05 -07:00
8549b80272
For #4456 : Adds total_uri_count to metrics core ping ( #6003 )
2019-10-30 11:02:33 -07:00
fb17ae2258
For #6229 - Remove all tab options from custom tab context menu
2019-10-25 13:25:31 -07:00
9543f38978
Use new toolbar API of AC 18.0.0.
2019-10-24 08:57:30 -07:00
cc9ee5a3d8
Merge #5332
...
5332: For #2483 #2629 : Close tab with no history on back press and return to parent if available r=ekager a=mawen7
Co-authored-by: mawen7 <mawen7@users.noreply.github.com>
2019-10-23 18:20:36 +00:00
f812ae4259
For #3676 : fix duplicate uri events on first load ( #6128 )
2019-10-23 10:21:46 -07:00
3af307b47f
Close tab with no history on back press and return to parent if available
2019-10-23 12:54:28 +02:00
aa8642f534
#4596 migrate collections ( #5911 )
...
* For #4596 : move code from CollectionCreationComponent to CollectionCreationStore
Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.
* For 4596: update CollectionCreateStore to libstate
* For 4596: copied CollectionCreationUIView into CollectionCreationView
Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.
* For 4596: update CollectionCreationView to LibState
Note that the minimal changes possible to enable migration were made. Refactoring will happen in a later commit.
* For 4596: updated CollectionCreationTabListAdapter to work with the new View
* For 4596: updated SaveCollectionListAdapter to work with the new View
* For 4596: implemented CollectionCreationController
For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer
* For 4596: copied over previous reducer code
No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer
* For 4596: update reducer code param names
Otherwise, no changes at this time
* For 4596: add arguments to CreateCollectionFragment in nav_graph
These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.
* For 4596: pass arguments to collection via transaction instead of VM
The VM will be removed in a later commit
* For 4596: update BrowserToolbarController to share state to collection via its Direction
* For 4596: removed CreateCollectionViewModel
* For 4596: test tab retrieval in CreateCollectionFragment
* For 4596: fix crashing CreateCollectionFragmentTest
* For 4596: removed classes create collection classes used by old architecture
* For 4596: collection interactor rename + kdoc
* For 4596: moved collection interactor interface
* For 4596: renamed CreateCollectionFragment
All related classes followed the pattern of CollectionCreationX
* For 4596: kdoc CollectionCreationController
There's no effective difference between these calls and their interactor equivalent, so I linked to them
* For 4596: fix bug that caused rename to not work
* For 4596: removed unused collection actions
These were unused before the LibState refactor
* For 4596: kdoc StepChanged
* For 4596: removed todos about moving logic to the reducer
saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive
handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here
stepBack: called by handleBackPress. See above
* For 4596: wrote tests for CollectionCreationController#stepback
* For 4596: fixed tests broken by changes to collections
* For 4596: small readability refactor for CollectionController#stepBack
No change to functionality (see tests)
* For 4596: broke apart CollectionView#update
There's probably a lot more that could be done here, but smaller changes were made to reduce scope
* For 4596: remove unnecessary todos
It looks like we don't follow the suggested pattern in this project
* For 4596: test CollectionCreationController#normalSessionSize
* For 4596: updated naming in CollectionCreationController per review
2019-10-22 17:33:54 -07:00
5d5358ae45
Issue #36170 : BaseBrowserFragment: Use new feature-prompts API.
2019-10-22 16:04:33 -04:00
485ccba189
Fixes #5323 : Show a snackbar while browsing data is deleting. ( #6105 )
2019-10-21 09:57:06 -07:00
faddf368e1
Fix #3122 - Hide the "Bookmark saved" Snackbar when user closes BrowserFragment
...
Previously the Snackbar was being inflated in the parent of this Fragment so
surviving it being closed.
Tying the Snackbar with the Fragment from which it is shown ensures it will be
effectively hidden whenever the user navigates from the Fragment.
2019-10-18 08:11:56 +03:00
aa1a5f3d32
Merge #6026
...
6026: For #5709 : Align ETP onboarding popup implementation with original mocks r=ekager a=mcarare
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-16 17:49:16 +00:00
610a70a8bc
Merge #6024
...
6024: For #5749 - Update string for ETP onboarding popup r=ekager a=BranescuMihai
Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com>
2019-10-16 00:12:52 +00:00
b82a794908
For #5709 : Align ETP onboarding popup implementation with original mocks
2019-10-15 17:07:47 +03:00
6fa9572ccf
Fixes #5063 : Added parameter customTabSessionId into ContextMenuFeature
...
Added parameter customTabSessionId into ContextMenuFeature in
BaseBrowserFragment in order to show the context menu in a custom tab.
2019-10-15 16:28:42 +03:00
1490c0178f
For #5749 - Update string for ETP onboarding popup
2019-10-15 15:56:59 +03:00
663126f696
No issue: Remove black flash workaround
2019-10-14 11:51:01 -07:00
8e4d7248ac
Merge #5908
...
5908: Closes #5876 : Removed @ObsoleteCoroutinesApi in tests r=sblatz a=shldhll
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
Co-authored-by: shldhll <iam.shldhll@gmail.com>
2019-10-14 16:52:22 +00:00
e8bb765ad7
For #5947 - Fix engineView NullPointerException
2019-10-11 09:03:24 -07:00
8e17ac05b1
Optimized imports. Closes #5876
2019-10-10 04:17:43 +05:30
f907ec52f0
Removed ObsoleteCoroutinesApi in tests. Closes #5876
2019-10-10 04:04:51 +05:30
f9afd97a68
For #1901 - Get rid of black flash when leaving GV Engine
2019-10-09 11:02:21 -07:00
411ccc8f1f
For 4780: add DefaultBrowsingModeManager tests
2019-10-08 15:13:17 -07:00
d1d20b544e
For 4780: update HomeActivity to maintain private mode in memory
...
As an added bonus, this makes the temporal coupling between `setPrivateModeIfNecessary` and `setupThemeAndBrowsingMode` explicit. They previously would have broken if called in reverse order, now it will fail to compile.
2019-10-08 15:13:17 -07:00
d5c3433041
Use the new fragment constructor
2019-10-07 11:07:48 -07:00
b733e4fa8f
Upgrade to Mozilla Android Components 16.0.0-SNAPSHOT
2019-10-03 11:07:26 -07:00
f7c9ab11eb
For #3487 - Add back open image in new tab
2019-10-01 12:45:09 -07:00
a4097cd380
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-30 10:33:56 -07:00
3f41a4e9c6
No issue: Update navigation library
2019-09-26 17:01:13 -07:00
ac2611d744
Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) ( #5578 )
...
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT
* Update findinpage integration to use browser-state
* Use new UseCases APIs after download migration.
2019-09-26 12:50:50 -07:00
24b3ed4384
For #5568 - Don't pass in Session for QuickActionSheetController
2019-09-25 13:33:38 -07:00
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
734d4031e2
Extract UriOpened observer from HomeActivity
2019-09-24 09:37:24 -07:00
9d9ff959b5
For #5312 - Add Telemetry for Tracking Protection
2019-09-23 08:29:45 -07:00
e9fd6892ba
For #394 , #778 - Add hide toolbar feature
...
And also add CustomTabsServiceStore
2019-09-20 12:34:49 -07:00
c2fb99a73f
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-16 19:44:13 -07:00
b8539ccb33
Use new feature-contextmenu API.
2019-09-16 17:24:13 +02:00
42bb3e1410
Change deleteAndQuit to take an activity
2019-09-15 20:03:04 -07:00
8cd0d8faf3
For #5304 - Align ETP Onboarding Tool Tip PopupWindow
2019-09-13 18:25:26 -07:00
3787dd7b1f
For #5254 : Fix transition to private browsing mode after sharing a page
2019-09-13 14:44:28 -07:00
dd85229c41
Use new feature-downloads API.
2019-09-13 15:01:25 +02:00
e3209dcc84
For #3700 - Add Setting to Delete Data on "Quit" menu action
2019-09-11 16:06:18 -07:00
4485b7f647
Add Tracking Protection Info Panel
2019-09-11 07:47:13 -07:00
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
16115f57d1
For #3440 - Reduce BrowserFragment require calls
2019-09-09 21:33:32 -07:00
aef087aae0
No issue: Removes unused nestedScrollQuickActionView ( #5143 )
2019-09-06 09:03:24 -07:00
58287cd5bb
For #5033 - Update browsing mode when session selected ( #5118 )
2019-09-05 14:27:30 -05:00
3a35233ac0
Remove ThumbnailsFeature. ( #5127 )
...
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
2c7fd93c7d
Update to Mozilla Android Components 12.0.0-SNAPSHOT.
2019-09-05 13:38:15 +02:00
ac32a88d45
Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
9b633f7f0f
Move creation of GeckoRuntime to flavor-specific source set.
...
Since we are now able to build against GeckoView Nightly and GeckoView Beta,
we should create the GeckoRuntime from a flavor-specific source set.
Creating the runtime is not covered by the AC abstraction and so API changes
in GeckoView Nightly can break the build and leaves us with no option to fix
it from a shared code base. Separating the creation of GeckoRuntime
allows us to adapt individually and also to configure the runtimes
differently.
2019-08-30 15:16:12 +02:00
a65f220b39
For #4921 - Adds WindowFeature to BaseBrowserFragment
2019-08-27 15:33:59 -04:00
66e14959ba
Add custom tab fragment
2019-08-23 16:12:19 -04:00
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
fb1d655d96
Closes #4822 - Update Bookmark State in onResume ( #4823 )
2019-08-19 16:22:20 -07:00
de14962e3f
Extract quick action sheet observer code ( #4368 )
2019-08-19 08:28:33 -07:00
7d02354f4f
For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController ( #4800 )
2019-08-18 20:36:40 -05:00
d1aed157dd
For #4686 : Fix potential security issue ( #4764 )
2019-08-16 16:50:54 -05:00
5b4a441bcb
For #1667 : Screen reader can't reach other UI items when QAB expanded ( #4695 )
2019-08-14 09:56:29 -07:00
1328d686aa
No issue - Autoformatting ( #4715 )
2019-08-14 09:40:46 -05:00
7f07eabbd8
For #4652 : Crash "Can not perform this action after onSaveInstanceState" ( #4654 )
2019-08-09 14:46:40 -05:00
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
23f5ac0fb9
For #4066 : Create InflationAwareFeature for lazy inflation
2019-08-09 11:48:55 -04:00
c9c43260c9
For #4529 : Handle crash initializing CreateCollectionViewModel late ( #4628 )
2019-08-08 17:40:55 -05:00
ef97173cd9
For #4529 , #4427 : Resuming after restoring instance state breaks UI ( #4571 )
...
* For #4529 , #4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
2019-08-08 11:05:01 -05:00
ff6e9bccb7
For #4451 : Adds tests for DefaultBrowserToolbarController ( #4493 )
...
* For #4451 : Adds tests for DefaultBrowserToolbarController
* Continue working
* Large refactoring of test
* Mock analytics
* Fix merge conflicts
2019-08-08 09:02:42 -07:00
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
9d65e665e5
No issue: Removes deprecated usage of ViewModelProviders
2019-08-07 19:21:41 -04:00
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
631b7ba7cb
Issue #1000 - Split out common browser functions
2019-08-06 12:31:25 -07:00
1e4399ee38
Use auto pause with BrowserFragment observers
2019-08-02 17:32:58 -07:00
cbd811dcfb
Closes #1657 - Use Gecko for downloads ( #4296 )
2019-08-02 17:28:30 -07:00
9887945296
For #4412 : Only consume state change when UI initialized
2019-08-01 11:51:32 -04:00
59c0005979
For #4412 : SiteSecurityClickedListener set incorrectly
2019-07-31 19:52:53 -04:00
76ed07bd5d
Closes #4412 : BrowserInteractor has not been initialized ( #4414 )
2019-07-31 09:14:05 -07:00
8946bf20c4
Closes #3341 - Remove UserAgentRewriter
2019-07-31 11:05:42 -04:00
385dfd2f15
For #4376 : Removes usage of selectedSessionOrThrow ( #4381 )
2019-07-30 12:39:58 -07:00
9bc0122ce3
For #4359 : findBookmarkedUrl blocks the main thread ( #4362 )
2019-07-29 17:01:02 -05:00
6fa022c2f8
For #4124 : Migrate BrowserToolbar to Libstate ( #4279 )
...
* For #4124 : Migrate BrowserToolbar to Libstate
* Restores QuickActionSheetReducer
* Improve tests
* Make QuickActionSheetController
* Finalize tests
* Breaks out QuickActionSheetState
* Fix comments
* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
87d8f3b037
Remove redundant super calls
2019-07-29 10:22:53 -07:00
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
7588251f8b
Closes #3986 & Closes #3661 : Migrate QuickActionSheet to LibState & add tests ( #4058 )
...
* Closes #3986 : Migrate QuickActionSheet to LibState
* Closes #3661 : Add tests for QuickActionSheet
Co-authored-by: boek <jeff@jeffboek.com>
* For #3986 : Fix feedback
2019-07-22 10:31:31 -07:00
fc2bff0fde
For #4145 - Remove anchor view from fullscreen snackbar ( #4160 )
2019-07-19 11:18:47 -07:00
9f40c25c75
For #4143 - Allow user to rotate to other landscape orientation
2019-07-19 14:12:33 -04:00
d298b5f2f5
Closes #4075 : Add Feature Flag class ( #4077 )
2019-07-18 17:20:12 -07:00
e544827e83
For #2267 : Adds telemetry for reader mode ( #3941 )
2019-07-18 15:17:15 -07:00
981b6b5b02
For #4124 - Remove browser toolbar editing code
2019-07-18 15:40:33 -04:00
62850430b7
Closes AC#3695 - Add UI to open current page in external app
2019-07-18 15:33:31 -04:00
9ab67557cf
For #4078 - Request landscape mode when entering fullscreen
2019-07-17 16:06:37 -07:00
90dd0ab469
Closes #4114 - Re-enable app-links
2019-07-17 10:39:17 -07:00
8855af2234
For #3615 : Long pressing the address bar should not copy link ( #4083 )
2019-07-16 13:42:05 -05:00
9b1e63224c
Closes #4052 : Remove pending intent workaround. ( #4059 )
...
Previously we needed to set a static launch function to be invoked when the find in page
integration should be launched. Now we can access the integration class directly and
can avoid the static property that caused issues when used by multiple activities.
2019-07-15 14:15:59 -05:00
5de1678e65
No issue: Use putCompoundDrawables helper ( #3982 )
2019-07-15 08:24:59 -07:00
e4e0d45c1b
Closes #3996 : Remove workaround for opening custom tab in browser.
...
`EngineView` now allows releasing the `Session` so that it can be rendered by an
other `EngineView` instance.
2019-07-15 10:52:57 +02:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
2019-07-10 14:13:10 -04:00
57ca75139b
For #3201 - Update bookmark state when session selected
2019-07-03 11:38:14 -07:00
ce2d597af3
For #203 - Adds find in page and request desktop site to custom tab menu ( #3835 )
2019-07-02 14:41:29 -07:00
ece0e30655
For #2054 : Collapses quick action bar when opening find in page ( #3837 )
2019-07-02 08:22:34 -07:00
7e46e71d00
For #3005 : Closes tabs when saving to collection ( #3723 )
2019-07-01 11:39:48 -05:00
7fa4cf4487
Use sessionId in FIP Integration, use pendingIntent for startActivity
2019-06-28 14:00:59 -07:00
6d0a4fdb4d
Revert "For #3609 - Remove FIP Integration, Use FIP Feature"
...
This reverts commit 428643d598e938f58a2fe4abfee417c46edec167.
2019-06-28 14:00:59 -07:00
66eb4fd03b
No issue: Fixes master compilation
2019-06-27 09:05:57 -07:00
4994554576
No issue: Adds lint exception for when statement ( #3685 )
2019-06-26 15:52:24 -07:00
d01bb8c442
Use lifecycleScope for collections fragments
2019-06-25 13:56:15 -07:00
084fab77d4
For #3609 - Remove FIP Integration, Use FIP Feature ( #3637 )
2019-06-24 15:31:32 -07:00
ac5c4a0f79
Closes #3493 - Show tab saved to collection snackbar in BrowserFragment
2019-06-14 15:49:56 -07:00
7ebdfcc87b
For #1116 - Uses alias link for help
2019-06-14 15:33:34 -07:00
5540230e3d
For #1116 - Changes help link ( #3491 )
2019-06-14 15:29:10 -05:00
d5c5587a0c
For #3209 : Disable shared element animations for crash temporarily ( #3482 )
2019-06-14 12:13:13 -05:00
381a5e6089
For #3403 : Subscribes to tab collections in BrowserFragment
2019-06-12 16:44:35 -07:00
80e7868fd7
For #1134 : Set UA to GeckoView 69.0 for whitelisted domains
2019-06-12 13:27:42 -04:00
66a836cf3a
For #3314 : Toolbar and QAB unresponsive after Android 6 perms check ( #3373 )
2019-06-12 10:08:39 -05:00
71f2b0bdaa
For #2253 - Use toolbar as anchorView with fullscreen snackbar
2019-06-11 15:09:07 -07:00
ccc7c70967
For #3252 : Reader mode appearance buttons are not visible in PB
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-11 18:02:29 -04:00
26d0ddda98
Fixes #3358 - disable feature-app-links ( #3359 )
2019-06-11 16:34:28 -05:00
f05eb032d4
For #2684 : Add an extension function Session.toTab to map Session to Tab and clean up their usage
2019-06-11 13:14:23 -07:00
decacbfc97
For #3323 Runs PublicSuffixList synchronously
2019-06-11 09:19:51 -07:00
975975e789
For #3326 - Remove open image in tab from context menu ( #3327 )
2019-06-11 08:59:00 -05:00
82d2a0661b
Remove deprecatd support-ktx methods ( #3305 )
2019-06-10 09:12:11 -05:00
bf4916418a
For #1998 - Removes stable flag in entering fullscreen navigation
2019-06-07 15:20:30 -07:00
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
2019-06-07 09:33:07 -07:00
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
0a3b001abe
For #3167 : Show help page in browser menu ( #3230 )
2019-06-06 16:55:15 -05:00
93a5456785
For #2253 - Shorten Fullscreen snackbar length ( #3190 )
2019-06-05 20:36:13 -05:00
0b3a8b7a54
For #2316 : Adds confirmation dialog to delete bookmark
2019-06-04 14:47:11 -07:00
ef0618a3d1
For #3103 - Exit fullscreen on pause ( #3112 )
2019-06-04 10:36:16 -05:00
04a759f0b0
For #2693 : Launching Fenix via adb with URL crashes ( #3099 )
2019-06-03 16:24:37 -05:00
94c4013810
Closes #3091 - Hide Pull to Refresh under flag ( #3092 )
...
This was merged in after feature freeze so we're pulling it out for
now. Pull to refresh will continue to work in debug mode so that the
design can be iterated on easily.
2019-06-03 14:10:53 -05:00
04bbeb5ae6
For #3073 'Open in Firefox Preview' no longer opens in app
...
Saving and restoring the custom tab session ID fixed one problem while causing another. I added code to only restore the ID if the session has a customTabConfig associated.
2019-06-03 10:04:17 -07:00
d285e799b9
Clean up logic to return margin pairs for readability
2019-06-03 10:00:00 -04:00
14fe356d62
For #2794 - Adjust engine margins when enter/exit fullscreen
2019-06-03 10:00:00 -04:00
98a40aabd7
For #2223 , For #371 - Replace Toolbar with FIP when opened
2019-06-01 10:24:55 -07:00
532483498a
No issue: Store the Custom Tab Session ID to avoid a crash ( #3062 )
2019-05-31 17:03:58 -05:00
0327b1146b
For #2977 - Update add new collections flow ( #2991 )
...
* For #2977 - Update add new collections flow
* Rename shared elements to be more general
* Make tab list not clickable in other modes
* For #2577 - Stop Flickering in List
* Add extensions function for next step with collections list size
2019-05-31 12:59:51 -05:00
060cd646c8
Fixes #1570 - Enable app-links feature
2019-05-31 10:39:47 -07:00
1bb4d72fd1
For #3027 , For #2858 Pass in Fenix Snackbar for Context Menu Candidate ( #3028 )
2019-05-31 10:16:08 -05:00
ab39a5088a
For #2052 : Fix BrowserToolbar overlapping web content
2019-05-30 20:40:56 -04:00
f9d70dbc92
For #2723 - Creates callbacks to wire up the mode and theme manager together
2019-05-30 16:38:31 -07:00
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
18cd9e58f9
Fixes Crash: Pop up to Browser Fragment if exists when coming from Search
2019-05-30 16:30:06 -07:00
8dbed67f7f
No issue: Simplify and speed up shared element transitions
2019-05-30 16:30:06 -07:00
43a961fe73
For #1973 - Toggle QR button on deny permissions, fix engineView crashes
2019-05-30 16:06:37 -07:00
74dd2a5f23
Issue #103 - Pull to refresh ( #3020 )
2019-05-30 17:05:49 -05:00
9e0e5d95d9
For #2931 : Show browser snackbar above quick action sheet
2019-05-30 14:52:09 -07:00
3685b05586
For #3011 - Size EngineView for Custom Tab Fixed Toolbar
2019-05-30 12:40:54 -07:00
c027feecd0
For #3011 - Size EngineView for Custom Tab Fixed Toolbar
2019-05-30 12:40:54 -07:00
3560e1793c
For #2980 - Pop to home if no session exists in Browser Fragment
2019-05-30 09:05:10 -07:00
8181705b58
Init Toolbar in edit mode so we don't see the flash
2019-05-29 12:27:48 -07:00
039990f608
For #2972 - Call session feature back press before custom tab back press
2019-05-29 09:40:52 -07:00
6290d7b890
For #2110 - Pressing back on external link should close the tab
2019-05-28 17:55:17 -07:00
cae95c0ee1
For #2952 - Delete All Tabs should run on Main Thread
2019-05-28 16:25:39 -07:00
b5d1d04d88
Closes #2900 : Fix crash when trying to show site info panel with
...
a null session.
2019-05-28 15:05:49 -07:00
ba6bb916e4
Closes #2789 : Custom tabs is not covering the full screen size.
2019-05-28 15:01:18 -07:00
2ad6875f09
No issue: Correct material dependency and anchor snackbar above toolbar
2019-05-24 17:38:20 -07:00
4e13de3ffd
No issue: Register observers with owner view
2019-05-24 10:53:05 -07:00
a676e964b5
For #966 - Preserve CustomTab history when opening in browser
2019-05-24 10:50:20 -07:00
2f46345954
Cancel pending findBookmarkJob if another is started
2019-05-24 09:42:22 -07:00
4b7c8a7db1
For #2228 - Update Bookmark Status in onUrlChanged
2019-05-24 09:42:22 -07:00
074eec7006
For #2815 - Use RootView for displaying snackbar in browserfragment ( #2816 )
2019-05-23 23:35:05 -07:00
40f2fe5166
For #1287 - Create animation for opening and closing tab from home
2019-05-23 13:41:00 -07:00
eb7646f073
Add custom share sheet and send tab support ( #2757 )
...
* Closes #2751 : Add custom app share sheet
* Closes #2753 : Add send tab devices to share sheet
* Closes #2752 : Add build flag for send tab
* Replace Context.share with ShareFragment
2019-05-23 10:48:22 -07:00
87df0a8103
For #2728 & #2729 : Uses view model selected tabs for collection creation ( #2748 )
2019-05-23 10:46:54 -07:00
763c8be815
For #2689 : Turns dynamic toolbar into fixed toolbar
2019-05-23 08:37:00 -07:00
afbe397f94
For #1575 : Enables adding tabs to existing collection
2019-05-21 09:39:55 -07:00
e534dad199
For #2028 - Pass Session ID for Custom Tab Prompts, Theme Dialogs
2019-05-20 19:24:48 -07:00
b54628210b
For #2414 - Fixes custom tab crash
2019-05-20 16:09:37 -07:00
2035be8cc6
Closes #2097 : Stop video playback when custom tab closes
2019-05-17 16:24:40 -07:00
6bc577eecd
For #1800 - "report site issue" should open in a new tab
2019-05-16 22:28:02 -07:00
72d29c2a43
For #2205 & #1578 : Integrates tab collection storage ( #2478 )
...
* For #2205 : Adds TabCollectionStorage
* For #1578 : Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
43843b0fb3
For #2561 - Dynamically set EngineView behavior in BrowserFragment
2019-05-16 11:22:14 -07:00
0b7df74731
For #2315 & For #2494 : Adds scrolling to custom tabs ( #2521 )
2019-05-15 09:37:05 -07:00
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
c2a3c844b8
For #2035 - Register Accessibility Manager Listener ( #2462 )
2019-05-14 14:34:01 -07:00
e0e7ba5a43
For #2302 - Listen to session to update QuickSettingsSheetDialogFragment
2019-05-14 13:49:59 -07:00
b71eeb9fb3
For #2245 : Updates quick action bar state and animation ( #2451 )
...
* Revert quick action changes
* For #2245 : Updates quick action bar state and animation
2019-05-14 08:14:41 -07:00
4070941657
No issue: Refactor dialogs to use nav graph
2019-05-10 19:58:48 -07:00
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
75ccce23dc
For #2323 - Update theme for browsing if needed in onResume ( #2360 )
2019-05-09 16:09:34 +00:00
b735cc9693
Closes #1311 : Enable downloads in custom tabs. ( #2311 )
2019-05-07 15:30:13 -05:00
84a7430e57
For #1745 - Allow trackers from Allow List ( #2310 )
2019-05-07 15:28:38 -05:00
583b954c5a
Closes #1320 : Customize site info panel dialog for custom tabs. ( #2304 )
2019-05-07 11:40:46 -05:00
e6e3ac35e0
For #2068 - Create QAS initial state ( #2298 )
2019-05-06 16:38:32 -05:00
7d577e5953
For #2205 : Adds collections view to home fragment ( #2249 )
...
* For #1574 : Adds collections to home view
* Adds colored icons and expansion
* Adds state change
* Adds more styling
* Adds ItsNotBrokenSnacks
* Adds chevron
* Improves styling of swipe to delete and adds delete action
* Fix nits
* Try to add real saving
2019-05-06 11:20:19 -07:00
9b0422b062
Issue #910 : Integrate feature-readerview component ( #2269 )
...
Closes #908 , Closes #910 , Closes #911 , Closes #912
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2019-05-03 21:01:45 +00:00
aa6d36dda9
For #2035 - Fixes a11y and loading toolbar behavior logic ( #2243 )
2019-05-02 16:28:57 -05:00
34bd6513b6
Fixes 1689 - Add sessionManager and sessionId to custom tabs menu and toolbar. ( #2229 )
2019-05-02 14:32:04 -05:00
2953b54a84
For #1573 - Polish Collections UI Component ( #2212 )
...
* Adds Keyboard resuming, Snackbar verification, layout edits to collections
Adds Keyboard resuming, Snackbar verification, layout edits to collections
* Adds new strings for collections/tabs management
* Adds constraintsets, hides checkboxes, adds scrim
* Update strings to plurals
2019-05-02 10:53:40 -05:00
b931957426
For #1586 : Behavior when adding a duplicate bookmark ( #2195 )
2019-05-01 12:21:28 -05:00
a07b6d8c0f
Closes #2156 - Update theme for selected session in BrowserFragment ( #2171 )
2019-04-30 20:04:16 -05:00
70486039c0
Closes #2147 : Refactors usage of openToBrowserAndLoad
2019-04-29 15:49:22 -07:00
14c4d12e49
For #1573 - Add Browsing Menu Item Add To Collections
2019-04-29 12:28:52 -07:00
d6879e2501
No issue: Sets BrowserFragment sessionId only in custom tabs
2019-04-29 09:45:46 -07:00
b11a7554c2
For #1836 - Update theme based on if session private ( #2099 )
2019-04-26 22:00:22 -07:00
66d76d3123
For #2074 : Displays title only in custom tabs ( #2075 )
2019-04-26 11:35:27 -07:00
99f979e86b
For #1601 - Bookmark icon should change visually if page is bookmarked
2019-04-25 17:29:27 -07:00
bc10c65c52
For #2035 Add TouchExplorationStateChangeListener and adjust toolbar
2019-04-25 17:13:20 -07:00
46924544b6
For #1975 & #1627 : Refactors getSessionById in BrowserFragment
2019-04-25 16:51:03 -07:00
4ae40b35e0
No issue Null check accessibility manager
2019-04-25 16:00:46 -07:00
9eaaedf4bd
For #1658 Update preferredColorScheme in onResume for auto-theming
2019-04-25 16:00:32 -07:00
1aee091485
For #2039 - Context check in setToolbarBehaviour ( #2040 )
2019-04-25 12:30:42 -07:00
10517580cc
No issue: Add back status/nav flags after fullscreen exit ( #2003 )
2019-04-25 07:39:14 -07:00
ec64286eac
No issue: Only set toolbar behavior for non custom tab sessions ( #2013 )
2019-04-25 07:37:30 -07:00
578a00a49b
Closes #1993 - Set toolbar behavior in onStart for browser resumed case
2019-04-24 13:40:55 -07:00
4dffd182b1
For #1206 - call fullScreenFeature onBackPressed
2019-04-24 13:40:01 -07:00
750ee266b0
For #2825 : use FenixSnackbar for fullscreen notification
2019-04-24 13:39:36 -07:00
8a4995099f
For #1205 : Adds search term to EditToolbar
2019-04-23 09:59:48 -07:00
5cf83cf8c1
BrowserToolbarBottomBehaviour: Remove unused parameter
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
b80b90c07d
Closes #1879 - Create toolbar background drawable instead of view
2019-04-22 14:22:28 -07:00
23e2b51db2
For #1759 - Try to change copy URL to plainText ( #1850 )
2019-04-20 14:15:37 -07:00
316569b899
Closes #1798 , Closes #1581 Corrects divider views and padding for toolbar and action sheet
2019-04-19 15:19:48 -07:00
4b59fc8939
Closes #1835 - Do not crash because of snackbar
2019-04-19 17:17:20 -05:00
849764d23a
For #974 : Telemetry for Bookmarks
2019-04-17 15:58:58 -07:00
01a181975d
For #1084 - Add tracking protection toggle to quick settings dialog
2019-04-15 19:59:10 -05:00
658f6dcf23
For #1495 - Reverts editing translated string and creates a new string
2019-04-15 13:33:09 -05:00
ec35283c9a
For #668 : Restyles custom tabs
2019-04-15 11:31:13 -07:00
3b1f684cb0
For #1599 : Crash creating a bookmark for a custom tab
2019-04-15 12:53:51 -05:00
29832c5e84
For #724 : Consolidates colors
2019-04-15 12:22:03 -05:00
4ba7527655
For #619 - Keep toolbar expanded while page is loading
2019-04-12 16:21:09 -07:00
070b7a397d
Fix #1159 - Hide the QuickActionBar if fullscreen
2019-04-11 08:50:08 -07:00
e67e57b7cc
for #1430 - Copy BottomToolbarBehavior to customize snackbar position
2019-04-10 19:59:23 -07:00
d4d1e6bd5f
For #1525 : Make BrowserPerformanceTestActivity pass through to IntentReceiverActivity.
...
Previously, this passed through to HomeActivity, but Intent arguments
were dropped. That means that actions (`-a
android.intent.action.VIEW`) and URLs (`-d data:...`) were dropped,
which means that Gecko itself wasn't started (and wasn't started with
a session owned by Fenix itself).
This simply passes through the intent to its final destination.
Along the way, I also enabled remote debugging for these test
configurations; it's probably not necessary, but eventually I want all
automation to be controlled by that setting. See
[Bug 1524673](https://bugzilla.mozilla.org/show_bug.cgi?id=1524673 )
for some of the motivation. This agrees with Chrome, and should
generalize to future remote control protocols.
2019-04-10 16:38:21 -05:00
e98db8bfb8
For #1430 - Adds a changelog entry
2019-04-10 09:58:00 -07:00
cd75b28b8f
No longer require a viewgroup to use FenixSnackbar
2019-04-10 09:58:00 -07:00
22eba72f8f
Closes #1170 : Allow user to add a new site exception to site permissions
2019-04-10 11:48:43 -05:00
043a3bbe9c
For #1068 - Adds the ability to quickly copy a URL
2019-04-09 17:13:30 -07:00
b54d4d1d58
Closes #1312 , #1236 , #1237 , #1238 , #1239 : Creating, Editing, and Deleting Bookmarks and Bookmark Folders
2019-04-08 14:48:36 -05:00
5b2417826e
Closes #1429 : Updated site permissions ui for MVP
2019-04-08 10:47:00 -05:00
e34d163034
Combines the Tab and Session component
2019-04-06 12:38:46 -05:00
5fc1e9227f
Closes #1195 : Adds telemetry for quick action sheet ( #1362 )
2019-04-05 15:08:55 -07:00
04f8a25bce
Closes #1377 : Fixed Doorhanger not shown when the toolbar padlock
...
is clicked.
2019-04-04 13:54:15 -05:00
4489edd97b
Closes #1165 : Added Doorhanger to the toolbar.
2019-04-03 21:51:13 -05:00
4b4d172e2e
Fixes #1024 - Adds metrics for browser menu items
2019-04-03 15:37:52 -07:00
c678b5d7c5
For #1036 - Maps facts to events
2019-04-03 12:17:20 -05:00
bd81e72239
Fixes #916 , fixes #917 , fixes #920 : Save, share, and delete bookmarks
2019-04-01 16:16:08 -05:00
061b6f3cd5
Closes #1167 : Added behavior for site permissions custom settings.
2019-03-29 23:28:10 -05:00
36af5107c6
Closes #875 : Adds search shortcuts ( #882 )
...
* Closes #875 : Adds shortcuts
* Refactor and clean up
* Remove TODO
* Removes local
* Fix nits
* Refactors to add ShortcutEngineManager
2019-03-29 13:49:50 -07:00
289785be90
Closes #1166 : Added behavior for site permissions recommended settings.
2019-03-29 10:19:23 -07:00
b5bd9357fc
For #986 - Adds support for opening Fenix with a link to telemetry
2019-03-22 17:14:35 -07:00
786592e8d0
For #959 - Adds telemetry for when the search bar is tapped
2019-03-22 17:14:35 -07:00
df40ec970e
Simplify ItsNotBrokenSnack() and make resilient
...
Co-authored by: Emily Kager <ekager@mozilla.com>
2019-03-22 15:00:38 -05:00
4963f7ccdb
Add Snackbar to link testers to Github issue for features
2019-03-22 15:00:38 -05:00
77e7c6d33c
A-C breaking change: FindInPageIntegration needs an engineView
2019-03-21 23:30:00 -05:00
f4648525f1
For #1072 : Removes screenshot button
2019-03-21 12:54:08 -05:00
0a449dc12c
For #1072 : Adds onAttachedToWindow
2019-03-21 12:54:08 -05:00
d2af87f8f8
For #1072 : Adds grabber handle bounce animation
2019-03-21 12:54:08 -05:00
4acd939289
For #1072 : Adds grabber handle
2019-03-21 12:54:08 -05:00
Christian Sadilek