For #1573 - Add Browsing Menu Item Add To Collections
parent
d6879e2501
commit
14c4d12e49
|
@ -477,6 +477,7 @@ class BrowserFragment : Fragment(), BackHandler, CoroutineScope,
|
|||
ToolbarMenu.Item.NewTab -> Item.NEW_TAB
|
||||
ToolbarMenu.Item.OpenInFenix -> Item.OPEN_IN_FENIX
|
||||
ToolbarMenu.Item.Share -> Item.SHARE
|
||||
ToolbarMenu.Item.SaveToCollection -> Item.SAVE_TO_COLLECTION
|
||||
}
|
||||
|
||||
requireComponents.analytics.metrics.track(Event.BrowserMenuItemTapped(item))
|
||||
|
@ -527,6 +528,10 @@ class BrowserFragment : Fragment(), BackHandler, CoroutineScope,
|
|||
Navigation.findNavController(view!!).navigate(directions)
|
||||
(activity as HomeActivity).browsingModeManager.mode = BrowsingModeManager.Mode.Normal
|
||||
}
|
||||
ToolbarMenu.Item.SaveToCollection -> {
|
||||
ItsNotBrokenSnack(requireContext())
|
||||
.showSnackbar("1843")
|
||||
}
|
||||
ToolbarMenu.Item.OpenInFenix -> {
|
||||
val intent = Intent(context, IntentReceiverActivity::class.java)
|
||||
intent.action = Intent.ACTION_VIEW
|
||||
|
|
|
@ -195,7 +195,8 @@ sealed class Event {
|
|||
data class BrowserMenuItemTapped(val item: Item) : Event() {
|
||||
enum class Item {
|
||||
SETTINGS, LIBRARY, HELP, DESKTOP_VIEW_ON, DESKTOP_VIEW_OFF, FIND_IN_PAGE, NEW_TAB,
|
||||
NEW_PRIVATE_TAB, SHARE, REPORT_SITE_ISSUE, BACK, FORWARD, RELOAD, STOP, OPEN_IN_FENIX
|
||||
NEW_PRIVATE_TAB, SHARE, REPORT_SITE_ISSUE, BACK, FORWARD, RELOAD, STOP, OPEN_IN_FENIX,
|
||||
SAVE_TO_COLLECTION
|
||||
}
|
||||
|
||||
override val extras: Map<String, String>?
|
||||
|
|
|
@ -164,6 +164,14 @@ class DefaultToolbarMenu(
|
|||
onItemTapped.invoke(ToolbarMenu.Item.ReportIssue)
|
||||
},
|
||||
|
||||
BrowserMenuImageText(
|
||||
context.getString(R.string.browser_menu_save_to_collection),
|
||||
R.drawable.ic_archive,
|
||||
DefaultThemeManager.resolveAttribute(R.attr.primaryText, context)
|
||||
) {
|
||||
onItemTapped.invoke(ToolbarMenu.Item.SaveToCollection)
|
||||
},
|
||||
|
||||
BrowserMenuDivider(),
|
||||
|
||||
menuToolbar
|
||||
|
|
|
@ -19,6 +19,7 @@ interface ToolbarMenu {
|
|||
object Stop : Item()
|
||||
object ReportIssue : Item()
|
||||
object OpenInFenix : Item()
|
||||
object SaveToCollection : Item()
|
||||
}
|
||||
|
||||
val menuBuilder: BrowserMenuBuilder
|
||||
|
|
|
@ -54,6 +54,8 @@
|
|||
<string name="browser_menu_private_tab">Private tab</string>
|
||||
<!-- Browser menu button that creates a new tab -->
|
||||
<string name="browser_menu_new_tab">New tab</string>
|
||||
<!-- Browser menu button that saves the current tab to a collection -->
|
||||
<string name="browser_menu_save_to_collection">Save to Collection</string>
|
||||
<!-- Browser menu button that opens a dialog to report issues with the current site -->
|
||||
<string name="browser_menu_report_issue">Report site issue</string>
|
||||
<!-- Browser menu button that open a share menu to share the current site -->
|
||||
|
|
Loading…
Reference in New Issue