blallo
/
fenix
1
0
Fork 0
Code Releases Activity

A-C breaking change: FindInPageIntegration needs an engineView

master
Grisha Kruglov 2019-03-21 11:26:02 -07:00 committed by Colin Lee
parent 8eb113fa32
commit 77e7c6d33c
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt
View File

@ -163,7 +163,9 @@ class BrowserFragment : Fragment(), BackHandler {
view = view)
findInPageIntegration.set(
feature = FindInPageIntegration(requireComponents.core.sessionManager, view.findInPageView),
feature = FindInPageIntegration(
requireComponents.core.sessionManager, view.findInPageView, view.engineView
),
owner = this,
view = view)

6
app/src/main/java/org/mozilla/fenix/components/FindInPageIntegration.kt
View File

@ -10,6 +10,7 @@ import android.view.View
import androidx.coordinatorlayout.widget.CoordinatorLayout
import mozilla.components.browser.session.SessionManager
import mozilla.components.browser.toolbar.BrowserToolbar
import mozilla.components.concept.engine.EngineView
import mozilla.components.feature.findinpage.FindInPageFeature
import mozilla.components.feature.findinpage.view.FindInPageBar
import mozilla.components.feature.findinpage.view.FindInPageView
@ -18,9 +19,10 @@ import mozilla.components.support.base.feature.LifecycleAwareFeature
class FindInPageIntegration(
private val sessionManager: SessionManager,
private val view: FindInPageView
private val view: FindInPageView,
engineView: EngineView
) : LifecycleAwareFeature, BackHandler {
private val feature = FindInPageFeature(sessionManager, view, ::onClose)
private val feature = FindInPageFeature(sessionManager, view, engineView, ::onClose)
override fun start() {
feature.start()