1
0
Fork 0
fenix/app/src/main/res
Severin Rudie aa8642f534
#4596 migrate collections (#5911)
* For #4596: move code from CollectionCreationComponent to CollectionCreationStore

Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreateStore to libstate

* For 4596: copied CollectionCreationUIView into CollectionCreationView

Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreationView to LibState

Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.

* For 4596: updated CollectionCreationTabListAdapter to work with the new View

* For 4596: updated SaveCollectionListAdapter to work with the new View

* For 4596: implemented CollectionCreationController

For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer

* For 4596: copied over previous reducer code

No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer

* For 4596: update reducer code param names

Otherwise, no changes at this time

* For 4596: add arguments to CreateCollectionFragment in nav_graph

These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.

* For 4596: pass arguments to collection via transaction instead of VM

The VM will be removed in a later commit

* For 4596: update BrowserToolbarController to share state to collection via its Direction

* For 4596: removed CreateCollectionViewModel

* For 4596: test tab retrieval in CreateCollectionFragment

* For 4596: fix crashing CreateCollectionFragmentTest

* For 4596: removed classes create collection classes used by old architecture

* For 4596: collection interactor rename + kdoc

* For 4596: moved collection interactor interface

* For 4596: renamed CreateCollectionFragment

All related classes followed the pattern of CollectionCreationX

* For 4596: kdoc CollectionCreationController

There's no effective difference between these calls and their interactor equivalent, so I linked to them

* For 4596: fix bug that caused rename to not work

* For 4596: removed unused collection actions

These were unused before the LibState refactor

* For 4596: kdoc StepChanged

* For 4596: removed todos about moving logic to the reducer

saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive

handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here

stepBack: called by handleBackPress. See above

* For 4596: wrote tests for CollectionCreationController#stepback

* For 4596: fixed tests broken by changes to collections

* For 4596: small readability refactor for CollectionController#stepBack

No change to functionality (see tests)

* For 4596: broke apart CollectionView#update

There's probably a lot more that could be done here, but smaller changes were made to reduce scope

* For 4596: remove unnecessary todos

It looks like we don't follow the suggested pattern in this project

* For 4596: test CollectionCreationController#normalSessionSize

* For 4596: updated naming in CollectionCreationController per review
2019-10-22 17:33:54 -07:00
..
anim For #1291: Reduces length of private mode animation (#2534) 2019-05-15 14:48:40 -07:00
animator Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
color For #5270 - Adds state list color for delete browsing checkboxes 2019-09-12 13:27:27 -07:00
drawable For #6100: Mirror ETP graphic in RTL 2019-10-18 15:24:49 +03:00
drawable-hdpi For #201: Search Widget 2019-08-02 11:26:48 -07:00
drawable-mdpi Minify drawable assets 2019-06-11 15:11:33 -07:00
drawable-night No issue: Remove duplicate wordmark and update about page (#3590) 2019-07-01 08:54:16 -07:00
drawable-v26 For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
drawable-xhdpi Replace notification icon (#3395) 2019-06-12 14:07:20 -05:00
drawable-xxhdpi Minify drawable assets 2019-06-11 15:11:33 -07:00
drawable-xxxhdpi Replace notification icon (#3395) 2019-06-12 14:07:20 -05:00
layout #4596 migrate collections (#5911) 2019-10-22 17:33:54 -07:00
menu Closes #2435 Change edit icon to share icon on the book… (#6137) 2019-10-22 14:34:05 -07:00
mipmap-anydpi-v26 For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
mipmap-hdpi For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
mipmap-mdpi For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
mipmap-xhdpi For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
mipmap-xxhdpi For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
mipmap-xxxhdpi For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
navigation #4596 migrate collections (#5911) 2019-10-22 17:33:54 -07:00
raw Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
raw-night Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
values Fixes #5323: Show a snackbar while browsing data is deleting. (#6105) 2019-10-21 09:57:06 -07:00
values-ca Import strings from android-l10n (#5300) 2019-09-13 12:15:08 -07:00
values-cs Import strings from android-l10n 2019-09-30 16:10:08 -07:00
values-de Import strings from android-l10n 2019-09-30 16:10:08 -07:00
values-es Import strings from android-l10n 2019-09-25 09:02:42 -07:00
values-es-rAR Import strings from android-l10n 2019-09-30 16:10:08 -07:00
values-es-rES Import l10n. 2019-10-08 21:38:24 -07:00
values-eu Import strings from android-l10n 2019-09-04 14:08:15 +02:00
values-fi Import l10n. 2019-10-19 17:40:27 +00:00
values-fr Import strings from android-l10n 2019-09-30 16:10:08 -07:00
values-hu Import l10n. 2019-10-08 21:38:24 -07:00
values-in Import l10n. 2019-10-08 21:38:24 -07:00
values-it Import strings from android-l10n 2019-09-30 16:10:08 -07:00
values-ja Import l10n. 2019-10-13 20:01:13 +00:00
values-ko Import l10n. 2019-10-08 21:38:24 -07:00
values-night For #5712: Updates text color for fill link from clipboard 2019-10-01 16:29:39 -07:00
values-nl Import strings from android-l10n 2019-09-30 16:10:08 -07:00
values-pa-rIN Import l10n. 2019-10-08 21:38:24 -07:00
values-pl Import strings from android-l10n 2019-09-30 16:10:08 -07:00
values-ru Import strings from android-l10n 2019-09-30 16:10:08 -07:00
values-sk Import l10n. 2019-10-13 20:01:13 +00:00
values-sv-rSE Import l10n. 2019-10-08 21:38:24 -07:00
values-ta Import strings from android-l10n 2019-08-23 14:36:01 +02:00
values-tr Import l10n. 2019-10-10 22:54:54 -07:00
values-v23 For #1876 - Correct Navigation Bar Color Logic (#2427) 2019-05-10 20:26:44 -05:00
values-v27 For #724: Corrects colors for all themes 2019-04-19 13:46:43 -07:00
values-v28 For #1399 - Only show battery saver theme preference for API <P 2019-04-04 23:34:54 -05:00
values-zh-rCN Import strings from android-l10n 2019-09-30 16:10:08 -07:00
values-zh-rTW Import l10n. 2019-10-08 21:38:24 -07:00
xml For #514 & #5742: Updates "launch links in private tab" functionality (#5721) 2019-10-03 12:43:33 -07:00