Mugurell
e1fc0cc038
Ensure logins deletion ( #12507 )
...
* For #11227 - Cleanup saved logins list when one is selected
Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.
To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.
* For #11227 - Refactor SavedLoginsView to be closer to MVI
- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
2020-07-16 14:40:08 -05:00
Tiger Oakes
2d066d77ad
Add tests for sync, wifi, and push ( #12581 )
2020-07-16 12:25:38 -07:00
Tiger Oakes
2291fb07aa
For #12565 : Add Locale settings tests & use activity ( #12579 )
2020-07-16 11:43:27 -07:00
jhugman
3373f8b987
For #12600 - remove AddonInstalled event when the permission dialog is shown ( #12601 ) r=csadilek,sblatz
2020-07-16 19:40:39 +01:00
Mihai Branescu
9373e7fcf4
For #12201 - forced callbacks to be on the main thread ( #12543 )
2020-07-16 13:39:31 -05:00
Elise Richards
4fe1fb8f4a
No issue: Delete unnecessary to-dos ( #12603 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 13:38:07 -05:00
Hakkı Kaan Çalışkan
b997fba953
No issue: Move dp's to dimens.xml
2020-07-16 13:08:55 -04:00
Kainalu Hagiwara
b867e0de45
Update TabTrayViewHolder with A-C thumbnail changes.
2020-07-16 12:50:33 -04:00
Roger Yang
7923255fda
For #12118 : Add isSubframeRequest parameter for app links
2020-07-16 12:50:33 -04:00
Christian Sadilek
a0d9cdc450
For #12248 : Webcompat reporter not active in Nightly
2020-07-16 12:24:21 -04:00
jhugman
fb1d7e12e6
For #11704 Add leanplum attributes for tracking protection ( #11965 ) r=sblatz
...
* For 11657: add LP attribute for tracking protection
* For #11704 : added tracking_protection_enabled attribute
* Added docs for the new attributes, linking to data-review to the mma.md
* Rename null to none when no ETP is enabled
2020-07-16 17:09:32 +01:00
Hakkı Kaan Çalışkan
cdd5d206fd
For #12105 : Follow ux mock on Settings --> Accessibility screen
2020-07-16 10:37:20 -04:00
James Hugman
798c1bf743
Address review comments
2020-07-16 10:37:03 -04:00
James Hugman
22689a9ff5
Remove need to specify component names for new intents
2020-07-16 10:37:03 -04:00
James Hugman
98a33ea82b
Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is
2020-07-16 10:37:03 -04:00
James Hugman
1629878a66
Add install_search_widget
2020-07-16 10:37:03 -04:00
James Hugman
8130aaa2cc
Add deep links for settings and home screens
2020-07-16 10:37:03 -04:00
Mugurell
d449184faa
For #12544 - Prevent search engines mixup
...
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
2020-07-16 16:49:54 +03:00
Tiger Oakes
6be39aebde
Add tests for StartupReportFullyDrawn ( #12560 )
2020-07-15 23:31:59 -07:00
Tiger Oakes
d4bb432e24
Add helper for underlining text ( #12520 )
2020-07-15 22:38:46 -07:00
Tiger Oakes
a0491b702e
Fix nav graph and theme tests ( #12567 )
2020-07-15 18:04:36 -07:00
Tiger Oakes
d0e9f1f165
Update Kotlin dependency ( #10806 )
2020-07-15 18:02:58 -07:00
mcarare
800702149b
For #12503 : Open addon permissions link in app.
2020-07-15 10:04:40 -04:00
ekager
9ed85510ae
For #7094 - Adds save login exceptions
2020-07-14 14:47:37 -04:00
Tiger Oakes
69020a1f26
For #12457 - Add MockK matcher for nav directions ( #12262 )
2020-07-14 10:39:23 -07:00
Tiger Oakes
1ff64cab67
Add tests for search ( #12437 )
2020-07-14 10:32:04 -07:00
Tiger Oakes
e9fb1a61c7
Test viewholders in home.sessioncontrol ( #12524 )
2020-07-14 10:31:50 -07:00
Hakkı Kaan Çalışkan
f424656575
For #12107 : Follow ux mock on Settings --> Account screen
2020-07-14 12:25:21 +03:00
Mozilla L10n Automation Bot
07e01c5b86
Import l10n.
2020-07-14 11:40:19 +03:00
ekager
88af736065
For #11099 For #12189 For #7532 - Clean up bottom navigation bar colors
2020-07-13 13:46:35 -04:00
Sawyer Blatz
98ad7ace49
For #10466 : Put call & email at top of context list
2020-07-13 10:33:55 -07:00
Hakkı Kaan Çalışkan
ca30fef579
For #12106 : Follow ux mock on Settings --> Logins screen
2020-07-13 11:14:32 -04:00
Mugurell
ea10d2a872
For #11875 - Prevent mixup of region / locale based search engines
...
We have two search engine types:
- one based on MLS reported region,
- one based only on Locale.
There are multiple steps involved in returning the default search engine for
example and though at each step we could verify if a certain operation is
completed we are still exposed to concurrency issues.
Simplest and most effective way to make sure the MLS engines do not mix with
Locale based engines is to use the same type of engines for the entire duration
of the app. At the next cold start we'll verify again which engines to use.
Using the Locale based engines (fallbacks) is expected to only happen once, at
the first run of the application after being installed.
2020-07-13 13:41:34 +03:00
Mozilla L10n Automation Bot
ca352c555b
Import l10n.
2020-07-13 07:59:10 +03:00
jhugman
9df13ae121
For #11655 : add leanplum event for installing an addon ( #12136 ) r=elise
...
* For #11655 : add leanplum event for installing an addon
* Add link to data-review request in PR
* Addressed CI comments
2020-07-12 23:47:34 +01:00
Grisha Kruglov
31248b835c
Synced Tabs: make sure to stop 'loading' when we encounter an error
2020-07-10 19:02:55 -07:00
ekager
0add94e353
For #11324 - Adds trash icon to swipe to delete
2020-07-10 20:16:57 -04:00
Nazım Can Altınova
7319f77114
Add profiler markers for HomeActivity.load and DefaultTabTrayController.onNewTabTapped
2020-07-10 16:43:06 -07:00
Sawyer Blatz
5d9fdd6266
Update app/src/main/java/org/mozilla/fenix/HomeActivity.kt
...
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-07-10 18:44:14 -04:00
Sawyer Blatz
bab0f9d95b
No issue: Update AC version
2020-07-10 18:44:14 -04:00
Mihai Eduard Badea
9aab1d1678
For issue #12339 - Collection delete dialog string update
...
Set the collection delete dialog title text to "Delete %1$s?"
2020-07-10 11:38:39 -04:00
Mozilla L10n Automation Bot
c3b06374a1
Import l10n.
2020-07-09 21:39:49 -04:00
Grisha Kruglov
806f6031ae
For #12433 - Allow synced tabs pull-to-refresh for non-critical account errors
2020-07-09 16:18:54 -07:00
ekager
ad265be672
For #11303 - Change copy login origin to open in browser
2020-07-09 18:09:41 -04:00
Tiger Oakes
c99a8f5cfa
Fixes #9832 - Change targetSdkVersion to Android 10 ( #11014 )
2020-07-09 10:50:51 -07:00
Emily Kager
63eb7b3e4e
For #12010 : Follow ux mock on Settings --> ETP --> Info screen ( #12429 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-09 09:47:09 -07:00
Sebastian Kaspari
a2a7b11425
Issue #12311 : BrowserToolbarController: Stop SessionFeature and release session from EngineView.
2020-07-09 12:36:56 -04:00
Mozilla L10n Automation Bot
cba27a3883
Import l10n.
2020-07-09 11:29:38 -04:00
David Walsh
85cebf8796
For 11889 - Fix snackbar for collection creation in browser fragment
2020-07-09 08:50:12 +03:00
mozilla-l10n-automation-bot
6f49e08725
Import l10n. ( #12404 )
2020-07-08 18:56:37 -07:00
Hakkı Kaan Çalışkan
d76d8d1881
For #11563 : Set ic_close.xml to use full width and height
2020-07-08 17:21:25 -04:00
ekager
38657bbfc6
For #11431 - Scroll to restored tab in tab tray
2020-07-08 17:18:16 -04:00
Christian Sadilek
216396d979
For #12353 : URL copied to clipboard should not be extension/reader URL
2020-07-08 16:55:32 -04:00
Tiger Oakes
9ae1aa6f16
Add tests for exceptions
2020-07-08 15:52:37 -04:00
MickeyMoz
236b981881
Update Android Components version to 50.0.20200708130551.
2020-07-08 12:44:51 -04:00
Tiger Oakes
67ce5ad5d9
Add tests for onboarding viewholders ( #11522 )
2020-07-08 07:53:22 -07:00
Tiger Oakes
720a590902
Add tests for browser helper classes ( #12370 )
2020-07-07 19:46:25 -07:00
Mozilla L10n Automation Bot
bedd1d452c
Import l10n.
2020-07-07 21:27:37 -04:00
Christian Sadilek
27c608d956
Update built-in extensions for new AC/GV API
...
New API (installBuiltIn/ensureBuiltin) requires
- Gecko IDs and new permissions
- Extension will only be re-installed if it has a new version
This includes a gradle task to automatically generate a
new version in manifest.json for every build so we don't
forget to update the version and end up with changes that
are never applied.
2020-07-07 18:41:12 -04:00
amkcpu
fab64229a5
Closes #11873 - Add scrollbar in tabs tray
2020-07-07 17:50:56 -04:00
ekager
bceb07a05b
For #12312 - Disable settings that navigate while authenticating
2020-07-07 16:46:14 -04:00
Michael Comella
3e617245b5
For #12345 : catch SecurityException when calling reportFullyDrawn.
...
That's amazing! I've got the same combination on my luggage.
2020-07-07 13:44:09 -07:00
Tiger Oakes
65637e9e2b
Use A-C version of Resources.getSpanned ( #12358 )
2020-07-07 13:36:29 -07:00
Mihai Eduard Badea
eeb8719fa1
For issue #12126 - Tab counter consumeFrom update
...
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
2020-07-07 11:12:55 -04:00
Mozilla L10n Automation Bot
f838049e97
Import l10n.
2020-07-07 11:12:02 -04:00
Tiger Oakes
8e8e5aea36
Extract radio group logic into helper ( #11493 )
2020-07-06 17:09:42 -07:00
ValentinTimisica
e39d5b6de7
For #11763 : Shows confirmation dialog when deleting last tab from collection
2020-07-06 17:06:10 -04:00
ValentinTimisica
c3acde438a
For #11889 : Changes collection creation confirmation snackbar strings
...
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
2020-07-06 17:02:02 -04:00
Tiger Oakes
1ab5fe3eb9
Add method to test fragments in roboletric ( #12261 )
2020-07-06 13:04:43 -07:00
Hakkı Kaan Çalışkan
426a1ba57d
For #12078 : Follow ux mock on Settings --> Language screen
2020-07-06 15:47:42 -04:00
mcarare
9bc4f443f5
For #9775 : Increase touch target of elements in add search engine screen
2020-07-06 15:47:25 -04:00
ekager
170ae1aa33
For #12263 - Adds end margin to synced tabs header
2020-07-06 15:37:53 -04:00
Hakkı Kaan Çalışkan
331090d1e6
For #12007 : Fix add search engine items using wrap content for height
2020-07-06 15:37:28 -04:00
Hakkı Kaan Çalışkan
296bdc5967
For #12016 : Follow ux mock on Settings --> Data Collection
2020-07-06 15:27:46 -04:00
Emily Kager
90f43bf350
For #12086 : Follow ux mock on Settings --> Customize screen ( #12324 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-06 12:25:54 -07:00
MickeyMoz
da39a7e671
Update Android Components version to 49.0.20200705130154.
2020-07-06 15:21:40 -04:00
mcarare
94273bc274
For #12125 : Handle visibility updates for add to collection button.
2020-07-06 14:37:39 -04:00
Mozilla L10n Automation Bot
2668a68678
Import l10n.
2020-07-06 14:06:24 -04:00
ekager
822d50192a
For #12316 - Allow text wrap on buttons
2020-07-06 20:56:54 +03:00
Tiger Oakes
fd18687ac9
Switch to any calls
2020-07-06 20:38:08 +03:00
Tiger Oakes
41452e945b
Move SearchProviderModel extension to class
2020-07-06 20:38:08 +03:00
Mugurell
0fb6bbc175
For #10401 - Hide Shortcuts if just one search engine is installed
...
Otherwise, the Shortcuts option which allows to choose with what search engines
to search would be redundant.
2020-07-06 14:36:04 +03:00
Sebastian Kaspari
388c144a62
SearchFragmentStore: Remove Session reference from state and read values from BrowserStore.
2020-07-03 21:01:59 +02:00
ekager
f863c341e8
Updates AC to 49.0.20200702190156 and fixes breaking changes
2020-07-03 06:40:06 -04:00
ekager
8533d96ee2
For #11320 - Expose login autofill setting to beta dimension
2020-07-03 06:40:06 -04:00
liuche
6ec0aeb843
Issue #12207 - Update "new nightly" link to point to org.mozilla.fenix ( #12209 )
2020-07-02 12:39:44 -07:00
Sawyer Blatz
8583cac8f8
Revert "For #11183 : Redirect user to homescreen after widget added"
...
This reverts commit a8ed913654
.
2020-07-02 11:22:18 -07:00
Sawyer Blatz
3cbab45566
For #12157 : Don't show two search widget dialogs
2020-07-02 11:22:18 -07:00
mozilla-l10n-automation-bot
321ba02832
Import l10n. ( #12175 )
2020-07-02 08:29:18 -07:00
liuche
ad8e28ae02
For #12007 : Follow ux mock on Settings --> Search screen ( #12177 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-02 00:48:31 -07:00
Tiger Oakes
ed3a80a756
For #12095 : Remove TWA feature flag ( #12096 )
2020-07-01 19:14:41 -07:00
Mihai Adrian Carare
daecbd348b
For #11996 : Open all links from add-on details in Fenix. ( #12080 )
...
* For #11996 : Open add-on homepage link in Fenix.
* For #11996 : Open add-on details links in Fenix.
2020-07-01 19:13:23 -07:00
Sawyer Blatz
306505fee0
No issue: Remove feature flag for tips ( #12172 )
2020-07-01 14:47:40 -07:00
Johan Lorenzo
4bc1cb94c5
Bug 1649400 - part 1: ship org.mozilla.fenix as a nightly product ( #12127 )
2020-07-01 11:03:10 +02:00
Mozilla L10n Automation Bot
d17e91cc2e
Import l10n.
2020-07-01 08:48:18 +03:00
Jeff Boek
fb4822498f
For #12081 - Properly installs searchengines when MLS completes
2020-06-30 13:35:08 -07:00
Mozilla L10n Automation Bot
7b3fe9bab4
Import l10n.
2020-06-30 10:25:21 +03:00
Tiger Oakes
50c3c9a9dd
Fix ignored XML lint issues ( #12094 )
2020-06-29 16:36:52 -07:00
ekager
70f90e71e8
For #11991 - Show tab count during onboarding
2020-06-29 17:59:19 -04:00
Tiger Oakes
6bde0378a2
Add tests for StrictModeManager ( #12013 )
2020-06-29 08:17:07 -07:00