1
0
Fork 0
Commit Graph

1957 Commits (dd5a1a5d0c849d39096a01ab221125c72a9ccc36)

Author SHA1 Message Date
Michael Droettboom 55e6e00355 Add glinter overrides 2019-10-08 21:40:20 -07:00
Mozilla L10n Automation Bot a9cfc83154 Import l10n. 2019-10-08 21:38:24 -07:00
Roger Yang e9760fb185 Closes #5847: Use IO thread when submitting crash report 2019-10-08 18:46:14 -07:00
Tiger Oakes 78bc829735 Closes #778 - Progressive Web Apps! (#4914) 2019-10-08 16:50:15 -07:00
Sawyer Blatz 0e435b8b7b For #5534: Temporarily disables find in page test 2019-10-08 16:17:38 -07:00
Tiger Oakes 5e2f0dcf26 Remove @ObsoleteCoroutinesApi from TestCore 2019-10-08 15:49:40 -07:00
Severin Rudie 411ccc8f1f For 4780: add DefaultBrowsingModeManager tests 2019-10-08 15:13:17 -07:00
Severin Rudie c9e68bda31 For 4780: remove Settings#usePrivateMode and tests 2019-10-08 15:13:17 -07:00
Severin Rudie dd6439269b For 4780: ThemeManager now sends an intent before recreating
Updating themes recreates the activity, so if we aren't persisting 'usePrivateMode', we need to pass it to the new instance
2019-10-08 15:13:17 -07:00
Severin Rudie 693034951c For 4780: rename 'setPrivateModeIfNecessary' 2019-10-08 15:13:17 -07:00
Severin Rudie d1d20b544e For 4780: update HomeActivity to maintain private mode in memory
As an added bonus, this makes the temporal coupling between `setPrivateModeIfNecessary` and `setupThemeAndBrowsingMode` explicit.  They previously would have broken if called in reverse order, now it will fail to compile.
2019-10-08 15:13:17 -07:00
Severin Rudie 10f334303d For #4780: remove previous fix for leaking private mode status
This didn't function when 'open links in a private tab' was set.  Rather than adding another sketchy fix for the edge case, following commits will change `usePrivateMode` to be maintained in memory, instead of in Settings.
2019-10-08 15:13:17 -07:00
Aaron Train e6d29df5de
No issue: fixes refreshTest (#5792) 2019-10-08 12:20:04 -04:00
Sawyer Blatz 4045fb0107 For #4190: Removes waterfall animation from awesomebar 2019-10-08 09:14:23 -07:00
Sawyer Blatz 6484a48147
For #5787: Fixes shortcuts asking to launch private alias (#5825) 2019-10-08 08:40:28 -07:00
mcarare 1c6aefd82b For #3604 Snackbar messages for closing tabs use closed instead of deleted 2019-10-08 17:06:02 +03:00
Mihai Adrian 18a130b38e For #5798: Fix info icon pixelation (#5841) 2019-10-08 09:30:32 -04:00
isabelrios 0e3148f0da fixing more reviewers comments 2019-10-08 09:56:29 +02:00
isabelrios 2fc6eaf5d4 fixing reviewers comments
improve writing email and password in file
2019-10-08 09:56:29 +02:00
isabelrios cdefb0d099 Fix TC error and run only ui tests 2019-10-08 09:56:29 +02:00
Isabel Rios 44f4cedefd Add fxa/sync integration tests
fixing Jenkins path to tests and clean tests

commenting future tests and adding doc with info about the tests
2019-10-08 09:56:29 +02:00
Grisha Kruglov ea3cd46133 Closes #1022: Auto-publication workflow for android-component
This patch enabled support for an auto-publication workflow for android-components.

It automates a common pattern seen in local development:

Old way:
- after every change in a-c, publish it locally with a unique version (bumping it manually)
- manually modify Fenix to consume a custom version of a-c from a mavenLocal repository

New way:
- set a flag in fenix's local.properties to enable auto-publication
- run Fenix builds after making changes to a-c. Changes in a-c will be automatically picked up.

Note that no changes are necessary to any Fenix files other than a single flag in local.properties.
Manually bumping android-components version is also not necessary.
2019-10-07 14:13:33 -07:00
Vipul Asri 31ae5709c2 Closes #5573: fix radio-button spacing in settings 2019-10-07 13:07:53 -07:00
Tiger Oakes d5c3433041 Use the new fragment constructor 2019-10-07 11:07:48 -07:00
sv-ohorvath bb7caa6365 Boomkarks UI tests
Added a comment to the clear all bookmarks method
2019-10-07 10:45:04 -07:00
Michael Droettboom 2b17052326 Update bug numbers to URLs 2019-10-07 10:44:11 -07:00
Denys M a4439ff373 For #3563. Use `ListAdapter` for App Share list. 2019-10-07 10:41:48 -07:00
Denys M e55eda30fb For #3563. Use `ListAdapter` for Bookmark folder selection list. 2019-10-07 10:40:55 -07:00
Madalin Valceleanu f4be12227f Fix the incognito icon looks out of place/misaligned 2019-10-07 10:15:11 -07:00
ekager f6285ad5f8 For #3846 - Pass in updated session icon to tabs 2019-10-07 09:38:43 -07:00
Tiger Oakes d028c97112 For #5213 - Use support library attributes 2019-10-06 16:17:00 -07:00
Prat T 80a1e6dd2c Fixes #5351 - listen to onIconChanged in HomeFragment 2019-10-06 10:41:34 -07:00
Prat T fe648a0b99 Fixes #5351 - use session icon in tab view on home 2019-10-06 10:41:34 -07:00
Emily Kager 2b19b28d25 For #5651 - Set up Standard vs Strict Tracking Protection Experiment 2019-10-05 10:14:09 -07:00
Sawyer Blatz 19a2d9df4f For #1620: Hide search results when they match URL 2019-10-04 14:05:55 -07:00
mcarare 22eb207cef For #5784: Fix hiding default browser preference in sdk<=23 2019-10-04 12:41:12 -07:00
Colin Lee b7647a454f
For #5599: Remove dependency on fetch_httpurlconnection (#5716)
* For #5599: Remove dependency on fetch_httpurlconnection

* For #5599: Switch Glean to GeckoViewFetchClient

* Use existing Gecko client for Glean
2019-10-04 12:28:23 -05:00
Emily Kager 40e6284aef For #5442 - Show Delete Browsing Data on Quit option in home menu 2019-10-04 09:26:59 -07:00
Sawyer Blatz 841b06b02f
No issue: fixes master (#5777) 2019-10-03 14:42:56 -07:00
Sawyer Blatz 371e2ac3d8
For #514 & #5742: Updates "launch links in private tab" functionality (#5721)
* For #514 & #5742: Updates "launch links in private tab" functionality

* Fixes comments
2019-10-03 12:43:33 -07:00
Madalin Valceleanu 4a0917ba32 Fix too much space under the address bar 2019-10-03 11:30:03 -07:00
Christian Sadilek b733e4fa8f Upgrade to Mozilla Android Components 16.0.0-SNAPSHOT 2019-10-03 11:07:26 -07:00
Severin Rudie 3be06953d6 For #4780 switch off private mode (#5614)
* Do not launch in Private Mode

When the app launches do not launch in Private Mode in order to prevent usage leaks to other users of the device.

* Issue #4780: add comments to use private mode

* For #4780: write tests for clear private mode on create app

* For #4780: clear private mode when privacy notification is removed
2019-10-03 10:23:13 -07:00
Sawyer Blatz e8216e3079
For #5094: Adds telemetry for suggestion toggles (#5704) 2019-10-03 10:03:14 -07:00
Sawyer Blatz 097d7c2038
For #5742: Adds strings (#5743) 2019-10-03 09:32:50 -07:00
Sawyer Blatz 785b8b9519
For #5567: Removes search shortcuts button (#5739)
* For #5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
Richard Pappalardo bc471ea59c
Fixes #5758 - Increase UI test wait time (#5759) 2019-10-03 07:54:10 -07:00
Sawyer Blatz 2896b36d14
No issue: Updates naming of launch links privately var (#5701)
The previous name was pretty confusing
2019-10-02 12:11:21 -07:00
Sawyer Blatz eb3c9f86e2
No issue: Removes feature flags for delete data (#5738) 2019-10-02 10:43:37 -07:00
Sawyer Blatz 2f0d8d8243 For #5712: Updates text color for fill link from clipboard 2019-10-01 16:29:39 -07:00
Emily Kager f7c9ab11eb For #3487 - Add back open image in new tab 2019-10-01 12:45:09 -07:00
Michael Droettboom a250241523 1585250: Initialize metrics off of the main thread 2019-10-01 10:29:54 -07:00
Sawyer Blatz 669e694af9 For #5672: Fixes broken send tab link 2019-09-30 16:13:40 -07:00
Axel Hecht 214ca421f7 Import strings from android-l10n
State: mozilla-l10n/android-l10n@10559d774c
2019-09-30 16:10:08 -07:00
Sawyer Blatz 69c42b6192 For #5681: Sets OPEN_TO_BROWSER false when using new tab shortcut 2019-09-30 14:56:16 -07:00
ekager 7dab810ee6 For #5534 - Make FIP Robot Wait for Text Changes 2019-09-30 13:17:29 -07:00
Emily Kager e9a0f1f65d For #2078 - Filter Out Self in Share Sheet (#5641) 2019-09-30 12:43:47 -07:00
Sawyer Blatz c8af16bd47
For #5679: Hides autoplay behind feature flag (#5685) 2019-09-30 12:01:04 -07:00
ekager ef29fe2584 Update BackgroundServicesTest, Suppress Complex Method 2019-09-30 10:33:56 -07:00
Grisha Kruglov a4097cd380 FxA WebChannels integration
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-30 10:33:56 -07:00
Chenxia Liu 8f97d247a6 For #235 - Add Glean crash count + docs. 2019-09-30 08:32:33 -07:00
Sawyer Blatz 3e42114190 For #5656: Fixes nightly major version number crash 2019-09-27 15:06:57 -07:00
Sawyer Blatz a38b73f19e Fixes #5653: Removes crash with null campaign 2019-09-27 15:01:00 -07:00
mcarare 64923978e6 For #1071 Added Desktop Mode icon 2019-09-27 09:47:10 -07:00
Sawyer Blatz 5e18ead45e For #4474: Adds tests and fixes issues 2019-09-27 08:59:05 -07:00
Tiger Oakes ee1f040e53 No issue: Move signedIn tracking to BookmarksSharedViewModel (#4755) 2019-09-27 08:57:38 -07:00
Sawyer Blatz 7f328a6dc4
For #1298: Adds adjustCampaignId to core ping (#5579) 2019-09-27 08:56:33 -07:00
Sawyer Blatz 6babf72352
For #5197: Adds telemetry for media notification (#5520) 2019-09-27 08:02:29 -07:00
Tiger Oakes 88aa519210 Closes #4711 - Extract VoiceSearchActivity (#5502) 2019-09-27 07:54:29 -07:00
Emily Kager 3f41a4e9c6 No issue: Update navigation library 2019-09-26 17:01:13 -07:00
Sawyer Blatz 11baabb63a No issue: Updates fact mapping to use enums 2019-09-26 17:00:51 -07:00
Emily Kager c3287b17ac Closes #5624 - Fix crash on preference change listener 2019-09-26 16:56:54 -07:00
Mihai Adrian 62ae025d65 For #4991:Ensured deleteSelectedBookmarks deletes all selected bookmarks (#5559)
Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
2019-09-26 16:52:59 -07:00
Severin Rudie dffa61bf16 Closes #4513: fixes bookmark tests broken by loading change
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
2019-09-26 16:29:14 -07:00
Severin Rudie fd7f1b2665 Closes #4513: adds tests for bookmark loading state 2019-09-26 16:29:14 -07:00
Severin Rudie fbdd537bc7 Closes #4513: show progress bar when loading bookmarks 2019-09-26 16:29:14 -07:00
Severin Rudie ca6c324f29 Issue #4513: added isLoading to bookmark state
This was added to the state object as a top level param because it could reasonably coexist with any value of `tree` or `mode`. Even if we don't now, we may someday want to display a loading indicator while also showing cached bookmarks.

For now, we set isLoading to false whenever we receive any bookmarks
2019-09-26 16:29:14 -07:00
Severin Rudie 5e8798e89c Issue #4513: add ProgressBar to bookmark component layout 2019-09-26 16:29:14 -07:00
Severin Rudie 96472a533a Issue #4513: fix mismatched bookmark listener lifecycles
The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed.

We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!
2019-09-26 16:29:14 -07:00
Colin Lee de93b05cac For #2754 Add tab cards to share sheet (#5493)
* For #2754 Add tab cards to share sheet

* For #2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
2019-09-26 14:25:34 -07:00
Christian Sadilek ac2611d744 Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) (#5578)
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT

* Update findinpage integration to use browser-state

* Use new UseCases APIs after download migration.
2019-09-26 12:50:50 -07:00
Mugurell c5330c6880 For 5092 - Show a Snackbar with retry option if sharing to devices fails (#5158)
* For #5092 - Show a Snackbar with retry option if sharing to devices fails

ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.

* For #5092 - Refactor ShareControllerTest

* For #5092: Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
Yeon Taek Jeong 59e2c124cb No issue: Update long-press shortcut strings (#5284)
* No issue: Update long-press shortcut strings

* Updates identifiers
2019-09-26 11:57:37 -07:00
ekager 0b01635ce0 For #2874, #5375, #5131 - submitList workaround for Android 5 + 6 2019-09-25 19:59:07 -07:00
Agi Sferro 365936b8df For #5529: Enable about:config in geckoNightly. 2019-09-25 16:17:09 -07:00
ekager 44bb592b43 For #5312 - Send ETP Strict/Standard event 2019-09-25 15:23:30 -07:00
ekager 24b3ed4384 For #5568 - Don't pass in Session for QuickActionSheetController 2019-09-25 13:33:38 -07:00
Emily Kager b0b60aa27d For #5281 - Use TrackerLog for reporting ETP categories (#5556) 2019-09-25 10:48:06 -07:00
Sawyer Blatz b6e6e36ccd For #561: Fix stutter of search icon & text when animating 2019-09-25 10:06:38 -07:00
Sawyer Blatz 75a25c9bd0 For #561: Fix linting issue 2019-09-25 10:06:38 -07:00
Jeff Boek c592a69aad For #561 - Fixes snackbar placement on homeview 2019-09-25 10:06:38 -07:00
Jeff Boek 32c506121e For #561 - Fixes visual inconsistencies with the search bar 2019-09-25 10:06:38 -07:00
Jeff Boek 5c092c1ef1 For #561 - Adds shadow/highlightto the bottom bar 2019-09-25 10:06:38 -07:00
Jeff Boek 00d1be97ac For #561 - Wires up add tab button inside the bottom bar 2019-09-25 10:06:38 -07:00
Jeff Boek b16754d78a For #561 - Adds add tab and menu button to bottom bar
- Adds space between wordmark and session control component
2019-09-25 10:06:38 -07:00
Jeff Boek abbb310ce3 For #561 - Removes the toolbar from the home screen
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
2019-09-25 10:06:38 -07:00
Axel Hecht 2829235651 Import strings from android-l10n
State: mozilla-l10n/android-l10n@97355ffcdc
2019-09-25 09:02:42 -07:00
mcarare bfe8bf4663 For #1383 Added tab title to close button content description 2019-09-25 10:34:02 +03:00
Jeff Boek 1c9c5317eb For #5552 - Temporary fix for startup crash on es locales 2019-09-24 19:21:47 -07:00
Sawyer Blatz 856399e9e2
No issue: Fixes GleanMetricsService nits & broken UI test (#5539)
* No issue: Fixes GleanMetricsService nits

* No issue: fixes broken UI test
2019-09-24 16:12:09 -07:00