No issue: fixes master (#5777)

app/src/main/java/org/mozilla/fenix/FenixApplication.kt

@@ -136,7 +136,7 @@ open class FenixApplication : Application() {
      * private mode was in use during the previous session.
      */
     fun maybeClearPrivateMode(settings: Settings = settings()) {
-        if (!settings.alwaysOpenInPrivateMode) settings.usePrivateMode = false
+        if (!settings.openLinksInAPrivateTab) settings.usePrivateMode = false
     }
 
     private fun registerRxExceptionHandling() {

app/src/main/java/org/mozilla/fenix/IntentReceiverActivity.kt

@@ -50,7 +50,7 @@ class IntentReceiverActivity : Activity() {
         if (didLaunchPrivateLink && Browsers.all(this).isDefaultBrowser) {
             this.settings().openLinksInAPrivateTab = true
         } else if (!Browsers.all(this).isDefaultBrowser) {
-            /* If the user has unset us as the default browser, unset alwaysOpenInPrivateMode */
+            /* If the user has unset us as the default browser, unset openLinksInAPrivateTab */
             this.settings().openLinksInAPrivateTab = false
         }
 

app/src/test/java/org/mozilla/fenix/FenixApplicationTest.kt

@@ -30,8 +30,8 @@ class FenixApplicationTest {
     }
 
     @Test
-    fun `GIVEN alwaysOpenInPrivateMode is active WHEN maybeClearPrivateMode is called THEN private mode should not be changed`() {
-        every { settings.alwaysOpenInPrivateMode } returns true
+    fun `GIVEN openLinksInAPrivateTab is active WHEN maybeClearPrivateMode is called THEN private mode should not be changed`() {
+        every { settings.openLinksInAPrivateTab } returns true
 
         application.maybeClearPrivateMode(settings)
 
@@ -39,8 +39,8 @@ class FenixApplicationTest {
     }
 
     @Test
-    fun `GIVEN alwaysOpenInPrivateMode is inactive WHEN maybeClearPrivateMode is called THEN private mode should be disabled`() {
-        every { settings.alwaysOpenInPrivateMode } returns false
+    fun `GIVEN openLinksInAPrivateTab is inactive WHEN maybeClearPrivateMode is called THEN private mode should be disabled`() {
+        every { settings.openLinksInAPrivateTab } returns false
 
         application.maybeClearPrivateMode(settings)