1
0
Fork 0
Commit Graph

213 Commits (d0e9f1f1654d60d2b056f488d6ac84dc39b268c5)

Author SHA1 Message Date
ekager f6285ad5f8 For #3846 - Pass in updated session icon to tabs 2019-10-07 09:38:43 -07:00
Prat T fe648a0b99 Fixes #5351 - use session icon in tab view on home 2019-10-06 10:41:34 -07:00
ekager 0b01635ce0 For #2874, #5375, #5131 - submitList workaround for Android 5 + 6 2019-09-25 19:59:07 -07:00
Jeff Boek 00d1be97ac For #561 - Wires up add tab button inside the bottom bar 2019-09-25 10:06:38 -07:00
Jeff Boek b16754d78a For #561 - Adds add tab and menu button to bottom bar
- Adds space between wordmark and session control component
2019-09-25 10:06:38 -07:00
mcarare bfe8bf4663 For #1383 Added tab title to close button content description 2019-09-25 10:34:02 +03:00
Mihai Adrian c7c752cabb For #5356 Improves private browsing "common myths" link accessibility (#5479)
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
2019-09-24 10:46:34 -07:00
Tiger Oakes 8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Tiger Oakes cb7701584f No issue: Extract home fragment mode (#5343) 2019-09-23 09:33:55 -07:00
Sawyer Blatz 4a6e647167
For #5197: Adds telemetry for media controls (#5266) 2019-09-20 14:49:27 -07:00
Mihai Adrian a1c8fc0698 For #3731 Improved UX for opening tabs from a Collection (#5427)
* For #3731 Changed order of items for a collection's overflow menu

* For #3731 Changed the order tabs open to keep same order from collections
2019-09-20 06:41:04 -07:00
Sawyer Blatz 999d3cb963 For #1114: Show playing tab 2019-09-11 15:45:22 -07:00
Tiger Oakes b77c4d2e2e Clean up SupportUtils 2019-09-10 10:16:04 -07:00
Mihai Adrian a31eb1f371 Code Health #4883: Refactored accessing settings by using Context extensions (#4973) 2019-09-10 10:11:58 -07:00
Mihai Adrian ed0b6bd5ef For #4193 - Makes close button for tabs more accessible (#4442)
* fixes #4193 - made close button for tabs more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible

* Fix margins
2019-09-06 10:33:55 -07:00
Sebastian Kaspari 3a35233ac0 Remove ThumbnailsFeature. (#5127)
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
Yeon Taek Jeong d87b8a8a5c
For #4658: Add some private browsing mode telemetry (#4968) 2019-08-28 14:41:37 -07:00
Tiger Oakes c475bc87cf Move classes out of top-level package 2019-08-21 13:52:30 -07:00
Yeon Taek Jeong 6f899c7fb5
For #2834: Delete all Private Tabs redesign (#4787) 2019-08-20 13:10:08 -07:00
Tiger Oakes 33f3b14c29 Adds setters and property delegates in `Settings` (#4809)
* Change Settings to use setters

* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
Emily Kager f71106cb51 Closes #3860 - Update description text for collections 2019-08-14 17:13:52 -04:00
Tiger Oakes 52542708aa Consodilate private browsing code 2019-08-09 11:00:41 -07:00
Sawyer Blatz 969d17b4a9
For #969: Adds more telemetry for collections (#4539) 2019-08-07 16:05:20 -07:00
ekager 015922ddd2 No issue: Fix Crash lower API by setting gradient drawables in onBind 2019-08-02 16:18:34 -07:00
ValentinTimisica da59e36c1b Fixes #4410: Modified visibility of 'Add Tab' button.
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
2019-08-02 08:49:50 -07:00
Grisha Kruglov ae33234bbc Closes #2593: FxA automatic sign-in integration 2019-08-01 17:03:45 -07:00
Sawyer Blatz 2e7a61860a For #969: Adds more telemetry for collections (#4358) 2019-07-31 17:07:41 -07:00
Tiger Oakes 88c05a5f43 Use glide-like image loading function 2019-07-29 10:22:23 -07:00
Tiger Oakes c2e6e25bef Fixes #4005 - Move getColorFromAttr to Context 2019-07-26 16:44:11 -04:00
Mihai Adrian c74cb61455 fixes #4176 (#4175)
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
2019-07-19 14:23:10 -05:00
Tiger Oakes 6da6ddb095 Use StateListDrawable & resources w/ TabCollection 2019-07-18 15:29:06 -04:00
Emily Kager 451093fd9e Closes #2560 - Updates Private Browsing explanation string 2019-07-18 15:27:59 -04:00
Tiger Oakes 5de1678e65 No issue: Use putCompoundDrawables helper (#3982) 2019-07-15 08:24:59 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Emily Kager c81dd0a4a8 For #3772 - Update FXA sign in UI (#3933) 2019-07-10 21:20:06 -05:00
Tiger Oakes 9901514766 Replace deprecated pxToDp (#3932) 2019-07-08 14:45:07 -05:00
Emily Kager 7a51ee3915 For #3734 - Don't SwipeToDelete RecyclerView without windowfocus (#3839) 2019-07-02 14:42:50 -07:00
Emily Kager 99209aa9da Closes #3268 - Change Tab Favicon Border Radius to 4 (#3856) 2019-07-02 14:42:20 -07:00
Tiger Oakes 8cd1a0cb38 Move adapter Job setup code to helper class (#3407) 2019-07-01 13:34:25 -05:00
Emily Kager 2d6ebb986d Revert "For #3135 - Reduce swipe to delete sensitivity"
This reverts commit 94881f8241.
2019-06-28 12:47:36 -07:00
Tiger Oakes e8bd090a8e No issue: Use ImageView rather than rebuilding drawable (#3616)
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
Tiger Oakes 4994554576 No issue: Adds lint exception for when statement (#3685) 2019-06-26 15:52:24 -07:00
Tiger Oakes 30930cdc88 Import variables referred to by path 2019-06-25 13:57:34 -07:00
Emily Kager 03a5cb2fb4 For #3620 - Adds automatic theme onboarding content description (#3629) 2019-06-24 13:15:38 -07:00
Tiger Oakes ab6101b0f4 Fixes #3539 - vectordrawablecompat for gradients (#3541) 2019-06-18 16:38:56 -07:00
Sawyer Blatz decacbfc97 For #3323 Runs PublicSuffixList synchronously 2019-06-11 09:19:51 -07:00
Arturo Mejia 5df726715f Revert "For #3008, For #2162 Add Simple Logic for Menu Orientation" (#3310)
#3114
2019-06-10 10:58:18 -05:00
Sawyer Blatz 054635735a
For #2750: Removes unecessary invalidate CollectionViewHolder call (#3264) 2019-06-07 13:38:18 -07:00
Sawyer Blatz 45c509fbce
For #2648: Updates trimming of url hostname (#3191)
* For #2648: Updates trimming of url hostname

* For #2648: Fix nits
2019-06-07 09:33:07 -07:00
Emily Kager acea0d5668 For #2785 - Adds back item animator session control (#3233) 2019-06-06 16:54:49 -05:00
Emily Kager 704f1e6a3d For #3004 - Restore MotionLayout on Home View only in onCreateView 2019-06-05 14:46:38 -07:00
Emily Kager 94881f8241 For #3135 - Reduce swipe to delete sensitivity 2019-06-04 16:10:28 -07:00
Emily Kager dc0d153580 For #3008, For #2162 Add Simple Logic for Menu Orientation (#3114)
* For #3008 - Adjust orientation of collections menu based on view location

* For #2162 - Add simple menu orientation logic to bookmark menu
2019-06-04 10:37:57 -05:00
Jeff Boek 14f1d40e10 Fixes #3041 - Fixes the string that gets displayed in the FxA Onboarding card 2019-05-31 10:44:14 -07:00
Jeff Boek a7d5cdcb9d For #2723 - Fixes theme manager 2019-05-30 16:38:31 -07:00
Jeff Boek e3031378bc For #225 - Address small nits, changes default color of ic_delete 2019-05-24 17:16:03 -07:00
Emily Kager 01c9317be0 For #2843 - Improve Collections UI and UX (#2851) 2019-05-24 17:06:17 -07:00
Tiger Oakes 207a8d6772 Use a ListAdapter for SessionControl 2019-05-24 13:13:52 -07:00
Emily Kager 09588dfda6 For #2529 - Remove "Delete Collection" button from private browsing 2019-05-24 10:53:15 -07:00
Emily Kager 0c8ad3ef6e For #2721 - Reorder onboarding theme settings (#2817) 2019-05-23 23:34:11 -07:00
Emily Kager 40f2fe5166 For #1287 - Create animation for opening and closing tab from home 2019-05-23 13:41:00 -07:00
Jeff Boek bf28462c47 For #2717 - Hides onboarding card when signed into a firefox account 2019-05-23 10:26:55 -07:00
Jeff Boek ab590df18b For #2717 - Adds auto signed in state to the accounts onboarding card 2019-05-23 10:26:55 -07:00
Grisha Kruglov f4f35bdde0 Closes #2713: Weave in "onboarding state" and split adapter items accordingly
we're ensuring that it has been initialized.

I wonder if we could just make background services load eagerly (they're lazy init now), instead.
2019-05-23 10:26:55 -07:00
Sawyer Blatz 220a843534 For #2205: Updates collection title constraints 2019-05-23 08:33:42 -07:00
Sawyer Blatz f73bb22955 No issue: Removes usage of COLLECTIONS_ENABLED flag 2019-05-21 10:34:30 -07:00
Sawyer Blatz 0080e7d701 For #2584: Adds opening a single tab from tab collection 2019-05-21 09:42:40 -07:00
Sawyer Blatz afbe397f94 For #1575: Enables adding tabs to existing collection 2019-05-21 09:39:55 -07:00
Jeff Boek 1cd50ba9cb No Issue - Fixes nits in #2669 2019-05-20 23:32:58 -07:00
Jeff Boek 692724be2f For #2395 - Navigates to turn on sync on button press 2019-05-20 23:32:58 -07:00
Jeff Boek 9a76c11dae For #2389 - Save state on homeview when switching themes 2019-05-20 23:32:58 -07:00
Jeff Boek b3650cacff For #2399 - Wires up tracking protection onboarding card 2019-05-20 23:32:58 -07:00
Jeff Boek a2a4524e51 For #982 - Opens privacy policy in a custom tab 2019-05-20 23:32:58 -07:00
Jeff Boek 591f367806 For #2392 - Adds icon to private browsing onboarding card 2019-05-20 23:32:58 -07:00
Jeff Boek 2dc76dda6a For #2392 - Centers private browsing icon 2019-05-20 23:32:58 -07:00
Sebastian Kaspari 291df48c4e Install the "icons" WebExtension to automatically load icons for every visited website. 2019-05-20 19:34:49 -07:00
Sawyer Blatz ec1a0e6c34 Revert #2533: Removes feature flag for tab collections 2019-05-20 15:22:45 -07:00
Sawyer Blatz 3619f1417d For #1574: Cleans up unused code and refactors 2019-05-20 14:31:17 -07:00
Sawyer Blatz 7861a80715 For #2205: Truncates tab collection titles 2019-05-20 14:31:17 -07:00
Sawyer Blatz 4e6f9b9ef1 For #1574: Displays previous tab collections when creating 2019-05-20 14:31:17 -07:00
Emily Kager d347f73e69 For #2389 - Create Theme Onboarding Card 2019-05-20 11:10:20 -07:00
Sawyer Blatz 72d29c2a43
For #2205 & #1578: Integrates tab collection storage (#2478)
* For #2205: Adds TabCollectionStorage

* For #1578: Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
Jeff Boek 95af2ddcc6 For #2390 - Adds the start browser button 2019-05-15 23:18:37 -07:00
Jeff Boek b2e6b59e91 For #2390 - Adds views for every onboarding card 2019-05-15 23:18:37 -07:00
Jeff Boek 8928b19079 For #2390 - Adds a theme picker card
- applies generic styling to cards
- adds margins to headers and onboarding cards
2019-05-15 23:18:37 -07:00
Jeff Boek fe16810ddb For #2390 - Adds onboarding section headers 2019-05-15 23:18:37 -07:00
Jeff Boek dfe14e1751 For #2390 - Adds the onboarding welcome message 2019-05-15 23:18:37 -07:00
Jeff Boek b14d0fa80c For #2390 - Applies onboarding mode on start 2019-05-15 23:18:37 -07:00
Jeff Boek b3a3c94169
Small refactor before we add onboarding cards (#2541)
* For #2390 - Cleans up the toAdapterList method before we add onboarding

* For #2514 - Hide tabs menu when no tabs are open
2019-05-15 17:06:49 -07:00
Jeff Boek 014de10b29 Fixes #2533 - Adds the feature flag to the menu item to create a collection 2019-05-15 13:32:37 -07:00
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Colin Lee 49ac62ab85 Fix ViewModel States (#2457)
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2019-05-14 13:49:02 -07:00
Colin Lee cfccb997fd For #1909: Tabs disappear intermittently (#2426) 2019-05-10 15:20:45 -07:00
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 2019-05-09 23:06:12 +00:00
Sawyer Blatz d64f5a2064
For #2205: Modifies styling of collections and tabs (#2328)
* For #2205: Modifies styling of collections and tabs

* Change bounding box
2019-05-08 11:12:41 -07:00
Sawyer Blatz 7d577e5953
For #2205: Adds collections view to home fragment (#2249)
* For #1574: Adds collections to home view

* Adds colored icons and expansion

* Adds state change

* Adds more styling

* Adds ItsNotBrokenSnacks

* Adds chevron

* Improves styling of swipe to delete and adds delete action

* Fix nits

* Try to add real saving
2019-05-06 11:20:19 -07:00
Emily Kager 0e44921e08 For #1573 - Update tabs header menu (#2141) 2019-04-29 17:03:40 -05:00
Emily Kager 1041500869 For #1573 - Long pressing tab selects that tab in save collections 2019-04-29 12:57:34 -07:00
Harsh Shandilya d0fb11a946 TabViewHolder: Remove unused parameter
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
Harsh Shandilya 753487b277 TabViewHolder: Remove useless lateinit
Fixes build-time warning: fenix/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabViewHolder.kt: (45, 13): Lateinit is unnecessary: definitely initialized in constructors

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
Jeff Boek ba690fde8e
Fixes tab sizing (#1906) 2019-04-22 14:50:22 -07:00
Jeff Boek f19a773ab9
Merge pull request #1842 from boek/i1840-collections_featureflag
For #1840 - Adds a save tab group button and puts it behind a feature  flag
2019-04-20 14:15:18 -07:00
Jeff Boek 4ea54252b0 For #1830 - Adds the ability to share a tab 2019-04-19 15:31:12 -07:00
Jeff Boek 774c5c0e0c For #1830 - Updates the tab visual style 2019-04-19 15:31:12 -07:00
Jeff Boek 146492bd59 Fixes #1828 - Adds an empty tab state 2019-04-19 14:06:31 -07:00
ekager d1c2ed2052 Closes #1803: remove text for swipe delete 2019-04-19 13:32:32 -05:00
Jeff Boek 5ca9040702 For #1696 - Removes sessions from session control 2019-04-17 22:41:59 -07:00
Sawyer Blatz 29832c5e84 For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
Emily Kager 2a19917619 For #538 - Reverse tabs in list 2019-04-12 10:05:52 -05:00
Emily Kager 659386bd5e For #176 - Start swipe to close gesture 2019-04-12 10:04:48 -05:00
Jeff Boek 8f6dca99dc For #1456 - Fixes missing delete button 2019-04-08 10:24:47 -07:00
Jeff Boek d346613733 Adds missing licenses 2019-04-06 12:38:46 -05:00
Jeff Boek e34d163034 Combines the Tab and Session component 2019-04-06 12:38:46 -05:00