blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #2584: Adds opening a single tab from tab collection

master
Sawyer Blatz 2019-05-20 11:31:25 -07:00 committed by Jeff Boek
parent a3f25b9f77
commit 0080e7d701
3 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
View File

@ -363,6 +363,13 @@ class HomeFragment : Fragment(), CoroutineScope {
is CollectionAction.Rename -> {
ItsNotBrokenSnack(context!!).showSnackbar(issueNumber = "1575")
}
is CollectionAction.OpenTab -> {
invokePendingDeleteSessionJob()
(activity as HomeActivity).openToBrowserAndLoad(
searchTermOrURL = action.tab.url,
newTab = true,
from = BrowserDirection.FromHome)
}
is CollectionAction.OpenTabs -> {
invokePendingDeleteSessionJob()
action.collection.tabs.forEach {

1
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlComponent.kt
View File

@ -96,6 +96,7 @@ sealed class CollectionAction : Action {
data class Delete(val collection: TabCollection) : CollectionAction()
data class AddTab(val collection: TabCollection) : CollectionAction()
data class Rename(val collection: TabCollection) : CollectionAction()
data class OpenTab(val tab: ComponentTab) : CollectionAction()
data class OpenTabs(val collection: TabCollection) : CollectionAction()
data class ShareTabs(val collection: TabCollection) : CollectionAction()
data class RemoveTab(val collection: TabCollection, val tab: ComponentTab) : CollectionAction()

4
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabInCollectionViewHolder.kt
View File

@ -61,6 +61,10 @@ class TabInCollectionViewHolder(
}
}
view.setOnClickListener {
actionEmitter.onNext(CollectionAction.OpenTab(tab))
}
collection_tab_close_button.increaseTapArea(buttonIncreaseDps)
collection_tab_close_button.setOnClickListener {
actionEmitter.onNext(CollectionAction.RemoveTab(collection, tab))