blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #3731 Improved UX for opening tabs from a Collection (#5427) 

* For #3731 Changed order of items for a collection's overflow menu

* For #3731 Changed the order tabs open to keep same order from collections
master
Mihai Adrian 2019-09-20 16:41:04 +03:00 committed by Sawyer Blatz
parent 05a4faec78
commit a1c8fc0698
2 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
View File

@ -532,7 +532,7 @@ class HomeFragment : Fragment(), AccountObserver {
val context = requireContext()
val components = context.components
action.collection.tabs.forEach {
action.collection.tabs.reversed().forEach {
val session = it.restore(
context = context,
engine = components.core.engine,

23
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CollectionViewHolder.kt
View File

@ -132,25 +132,28 @@ class CollectionItemMenu(
private val menuItems by lazy {
listOf(
SimpleBrowserMenuItem(
context.getString(R.string.collection_delete),
textColorResource = ThemeManager.resolveAttribute(R.attr.destructive, context)
context.getString(R.string.collection_open_tabs)
) {
onItemTapped.invoke(Item.DeleteCollection)
onItemTapped.invoke(Item.OpenTabs)
},
SimpleBrowserMenuItem(
context.getString(R.string.add_tab)
) {
onItemTapped.invoke(Item.AddTab)
}.apply { visible = { sessionHasOpenTabs } },
SimpleBrowserMenuItem(
context.getString(R.string.collection_rename)
) {
onItemTapped.invoke(Item.RenameCollection)
},
SimpleBrowserMenuItem(
context.getString(R.string.collection_open_tabs)
context.getString(R.string.add_tab)
) {
onItemTapped.invoke(Item.OpenTabs)
onItemTapped.invoke(Item.AddTab)
}.apply { visible = { sessionHasOpenTabs } },
SimpleBrowserMenuItem(
context.getString(R.string.collection_delete),
textColorResource = ThemeManager.resolveAttribute(R.attr.destructive, context)
) {
onItemTapped.invoke(Item.DeleteCollection)
}
)
}