769c1e422d
For #5694 & #6054 : Allows users to change toolbar position ( #6608 )
...
* For #5694 & #6054 : Adds preference screen for toolbar
* For #5694 : Adds changing toolbar position functionality
* No issue: Updates telemetry links to actually work lol 😬
* For #6054 : Adds toolbar position to core ping
2019-11-25 16:43:32 -08:00
422faaf7c0
Add toolbar helpers ( #6531 )
2019-11-25 15:36:47 -05:00
1d36098878
For #1019 Add onboarding search suggestion hint panel
2019-11-21 14:36:14 -08:00
5543f3272d
For #1019 Add option to enable search suggestions in private mode
2019-11-21 14:36:14 -08:00
ef3c3de8a1
For #6625 Fix back navigation in search mode from browser
2019-11-21 14:35:12 -08:00
81ab082c1c
For #6707 #6708 - Fix UI Tests for new Search Engine Behavior
2019-11-20 10:23:48 -08:00
607c3d4c87
Adds custom search engines ( #6551 )
...
* For #5577 - Adds button to add a new search engine
* For #5577 - Adds custom engine store
* For #5577 - Creates a custom SearchEngineProvider
* For #5577 - Gives the ability to delete search engines
* For #5577 - Adds the UI to add a custom search engine
* For #5577 - Adds form to create a custom search engine
* For #5577 - Adds the ability to add a custom search engine
* For #5577 - Adds the ability to delete custom search engines
* For #5577 - Selects the first element on the add custom search engine screen
* For #5577 - Prevents adding a search engine that already exists
* For #5577 - Styles the add search engine preference
* For #5577 - Makes the name check case-insensitive
* For #5577 - Fix bug where home screen doesnt see new search engines
* For #5577 - Moves Search URL validation to its own type
* For #5577 - Fixes linting errors
* For #5577 - Adds the ability to edit a custom search engine
* For #5577 - Allows the user to edit a serach engine even when it is the last item in the list
* For #5577 - Adds an undo snackbar when deleting a search engine
* For #5577 - Moves all of the strings to be translated
* For #5577 - Fixes bug when deleting your default search engine
* For #5577 - Puts adding search engines behind a feature flag
* For #5577 - Navigate to custom search engine SUMO article when tapping learn more
* For #5577 - Fixes nits
* For #5577 - Uses concept-fetch to validate search string
* For #5577 - Adds string resources for the cannot reach error state
2019-11-19 16:30:56 -08:00
1388156953
For #1211 Hide the keyboard when scrolling through engine suggestions ( #6474 )
2019-11-08 14:36:39 -08:00
0d5fb67303
For #6284 : Fixes SearchShortcut button functionality when in a session
...
This makes it so searchShortcuts button works when going from browser -> search
2019-11-06 11:08:41 -08:00
2b955c1a1a
For #6087
...
- added engine hashmap so that we create each type of search provider once
(previously the providers to be added were checked by id, but since the id
is a UUID, it was always unique -> bug with multiple providers with same engine
but different id
- refactored update() flow so that it's more understandable + remove complex
method warning
2019-11-06 11:08:41 -08:00
9543f38978
Use new toolbar API of AC 18.0.0.
2019-10-24 08:57:30 -07:00
2be4d08228
For #6018 - Added back shortcuts button in awesomebar
...
Refactored logic for adding providers, since shortcut providers should
be alone in the list, while all others can be as list
2019-10-18 14:48:58 +03:00
8e17ac05b1
Optimized imports. Closes #5876
2019-10-10 04:17:43 +05:30
f907ec52f0
Removed ObsoleteCoroutinesApi in tests. Closes #5876
2019-10-10 04:04:51 +05:30
4045fb0107
For #4190 : Removes waterfall animation from awesomebar
2019-10-08 09:14:23 -07:00
19a2d9df4f
For #1620 : Hide search results when they match URL
2019-10-04 14:05:55 -07:00
785b8b9519
For #5567 : Removes search shortcuts button ( #5739 )
...
* For #5567 : Removes search shortcut button
* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
3f41a4e9c6
No issue: Update navigation library
2019-09-26 17:01:13 -07:00
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
f02603be37
For #5460 : Fixes styling of fill link from clipboard ( #5464 )
2019-09-20 15:29:16 -07:00
2db2d9ceae
For #1744 : Adds tests for clipboard
2019-09-19 08:24:27 -07:00
e961a9d63d
For #1744 : Adds clipboard provider to search engine screen
2019-09-19 08:24:27 -07:00
284cbab9ea
Use .orEmpty()
2019-09-17 11:09:21 -07:00
fdd2b59fb8
For #4155 : Adds popup menu for browser toolbar
2019-09-11 09:03:17 -07:00
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
38d97fda8b
Stores: Reduce visibility of reducer functions.
2019-09-03 10:09:06 -07:00
61e84c161d
Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
4cf03be236
For #2088 : Use new async API to load default search engine in HomeFragment
2019-08-30 17:56:18 -04:00
3abffd5d77
Use new async API to load and access search engines
...
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
2019-08-29 18:16:02 -07:00
b9f6f7fa93
For #4779 : Don't double navigate with global directions in HomeActivity
2019-08-23 12:01:28 -04:00
416e25e8a5
No issue: Don't show session provider in private mode
2019-08-20 16:09:55 -07:00
1afc0eacd8
For #4399 : Create LibState Controller for Search ( #4673 )
...
* For #4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
2f265eccbd
For #4732 : Fix search engine display issue ( #4735 )
2019-08-14 11:03:14 -07:00
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
59c60ef189
Fixes #4354 : Updated SearchFragment state after returning from SearchEngineFragment.
...
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
2019-08-07 13:19:53 -07:00
6f962d3376
For #1744 : Open search shortcuts when entering search mode ( #4536 )
2019-08-05 15:07:03 -07:00
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
83ceec6289
For #201 : Search Widget
2019-08-02 11:26:48 -07:00
46de06d132
For #4339 reduce build warnings ( #4340 )
2019-07-31 11:43:49 -07:00
4c13f45e9e
Fixes #4192 : Private keyboard in private browsing ( #4345 )
...
Sets compliant keyboards to private mode when in private browsing.
2019-07-29 18:00:48 -04:00
6fa022c2f8
For #4124 : Migrate BrowserToolbar to Libstate ( #4279 )
...
* For #4124 : Migrate BrowserToolbar to Libstate
* Restores QuickActionSheetReducer
* Improve tests
* Make QuickActionSheetController
* Finalize tests
* Breaks out QuickActionSheetState
* Fix comments
* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
48aeb19db1
For #3695 : Make SessionSuggestionProvider link to existing tab ( #4280 )
2019-07-26 09:49:25 -05:00
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
28eb5c541a
For #1944 & #1750 : Updates private & night mode colors ( #4232 )
2019-07-23 09:35:24 -07:00
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
c04dcec03f
Closes #4096 : IllegalStateException in SearchFragment ( #4131 )
2019-07-17 15:10:24 -05:00
ec099a6e11
For #3633 - Creates generic store provider ( #4060 )
2019-07-15 15:54:13 -07:00
e91a2e61a2
For #3633 : Add unit tests for SearchStore
2019-07-15 13:47:01 -04:00
e4ff70c542
For #3633 - Refactors the search screen to use lib-state
...
* For #3633 - Adds SearchStore
* For #3633 - Refactors AwesomeBarUIView
* For #3633 - Refactors ToolbarUIView to use lib-state
* For #3633 - Fixes a couple of state bugs
* For #3633 - Moves all user interaction to SearchInteractor
* For #3633 - Adds kdocs to SearchStore and SearchInteractor
* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property
* For #3633 - Creates `StateViewModel` to handle state restoration
* For #3633 - Adds a test for onTextChanged
* For #3633 - Adds tests for SearchInteractor
* For #3633 - Fixes bugs and adds documentation
2019-07-12 16:32:00 -07:00
867067537a
For #3568 - Use correct styling for QR and Share Alert Dialogs
2019-07-12 11:40:33 -07:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
161e7b3b57
No issue: Fix master builds ( #3825 )
2019-07-01 14:15:54 -05:00
61a8795576
For #1211 - Hide keyboard on fling suggestions list
2019-06-26 16:44:35 -07:00
427bc5c1e6
Revert "For #1211 - Hide keyboard on fling suggestions list"
...
This reverts commit cb6fd83c9879c268cb739fb768187d5276c5af66.
2019-06-26 11:19:09 -07:00
30930cdc88
Import variables referred to by path
2019-06-25 13:57:34 -07:00
6e3197f61c
For #3622 - Add ID to engine shortcut suggestions ( #3636 )
2019-06-24 15:30:27 -07:00
b1102c2e76
For #3544 - Set SearchSuggestions preference value from settings
2019-06-18 16:56:34 -07:00
f323c38be0
For #981 - Adds missing Leanplum events
2019-06-14 13:27:50 -07:00
d5c5587a0c
For #3209 : Disable shared element animations for crash temporarily ( #3482 )
2019-06-14 12:13:13 -05:00
5eb2bc6d55
For #3138 - Sets height of toolbar in SearchFragment to match_parent ( #3400 )
2019-06-12 19:44:44 -05:00
66a836cf3a
For #3314 : Toolbar and QAB unresponsive after Android 6 perms check ( #3373 )
2019-06-12 10:08:39 -05:00
82d2a0661b
Remove deprecatd support-ktx methods ( #3305 )
2019-06-10 09:12:11 -05:00
c9570fd6ff
Use `Drawable.toBitmap()` from androidx-ktx. ( #3286 )
2019-06-10 08:50:37 -04:00
86aac3e313
For #3176 : Hides camera options on devices without cameras ( #3273 )
2019-06-07 19:37:43 -05:00
f7bd39da77
For #3138 : Fix white background on search bar
2019-06-06 17:11:06 -07:00
605a552f16
For #1366 . Update toolbar search state when typing. ( #2908 )
2019-06-06 08:16:22 -07:00
ca186c8776
Closes #1618 - Add fade to awesome bar list instead of shadow ( #3110 )
...
* Closes #1618 - Add fade to awesome bar list instead of shadow
* For #1211 - Hide keyboard on fling suggestions list
2019-06-04 10:35:47 -05:00
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
8dbed67f7f
No issue: Simplify and speed up shared element transitions
2019-05-30 16:30:06 -07:00
43a961fe73
For #1973 - Toggle QR button on deny permissions, fix engineView crashes
2019-05-30 16:06:37 -07:00
0b00c0ce9b
No issue: ClipboardProvider no longer needs to be added/removed based on input
2019-05-30 13:03:50 -07:00
8181705b58
Init Toolbar in edit mode so we don't see the flash
2019-05-29 12:27:48 -07:00
dee3c059dc
Adds Shared Transition between Home and Search
2019-05-29 12:27:48 -07:00
a80053547e
For #2806 - navigate up from SearchFragment instead of activity back press ( #2812 )
2019-05-23 21:30:05 -07:00
291df48c4e
Install the "icons" WebExtension to automatically load icons for every visited website.
2019-05-20 19:34:49 -07:00
e534dad199
For #2028 - Pass Session ID for Custom Tab Prompts, Theme Dialogs
2019-05-20 19:24:48 -07:00
028c6cad70
For #2025 - Create and theme Dialog for deleting all history
2019-05-20 19:24:48 -07:00
9e50b55340
For #1857 : Adds telemetry for QR scanner
2019-05-17 10:46:53 -07:00
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
49ac62ab85
Fix ViewModel States ( #2457 )
...
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2019-05-14 13:49:02 -07:00
24f15c8b77
Closes #1083 . Don't print sensitive data to logs in the production app. ( #2437 )
2019-05-11 22:01:41 -07:00
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
e4b4934f53
For #2393 - SearchTermsTapped even on URL should search ( #2398 )
2019-05-09 16:21:33 -05:00
70486039c0
Closes #2147 : Refactors usage of openToBrowserAndLoad
2019-04-29 15:49:22 -07:00
5b7e297adf
For #1955 : Add prompt before loading QR code ( #2096 )
2019-04-28 01:00:55 -05:00
97e4f43fda
No issue: null check context on permission granted ( #2104 )
2019-04-26 22:02:50 -07:00
29238d6e5f
For #1954 : Hides keyboard when requesting camera permission
2019-04-26 15:53:38 -07:00
11918d45f4
For #1619 : Hides clipboard provider when text is entered ( #2081 )
2019-04-26 11:37:02 -07:00
46924544b6
For #1975 & #1627 : Refactors getSessionById in BrowserFragment
2019-04-25 16:51:03 -07:00
4945805e37
For #1954 : Resolves QR scanner back press and keyboard issues ( #2036 )
2019-04-25 12:31:17 -07:00
36cd275eed
For #1917 : Hides search suggestions in shortcuts when needed ( #1988 )
2019-04-24 13:50:55 -07:00
31494a4341
Sets the search engine to the default if no shortcut is used
2019-04-23 17:39:57 -05:00
8a4995099f
For #1205 : Adds search term to EditToolbar
2019-04-23 09:59:48 -07:00
e20fa5dc32
AwesomeBarUIView: Rename variable to prevent name shadowing
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
6199d31924
For #1851 : QR code scanner doesn't load right after permission grant
2019-04-22 13:56:43 -07:00
d1fd5ec879
For #113 : QR Scan
2019-04-19 14:47:53 -07:00
bf056b73c1
For #1375 - Add Bookmarks Suggestion Provider
2019-04-18 19:21:12 -05:00
cb7ad32b62
For #1158 - Add search counts
2019-04-17 10:04:49 -07:00
f48e2b072e
No issue: Cleans up SearchShortcut changes
2019-04-17 11:20:59 -05:00
353270a5c7
Fixes #1610 : Gives unique identifier to shortcut engine picker suggestions
2019-04-15 13:32:34 -05:00
29832c5e84
For #724 : Consolidates colors
2019-04-15 12:22:03 -05:00
5f0fe216cb
For #1375 - Suppress history suggestions in awesome bar via setting
2019-04-10 16:45:02 -05:00
9cb252da40
For #1421 - Fix Shortcut ToggleButton states
2019-04-05 16:29:36 -07:00
5d1738e011
For #208 - Dark Mode UX edits
2019-04-04 19:35:36 -07:00
471b08d97a
Closes #1194 : Adds shortcut telemetry
2019-04-03 11:12:17 -05:00
a2200b6335
For #208 - Dark/Night Theme
2019-04-02 22:18:11 -05:00
36af5107c6
Closes #875 : Adds search shortcuts ( #882 )
...
* Closes #875 : Adds shortcuts
* Refactor and clean up
* Remove TODO
* Removes local
* Fix nits
* Refactors to add ShortcutEngineManager
2019-03-29 13:49:50 -07:00
edb197d10b
Adds search engine icon to the toolbar
2019-03-25 14:42:13 -07:00
32f8e06e98
For #959 - Adds search related telemetry
2019-03-22 17:14:35 -07:00
df40ec970e
Simplify ItsNotBrokenSnack() and make resilient
...
Co-authored by: Emily Kager <ekager@mozilla.com>
2019-03-22 15:00:38 -05:00
4963f7ccdb
Add Snackbar to link testers to Github issue for features
2019-03-22 15:00:38 -05:00
8f11ab6fcf
AwesomeBar: Limit number of search engine suggestions.
2019-03-22 11:19:05 -05:00
52e9394324
Pass BrowserIcons instance to SessionSuggestionProvider and HistoryStorageSuggestionProvider.
2019-03-22 11:18:43 -05:00
8eb113fa32
Bump A-C snapshot version to 0.48
...
This is necessary to pick up an application-services dependency bump, and unbreak master.
AwesomeBarUIView changes are needed because, evidently, a new parameter was introduced, and
not at the end.
2019-03-21 23:30:00 -05:00
1e1c8a7b46
Pre: fix an IDE warning
2019-03-13 19:07:28 -05:00
9d18bbad12
Closes #847 : Implement onCancelEditing to handle keyboard backPress ( #929 )
2019-03-13 11:12:58 -07:00
f66bae0801
Closes #963 - Hooks up show search suggestion pref
2019-03-12 11:12:03 -07:00
fd4acf6e92
Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443 ( #958 )
...
* Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443
* Fix compliation errors
2019-03-12 08:49:22 -07:00
d15e4bb3fa
Closes #877 - Add Search Engine Settings
2019-03-06 16:20:35 -08:00
a79134fdc3
Closes #823 & Closes #835 : Refactors openToBrowserAndLoad to include fromFragment ( #833 )
2019-03-06 14:53:49 -08:00
c4674a9026
Closes #754 - Restore SearchFragment navigation logic
2019-03-01 00:02:52 -08:00
104b6fbf22
No issue - pulls logic outside of the UIView
2019-02-28 14:19:49 -06:00
e57aa67d60
Closes #664 & Closes #665 : Refactors load to respect private mode ( #667 )
2019-02-28 09:25:37 -08:00
5b8d40e6e0
Closes #655 - Show/Hide toolbar in onResume
2019-02-25 11:45:59 -08:00
9d6ea0ac28
disable blank searches
2019-02-24 08:29:52 -08:00
53f391de60
Closes #537 : Refactors private sessions ( #629 )
2019-02-22 09:49:02 -08:00
5ab49ff7cf
For #507 - Leaves a comment to explain the current state
2019-02-21 11:29:13 -08:00
bacf84678d
For #507 - Moves the loading of the URL to the fragment
2019-02-21 11:29:13 -08:00
797d1cc423
Fixes #566 : Clears search on new tab
2019-02-20 15:32:24 -06:00
291f21aa8e
Handle listener state bugs as onViewCreated isn't always called
2019-02-19 09:08:25 -08:00
6d71faa44d
Fixes #541 : Crash on Home Screen
...
The Android Lifecycle Architecture component does not have fine-grained enough lifecycle event callbacks to safely manage Rx subscriptions in Fragment lifecycles. Added autodispose to simplify.
2019-02-16 19:40:39 -08:00
e5fe80f928
Closes #347 : Adds private browsing logic ( #506 )
...
* For #347 : Adds private browsing logic
* For #347 : Adds private session explainer
* Adds persistence
2019-02-15 09:31:03 -08:00
4a66c60548
Pass concept-fetch Client implementation to SearchSuggestionProvider.
2019-02-14 10:18:20 -06:00
4873d989a0
Moves the shared toolbar component to the components package
2019-02-12 16:25:40 -08:00
cbb26cb45f
Handle multitasking via toolbar actions
2019-02-09 21:11:30 -06:00
f09dc2453f
Fixes #351 Create home screen component for multitasking
2019-02-09 15:52:10 -06:00
77883c0f30
Closes #403 Use Fragments for Navigation, Add Toolbar to HomeActivity
2019-02-08 12:57:38 -08:00
cf260e4b8d
Use ViewBoundFeatureWrapper and BackHandler from the base component.
2019-02-08 12:00:11 -08:00
a4fe413537
Closes #412 : Enforces consistent naming in colors.xml
2019-02-08 12:53:16 -06:00
3ff95880eb
Closes #358 : Adds local history to AwesomeBar ( #413 )
2019-02-08 09:55:30 -08:00
d09dc149ed
Closes #363 & Closes #364 : Adds private browsing theme ( #405 )
...
* For #345 #346 - Adds private browsing theme
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
* Abstracts theme management
* Theme browser toolbar
* Remove unused imports
* Begin work on sharedPreferences
* fix lint
* #346 - Refactors ThemeManager to take a callback
* Adds clean status bar and nav bar
* lint
* Themes settings icons better
* Small clean up
2019-02-08 09:43:17 -08:00
0298950025
Closes #335 - Adds Report Site Issue Menu Item
2019-02-08 08:08:57 -08:00
b8ab51318e
For #355 - re-adds the request desktop functionality
2019-02-07 15:41:15 -08:00
98a1ae578e
For #355 - Present the Library when the menu item is tapped
2019-02-07 15:41:15 -08:00
623dc55eac
Fixes #391 : Home button is not visible
2019-02-06 14:50:26 -08:00
Sawyer Blatz