1
0
Fork 0
Commit Graph

269 Commits (c119070e213ac2f835967f045d13bca36db972b9)

Author SHA1 Message Date
Christian Sadilek c04dcec03f Closes #4096: IllegalStateException in SearchFragment (#4131) 2019-07-17 15:10:24 -05:00
Jeff Boek ec099a6e11
For #3633 - Creates generic store provider (#4060) 2019-07-15 15:54:13 -07:00
Christian Sadilek e91a2e61a2 For #3633: Add unit tests for SearchStore 2019-07-15 13:47:01 -04:00
Jeff Boek e4ff70c542
For #3633 - Refactors the search screen to use lib-state
* For #3633 - Adds SearchStore

* For #3633 - Refactors AwesomeBarUIView

* For #3633 - Refactors ToolbarUIView to use lib-state

* For #3633 - Fixes a couple of state bugs

* For #3633 - Moves all user interaction to SearchInteractor

* For #3633 - Adds kdocs to SearchStore and SearchInteractor

* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property

* For #3633 - Creates `StateViewModel` to handle state restoration

* For #3633 - Adds a test for onTextChanged

* For #3633 - Adds tests for SearchInteractor

* For #3633 - Fixes bugs and adds documentation
2019-07-12 16:32:00 -07:00
Emily Kager 867067537a For #3568 - Use correct styling for QR and Share Alert Dialogs 2019-07-12 11:40:33 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Colin Lee 161e7b3b57
No issue: Fix master builds (#3825) 2019-07-01 14:15:54 -05:00
ekager 61a8795576 For #1211 - Hide keyboard on fling suggestions list 2019-06-26 16:44:35 -07:00
Emily Kager 427bc5c1e6 Revert "For #1211 - Hide keyboard on fling suggestions list"
This reverts commit cb6fd83c9879c268cb739fb768187d5276c5af66.
2019-06-26 11:19:09 -07:00
Tiger Oakes 30930cdc88 Import variables referred to by path 2019-06-25 13:57:34 -07:00
Emily Kager 6e3197f61c For #3622 - Add ID to engine shortcut suggestions (#3636) 2019-06-24 15:30:27 -07:00
Emily Kager b1102c2e76 For #3544 - Set SearchSuggestions preference value from settings 2019-06-18 16:56:34 -07:00
Jeff Boek f323c38be0 For #981 - Adds missing Leanplum events 2019-06-14 13:27:50 -07:00
Colin Lee d5c5587a0c
For #3209: Disable shared element animations for crash temporarily (#3482) 2019-06-14 12:13:13 -05:00
Emily Kager 5eb2bc6d55 For #3138 - Sets height of toolbar in SearchFragment to match_parent (#3400) 2019-06-12 19:44:44 -05:00
Colin Lee 66a836cf3a
For #3314: Toolbar and QAB unresponsive after Android 6 perms check (#3373) 2019-06-12 10:08:39 -05:00
Tiger Oakes 82d2a0661b Remove deprecatd support-ktx methods (#3305) 2019-06-10 09:12:11 -05:00
Denys M c9570fd6ff Use `Drawable.toBitmap()` from androidx-ktx. (#3286) 2019-06-10 08:50:37 -04:00
Sawyer Blatz 86aac3e313 For #3176: Hides camera options on devices without cameras (#3273) 2019-06-07 19:37:43 -05:00
Jonathan Almeida f7bd39da77 For #3138: Fix white background on search bar 2019-06-06 17:11:06 -07:00
Denys M 605a552f16 For #1366. Update toolbar search state when typing. (#2908) 2019-06-06 08:16:22 -07:00
Emily Kager ca186c8776 Closes #1618 - Add fade to awesome bar list instead of shadow (#3110)
* Closes #1618 - Add fade to awesome bar list instead of shadow

* For #1211 - Hide keyboard on fling suggestions list
2019-06-04 10:35:47 -05:00
Jeff Boek a7d5cdcb9d For #2723 - Fixes theme manager 2019-05-30 16:38:31 -07:00
Emily Kager 8dbed67f7f No issue: Simplify and speed up shared element transitions 2019-05-30 16:30:06 -07:00
Emily Kager 43a961fe73 For #1973 - Toggle QR button on deny permissions, fix engineView crashes 2019-05-30 16:06:37 -07:00
Christian Sadilek 0b00c0ce9b No issue: ClipboardProvider no longer needs to be added/removed based on input 2019-05-30 13:03:50 -07:00
Emily Kager 8181705b58 Init Toolbar in edit mode so we don't see the flash 2019-05-29 12:27:48 -07:00
ekager dee3c059dc Adds Shared Transition between Home and Search 2019-05-29 12:27:48 -07:00
Emily Kager a80053547e For #2806 - navigate up from SearchFragment instead of activity back press (#2812) 2019-05-23 21:30:05 -07:00
Sebastian Kaspari 291df48c4e Install the "icons" WebExtension to automatically load icons for every visited website. 2019-05-20 19:34:49 -07:00
Emily Kager e534dad199 For #2028 - Pass Session ID for Custom Tab Prompts, Theme Dialogs 2019-05-20 19:24:48 -07:00
Emily Kager 028c6cad70 For #2025 - Create and theme Dialog for deleting all history 2019-05-20 19:24:48 -07:00
Sawyer Blatz 9e50b55340 For #1857: Adds telemetry for QR scanner 2019-05-17 10:46:53 -07:00
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Colin Lee 49ac62ab85 Fix ViewModel States (#2457)
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2019-05-14 13:49:02 -07:00
Denys M 24f15c8b77 Closes #1083. Don't print sensitive data to logs in the production app. (#2437) 2019-05-11 22:01:41 -07:00
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 2019-05-09 23:06:12 +00:00
Emily Kager e4b4934f53 For #2393 - SearchTermsTapped even on URL should search (#2398) 2019-05-09 16:21:33 -05:00
Sawyer Blatz 70486039c0 Closes #2147: Refactors usage of openToBrowserAndLoad 2019-04-29 15:49:22 -07:00
Colin Lee 5b7e297adf
For #1955: Add prompt before loading QR code (#2096) 2019-04-28 01:00:55 -05:00
Emily Kager 97e4f43fda No issue: null check context on permission granted (#2104) 2019-04-26 22:02:50 -07:00
Sawyer Blatz 29238d6e5f For #1954: Hides keyboard when requesting camera permission 2019-04-26 15:53:38 -07:00
Sawyer Blatz 11918d45f4
For #1619: Hides clipboard provider when text is entered (#2081) 2019-04-26 11:37:02 -07:00
Sawyer Blatz 46924544b6 For #1975 & #1627: Refactors getSessionById in BrowserFragment 2019-04-25 16:51:03 -07:00
Sawyer Blatz 4945805e37
For #1954: Resolves QR scanner back press and keyboard issues (#2036) 2019-04-25 12:31:17 -07:00
Sawyer Blatz 36cd275eed
For #1917: Hides search suggestions in shortcuts when needed (#1988) 2019-04-24 13:50:55 -07:00
Jeff Boek 31494a4341 Sets the search engine to the default if no shortcut is used 2019-04-23 17:39:57 -05:00
Sawyer Blatz 8a4995099f For #1205: Adds search term to EditToolbar 2019-04-23 09:59:48 -07:00
Harsh Shandilya e20fa5dc32 AwesomeBarUIView: Rename variable to prevent name shadowing
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
Colin Lee 6199d31924 For #1851: QR code scanner doesn't load right after permission grant 2019-04-22 13:56:43 -07:00
Colin Lee d1fd5ec879 For #113: QR Scan 2019-04-19 14:47:53 -07:00
Emily Kager bf056b73c1 For #1375 - Add Bookmarks Suggestion Provider 2019-04-18 19:21:12 -05:00
Jeff Boek cb7ad32b62 For #1158 - Add search counts 2019-04-17 10:04:49 -07:00
Sawyer Blatz f48e2b072e No issue: Cleans up SearchShortcut changes 2019-04-17 11:20:59 -05:00
Sawyer Blatz 353270a5c7 Fixes #1610: Gives unique identifier to shortcut engine picker suggestions 2019-04-15 13:32:34 -05:00
Sawyer Blatz 29832c5e84 For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
Emily Kager 5f0fe216cb For #1375 - Suppress history suggestions in awesome bar via setting 2019-04-10 16:45:02 -05:00
Emily Kager 9cb252da40 For #1421 - Fix Shortcut ToggleButton states 2019-04-05 16:29:36 -07:00
Emily Kager 5d1738e011 For #208 - Dark Mode UX edits 2019-04-04 19:35:36 -07:00
Sawyer Blatz 471b08d97a Closes #1194: Adds shortcut telemetry 2019-04-03 11:12:17 -05:00
Emily Kager a2200b6335 For #208 - Dark/Night Theme 2019-04-02 22:18:11 -05:00
Sawyer Blatz 36af5107c6
Closes #875: Adds search shortcuts (#882)
* Closes #875: Adds shortcuts

* Refactor and clean up

* Remove TODO

* Removes local

* Fix nits

* Refactors to add ShortcutEngineManager
2019-03-29 13:49:50 -07:00
Jeff Boek edb197d10b Adds search engine icon to the toolbar 2019-03-25 14:42:13 -07:00
Jeff Boek 32f8e06e98 For #959 - Adds search related telemetry 2019-03-22 17:14:35 -07:00
Colin Lee df40ec970e Simplify ItsNotBrokenSnack() and make resilient
Co-authored by: Emily Kager <ekager@mozilla.com>
2019-03-22 15:00:38 -05:00
Emily Kager 4963f7ccdb Add Snackbar to link testers to Github issue for features 2019-03-22 15:00:38 -05:00
Sebastian Kaspari 8f11ab6fcf AwesomeBar: Limit number of search engine suggestions. 2019-03-22 11:19:05 -05:00
Sebastian Kaspari 52e9394324 Pass BrowserIcons instance to SessionSuggestionProvider and HistoryStorageSuggestionProvider. 2019-03-22 11:18:43 -05:00
Grisha Kruglov 8eb113fa32 Bump A-C snapshot version to 0.48
This is necessary to pick up an application-services dependency bump, and unbreak master.

AwesomeBarUIView changes are needed because, evidently, a new parameter was introduced, and
not at the end.
2019-03-21 23:30:00 -05:00
Grisha Kruglov 1e1c8a7b46 Pre: fix an IDE warning 2019-03-13 19:07:28 -05:00
Sawyer Blatz 9d18bbad12
Closes #847: Implement onCancelEditing to handle keyboard backPress (#929) 2019-03-13 11:12:58 -07:00
Emily Kager f66bae0801 Closes #963 - Hooks up show search suggestion pref 2019-03-12 11:12:03 -07:00
Arturo Mejia fd4acf6e92 Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443 (#958)
* Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443

* Fix compliation errors
2019-03-12 08:49:22 -07:00
Emily Kager d15e4bb3fa Closes #877 - Add Search Engine Settings 2019-03-06 16:20:35 -08:00
Sawyer Blatz a79134fdc3
Closes #823 & Closes #835: Refactors openToBrowserAndLoad to include fromFragment (#833) 2019-03-06 14:53:49 -08:00
ekager c4674a9026 Closes #754 - Restore SearchFragment navigation logic 2019-03-01 00:02:52 -08:00
Jeff Boek 104b6fbf22 No issue - pulls logic outside of the UIView 2019-02-28 14:19:49 -06:00
Sawyer Blatz e57aa67d60
Closes #664 & Closes #665: Refactors load to respect private mode (#667) 2019-02-28 09:25:37 -08:00
Emily Kager 5b8d40e6e0 Closes #655 - Show/Hide toolbar in onResume 2019-02-25 11:45:59 -08:00
nikit19 9d6ea0ac28 disable blank searches 2019-02-24 08:29:52 -08:00
Sawyer Blatz 53f391de60
Closes #537: Refactors private sessions (#629) 2019-02-22 09:49:02 -08:00
Jeff Boek 5ab49ff7cf For #507 - Leaves a comment to explain the current state 2019-02-21 11:29:13 -08:00
Jeff Boek bacf84678d For #507 - Moves the loading of the URL to the fragment 2019-02-21 11:29:13 -08:00
Sawyer Blatz 797d1cc423 Fixes #566: Clears search on new tab 2019-02-20 15:32:24 -06:00
Colin Lee 291f21aa8e Handle listener state bugs as onViewCreated isn't always called 2019-02-19 09:08:25 -08:00
Colin Lee 6d71faa44d Fixes #541: Crash on Home Screen
The Android Lifecycle Architecture component does not have fine-grained enough lifecycle event callbacks to safely manage Rx subscriptions in Fragment lifecycles. Added autodispose to simplify.
2019-02-16 19:40:39 -08:00
Sawyer Blatz e5fe80f928
Closes #347: Adds private browsing logic (#506)
* For #347: Adds private browsing logic

*  For #347: Adds private session explainer

* Adds persistence
2019-02-15 09:31:03 -08:00
Sebastian Kaspari 4a66c60548 Pass concept-fetch Client implementation to SearchSuggestionProvider. 2019-02-14 10:18:20 -06:00
Jeff Boek 4873d989a0 Moves the shared toolbar component to the components package 2019-02-12 16:25:40 -08:00
Colin Lee cbb26cb45f Handle multitasking via toolbar actions 2019-02-09 21:11:30 -06:00
Colin Lee f09dc2453f Fixes #351 Create home screen component for multitasking 2019-02-09 15:52:10 -06:00
Emily Kager 77883c0f30 Closes #403 Use Fragments for Navigation, Add Toolbar to HomeActivity 2019-02-08 12:57:38 -08:00
Sebastian Kaspari cf260e4b8d Use ViewBoundFeatureWrapper and BackHandler from the base component. 2019-02-08 12:00:11 -08:00
Sawyer Blatz a4fe413537 Closes #412: Enforces consistent naming in colors.xml 2019-02-08 12:53:16 -06:00
Sawyer Blatz 3ff95880eb
Closes #358: Adds local history to AwesomeBar (#413) 2019-02-08 09:55:30 -08:00
Sawyer Blatz d09dc149ed
Closes #363 & Closes #364: Adds private browsing theme (#405)
* For #345 #346 - Adds private browsing theme

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>

* Abstracts theme management

* Theme browser toolbar

* Remove unused imports

* Begin work on sharedPreferences

* fix lint

* #346 - Refactors ThemeManager to take a callback

* Adds clean status bar and nav bar

* lint

* Themes settings icons better

* Small clean up
2019-02-08 09:43:17 -08:00
ekager 0298950025 Closes #335 - Adds Report Site Issue Menu Item 2019-02-08 08:08:57 -08:00
Jeff Boek b8ab51318e For #355 - re-adds the request desktop functionality 2019-02-07 15:41:15 -08:00
Jeff Boek 98a1ae578e For #355 - Present the Library when the menu item is tapped 2019-02-07 15:41:15 -08:00
Colin Lee 623dc55eac Fixes #391: Home button is not visible 2019-02-06 14:50:26 -08:00
Jonathan Almeida 21508f49ca WIP: Integrate feature-customtabs component 2019-02-05 17:30:51 -08:00
Emily Kager e358ea138a Adds new home icon and adds padding to URL background 2019-02-05 15:32:58 -08:00
Jeff Boek 461664ed87 For #364 - Refactors BrowserFragment to use the ToolbarComponent
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
2019-02-04 16:44:10 -08:00
Jeff Boek dbea570747 For #364 - Moves edit mode to be a part of the toolbar component state
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
2019-02-04 16:44:10 -08:00
Colin Lee 0120558fce Enforce unidirectional arch better 2019-01-31 08:10:39 -08:00
Jeff Boek 5a57b9a6c5 Cleans up clipboard awesomebar suggestion 2019-01-30 19:25:37 -08:00
Jeff Boek ed1e563087 Pull awesome bar into a component 2019-01-30 19:25:37 -08:00
Colin Lee 273f33b244 Fixes #290: Integrate new Fenix architecture 2019-01-30 13:44:58 -06:00
Colin Lee b2b6a530d0 Make ktlint and detekt style changes 2019-01-30 11:08:25 -06:00
Jeff Boek ebb5da7f4e For #141 - Cleans up search UI 2019-01-29 21:08:07 -06:00
Grisha Kruglov 0e3965632a Closes #270: Integrate browser-storage-sync for history storage and toolbar autocompletion 2019-01-29 14:40:59 -06:00
Jeff Boek ef7122a147 For #144 - Adds the clipboard to the awesomebar 2019-01-25 09:44:36 -08:00
Jeff Boek 6f17107e87 Migrates away from using the chip suggestions, fixes text colors 2019-01-24 14:13:28 -08:00
Jeff Boek 926fa22909 Fixes transition to browserFragment 2019-01-24 14:13:28 -08:00
Jeff Boek 6587518ed6 Use more user-friendly method name 2019-01-24 14:13:28 -08:00
Jeff Boek 3a8a99d8f0 unhardcode sessionId 2019-01-24 14:13:28 -08:00
Jeff Boek 560aea9b56 For #141 - wires up toolbar and awesomebar 2019-01-24 14:13:28 -08:00
Jeff Boek 480ae93a72 For #141 - Adds autocomplete ot the search screen
- Adds convenience extensions to Context and Fragment
- Imports more components from Android Components
2019-01-24 14:13:28 -08:00
Emily Kager 4421adecbb Implement Navigation, Add Search Fragment, Add Browser Fragment 2019-01-15 14:08:37 -08:00