1
0
Fork 0

For #507 - Leaves a comment to explain the current state

master
Jeff Boek 2019-02-21 10:58:07 -08:00
parent bacf84678d
commit 5ab49ff7cf
2 changed files with 5 additions and 4 deletions

View File

@ -58,10 +58,6 @@ class ToolbarUIView(
url = text
actionEmitter.onNext(SearchAction.TextChanged(text))
}
override fun onStopEditing() {
// actionEmitter.onNext(SearchAction.UrlCommitted(url))
}
})
}

View File

@ -98,6 +98,11 @@ class SearchFragment : Fragment() {
}
}
// Issue: https://github.com/mozilla-mobile/fenix/issues/626
// Currently we were kind of forcing all this logic through the Toolbar Feature.
// But since we cannot actually load a page without an available GeckoSession
// we have to wait until after we navigate to call the use case.
// We should move this logic into a place that makes more sense.
private fun load(text: String) {
val sessionId = SearchFragmentArgs.fromBundle(arguments!!).sessionId
val isPrivate = SearchFragmentArgs.fromBundle(arguments!!).isPrivateTab