69c42b6192
For #5681 : Sets OPEN_TO_BROWSER false when using new tab shortcut
2019-09-30 14:56:16 -07:00
e9a0f1f65d
For #2078 - Filter Out Self in Share Sheet ( #5641 )
2019-09-30 12:43:47 -07:00
c8af16bd47
For #5679 : Hides autoplay behind feature flag ( #5685 )
2019-09-30 12:01:04 -07:00
ef29fe2584
Update BackgroundServicesTest, Suppress Complex Method
2019-09-30 10:33:56 -07:00
a4097cd380
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-30 10:33:56 -07:00
8f97d247a6
For #235 - Add Glean crash count + docs.
2019-09-30 08:32:33 -07:00
3e42114190
For #5656 : Fixes nightly major version number crash
2019-09-27 15:06:57 -07:00
a38b73f19e
Fixes #5653 : Removes crash with null campaign
2019-09-27 15:01:00 -07:00
64923978e6
For #1071 Added Desktop Mode icon
2019-09-27 09:47:10 -07:00
5e18ead45e
For #4474 : Adds tests and fixes issues
2019-09-27 08:59:05 -07:00
ee1f040e53
No issue: Move signedIn tracking to BookmarksSharedViewModel ( #4755 )
2019-09-27 08:57:38 -07:00
7f328a6dc4
For #1298 : Adds adjustCampaignId to core ping ( #5579 )
2019-09-27 08:56:33 -07:00
6babf72352
For #5197 : Adds telemetry for media notification ( #5520 )
2019-09-27 08:02:29 -07:00
88aa519210
Closes #4711 - Extract VoiceSearchActivity ( #5502 )
2019-09-27 07:54:29 -07:00
3f41a4e9c6
No issue: Update navigation library
2019-09-26 17:01:13 -07:00
11baabb63a
No issue: Updates fact mapping to use enums
2019-09-26 17:00:51 -07:00
c3287b17ac
Closes #5624 - Fix crash on preference change listener
2019-09-26 16:56:54 -07:00
62ae025d65
For #4991:Ensured deleteSelectedBookmarks deletes all selected bookmarks ( #5559 )
...
Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
2019-09-26 16:52:59 -07:00
dffa61bf16
Closes #4513 : fixes bookmark tests broken by loading change
...
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
2019-09-26 16:29:14 -07:00
fd7f1b2665
Closes #4513 : adds tests for bookmark loading state
2019-09-26 16:29:14 -07:00
fbdd537bc7
Closes #4513 : show progress bar when loading bookmarks
2019-09-26 16:29:14 -07:00
ca6c324f29
Issue #4513 : added isLoading to bookmark state
...
This was added to the state object as a top level param because it could reasonably coexist with any value of `tree` or `mode`. Even if we don't now, we may someday want to display a loading indicator while also showing cached bookmarks.
For now, we set isLoading to false whenever we receive any bookmarks
2019-09-26 16:29:14 -07:00
96472a533a
Issue #4513 : fix mismatched bookmark listener lifecycles
...
The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed.
We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!
2019-09-26 16:29:14 -07:00
de93b05cac
For #2754 Add tab cards to share sheet ( #5493 )
...
* For #2754 Add tab cards to share sheet
* For #2754 : Fix background near rounded corners and ShareButtonAppearanceTest
* Add license to share_tab_item
2019-09-26 14:25:34 -07:00
ac2611d744
Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) ( #5578 )
...
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT
* Update findinpage integration to use browser-state
* Use new UseCases APIs after download migration.
2019-09-26 12:50:50 -07:00
c5330c6880
For 5092 - Show a Snackbar with retry option if sharing to devices fails ( #5158 )
...
* For #5092 - Show a Snackbar with retry option if sharing to devices fails
ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.
* For #5092 - Refactor ShareControllerTest
* For #5092 : Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
0b01635ce0
For #2874 , #5375 , #5131 - submitList workaround for Android 5 + 6
2019-09-25 19:59:07 -07:00
44bb592b43
For #5312 - Send ETP Strict/Standard event
2019-09-25 15:23:30 -07:00
24b3ed4384
For #5568 - Don't pass in Session for QuickActionSheetController
2019-09-25 13:33:38 -07:00
b0b60aa27d
For #5281 - Use TrackerLog for reporting ETP categories ( #5556 )
2019-09-25 10:48:06 -07:00
b6e6e36ccd
For #561 : Fix stutter of search icon & text when animating
2019-09-25 10:06:38 -07:00
75a25c9bd0
For #561 : Fix linting issue
2019-09-25 10:06:38 -07:00
c592a69aad
For #561 - Fixes snackbar placement on homeview
2019-09-25 10:06:38 -07:00
5c092c1ef1
For #561 - Adds shadow/highlightto the bottom bar
2019-09-25 10:06:38 -07:00
00d1be97ac
For #561 - Wires up add tab button inside the bottom bar
2019-09-25 10:06:38 -07:00
b16754d78a
For #561 - Adds add tab and menu button to bottom bar
...
- Adds space between wordmark and session control component
2019-09-25 10:06:38 -07:00
abbb310ce3
For #561 - Removes the toolbar from the home screen
...
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
2019-09-25 10:06:38 -07:00
bfe8bf4663
For #1383 Added tab title to close button content description
2019-09-25 10:34:02 +03:00
1c9c5317eb
For #5552 - Temporary fix for startup crash on es locales
2019-09-24 19:21:47 -07:00
856399e9e2
No issue: Fixes GleanMetricsService nits & broken UI test ( #5539 )
...
* No issue: Fixes GleanMetricsService nits
* No issue: fixes broken UI test
2019-09-24 16:12:09 -07:00
1ffdf1cf9b
Add basic test coverage for Glean metrics in Fenix
...
This introduces test coverage, using the Glean SDK
testing API, for the metrics that are set at startup
by Fenix in the GleanMetricsService.
This additional adds a basic test for the translation
of the `app_opened` event.
2019-09-24 12:33:14 -07:00
25e2a7abfc
For #2765 - Run places maintenance daily ( #5466 )
2019-09-24 10:50:11 -07:00
c7c752cabb
For #5356 Improves private browsing "common myths" link accessibility ( #5479 )
...
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
2019-09-24 10:46:34 -07:00
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
734d4031e2
Extract UriOpened observer from HomeActivity
2019-09-24 09:37:24 -07:00
e3c60faf24
Move BookmarkNode extensions to helper class ( #4752 )
2019-09-24 09:17:29 -07:00
236f702bbe
For#5468 Changed info source for url clipboard copy from view to session ( #5514 )
2019-09-24 07:56:59 -07:00
cb7701584f
No issue: Extract home fragment mode ( #5343 )
2019-09-23 09:33:55 -07:00
9d9ff959b5
For #5312 - Add Telemetry for Tracking Protection
2019-09-23 08:29:45 -07:00
c866ae1a1e
Closes #5444 : IntentReceiverActivity: Add tests for intent processing
2019-09-20 19:44:05 -04:00
f02603be37
For #5460 : Fixes styling of fill link from clipboard ( #5464 )
2019-09-20 15:29:16 -07:00
4a6e647167
For #5197 : Adds telemetry for media controls ( #5266 )
2019-09-20 14:49:27 -07:00
6c30a94081
Move settings classes to packages
2019-09-20 12:36:15 -07:00
699eacab39
For #778 - Rename CustomTabActivity
2019-09-20 12:35:12 -07:00
e9fd6892ba
For #394 , #778 - Add hide toolbar feature
...
And also add CustomTabsServiceStore
2019-09-20 12:34:49 -07:00
78ac6fc912
For #5448 - Reload custom tab session when TP is toggled
2019-09-20 12:30:02 -07:00
a63eaa9d67
1581556: Initialize Glean on the main thread
2019-09-20 12:29:40 -07:00
47064a68e0
For #5141 Changed "learn more" link to be accessible to Talkback users
2019-09-20 12:29:02 -07:00
172a9cf06c
Extract and test crash reporter code
2019-09-20 11:04:11 -07:00
464122fda1
For #5421 - Make share dialog scrim dismiss fragment
2019-09-20 09:52:39 -07:00
5577470d0b
No bug - Add WebCompat feature.
2019-09-20 08:33:48 -07:00
f71ec8928b
Add note about lazy in FeatureFlags
2019-09-20 08:33:29 -07:00
6f3d7b4ee8
For #5396 : Adds "always launch in private mode" to settings
2019-09-20 08:33:07 -07:00
a1c8fc0698
For #3731 Improved UX for opening tabs from a Collection ( #5427 )
...
* For #3731 Changed order of items for a collection's overflow menu
* For #3731 Changed the order tabs open to keep same order from collections
2019-09-20 06:41:04 -07:00
05a4faec78
Add tryGetHostFromUrl and update ExceptionDomains
2019-09-19 22:40:35 -04:00
1aa4f5a519
For #255 : Toggle Media Autoplay
2019-09-19 15:13:04 -07:00
2db2d9ceae
For #1744 : Adds tests for clipboard
2019-09-19 08:24:27 -07:00
fd1fcd8b89
For #4155 : Adds paste & go for search terms
2019-09-19 08:24:27 -07:00
e961a9d63d
For #1744 : Adds clipboard provider to search engine screen
2019-09-19 08:24:27 -07:00
1777b5a830
Use enum to simplify delete on quit code
2019-09-18 20:20:08 -07:00
106458c2c9
For #3440 - Reduce HomeFragment require calls
2019-09-18 17:25:44 -07:00
976c840047
For #3077 - Replaces connect another device dialog with a scree
2019-09-18 17:24:43 -07:00
065ce13999
Pass color resource for what's new menu item by id
2019-09-18 16:41:03 -07:00
50cd2920d3
For #5371 : Updates search engine settings string ( #5393 )
2019-09-18 11:26:44 -07:00
e1b84a7a08
For #5396 : Reverts broken activity alias
2019-09-17 18:35:31 -07:00
284cbab9ea
Use .orEmpty()
2019-09-17 11:09:21 -07:00
3e132f102c
No issue: Update androidx libraries Sept 5 2019
2019-09-17 09:50:31 -07:00
1767bd5569
For #5174 Changed FindInPage height to toolbar height to cover QAB ( #5376 )
2019-09-17 05:47:17 -07:00
2b71af4087
For #5258 - Pop AccountProblemFragment if signed out
2019-09-16 21:26:01 -07:00
8a9340fd9d
Post: Clean up 'push' initialization code
2019-09-16 19:44:13 -07:00
d67fb3eed2
Post: Add experiment flags, push and telemetry tests for BackgroundServices
2019-09-16 19:44:13 -07:00
eeaeb973ff
Post: minor cleanup
2019-09-16 19:44:13 -07:00
c2fb99a73f
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-16 19:44:13 -07:00
a61391ef58
Separates tracker bucket sorting code
2019-09-16 15:16:12 -07:00
140da0dd0f
For #5359 , #5360 - Update ETP Vectors for Android 5+6
2019-09-16 15:01:29 -07:00
9ebd4efe70
Pass app name to delete browsing data prompt
2019-09-16 09:59:42 -07:00
b8539ccb33
Use new feature-contextmenu API.
2019-09-16 17:24:13 +02:00
42bb3e1410
Change deleteAndQuit to take an activity
2019-09-15 20:03:04 -07:00
da37dedba3
For #5279 - Don't use runBlocking in delete and quit
2019-09-14 11:18:43 -07:00
8cd0d8faf3
For #5304 - Align ETP Onboarding Tool Tip PopupWindow
2019-09-13 18:25:26 -07:00
3787dd7b1f
For #5254 : Fix transition to private browsing mode after sharing a page
2019-09-13 14:44:28 -07:00
e247870b9f
For #5277 : Updates string for delete browsing data ( #5309 )
2019-09-13 10:18:25 -07:00
dd85229c41
Use new feature-downloads API.
2019-09-13 15:01:25 +02:00
42b31f0088
For #4155 : Adds elevation to copy/paste menu
2019-09-12 14:03:12 -07:00
c8bc144114
For #2570 : Hide 3-dots menu when in select mode for bookmarks and history ( #5173 )
...
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
2019-09-12 13:56:39 -07:00
b83ae45c36
For #5263 - Hide ETP Panel Settings for custom tab
2019-09-12 10:45:35 -07:00
4acf48e817
Fixes #5212 - Change tint in onCreateOptionsMenu
...
Also fixes #5213
2019-09-12 10:30:49 -07:00
bc16061939
For #3371 : Show snackbar message when share fails with crash ( #5210 )
2019-09-12 09:26:24 -07:00
fcb0448fa5
For #4458 - Enable font inflation with font auto size setting ( #5252 )
2019-09-12 09:05:16 -07:00
4461230e9b
For #5229 , #5228 - Dismiss ETP panel on back press, don't truncate text
2019-09-12 07:40:49 -07:00
a5859e0028
For #5178 - Polish delete browsing data item layout
2019-09-11 18:11:26 -07:00
102a36bd7e
No issue: Updates isPWA to isInstallable for AC 13 snapshot
2019-09-11 18:10:52 -07:00
b3eca65614
Closes #5091 : Refactor Sentry BreadCrumbs to use lib-crash BreadCrumbs
2019-09-11 16:14:42 -07:00
e092dfd684
For #5047 - Addresses nits
...
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
2019-09-11 16:10:54 -07:00
d18ec49704
For #5047 - Wires up dialog to webAppUseCases
2019-09-11 16:10:54 -07:00
faff73b9b3
For #5047 - Creates dialog ui for naming a shortcut
2019-09-11 16:10:54 -07:00
e3209dcc84
For #3700 - Add Setting to Delete Data on "Quit" menu action
2019-09-11 16:06:18 -07:00
ddc1b2e648
For #4658 : Add private browsing mode shortcut telemetry
2019-09-11 16:03:22 -07:00
418b1ba890
For #1749 - Use Strict ETP by default, use Feature Flag for Settings
2019-09-11 16:03:01 -07:00
999d3cb963
For #1114 : Show playing tab
2019-09-11 15:45:22 -07:00
9a4610f068
For #2897 - Add Action States To Share Sheet
2019-09-11 11:32:26 -07:00
2e2bac4ccd
For #419 : Create launch icon for private browsing ( #4948 )
2019-09-11 10:52:33 -07:00
5586b18c3e
For #4155 : Handle custom tabs & fix test
2019-09-11 09:03:17 -07:00
53b3f105ca
For #4155 : Sets pastedText default value
2019-09-11 09:03:17 -07:00
9d30d7bb03
For #4155 : Restyle to custom menu
2019-09-11 09:03:17 -07:00
52fd327bc0
For #4155 : Adds tests for browser toolbar popup menu
2019-09-11 09:03:17 -07:00
fdd2b59fb8
For #4155 : Adds popup menu for browser toolbar
2019-09-11 09:03:17 -07:00
4485b7f647
Add Tracking Protection Info Panel
2019-09-11 07:47:13 -07:00
ef4a6b4154
For #4877 : Restored logic for closing tabs when not on browserFragment
...
Added return in function when saving collections coming from browser fragment
2019-09-10 21:42:16 -07:00
e240de7e31
For #4908 : Adds telemetry for send tab
2019-09-10 20:58:12 -07:00
d0ef2d40c2
Move bookmark navigation listener to separate file
2019-09-10 16:53:09 -07:00
f7dde41b3b
For #5021 : Adds telemetry for what's new button
2019-09-10 14:15:34 -07:00
3c07cacf4d
Use A-C preferences property delegates
2019-09-10 13:19:00 -07:00
b77c4d2e2e
Clean up SupportUtils
2019-09-10 10:16:04 -07:00
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
2019-09-10 09:04:05 -07:00
16115f57d1
For #3440 - Reduce BrowserFragment require calls
2019-09-09 21:33:32 -07:00
4c2a7ac10e
Delete AUTH_SESSIONS with COOKIES
2019-09-09 12:32:28 -07:00
758f4c13ec
Updates per UX and PR feedback
2019-09-09 12:32:28 -07:00
2b9efccfca
For #3106 : Granular options for clearing user data
2019-09-09 12:32:28 -07:00
53341f620a
Code cleanup - Remove unused FindInPageBarBehavior
...
There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
2019-09-06 14:20:02 -04:00
716cf3995a
Fix #4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature
...
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().
This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
2019-09-06 14:20:02 -04:00
ed0b6bd5ef
For #4193 - Makes close button for tabs more accessible ( #4442 )
...
* fixes #4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
2019-09-06 10:33:55 -07:00
aef087aae0
No issue: Removes unused nestedScrollQuickActionView ( #5143 )
2019-09-06 09:03:24 -07:00
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
ccd9e44a3e
No issue: Add logging for firebase/autopush
2019-09-05 16:03:36 -04:00
58287cd5bb
For #5033 - Update browsing mode when session selected ( #5118 )
2019-09-05 14:27:30 -05:00
bb2a685ad9
For #5075 - Fix boolean error for private mode notification persistence ( #5120 )
2019-09-05 09:21:56 -07:00
3a35233ac0
Remove ThumbnailsFeature. ( #5127 )
...
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
231924f5eb
Fix breaking services APIs changes
2019-09-05 13:38:15 +02:00
2c7fd93c7d
Update to Mozilla Android Components 12.0.0-SNAPSHOT.
2019-09-05 13:38:15 +02:00
c2db07acf8
Add browser-state component.
2019-09-05 13:38:15 +02:00
a5e9da7a55
For #5025 - Do not remove custom tab session with config removed
2019-09-05 10:57:37 +02:00
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
46b09395f8
For #5067 - Refactor ShareControllerTest following the use of SendTabUseCases
2019-09-03 12:01:26 -07:00
f7087e46e3
Fix #5067 - Refactor ShareController to use SendTabUseCases
...
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
2019-09-03 12:01:26 -07:00
ba05d21657
Fix ktlint MaxLineLength issues.
2019-09-03 10:09:06 -07:00
38d97fda8b
Stores: Reduce visibility of reducer functions.
2019-09-03 10:09:06 -07:00
2723a55b03
Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
f3d8a89c63
Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
61e84c161d
Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
22446263f1
Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
ac32a88d45
Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
76063e307a
Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
fc8fc2b33d
Fixes #4997 : Changed navigation to ShareFragment
...
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
2019-09-03 07:08:08 -10:00
709588572a
For #5055 : Crash when opening bookmarks ( #5058 )
2019-08-31 17:41:50 -05:00
4cf03be236
For #2088 : Use new async API to load default search engine in HomeFragment
2019-08-30 17:56:18 -04:00
9b633f7f0f
Move creation of GeckoRuntime to flavor-specific source set.
...
Since we are now able to build against GeckoView Nightly and GeckoView Beta,
we should create the GeckoRuntime from a flavor-specific source set.
Creating the runtime is not covered by the AC abstraction and so API changes
in GeckoView Nightly can break the build and leaves us with no option to fix
it from a shared code base. Separating the creation of GeckoRuntime
allows us to adapt individually and also to configure the runtimes
differently.
2019-08-30 15:16:12 +02:00
3abffd5d77
Use new async API to load and access search engines
...
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
2019-08-29 18:16:02 -07:00
bf5b0e5cda
For 4007 - Add unit tests for the Share Interactor, Controller and list Adapters
2019-08-29 18:12:50 -07:00
e165868a53
For #4007 - Add ShareController for handling ShareFragment's business logic
...
`ShareController` defines a contract with all possible `ShareFragment`'s
behavior changes and comes with a default implementation -
`DefaultShareController`.
It is to be delegated by all `ShareFragment`s contained Views' Interactors
following any user interactions.
2019-08-29 18:12:50 -07:00
16eba61b25
For #4007 - ShareFragment will set the contained Views' state
...
ShareFragment which acts as a container would contain all business logic needed
for populating it's Views.
Data initialization should be done only once since the app state has no reason
to change after the ShareFragment is created and is done as soon as possible,
in onAttach().
Because of the expected short lifespan of this fragment, given the fact that
the state has no reason to change and we handle orientation changes ourselves
to keep things simple I didn't use a ViewModel to persist the state.
2019-08-29 18:12:50 -07:00
095870145f
For #4007 - Refactor AppShareView in standalone Share Views
...
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
2019-08-29 18:12:50 -07:00
5e19741ddd
For #4007 - Use camelCase for views referenced from code
...
As per #4341 .
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
2019-08-29 18:12:50 -07:00
fb907033bb
Add comments to AuthCustomTabActivity
2019-08-29 15:06:34 -07:00
cea18f31c4
For #3892 : Fixes help link on nightly ( #4956 )
2019-08-29 13:27:50 -07:00
9b911f3276
Fixes #4894 : added workaround for SDK<24 vector drawable with gradient color ( #4944 )
...
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
2019-08-29 12:55:51 -07:00
f740d4382a
Closes #773 - Add shortcuts to homescreen ( #4925 )
2019-08-29 14:45:11 -05:00
5e78420cce
Fixes #3602:navigate to top of home screen after tapping "start browsing"
...
After onboarding.finish(), scrolled homeLayout to top
2019-08-29 07:45:04 -07:00
f25a9660e8
Closes #4218 : Remove forced registration renewal for push
2019-08-28 21:14:12 -04:00
18ca62b887
For #4063 : Remove SendTab feature flags
2019-08-28 21:14:12 -04:00
d87b8a8a5c
For #4658 : Add some private browsing mode telemetry ( #4968 )
2019-08-28 14:41:37 -07:00
09ed721015
For #4969 : Removes erroneous FxA sign up ping ( #4970 )
2019-08-28 14:32:43 -07:00
cc5408d717
For #2053 : Add persistent notification to close all private browsing tabs ( #4913 )
2019-08-28 12:55:24 -07:00
aa5069caca
Closes #4215 : CustomTabActivity: Remove attached session if activity is finishing. ( #4985 )
2019-08-28 11:03:04 -07:00
7b5ed2673b
For #4863 - Remove delay in HomeFragment onPreDraw
2019-08-28 13:48:14 -04:00
66a8c04967
Fixes #4488 : Shows snackbar on bookmark deletion from edit fragment ( #4792 )
...
* Fixes #4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
2019-08-28 10:12:39 -07:00
8608375eac
Use Mozilla Android Components 10.0.1.
2019-08-28 15:31:25 +02:00
681257bea7
For #4960 : Initialize push only if available ( #4964 )
2019-08-27 14:15:38 -07:00
bfb2beabe7
For #4063 - Always enable the push service ( #4932 )
2019-08-27 13:12:29 -07:00
d1964d6536
Fixes #4771 - Add method for sessions of type ( #4782 )
...
Fixes share tabs to use the new method
2019-08-27 13:04:03 -07:00
1cf8a40059
For #4295 - Adds Experiments Pref to Data Collection Settings ( #4915 )
2019-08-27 12:56:16 -07:00
c322343248
Closes #4431 : Enable feature-media component for all builds. ( #4898 )
2019-08-27 12:51:27 -07:00
a65f220b39
For #4921 - Adds WindowFeature to BaseBrowserFragment
2019-08-27 15:33:59 -04:00
24f79b3263
Fix safe browsing API breaking change. ( #4946 )
2019-08-27 13:43:22 -05:00
091778a4b9
For #4398 - add HistoryController ( #4837 )
2019-08-27 10:33:40 -07:00
dc9fdd9db3
Fixes #4067 besides snackbar ( #4777 )
...
* Fixes #4067 besides snackbar
Makes layout hierarchy more shallow to increase performance.
* Fix #4067 Feedback
Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
2019-08-27 10:09:55 -07:00
66e14959ba
Add custom tab fragment
2019-08-23 16:12:19 -04:00
ffbbe119f3
For #3967 - Invoke pending deletion on back pressed
2019-08-23 15:32:27 -04:00
b07df9698a
For #4868 - Update content description of tabs button with number of tabs
2019-08-23 09:21:32 -07:00
282c2dc182
No issue: only sync once on startup
2019-08-23 12:08:11 -04:00
b9f6f7fa93
For #4779 : Don't double navigate with global directions in HomeActivity
2019-08-23 12:01:28 -04:00
84b0693fd2
For #4652 : Use workaround for HomeScreenViewModel ( #4887 )
2019-08-22 13:35:51 -05:00
9f154dc3a0
Extract intent processors from HomeActivity ( #4884 )
2019-08-22 13:31:40 -05:00
79e58250fc
Make `Settings.instance` private
2019-08-22 08:14:08 -07:00
f62e295fc6
Closes #4874 : Use new build types in FeatureFlags class.
2019-08-22 08:12:49 -07:00
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
051ae9f584
For #3869 : Switch to A-C SearchLocalizationProvider ( #4858 )
...
* For #3869 : Switch to A-C SearchLocalizationProvider
* Fix test
2019-08-21 11:14:59 -07:00
df3e1bf9d3
Fixes #4795 fixed requestDesktopStateProvider value from private to desktopMode ( #4810 )
...
RequestDesktopStateProvider was taken from private instead of desktopMode
2019-08-21 09:10:06 -07:00
aab357845b
No issue: Clean up preferences code ( #4699 )
2019-08-21 08:38:14 -07:00
c1b1c2f332
For #3967 - Invokes pending deletion with more bookmark actions ( #4522 )
2019-08-21 08:36:41 -07:00
71a2478f4d
Use Mozilla Android Components 10.0.0
2019-08-21 10:06:05 -04:00
416e25e8a5
No issue: Don't show session provider in private mode
2019-08-20 16:09:55 -07:00
6f899c7fb5
For #2834 : Delete all Private Tabs redesign ( #4787 )
2019-08-20 13:10:08 -07:00
c076cc85f9
For #4436 : Dismiss onboarding before navigating away from home ( #4801 )
2019-08-20 10:56:28 -07:00
33f3b14c29
Adds setters and property delegates in `Settings` ( #4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
ac6c1ec2ee
Closes #2690 - Clean up CreateCollection viewmodel ( #4731 )
2019-08-20 10:45:41 -07:00
9ee8c00928
For #4774 - Use vector drawable compat ( #4811 )
2019-08-20 10:43:02 -07:00
ad98b2f3ea
For #4744 - Extract private browsing button ( #4813 )
2019-08-20 10:41:18 -07:00
090e8006b0
Color the system bars in custom tabs ( #4819 )
2019-08-20 10:13:01 -07:00
95ef312b1e
Issue #1000 - Remove isCustomTab flag ( #4656 )
2019-08-20 10:00:49 -07:00
1afc0eacd8
For #4399 : Create LibState Controller for Search ( #4673 )
...
* For #4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
ab6e7dc52b
Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
2019-08-20 13:45:55 +02:00
b8c93107c0
For #4744 - Extract TransitionPreDrawListener ( #4812 )
2019-08-19 16:27:43 -07:00
a632d8f1dc
For #4744 - Move search bar icon padding to dimens ( #4814 )
2019-08-19 16:22:51 -07:00
fb1d655d96
Closes #4822 - Update Bookmark State in onResume ( #4823 )
2019-08-19 16:22:20 -07:00
0d4eceed56
For #2706 : Refactor Glean to reduce errors ( #4753 )
...
* For #2706 : Adds recording for untracked events
* For #2706 : Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
4731977f5d
For #4421 : Fixes issues with new glean events ( #4816 )
2019-08-19 14:49:48 -07:00
73e3db8fe0
For #4804 : Resolves issue with crash reporter stack
2019-08-19 16:40:41 -04:00
210868f5bc
Use Mozilla Android Components 9.0.0-SNAPSHOT. ( #4750 )
2019-08-19 10:29:10 -07:00
806961094b
Fixes #4704 ( #4728 )
...
* Fixes #4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
2019-08-19 09:23:12 -07:00
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
de14962e3f
Extract quick action sheet observer code ( #4368 )
2019-08-19 08:28:33 -07:00
7d02354f4f
For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController ( #4800 )
2019-08-18 20:36:40 -05:00
d1aed157dd
For #4686 : Fix potential security issue ( #4764 )
2019-08-16 16:50:54 -05:00
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
a680d733c8
For #4384 : Hide mic icon if speech-to-text is unavailable ( #4701 )
2019-08-14 16:40:21 -07:00
2441592ef2
For #4516 : Use full width for large search widgets ( #4659 )
2019-08-14 16:00:13 -07:00
f71106cb51
Closes #3860 - Update description text for collections
2019-08-14 17:13:52 -04:00
b7ca520787
For #4421 : Adds Leanplum events and attributes ( #4626 )
...
* For #4421 : Adds Leanplum events and attributes
* For #4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
67f3b63ae5
For #4421 : Add search widget attribute to Leanplum ( #4694 )
2019-08-14 12:00:29 -07:00
f5ffe3734c
For #4457 : Adds telemetry for search widget actions ( #4714 )
2019-08-14 11:39:54 -07:00
2f265eccbd
For #4732 : Fix search engine display issue ( #4735 )
2019-08-14 11:03:14 -07:00
12371ca9c1
Add no-op experiment to test service-experiments integration ( #4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
2019-08-14 12:07:41 -05:00
3acabeb6c3
Use global navigation action for browser fragment ( #4691 )
2019-08-14 11:58:29 -05:00
5b4a441bcb
For #1667 : Screen reader can't reach other UI items when QAB expanded ( #4695 )
2019-08-14 09:56:29 -07:00
1328d686aa
No issue - Autoformatting ( #4715 )
2019-08-14 09:40:46 -05:00
42e3b2771e
fix #4633 : show toast only on first login ( #4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
2019-08-13 16:28:34 -05:00
5aac05859d
Fix #4436 : hide onboarding before navigating to settings ( #4675 )
...
* Fix #4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
2019-08-13 15:49:42 -05:00
d03c15d15c
Issue #4431 : Integrate feature-media component (Nightly and debug builds only). ( #4683 )
2019-08-13 15:02:20 -05:00
0c8bcd39be
For #4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
2019-08-12 15:51:49 -04:00
337ad1e88e
For #3424 - Make talkback ignore ImageButton in Collection Sele… ( #3792 )
...
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
2019-08-12 11:49:25 -04:00
b38b94ed79
Closes #4671 : Fix a potential NPE in BookmarkFragment
2019-08-12 11:16:28 -04:00
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
2019-08-09 17:27:58 -07:00
f323105163
No issue: reduce code duplication in BookmarkFragmentInteractor
2019-08-09 17:27:58 -07:00
5fe05e919a
For #4125 : Suppress coroutine warning to fix release build
2019-08-09 17:30:27 -04:00
0ec92d716f
For #4123 : Adds telemetry for quick action open in app ( #4629 )
2019-08-09 13:51:12 -07:00
6c9ce784b1
Fix, add some tests
2019-08-09 13:39:51 -07:00
2a6069bfb7
Fix rest of issues
2019-08-09 13:39:51 -07:00
Sawyer Blatz