For #4969: Removes erroneous FxA sign up ping (#4970)

app/metrics.yaml

@@ -795,17 +795,6 @@ sync_auth:
     notification_emails:
       - fenix-core@mozilla.com
     expires: "2020-03-01"
-  sign_up:
-    type: event
-    description: >
-      A user signed up for a new FxA account
-    bugs:
-      - 4421
-    data_reviews:
-      - https://github.com/mozilla-mobile/fenix/pull/4816
-    notification_emails:
-      - fenix-core@mozilla.com
-    expires: "2020-03-01"
   scan_pairing:
     type: event
     description: >

app/src/main/java/org/mozilla/fenix/components/BackgroundServices.kt

@@ -146,7 +146,6 @@ class BackgroundServices(
 
         override fun onAuthenticated(account: OAuthAccount, newAccount: Boolean) {
             if (newAccount) {
-                context.components.analytics.metrics.track(Event.FXANewSignup)
                 push.subscribeForType(PushType.Services)
             }
 

app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt

@@ -226,9 +226,6 @@ private val Event.wrapper: EventWrapper<*>?
         is Event.SyncAuthSignOut -> EventWrapper<NoExtraKeys>(
             { SyncAuth.signOut.record(it) }
         )
-        is Event.FXANewSignup -> EventWrapper<NoExtraKeys>(
-            { SyncAuth.signUp.record(it) }
-        )
         is Event.SyncAuthScanPairing -> EventWrapper<NoExtraKeys>(
             { SyncAuth.scanPairing.record(it) }
         )

app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt

@@ -26,7 +26,6 @@ private val Event.name: String?
         is Event.CollectionTabRestored -> "E_Collection_Tab_Opened"
         is Event.SyncAuthSignIn -> "E_Sign_In_FxA"
         is Event.SyncAuthSignOut -> "E_Sign_Out_FxA"
-        is Event.FXANewSignup -> "E_New_Sign_Up_FxA"
         is Event.ClearedPrivateData -> "E_Cleared_Private_Data"
         is Event.DismissedOnboarding -> "E_Dismissed_Onboarding"
 

app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt

@@ -28,7 +28,6 @@ sealed class Event {
     // Interaction Events
     object OpenedAppFirstRun : Event()
     object InteractWithSearchURLArea : Event()
-    object FXANewSignup : Event()
     object DismissedOnboarding : Event()
     object ClearedPrivateData : Event()
     object SearchShortcutMenuOpened : Event()

docs/metrics.md

@@ -653,14 +653,6 @@ tracking_protection</td>
         <td></td>
         <td>2020-03-01</td>
     </tr>
-    <tr>
-        <td>sign_up</td>
-        <td>event</td>
-        <td> A user signed up for a new FxA account</td>
-        <td><a href="https://github.com/mozilla-mobile/fenix/pull/4816#issuecomment-522643217">link</a></td>
-        <td></td>
-        <td>2020-03-01</td>
-    </tr>
     <tr>
         <td>scan_pairing</td>
         <td>event</td>

docs/mma.md

@@ -210,12 +210,7 @@ Here is the list of current Events sent, which can be found here in the code bas
     <td>`E_Sign_Out_FxA`</td>
     <td>The user successfully signed out of FxA</td>
     <td><a href="https://github.com/mozilla-mobile/fenix/pull/4626#issuecomment-519691332">#4626</a></td>
-  </tr> 
-  <tr>
-    <td>`E_New_Sign_Up_FxA`</td>
-    <td>The user successfully signed up for a new FxA account</td>
-    <td><a href="https://github.com/mozilla-mobile/fenix/pull/4626#issuecomment-519691332">#4626</a></td>
-  </tr>  
+  </tr>
   <tr>
     <td>`E_Cleared_Private_Data`</td>
     <td>The user cleared one or many types of private data</td>