8cf54f773b
Merge #5882
...
5882: For #5873 Added on/off indicator for delete browsing data on exit pref r=sblatz a=mcarare
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-11 13:22:33 +00:00
167c6dca93
For #2570 : Hide 3-dots menu for all library items when in select mode ( #5699 )
...
Removed items from RecyclerView cache to allow setting the new visibility
Disabled hidden buttons, otherwise they could still be clicked
2019-10-10 23:02:22 -07:00
980b11610b
For #5094 : Adds telemetry for show search shortcuts
2019-10-10 22:52:41 -07:00
b0d796ccee
For #5898 : Default browser toggle sends user to SUMO on Android 5&6 ( #5918 )
2019-10-10 11:16:21 -07:00
a497d2bcd0
Removes legacy nightly automation
2019-10-10 11:13:23 -07:00
8f0325c05b
For #3584 - Check if menu is open before showing a new one ( #5674 )
...
Could have implemented this check (if menu is showing) inside the show() method
of BrowserMenu but this would mean the client (us) would go to the process of
building a new menu and then trying to have it displayed only for this to be
ignored by BrowserMenu in a somewhat opaque way.
Having this check done as soon as possible offers us full control and avoids
the unnecessary steps for building an already shown menu.
2019-10-10 06:37:47 -07:00
17d183ea0b
Closes #5913 : Add new sessionToken scope
2019-10-09 17:44:41 -07:00
8e17ac05b1
Optimized imports. Closes #5876
2019-10-10 04:17:43 +05:30
f907ec52f0
Removed ObsoleteCoroutinesApi in tests. Closes #5876
2019-10-10 04:04:51 +05:30
ed239ec250
For #373 - Integrate leanplum-fcm
2019-10-09 14:43:48 -07:00
7552bacb32
For #778 : Follow-up to fix find in page
2019-10-09 17:14:14 -04:00
f9afd97a68
For #1901 - Get rid of black flash when leaving GV Engine
2019-10-09 11:02:21 -07:00
6ec0d46f6b
Closes #394 - Trusted Web Activities ( #5391 )
2019-10-09 09:17:49 -07:00
788e52be0c
For #5873 Added on/off indicator for delete browsing data on exit pref
2019-10-09 11:55:37 +03:00
e9760fb185
Closes #5847 : Use IO thread when submitting crash report
2019-10-08 18:46:14 -07:00
78bc829735
Closes #778 - Progressive Web Apps! ( #4914 )
2019-10-08 16:50:15 -07:00
411ccc8f1f
For 4780: add DefaultBrowsingModeManager tests
2019-10-08 15:13:17 -07:00
c9e68bda31
For 4780: remove Settings#usePrivateMode and tests
2019-10-08 15:13:17 -07:00
dd6439269b
For 4780: ThemeManager now sends an intent before recreating
...
Updating themes recreates the activity, so if we aren't persisting 'usePrivateMode', we need to pass it to the new instance
2019-10-08 15:13:17 -07:00
693034951c
For 4780: rename 'setPrivateModeIfNecessary'
2019-10-08 15:13:17 -07:00
d1d20b544e
For 4780: update HomeActivity to maintain private mode in memory
...
As an added bonus, this makes the temporal coupling between `setPrivateModeIfNecessary` and `setupThemeAndBrowsingMode` explicit. They previously would have broken if called in reverse order, now it will fail to compile.
2019-10-08 15:13:17 -07:00
10f334303d
For #4780 : remove previous fix for leaking private mode status
...
This didn't function when 'open links in a private tab' was set. Rather than adding another sketchy fix for the edge case, following commits will change `usePrivateMode` to be maintained in memory, instead of in Settings.
2019-10-08 15:13:17 -07:00
4045fb0107
For #4190 : Removes waterfall animation from awesomebar
2019-10-08 09:14:23 -07:00
6484a48147
For #5787 : Fixes shortcuts asking to launch private alias ( #5825 )
2019-10-08 08:40:28 -07:00
1c6aefd82b
For #3604 Snackbar messages for closing tabs use closed instead of deleted
2019-10-08 17:06:02 +03:00
0e3148f0da
fixing more reviewers comments
2019-10-08 09:56:29 +02:00
44f4cedefd
Add fxa/sync integration tests
...
fixing Jenkins path to tests and clean tests
commenting future tests and adding doc with info about the tests
2019-10-08 09:56:29 +02:00
d5c3433041
Use the new fragment constructor
2019-10-07 11:07:48 -07:00
a4439ff373
For #3563 . Use `ListAdapter` for App Share list.
2019-10-07 10:41:48 -07:00
e55eda30fb
For #3563 . Use `ListAdapter` for Bookmark folder selection list.
2019-10-07 10:40:55 -07:00
f6285ad5f8
For #3846 - Pass in updated session icon to tabs
2019-10-07 09:38:43 -07:00
d028c97112
For #5213 - Use support library attributes
2019-10-06 16:17:00 -07:00
80a1e6dd2c
Fixes #5351 - listen to onIconChanged in HomeFragment
2019-10-06 10:41:34 -07:00
fe648a0b99
Fixes #5351 - use session icon in tab view on home
2019-10-06 10:41:34 -07:00
2b19b28d25
For #5651 - Set up Standard vs Strict Tracking Protection Experiment
2019-10-05 10:14:09 -07:00
19a2d9df4f
For #1620 : Hide search results when they match URL
2019-10-04 14:05:55 -07:00
22eb207cef
For #5784 : Fix hiding default browser preference in sdk<=23
2019-10-04 12:41:12 -07:00
b7647a454f
For #5599 : Remove dependency on fetch_httpurlconnection ( #5716 )
...
* For #5599 : Remove dependency on fetch_httpurlconnection
* For #5599 : Switch Glean to GeckoViewFetchClient
* Use existing Gecko client for Glean
2019-10-04 12:28:23 -05:00
40e6284aef
For #5442 - Show Delete Browsing Data on Quit option in home menu
2019-10-04 09:26:59 -07:00
841b06b02f
No issue: fixes master ( #5777 )
2019-10-03 14:42:56 -07:00
371e2ac3d8
For #514 & #5742 : Updates "launch links in private tab" functionality ( #5721 )
...
* For #514 & #5742 : Updates "launch links in private tab" functionality
* Fixes comments
2019-10-03 12:43:33 -07:00
b733e4fa8f
Upgrade to Mozilla Android Components 16.0.0-SNAPSHOT
2019-10-03 11:07:26 -07:00
3be06953d6
For #4780 switch off private mode ( #5614 )
...
* Do not launch in Private Mode
When the app launches do not launch in Private Mode in order to prevent usage leaks to other users of the device.
* Issue #4780 : add comments to use private mode
* For #4780 : write tests for clear private mode on create app
* For #4780 : clear private mode when privacy notification is removed
2019-10-03 10:23:13 -07:00
e8216e3079
For #5094 : Adds telemetry for suggestion toggles ( #5704 )
2019-10-03 10:03:14 -07:00
785b8b9519
For #5567 : Removes search shortcuts button ( #5739 )
...
* For #5567 : Removes search shortcut button
* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
2896b36d14
No issue: Updates naming of launch links privately var ( #5701 )
...
The previous name was pretty confusing
2019-10-02 12:11:21 -07:00
eb3c9f86e2
No issue: Removes feature flags for delete data ( #5738 )
2019-10-02 10:43:37 -07:00
f7c9ab11eb
For #3487 - Add back open image in new tab
2019-10-01 12:45:09 -07:00
a250241523
1585250: Initialize metrics off of the main thread
2019-10-01 10:29:54 -07:00
669e694af9
For #5672 : Fixes broken send tab link
2019-09-30 16:13:40 -07:00
69c42b6192
For #5681 : Sets OPEN_TO_BROWSER false when using new tab shortcut
2019-09-30 14:56:16 -07:00
e9a0f1f65d
For #2078 - Filter Out Self in Share Sheet ( #5641 )
2019-09-30 12:43:47 -07:00
c8af16bd47
For #5679 : Hides autoplay behind feature flag ( #5685 )
2019-09-30 12:01:04 -07:00
ef29fe2584
Update BackgroundServicesTest, Suppress Complex Method
2019-09-30 10:33:56 -07:00
a4097cd380
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-30 10:33:56 -07:00
8f97d247a6
For #235 - Add Glean crash count + docs.
2019-09-30 08:32:33 -07:00
3e42114190
For #5656 : Fixes nightly major version number crash
2019-09-27 15:06:57 -07:00
a38b73f19e
Fixes #5653 : Removes crash with null campaign
2019-09-27 15:01:00 -07:00
64923978e6
For #1071 Added Desktop Mode icon
2019-09-27 09:47:10 -07:00
5e18ead45e
For #4474 : Adds tests and fixes issues
2019-09-27 08:59:05 -07:00
ee1f040e53
No issue: Move signedIn tracking to BookmarksSharedViewModel ( #4755 )
2019-09-27 08:57:38 -07:00
7f328a6dc4
For #1298 : Adds adjustCampaignId to core ping ( #5579 )
2019-09-27 08:56:33 -07:00
6babf72352
For #5197 : Adds telemetry for media notification ( #5520 )
2019-09-27 08:02:29 -07:00
88aa519210
Closes #4711 - Extract VoiceSearchActivity ( #5502 )
2019-09-27 07:54:29 -07:00
3f41a4e9c6
No issue: Update navigation library
2019-09-26 17:01:13 -07:00
11baabb63a
No issue: Updates fact mapping to use enums
2019-09-26 17:00:51 -07:00
c3287b17ac
Closes #5624 - Fix crash on preference change listener
2019-09-26 16:56:54 -07:00
62ae025d65
For #4991:Ensured deleteSelectedBookmarks deletes all selected bookmarks ( #5559 )
...
Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
2019-09-26 16:52:59 -07:00
dffa61bf16
Closes #4513 : fixes bookmark tests broken by loading change
...
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
2019-09-26 16:29:14 -07:00
fd7f1b2665
Closes #4513 : adds tests for bookmark loading state
2019-09-26 16:29:14 -07:00
fbdd537bc7
Closes #4513 : show progress bar when loading bookmarks
2019-09-26 16:29:14 -07:00
ca6c324f29
Issue #4513 : added isLoading to bookmark state
...
This was added to the state object as a top level param because it could reasonably coexist with any value of `tree` or `mode`. Even if we don't now, we may someday want to display a loading indicator while also showing cached bookmarks.
For now, we set isLoading to false whenever we receive any bookmarks
2019-09-26 16:29:14 -07:00
96472a533a
Issue #4513 : fix mismatched bookmark listener lifecycles
...
The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed.
We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!
2019-09-26 16:29:14 -07:00
de93b05cac
For #2754 Add tab cards to share sheet ( #5493 )
...
* For #2754 Add tab cards to share sheet
* For #2754 : Fix background near rounded corners and ShareButtonAppearanceTest
* Add license to share_tab_item
2019-09-26 14:25:34 -07:00
ac2611d744
Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) ( #5578 )
...
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT
* Update findinpage integration to use browser-state
* Use new UseCases APIs after download migration.
2019-09-26 12:50:50 -07:00
c5330c6880
For 5092 - Show a Snackbar with retry option if sharing to devices fails ( #5158 )
...
* For #5092 - Show a Snackbar with retry option if sharing to devices fails
ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.
* For #5092 - Refactor ShareControllerTest
* For #5092 : Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
0b01635ce0
For #2874 , #5375 , #5131 - submitList workaround for Android 5 + 6
2019-09-25 19:59:07 -07:00
44bb592b43
For #5312 - Send ETP Strict/Standard event
2019-09-25 15:23:30 -07:00
24b3ed4384
For #5568 - Don't pass in Session for QuickActionSheetController
2019-09-25 13:33:38 -07:00
b0b60aa27d
For #5281 - Use TrackerLog for reporting ETP categories ( #5556 )
2019-09-25 10:48:06 -07:00
b6e6e36ccd
For #561 : Fix stutter of search icon & text when animating
2019-09-25 10:06:38 -07:00
75a25c9bd0
For #561 : Fix linting issue
2019-09-25 10:06:38 -07:00
c592a69aad
For #561 - Fixes snackbar placement on homeview
2019-09-25 10:06:38 -07:00
5c092c1ef1
For #561 - Adds shadow/highlightto the bottom bar
2019-09-25 10:06:38 -07:00
00d1be97ac
For #561 - Wires up add tab button inside the bottom bar
2019-09-25 10:06:38 -07:00
b16754d78a
For #561 - Adds add tab and menu button to bottom bar
...
- Adds space between wordmark and session control component
2019-09-25 10:06:38 -07:00
abbb310ce3
For #561 - Removes the toolbar from the home screen
...
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
2019-09-25 10:06:38 -07:00
bfe8bf4663
For #1383 Added tab title to close button content description
2019-09-25 10:34:02 +03:00
1c9c5317eb
For #5552 - Temporary fix for startup crash on es locales
2019-09-24 19:21:47 -07:00
856399e9e2
No issue: Fixes GleanMetricsService nits & broken UI test ( #5539 )
...
* No issue: Fixes GleanMetricsService nits
* No issue: fixes broken UI test
2019-09-24 16:12:09 -07:00
1ffdf1cf9b
Add basic test coverage for Glean metrics in Fenix
...
This introduces test coverage, using the Glean SDK
testing API, for the metrics that are set at startup
by Fenix in the GleanMetricsService.
This additional adds a basic test for the translation
of the `app_opened` event.
2019-09-24 12:33:14 -07:00
25e2a7abfc
For #2765 - Run places maintenance daily ( #5466 )
2019-09-24 10:50:11 -07:00
c7c752cabb
For #5356 Improves private browsing "common myths" link accessibility ( #5479 )
...
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
2019-09-24 10:46:34 -07:00
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
734d4031e2
Extract UriOpened observer from HomeActivity
2019-09-24 09:37:24 -07:00
e3c60faf24
Move BookmarkNode extensions to helper class ( #4752 )
2019-09-24 09:17:29 -07:00
236f702bbe
For#5468 Changed info source for url clipboard copy from view to session ( #5514 )
2019-09-24 07:56:59 -07:00
cb7701584f
No issue: Extract home fragment mode ( #5343 )
2019-09-23 09:33:55 -07:00
9d9ff959b5
For #5312 - Add Telemetry for Tracking Protection
2019-09-23 08:29:45 -07:00
c866ae1a1e
Closes #5444 : IntentReceiverActivity: Add tests for intent processing
2019-09-20 19:44:05 -04:00
f02603be37
For #5460 : Fixes styling of fill link from clipboard ( #5464 )
2019-09-20 15:29:16 -07:00
4a6e647167
For #5197 : Adds telemetry for media controls ( #5266 )
2019-09-20 14:49:27 -07:00
6c30a94081
Move settings classes to packages
2019-09-20 12:36:15 -07:00
699eacab39
For #778 - Rename CustomTabActivity
2019-09-20 12:35:12 -07:00
e9fd6892ba
For #394 , #778 - Add hide toolbar feature
...
And also add CustomTabsServiceStore
2019-09-20 12:34:49 -07:00
78ac6fc912
For #5448 - Reload custom tab session when TP is toggled
2019-09-20 12:30:02 -07:00
a63eaa9d67
1581556: Initialize Glean on the main thread
2019-09-20 12:29:40 -07:00
47064a68e0
For #5141 Changed "learn more" link to be accessible to Talkback users
2019-09-20 12:29:02 -07:00
172a9cf06c
Extract and test crash reporter code
2019-09-20 11:04:11 -07:00
464122fda1
For #5421 - Make share dialog scrim dismiss fragment
2019-09-20 09:52:39 -07:00
5577470d0b
No bug - Add WebCompat feature.
2019-09-20 08:33:48 -07:00
f71ec8928b
Add note about lazy in FeatureFlags
2019-09-20 08:33:29 -07:00
6f3d7b4ee8
For #5396 : Adds "always launch in private mode" to settings
2019-09-20 08:33:07 -07:00
a1c8fc0698
For #3731 Improved UX for opening tabs from a Collection ( #5427 )
...
* For #3731 Changed order of items for a collection's overflow menu
* For #3731 Changed the order tabs open to keep same order from collections
2019-09-20 06:41:04 -07:00
05a4faec78
Add tryGetHostFromUrl and update ExceptionDomains
2019-09-19 22:40:35 -04:00
1aa4f5a519
For #255 : Toggle Media Autoplay
2019-09-19 15:13:04 -07:00
2db2d9ceae
For #1744 : Adds tests for clipboard
2019-09-19 08:24:27 -07:00
fd1fcd8b89
For #4155 : Adds paste & go for search terms
2019-09-19 08:24:27 -07:00
e961a9d63d
For #1744 : Adds clipboard provider to search engine screen
2019-09-19 08:24:27 -07:00
1777b5a830
Use enum to simplify delete on quit code
2019-09-18 20:20:08 -07:00
106458c2c9
For #3440 - Reduce HomeFragment require calls
2019-09-18 17:25:44 -07:00
976c840047
For #3077 - Replaces connect another device dialog with a scree
2019-09-18 17:24:43 -07:00
065ce13999
Pass color resource for what's new menu item by id
2019-09-18 16:41:03 -07:00
50cd2920d3
For #5371 : Updates search engine settings string ( #5393 )
2019-09-18 11:26:44 -07:00
e1b84a7a08
For #5396 : Reverts broken activity alias
2019-09-17 18:35:31 -07:00
284cbab9ea
Use .orEmpty()
2019-09-17 11:09:21 -07:00
3e132f102c
No issue: Update androidx libraries Sept 5 2019
2019-09-17 09:50:31 -07:00
1767bd5569
For #5174 Changed FindInPage height to toolbar height to cover QAB ( #5376 )
2019-09-17 05:47:17 -07:00
2b71af4087
For #5258 - Pop AccountProblemFragment if signed out
2019-09-16 21:26:01 -07:00
8a9340fd9d
Post: Clean up 'push' initialization code
2019-09-16 19:44:13 -07:00
d67fb3eed2
Post: Add experiment flags, push and telemetry tests for BackgroundServices
2019-09-16 19:44:13 -07:00
eeaeb973ff
Post: minor cleanup
2019-09-16 19:44:13 -07:00
c2fb99a73f
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-16 19:44:13 -07:00
a61391ef58
Separates tracker bucket sorting code
2019-09-16 15:16:12 -07:00
140da0dd0f
For #5359 , #5360 - Update ETP Vectors for Android 5+6
2019-09-16 15:01:29 -07:00
9ebd4efe70
Pass app name to delete browsing data prompt
2019-09-16 09:59:42 -07:00
b8539ccb33
Use new feature-contextmenu API.
2019-09-16 17:24:13 +02:00
42bb3e1410
Change deleteAndQuit to take an activity
2019-09-15 20:03:04 -07:00
da37dedba3
For #5279 - Don't use runBlocking in delete and quit
2019-09-14 11:18:43 -07:00
8cd0d8faf3
For #5304 - Align ETP Onboarding Tool Tip PopupWindow
2019-09-13 18:25:26 -07:00
3787dd7b1f
For #5254 : Fix transition to private browsing mode after sharing a page
2019-09-13 14:44:28 -07:00
e247870b9f
For #5277 : Updates string for delete browsing data ( #5309 )
2019-09-13 10:18:25 -07:00
dd85229c41
Use new feature-downloads API.
2019-09-13 15:01:25 +02:00
42b31f0088
For #4155 : Adds elevation to copy/paste menu
2019-09-12 14:03:12 -07:00
c8bc144114
For #2570 : Hide 3-dots menu when in select mode for bookmarks and history ( #5173 )
...
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
2019-09-12 13:56:39 -07:00
b83ae45c36
For #5263 - Hide ETP Panel Settings for custom tab
2019-09-12 10:45:35 -07:00
4acf48e817
Fixes #5212 - Change tint in onCreateOptionsMenu
...
Also fixes #5213
2019-09-12 10:30:49 -07:00
bc16061939
For #3371 : Show snackbar message when share fails with crash ( #5210 )
2019-09-12 09:26:24 -07:00
fcb0448fa5
For #4458 - Enable font inflation with font auto size setting ( #5252 )
2019-09-12 09:05:16 -07:00
4461230e9b
For #5229 , #5228 - Dismiss ETP panel on back press, don't truncate text
2019-09-12 07:40:49 -07:00
a5859e0028
For #5178 - Polish delete browsing data item layout
2019-09-11 18:11:26 -07:00
102a36bd7e
No issue: Updates isPWA to isInstallable for AC 13 snapshot
2019-09-11 18:10:52 -07:00
b3eca65614
Closes #5091 : Refactor Sentry BreadCrumbs to use lib-crash BreadCrumbs
2019-09-11 16:14:42 -07:00
e092dfd684
For #5047 - Addresses nits
...
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
2019-09-11 16:10:54 -07:00
d18ec49704
For #5047 - Wires up dialog to webAppUseCases
2019-09-11 16:10:54 -07:00
faff73b9b3
For #5047 - Creates dialog ui for naming a shortcut
2019-09-11 16:10:54 -07:00
e3209dcc84
For #3700 - Add Setting to Delete Data on "Quit" menu action
2019-09-11 16:06:18 -07:00
ddc1b2e648
For #4658 : Add private browsing mode shortcut telemetry
2019-09-11 16:03:22 -07:00
418b1ba890
For #1749 - Use Strict ETP by default, use Feature Flag for Settings
2019-09-11 16:03:01 -07:00
999d3cb963
For #1114 : Show playing tab
2019-09-11 15:45:22 -07:00
9a4610f068
For #2897 - Add Action States To Share Sheet
2019-09-11 11:32:26 -07:00
2e2bac4ccd
For #419 : Create launch icon for private browsing ( #4948 )
2019-09-11 10:52:33 -07:00
5586b18c3e
For #4155 : Handle custom tabs & fix test
2019-09-11 09:03:17 -07:00
53b3f105ca
For #4155 : Sets pastedText default value
2019-09-11 09:03:17 -07:00
9d30d7bb03
For #4155 : Restyle to custom menu
2019-09-11 09:03:17 -07:00
52fd327bc0
For #4155 : Adds tests for browser toolbar popup menu
2019-09-11 09:03:17 -07:00
fdd2b59fb8
For #4155 : Adds popup menu for browser toolbar
2019-09-11 09:03:17 -07:00
4485b7f647
Add Tracking Protection Info Panel
2019-09-11 07:47:13 -07:00
ef4a6b4154
For #4877 : Restored logic for closing tabs when not on browserFragment
...
Added return in function when saving collections coming from browser fragment
2019-09-10 21:42:16 -07:00
e240de7e31
For #4908 : Adds telemetry for send tab
2019-09-10 20:58:12 -07:00
d0ef2d40c2
Move bookmark navigation listener to separate file
2019-09-10 16:53:09 -07:00
f7dde41b3b
For #5021 : Adds telemetry for what's new button
2019-09-10 14:15:34 -07:00
3c07cacf4d
Use A-C preferences property delegates
2019-09-10 13:19:00 -07:00
b77c4d2e2e
Clean up SupportUtils
2019-09-10 10:16:04 -07:00
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
2019-09-10 09:04:05 -07:00
16115f57d1
For #3440 - Reduce BrowserFragment require calls
2019-09-09 21:33:32 -07:00
4c2a7ac10e
Delete AUTH_SESSIONS with COOKIES
2019-09-09 12:32:28 -07:00
758f4c13ec
Updates per UX and PR feedback
2019-09-09 12:32:28 -07:00
2b9efccfca
For #3106 : Granular options for clearing user data
2019-09-09 12:32:28 -07:00
53341f620a
Code cleanup - Remove unused FindInPageBarBehavior
...
There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
2019-09-06 14:20:02 -04:00
716cf3995a
Fix #4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature
...
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().
This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
2019-09-06 14:20:02 -04:00
ed0b6bd5ef
For #4193 - Makes close button for tabs more accessible ( #4442 )
...
* fixes #4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
2019-09-06 10:33:55 -07:00
aef087aae0
No issue: Removes unused nestedScrollQuickActionView ( #5143 )
2019-09-06 09:03:24 -07:00
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
ccd9e44a3e
No issue: Add logging for firebase/autopush
2019-09-05 16:03:36 -04:00
58287cd5bb
For #5033 - Update browsing mode when session selected ( #5118 )
2019-09-05 14:27:30 -05:00
bb2a685ad9
For #5075 - Fix boolean error for private mode notification persistence ( #5120 )
2019-09-05 09:21:56 -07:00
3a35233ac0
Remove ThumbnailsFeature. ( #5127 )
...
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
231924f5eb
Fix breaking services APIs changes
2019-09-05 13:38:15 +02:00
2c7fd93c7d
Update to Mozilla Android Components 12.0.0-SNAPSHOT.
2019-09-05 13:38:15 +02:00
c2db07acf8
Add browser-state component.
2019-09-05 13:38:15 +02:00
a5e9da7a55
For #5025 - Do not remove custom tab session with config removed
2019-09-05 10:57:37 +02:00
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
46b09395f8
For #5067 - Refactor ShareControllerTest following the use of SendTabUseCases
2019-09-03 12:01:26 -07:00
f7087e46e3
Fix #5067 - Refactor ShareController to use SendTabUseCases
...
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
2019-09-03 12:01:26 -07:00
ba05d21657
Fix ktlint MaxLineLength issues.
2019-09-03 10:09:06 -07:00
38d97fda8b
Stores: Reduce visibility of reducer functions.
2019-09-03 10:09:06 -07:00
2723a55b03
Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
f3d8a89c63
Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
MozLando