a72620ae07
For #7522 Catch IllegalArgumentException when validating search string
2020-01-10 11:26:11 -08:00
718c211a86
For #1718 : Sets accessibility users to top toolbar by default ( #7486 )
2020-01-09 09:15:02 -08:00
e6791b5c08
For #7154 - Fix crash when tapping on "Blocked" in the site info panel ( #7404 )
2020-01-08 13:51:45 -08:00
2bdde48986
For #7522 Ensure correct protocol is used in search string
2020-01-08 11:13:49 -08:00
8ed14ac062
Issue 5736 Improve pop behavior after deleting tabs in settings ( #7478 )
2020-01-08 10:27:14 -08:00
9c28cb632c
Issue #7425 (et al): Cache the list of installed browsers
...
Cache the list of installed browsers. Calling `Browsers.all`
the application directly redundantly recalculates the list.
Accessing the list of installed browsers through this cache
will reduce that overhead.
2020-01-07 18:40:07 -08:00
ea2411a88b
Feature/#220 language menu ( #7070 )
...
* For #220
- Added advanced header + locale settings item in the settings fragment
* For #220
- Added locale selection page with lib state + handling of locale changes
* For #220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario
* For #220
- Added unit tests for locale settings page
* For #220 : fixed an outdated unit test
ga-a
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2020-01-03 18:15:35 -08:00
c7c4ad051a
For #6413 : Adds more snackbar positioning logic ( #7444 )
...
* For #6413 : Adds more snackbar positioning logic
* Refactor
2020-01-02 14:31:52 -08:00
3fb060f682
For #6413 : Fixes snackbar positionining for bottom toolbar ( #7415 )
...
* For #6413 : Fixes snackbar positionining for bottom toolbar
* For #6413 : Cleans up snackbar usage
2019-12-30 14:43:15 -08:00
13f73c2d2c
For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. ( #7246 )
...
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
2019-12-30 14:42:13 -08:00
593981fa4b
Fix parameterized message in search engine ( #7302 )
2019-12-20 10:27:05 +02:00
b85673acac
Clean up settings fragments
2019-12-19 14:29:28 -08:00
907d96e39f
For #6709 , for #6849 Handle default engine deletion and undo operation
...
Uninstall engine immediately and allow reinstall in onCancel.
Set previous list with default engine in onCancel.
Keep default engine change in operation and remove now unnecessary view refresh.
2019-12-18 23:00:42 -08:00
e727ae5d7e
Fix 5366 - Use VectorDrawableCompat for all imagery ( #7221 )
...
* Fix 5366 - Use VectorDrawableCompat for all imagery
* Fix detekt lint issues
* Restore previous comment contents
2019-12-16 20:35:36 -08:00
bc6b7725e9
For #6968 Close response stream to allow use of caching
2019-12-13 12:35:25 -08:00
d2abac78eb
For #7075 Update passwords preference visibility and string
...
Set visibility for feature flags before settings screen it's displayed.
Change string for preference to match existing header string.
Update UI Tests
2019-12-13 12:19:14 -08:00
b819cb11c9
For #4776 : Added Unit tests for About Page.
2019-12-12 11:34:10 +02:00
c6c827f693
For #4776 : Redesign and refactor the About Page
...
Added new items to be displayed.
2019-12-12 11:34:10 +02:00
6e9769a81b
For #7031 - Hide progress bar when leaving DeleteBrowsingDataFragment ( #7056 )
2019-12-10 11:17:45 -05:00
45ae8cb35a
For #6997 Avoid overwriting empty_search_string error ( #6998 )
...
Setting error twice also clips error message
2019-12-09 18:10:24 -08:00
76e9200304
For #6922 - Check current destination is logins fragment before navigation ( #6924 )
2019-12-09 15:42:40 -08:00
eb6e6b774f
For #6848 - Sorts the search engine list without case sensitivity
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
1cc496a683
For #6847 - Properly rebuilds the SearchEngineList on undo
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
d8babadf7f
For #6889 - Check current destination before navigating from settings
2019-12-02 10:40:21 -08:00
f5cf0b7e2a
For #6890 - Don't crash with no connection when adding custom search engine
2019-12-02 10:37:31 -08:00
1b1f9348dc
No Issue - Fixes warnings / compiler errors with A-C update
2019-11-28 12:45:45 +01:00
7cf71c8ef3
For #6396 - Added metrics for tracking history/bookmarks account sync toggles ( #6601 )
2019-11-27 11:16:23 +02:00
769c1e422d
For #5694 & #6054 : Allows users to change toolbar position ( #6608 )
...
* For #5694 & #6054 : Adds preference screen for toolbar
* For #5694 : Adds changing toolbar position functionality
* No issue: Updates telemetry links to actually work lol 😬
* For #6054 : Adds toolbar position to core ping
2019-11-25 16:43:32 -08:00
422faaf7c0
Add toolbar helpers ( #6531 )
2019-11-25 15:36:47 -05:00
afac413c98
Add ETP accessibility labels
2019-11-21 15:27:35 -08:00
1d36098878
For #1019 Add onboarding search suggestion hint panel
2019-11-21 14:36:14 -08:00
5543f3272d
For #1019 Add option to enable search suggestions in private mode
2019-11-21 14:36:14 -08:00
54773afb68
For #2477 - Removes the feature flag for Force Enable Zoom ( #6646 )
...
* For #2477 - Removes the feature flag for Force Enable Zoom
* For #2477 - Fixes bug where zoom preference doesnt persist between launches
2019-11-20 10:32:38 -08:00
607c3d4c87
Adds custom search engines ( #6551 )
...
* For #5577 - Adds button to add a new search engine
* For #5577 - Adds custom engine store
* For #5577 - Creates a custom SearchEngineProvider
* For #5577 - Gives the ability to delete search engines
* For #5577 - Adds the UI to add a custom search engine
* For #5577 - Adds form to create a custom search engine
* For #5577 - Adds the ability to add a custom search engine
* For #5577 - Adds the ability to delete custom search engines
* For #5577 - Selects the first element on the add custom search engine screen
* For #5577 - Prevents adding a search engine that already exists
* For #5577 - Styles the add search engine preference
* For #5577 - Makes the name check case-insensitive
* For #5577 - Fix bug where home screen doesnt see new search engines
* For #5577 - Moves Search URL validation to its own type
* For #5577 - Fixes linting errors
* For #5577 - Adds the ability to edit a custom search engine
* For #5577 - Allows the user to edit a serach engine even when it is the last item in the list
* For #5577 - Adds an undo snackbar when deleting a search engine
* For #5577 - Moves all of the strings to be translated
* For #5577 - Fixes bug when deleting your default search engine
* For #5577 - Puts adding search engines behind a feature flag
* For #5577 - Navigate to custom search engine SUMO article when tapping learn more
* For #5577 - Fixes nits
* For #5577 - Uses concept-fetch to validate search string
* For #5577 - Adds string resources for the cannot reach error state
2019-11-19 16:30:56 -08:00
c69e72bdba
Fix 3809 - Show entire URL in security info view
2019-11-18 14:01:40 -08:00
cc318021cc
For #5586 - Adds Logins Telemetry ( #6352 )
...
* For #5586 - Adds Logins Telemetry
* Adds Logins Sync Telemetry to PreferenceToggled event
2019-11-12 15:55:36 -08:00
6ee59322b5
Added Vibration Effect On Scanning QR Code ( #6129 )
...
* Added Vibration Effect On Scanning QR Code
Added Vibration Feature for the new feature Request
Vibrate phone upon successful pairing #2928
* Added Vibration Effect On Scanning QR Code
Added Vibration Feature for the new feature Request
Vibrate phone upon successful pairing #2928
* Update PairFragment.kt
Removed unwanted blank lines
* Update PairFragment.kt
Removed the Casting with !!
2019-11-08 13:37:36 -08:00
d9615108ee
For #6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default
2019-11-08 08:37:15 -08:00
40047315c2
For #6490 - track abnormal FxA behaviour via Sentry
2019-11-07 15:11:41 -08:00
4183dea591
For #5547 : Reuse biometricPrompt when authenticating
...
This fixes an issue with Samsung devices where an invisible DeviceCredentialHandler because the executor was "null" (it wasn't actually)
You *must* reuse the biometric object instead of creating a new one.
2019-11-07 13:45:41 -08:00
3e2b88cc91
For #5547 - Add top level auth when accessing passwords
2019-11-07 13:45:41 -08:00
18c0525ff6
Use new API for ETP Exceptions
2019-11-05 12:45:58 -08:00
1ee0703bc3
For #6441 - Only enable experiments for Beta/Prod
2019-11-04 16:45:35 -08:00
c5739df969
For #4126 - Add tests for the new classes resulting from refactoring
...
Used runBlocking to ensure we wait for the code using coroutines to execute
instead of runBlockingTest and join() since this last option led to failed
tests in CI because of
"java.lang.IllegalStateException: This job has not completed yet".
2019-10-31 17:08:40 -07:00
9f56624788
For #4126 - Document the newly introduced public APIs
...
Now that the code should be in a ready-to-ship form it would be nice to have
all the major functionalities properly documented.
2019-10-31 17:08:40 -07:00
d70afcaa90
For #4126 - Handle all business logic with Interactors and a Controller
...
Combined all Stores into one for all Views shown in on Fragment.
Used a static `createStore()` which will build the initial state residing
inside the Store and not in the Fragment as to decouple the Fragment from the
business logic needed to build all the needed initial States.
Added Interactors that handle a MVI View's business logic for
TrackingProtectionView and WebsitePermissionsView.
WebsiteInfoView doesn't register any user input events and does not have any
reason to change while it is displayed so it does not have an Interactor.
The two Interactors will delegate Fragment's QuickSettingsController for
complex Android interactions, communication with other app features or for
Store updates.
Also refactored the stubs from the previous commit so that with this commit the
the quicksettings feature should all be working now based on lib-state.
2019-10-31 17:08:40 -07:00
f1f74bc3d6
For #4126 - Refactor Views and layouts
...
Refactored `fragment_quick_settings_dialog_sheet` to now be composed of of
FrameLayouts placeholders in which each independent View will inflate itself.
Refactored the QuickSettingsUIView and Component to 3 standalone Views with
their own lib-state components: Store, State, Actions, Reducer.
2019-10-31 17:08:40 -07:00
6290c0c826
Closes #2441 . Update LeakCanary to `2.0-beta-3` version.
2019-10-24 11:19:09 -07:00
f49331de55
For #5544 : Bare Minimum Logins UI
2019-10-24 10:29:03 -07:00
d1643b785e
For #2477 - Adds accessibility setting to force enable zoom
2019-10-24 09:35:21 -07:00
ef42d3e4dc
Fixes #5030 : Modified Dialog to match the others. ( #6022 )
...
I changed the Dialog from permissions exceptions and used AlertDialog
instead of Context.alert extension function.
2019-10-21 09:59:04 -07:00
d223a0bd35
Closes #5465 : Added OnCheckListener to all checkboxes ,when there are no items checked delete button will be disabled ( #6098 )
2019-10-21 09:57:29 -07:00
485ccba189
Fixes #5323 : Show a snackbar while browsing data is deleting. ( #6105 )
2019-10-21 09:57:06 -07:00
a598148b29
Fixes #5225 - Hide AuthCustomTabActivity
2019-10-18 10:56:06 -07:00
052695ffa1
Issue #5233 : Minor modifications suggested in code review.
2019-10-14 11:20:18 -07:00
9913a024d8
Issue #5233 : Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "add private browing shortcut" item is visible in the settings menu.
2019-10-14 11:20:17 -07:00
8e4d7248ac
Merge #5908
...
5908: Closes #5876 : Removed @ObsoleteCoroutinesApi in tests r=sblatz a=shldhll
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
Co-authored-by: shldhll <iam.shldhll@gmail.com>
2019-10-14 16:52:22 +00:00
2395b9b941
For #5898 : Launch SUMO article properly for default browser
2019-10-11 14:40:08 -07:00
8cf54f773b
Merge #5882
...
5882: For #5873 Added on/off indicator for delete browsing data on exit pref r=sblatz a=mcarare
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-11 13:22:33 +00:00
b0d796ccee
For #5898 : Default browser toggle sends user to SUMO on Android 5&6 ( #5918 )
2019-10-10 11:16:21 -07:00
8e17ac05b1
Optimized imports. Closes #5876
2019-10-10 04:17:43 +05:30
f907ec52f0
Removed ObsoleteCoroutinesApi in tests. Closes #5876
2019-10-10 04:04:51 +05:30
788e52be0c
For #5873 Added on/off indicator for delete browsing data on exit pref
2019-10-09 11:55:37 +03:00
d5c3433041
Use the new fragment constructor
2019-10-07 11:07:48 -07:00
22eb207cef
For #5784 : Fix hiding default browser preference in sdk<=23
2019-10-04 12:41:12 -07:00
371e2ac3d8
For #514 & #5742 : Updates "launch links in private tab" functionality ( #5721 )
...
* For #514 & #5742 : Updates "launch links in private tab" functionality
* Fixes comments
2019-10-03 12:43:33 -07:00
785b8b9519
For #5567 : Removes search shortcuts button ( #5739 )
...
* For #5567 : Removes search shortcut button
* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
2896b36d14
No issue: Updates naming of launch links privately var ( #5701 )
...
The previous name was pretty confusing
2019-10-02 12:11:21 -07:00
eb3c9f86e2
No issue: Removes feature flags for delete data ( #5738 )
2019-10-02 10:43:37 -07:00
669e694af9
For #5672 : Fixes broken send tab link
2019-09-30 16:13:40 -07:00
c8af16bd47
For #5679 : Hides autoplay behind feature flag ( #5685 )
2019-09-30 12:01:04 -07:00
ef29fe2584
Update BackgroundServicesTest, Suppress Complex Method
2019-09-30 10:33:56 -07:00
a4097cd380
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-30 10:33:56 -07:00
3f41a4e9c6
No issue: Update navigation library
2019-09-26 17:01:13 -07:00
c3287b17ac
Closes #5624 - Fix crash on preference change listener
2019-09-26 16:56:54 -07:00
44bb592b43
For #5312 - Send ETP Strict/Standard event
2019-09-25 15:23:30 -07:00
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
9d9ff959b5
For #5312 - Add Telemetry for Tracking Protection
2019-09-23 08:29:45 -07:00
6c30a94081
Move settings classes to packages
2019-09-20 12:36:15 -07:00
6f3d7b4ee8
For #5396 : Adds "always launch in private mode" to settings
2019-09-20 08:33:07 -07:00
05a4faec78
Add tryGetHostFromUrl and update ExceptionDomains
2019-09-19 22:40:35 -04:00
1aa4f5a519
For #255 : Toggle Media Autoplay
2019-09-19 15:13:04 -07:00
1777b5a830
Use enum to simplify delete on quit code
2019-09-18 20:20:08 -07:00
976c840047
For #3077 - Replaces connect another device dialog with a scree
2019-09-18 17:24:43 -07:00
50cd2920d3
For #5371 : Updates search engine settings string ( #5393 )
2019-09-18 11:26:44 -07:00
3e132f102c
No issue: Update androidx libraries Sept 5 2019
2019-09-17 09:50:31 -07:00
2b71af4087
For #5258 - Pop AccountProblemFragment if signed out
2019-09-16 21:26:01 -07:00
9ebd4efe70
Pass app name to delete browsing data prompt
2019-09-16 09:59:42 -07:00
e247870b9f
For #5277 : Updates string for delete browsing data ( #5309 )
2019-09-13 10:18:25 -07:00
a5859e0028
For #5178 - Polish delete browsing data item layout
2019-09-11 18:11:26 -07:00
e3209dcc84
For #3700 - Add Setting to Delete Data on "Quit" menu action
2019-09-11 16:06:18 -07:00
ddc1b2e648
For #4658 : Add private browsing mode shortcut telemetry
2019-09-11 16:03:22 -07:00
418b1ba890
For #1749 - Use Strict ETP by default, use Feature Flag for Settings
2019-09-11 16:03:01 -07:00
2e2bac4ccd
For #419 : Create launch icon for private browsing ( #4948 )
2019-09-11 10:52:33 -07:00
4485b7f647
Add Tracking Protection Info Panel
2019-09-11 07:47:13 -07:00
f7dde41b3b
For #5021 : Adds telemetry for what's new button
2019-09-10 14:15:34 -07:00
3c07cacf4d
Use A-C preferences property delegates
2019-09-10 13:19:00 -07:00
b77c4d2e2e
Clean up SupportUtils
2019-09-10 10:16:04 -07:00
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
4c2a7ac10e
Delete AUTH_SESSIONS with COOKIES
2019-09-09 12:32:28 -07:00
758f4c13ec
Updates per UX and PR feedback
2019-09-09 12:32:28 -07:00
2b9efccfca
For #3106 : Granular options for clearing user data
2019-09-09 12:32:28 -07:00
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
231924f5eb
Fix breaking services APIs changes
2019-09-05 13:38:15 +02:00
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
ba05d21657
Fix ktlint MaxLineLength issues.
2019-09-03 10:09:06 -07:00
f3d8a89c63
Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
cea18f31c4
For #3892 : Fixes help link on nightly ( #4956 )
2019-08-29 13:27:50 -07:00
1cf8a40059
For #4295 - Adds Experiments Pref to Data Collection Settings ( #4915 )
2019-08-27 12:56:16 -07:00
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
aab357845b
No issue: Clean up preferences code ( #4699 )
2019-08-21 08:38:14 -07:00
71a2478f4d
Use Mozilla Android Components 10.0.0
2019-08-21 10:06:05 -04:00
33f3b14c29
Adds setters and property delegates in `Settings` ( #4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
9ee8c00928
For #4774 - Use vector drawable compat ( #4811 )
2019-08-20 10:43:02 -07:00
210868f5bc
Use Mozilla Android Components 9.0.0-SNAPSHOT. ( #4750 )
2019-08-19 10:29:10 -07:00
806961094b
Fixes #4704 ( #4728 )
...
* Fixes #4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
2019-08-19 09:23:12 -07:00
b7ca520787
For #4421 : Adds Leanplum events and attributes ( #4626 )
...
* For #4421 : Adds Leanplum events and attributes
* For #4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
5fe05e919a
For #4125 : Suppress coroutine warning to fix release build
2019-08-09 17:30:27 -04:00
6c9ce784b1
Fix, add some tests
2019-08-09 13:39:51 -07:00
2a6069bfb7
Fix rest of issues
2019-08-09 13:39:51 -07:00
69434a765f
Fix most issues
2019-08-09 13:39:51 -07:00
faf0ecbcc0
For #4125 : Migrate Sign in to Sync to Libstate
2019-08-09 13:39:51 -07:00
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
ef97173cd9
For #4529 , #4427 : Resuming after restoring instance state breaks UI ( #4571 )
...
* For #4529 , #4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
2019-08-08 11:05:01 -05:00
0ea595743d
Fixes #4562 : Add a-c git hash to about page
2019-08-07 16:59:11 -07:00
a514cb3f8c
No issue: Add OSS licenses link to About page
2019-08-07 12:40:10 -07:00
0604e9858d
Closes #3939 - Adds strings for delete browsing history
2019-08-06 16:06:56 -07:00
5edc9d0b4e
For #2021 - Update custom preferences' views with email/account changes
2019-08-05 09:53:27 -07:00
8aecc2b850
For #4530 Reduce build warnings ( #4531 )
2019-08-05 11:10:57 -05:00
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
1cb9f88787
For #4199 make checkbox disabled when there is no data ( #4200 )
...
* For #4199 make checkbox unclickable when there is no data
2019-08-02 17:42:39 -07:00
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
210864186b
Reflect current sync status when opening account settings
2019-08-01 17:03:45 -07:00
46de06d132
For #4339 reduce build warnings ( #4340 )
2019-07-31 11:43:49 -07:00
0703fdc91f
Closes #4240 - Exclude custom tabs from displayed tab count
2019-07-30 13:28:50 -04:00
d1651ecf71
Closes #4012 - Animate quick settings ( #4047 )
2019-07-30 09:50:50 -07:00
bf44c50dfd
Fix #4372 - Set SitePermissionsDetailsExceptionsFragment toolbar title in onResume
...
The flow we are currently using involves setting a new title for the containing
Activity when the user navigates to a new Fragment.
This happened for SitePermissionsDetailsExceptionsFragment in it's onCreate().
Opening a permission (SitePermissionsManageExceptionsPhoneFeatureFragment) will
set a new title in it's onCreate() but going back from this new Fragment will
not create again a new SitePermissionsDetailsExceptionsFragment.
As a workaround I moved the call to set Activity's title in onResume().
2019-07-30 11:56:44 -04:00
5e52fc46b8
For #3443 - convert textPercentageSeekBar to Kotlin ( #4081 )
...
* convert textPercentageSeekBar to Kotlin
* fix test
* fix test again
* fix test again
* conflicts resolved
* merge multiple kdocs into one
2019-07-30 10:17:41 -05:00
87d8f3b037
Remove redundant super calls
2019-07-29 10:22:53 -07:00
88c05a5f43
Use glide-like image loading function
2019-07-29 10:22:23 -07:00
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
9b5baa2358
For #3360 - Adds empty state for TP Exceptions
2019-07-22 17:21:06 -04:00
f110ba2861
use synthetic binding instead of findviewbyid
2019-07-19 16:51:26 -04:00
5630904f93
For#3278 - Updates strings in preferences ( #4184 )
2019-07-19 12:31:55 -07:00
e25ceafd1f
No issue: Removes unnecessary fragment transitions from accounts
...
Co-authored-by: ekager <emilykager@gmail.com>
2019-07-18 19:56:25 -04:00
95367c2b50
For #3521 - Show Quick Settings Dialog Entirely in Landscape
2019-07-17 09:52:01 -07:00
13b7e64c9b
For #3134 - Add confirmation dialog to sign out of FxA ( #3959 )
2019-07-15 16:21:13 -07:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
fe51bbcf7b
Update FxA integration to new APIs
2019-07-11 13:19:37 +02:00
c81dd0a4a8
For #3772 - Update FXA sign in UI ( #3933 )
2019-07-10 21:20:06 -05:00
c6c9818751
For #3240 - Create AuthCustomTabActivity to fix dead end on auth
2019-07-10 12:23:01 -04:00
c92eabdd64
Modify the order of Privacy Policy and About in Settings ( #2760 )
2019-07-08 12:16:18 -05:00
d168d52516
For #3772 - Remove Create an Account Option on TurnOnSyncFragment ( #3928 )
2019-07-08 12:07:09 -05:00
003837eb4f
Closes #3879 - Remove attributeSetId from AccountPreference
2019-07-07 18:06:17 -07:00
29402a297e
For #3317 : Prepopulate FxA device name field with existing name ( #3733 )
2019-07-03 08:38:09 -07:00
887102d215
For #3645 : Fix search engine selection ( #3665 )
...
* Remove RadioButton drawable applied in runtime
* Add default RadioButton layout
2019-07-01 11:08:58 -05:00
654c2b12df
No issue: Remove attributeSetId from DefaultBrowserPreference ( #3712 )
2019-07-01 09:02:40 -07:00
d42052079a
No issue: Remove duplicate wordmark and update about page ( #3590 )
2019-07-01 08:54:16 -07:00
219b5f3d01
For #3381 : Fix 'Remove account' returning app to home screen ( #3778 )
...
* For #3381 : Fix 'Remove account' returning app to home screen
* Remove unused import
* Move popBackStack() outside lifecycleScope instead
2019-07-01 08:32:06 -07:00
b82340bf1f
For #3750 : Crash when tapping "Blocked" on Google Maps after disabling
...
location requests.
2019-06-29 18:39:19 -07:00
2cafd5bba6
For #3678 : Fix crash when tapping on your account ( #3688 )
2019-06-26 13:33:27 -07:00
a78d36354a
Switch RadioButtonPreference to ConstraintLayout
...
Also ensure that RTL works properly.
2019-06-26 09:45:55 -07:00
30930cdc88
Import variables referred to by path
2019-06-25 13:57:34 -07:00
55f5c5d049
Use lifecycleScope for settings fragments
2019-06-25 13:56:33 -07:00
6bf8d6be34
Use @JvmOverloads instead of multiple constructors
2019-06-25 13:55:31 -07:00
74111c75de
For #3639 - Remove fontInflationEnabled ( #3640 )
2019-06-25 10:24:32 -05:00
721908ade6
For #3055 : Adds android components version to about page ( #3596 )
2019-06-24 12:52:04 -07:00
b1102c2e76
For #3544 - Set SearchSuggestions preference value from settings
2019-06-18 16:56:34 -07:00
b70dced16e
Fixes #3538 - Fix ic_tabs icon path ( #3540 )
2019-06-18 16:38:42 -07:00
7ebdfcc87b
For #1116 - Uses alias link for help
2019-06-14 15:33:34 -07:00
5540230e3d
For #1116 - Changes help link ( #3491 )
2019-06-14 15:29:10 -05:00
dfe181aa0a
Add application-services fretboard feature flags
2019-06-13 15:29:59 -07:00
227a80957e
For #382 - Include Marshmellow in the guard..
2019-06-12 15:45:58 -07:00
dad671ca3c
For #382 - Hides default browser switch for older versions of Android
2019-06-12 15:07:58 -07:00
1b7a9817e2
For #2905 : Remove device name during sync logout
2019-06-12 17:07:56 -04:00
f71bdcfd10
For #3388 : Set max length for device name ( #3397 )
2019-06-12 15:35:06 -05:00
332b4c4da5
For #3278 - makes the string a constant
2019-06-11 16:24:28 -07:00
fc603e65a5
For #3278 - Removed redundant override
2019-06-11 16:24:28 -07:00
fead5183c8
For #3278 - pin the default search engine to the top
2019-06-11 16:24:28 -07:00
a86ec60f8f
For #3278 - Fixes search engine selector layout
2019-06-11 16:24:28 -07:00
d2c3427f1e
Doesn't print gecko emoji on android ver < 7 (android N) ( #3115 )
...
* Doesnt print gecko emoji on android ver < 7
* fixed typo on maybeGecko variable
* Closes #3076 : Lizard char now doesn't appear if not supported androidver
* Closes #3115 : Prints string instead of gecko emoji in unsupported
android versions
2019-06-11 16:40:51 -05:00
a58a77317e
Automatically close the 'auth-problems fragment' once we're through the auth flow ( #3340 )
2019-06-11 09:36:05 -05:00
82d2a0661b
Remove deprecatd support-ktx methods ( #3305 )
2019-06-10 09:12:11 -05:00
86aac3e313
For #3176 : Hides camera options on devices without cameras ( #3273 )
2019-06-07 19:37:43 -05:00
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
ed39b7828b
For #3234 - Updates labels of fragments in the nav graph to avoid flash ( #3235 )
2019-06-06 16:52:25 -05:00
fe3c163a20
Fix how we reflect FxA state in preference
...
This cleans up how we're displaying account state in the main preference UI.
Before when it worked, it worked mostly accidentally.
'launch' wrapper around "update ui" methods would trigger a race condition
between binding the account pref view holder and actually updating that view
with values. Sometimes the "update view with values" would happen after view
was bound, and the UI will be correct. Most of the time it would happen before,
and so there will be nothing to update and we'd get into an inconsistent state.
This also splits up the "accountpreference" into two: account is good,
and account needs re-auth. This greatly simplifies their management.
2019-06-05 14:38:06 -07:00
0e1d81126d
Make 'remove account' work on the "reconnect to sync" screen
...
This seems to have been copy-pasted and wasn't hooked up correctly.
2019-06-05 14:38:06 -07:00
7af61b1560
Navigate away from account settings after encountering auth problems
2019-06-05 14:38:06 -07:00
47c14b07dd
For #1190 : Removes syncing items from FxA telemetry
2019-06-05 13:57:18 -07:00
c4c5d44430
For #975 : Updates telemetry for settings ( #3171 )
2019-06-05 13:34:42 -05:00
27fdd9605b
For #2395 - Adds an early return statement and documents why we copy a feature
2019-06-05 10:47:21 -07:00
f26c402f0a
For #2395 - Properly takes you back to where you start authentication on completion
2019-06-05 10:47:21 -07:00
40a3246c32
Adds dialog style for Firefox Accounts
2019-06-03 19:08:26 -07:00
038aecc0ee
For #1919- Websites' icons are not displayed on Site permissions ( #3050 )
...
Exceptions.
2019-05-31 16:27:12 -05:00
d5a9627273
For #2941 - Remove Delete Dialog, Theme Dialogs ( #3052 )
2019-05-31 16:26:34 -05:00
35a745d67d
For #2836 : Fixes custom tab close button color
2019-05-31 09:50:46 -07:00
301984733a
For #225 - Adds completion snackbar
2019-05-31 09:42:44 -07:00
eda70ab74c
Fixes #3037 - Unchecks boxes after deletion
2019-05-31 09:42:44 -07:00
0036938312
For #225 - Fixes crash by moving GeckoView calls t othe main thread
2019-05-31 09:42:44 -07:00
f9d70dbc92
For #2723 - Creates callbacks to wire up the mode and theme manager together
2019-05-30 16:38:31 -07:00
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
4c970a545d
For #2230 - Fix theme selection radio button for Android 6 ( #3019 )
2019-05-30 17:06:46 -05:00
5e0771a6f0
For #2327 : Fix early return from displayAccountError
2019-05-30 13:45:56 -07:00
0054e017ea
For #255 - Moves all deletion operations to the same coroutine
2019-05-30 13:05:51 -07:00
b8c04e02e9
For #2327 : Fixes nits
2019-05-30 11:45:39 -07:00
fe50e88fc8
For #2327 : Adds error state syncing
2019-05-30 11:45:39 -07:00
3fd831cc4d
Fixes #2942 : Updates strings for l10n ( #2950 )
2019-05-29 10:47:19 -05:00
cae95c0ee1
For #2952 - Delete All Tabs should run on Main Thread
2019-05-28 16:25:39 -07:00
b2e27d26dc
Closes #2903 : Fixed crash when trying to rate the app on a devices without
...
the play store app.
2019-05-28 15:14:56 -07:00
e0ceb195ff
For #2337 - Open Report Site in Browser from Custom Tab
2019-05-28 14:56:01 -07:00
7d65e21b83
For #2941 - Creates delete dialog style
2019-05-28 13:41:38 -07:00
7d9c8726c5
treewide: Resolve compilation warnings ( #2859 )
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-05-27 19:04:17 +02:00
db2eba9762
For #2876 : Fix crash on sync now button clicked
2019-05-27 12:38:11 -04:00
9aa4f48e77
For #1190 : Adds additional telemetry for FxA login
2019-05-24 17:39:19 -07:00
62bed0cd06
For #1190 : Adds telemetry for FxA login
2019-05-24 17:39:19 -07:00
e3031378bc
For #225 - Address small nits, changes default color of ic_delete
2019-05-24 17:16:03 -07:00
0cbaeaffdc
For #225 - Properly delete collections
2019-05-24 17:16:03 -07:00
51451ff002
For #225 - Deletes data on button press
2019-05-24 17:16:03 -07:00
3cf91fc303
For #225 - Adds button to delete browsing data
2019-05-24 17:16:03 -07:00
072ef5785d
For #225 -Adds checkbox listener to data items
2019-05-24 17:16:03 -07:00
e9c7943fe8
For #225 - Adds icons for list items
2019-05-24 17:16:03 -07:00
3006b21508
For #225 - Adds list items for delete browsing data
2019-05-24 17:16:03 -07:00
182bbdf359
For #225 - Adds delete browsing data fragment
2019-05-24 17:16:03 -07:00
1de2e58644
No issue: Add device name to account page
2019-05-24 15:29:34 -07:00
36f4b97712
For #658 : Adds your rights page link
2019-05-24 11:32:27 -07:00
833290799e
For #1286 - Add Automatic Font Sizing Preference
2019-05-24 09:42:05 -07:00
c6ac791609
No issues: Set ThemeFragment title in onResume ( #2801 )
2019-05-23 21:30:29 -07:00
7951a5f5df
No issue: Update Account UI and visibility in onCreate so it doesn't flash ( #2804 )
2019-05-23 16:52:31 -07:00
6b8938e47e
Fixes #2739 . Update sign-in preference visibility when screen is resumed.
2019-05-23 15:34:29 -07:00
6a8d0f324e
Closes #2770 : Allow receiving tabs from FxA devices ( #2772 )
...
* Closes #2770 : Allow receiving tabs from FxA devices
Now that we're on a-c 0.54, we can land this since it supports device
capability migration.
This patch adds a SEND_TAB device capability, making Fenix a valid target
in the Send Tab device list on Desktop Firefox.
Additionally, it adds a notification manager which manages notification
channels and knows how to display "received tabs" notifications".
* Post: remove unusued test file that's causing issues
2019-05-23 13:13:27 -07:00
7492de321d
For #2530 - Show report site issue and TP off globally in quick settings
2019-05-23 08:34:24 -07:00
36cf9817d9
For #1286 - Dynamically set fontsizefactor and reload current session
2019-05-22 14:07:11 -07:00
16b3309053
For #2531 - Adds privacy notice to settings
2019-05-21 21:34:06 -07:00
c2339e9669
Closes #2699 - Removes Feedback from Settings
2019-05-21 13:37:00 -07:00
692724be2f
For #2395 - Navigates to turn on sync on button press
2019-05-20 23:32:58 -07:00
b3650cacff
For #2399 - Wires up tracking protection onboarding card
2019-05-20 23:32:58 -07:00
a2a4524e51
For #982 - Opens privacy policy in a custom tab
2019-05-20 23:32:58 -07:00
cfca683a14
Use UpdateTrackingProtectionUseCase
...
mozilla-mobile/android-components#2746
2019-05-20 19:39:20 -07:00
291df48c4e
Install the "icons" WebExtension to automatically load icons for every visited website.
2019-05-20 19:34:49 -07:00
d347f73e69
For #2389 - Create Theme Onboarding Card
2019-05-20 11:10:20 -07:00
42d1491976
Closes #2635 - Save settings changes to new Shared Preferences file
2019-05-20 08:58:45 -07:00
6bc577eecd
For #1800 - "report site issue" should open in a new tab
2019-05-16 22:28:02 -07:00
a44322b120
Update mapping to represent steps of 5 from 50-200
2019-05-16 22:26:54 -07:00
e00380960f
Add Accessibility Fragment and Text Size Adjustment Setting
2019-05-16 22:26:54 -07:00
855acd5fe2
Closes #2528 - Fixes Dialog navigation
2019-05-16 22:24:09 -07:00
72d29c2a43
For #2205 & #1578 : Integrates tab collection storage ( #2478 )
...
* For #2205 : Adds TabCollectionStorage
* For #1578 : Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
e52157d358
Closes #2518 - Fix back button in PairFragment
2019-05-15 11:46:34 -07:00
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
mcarare