blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #2531 - Adds privacy notice to settings

master
Jeff Boek 2019-05-21 17:34:03 -07:00
parent e7ecd49353
commit 16b3309053
4 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt
View File

@ -37,6 +37,7 @@ import org.mozilla.fenix.R.string.pref_key_help
import org.mozilla.fenix.R.string.pref_key_language
import org.mozilla.fenix.R.string.pref_key_leakcanary
import org.mozilla.fenix.R.string.pref_key_make_default_browser
import org.mozilla.fenix.R.string.pref_key_privacy_policy
import org.mozilla.fenix.R.string.pref_key_rate
import org.mozilla.fenix.R.string.pref_key_remote_debugging
import org.mozilla.fenix.R.string.pref_key_search_engine_settings
@ -160,6 +161,12 @@ class SettingsFragment : PreferenceFragmentCompat(), CoroutineScope, AccountObse
resources.getString(pref_key_theme) -> {
navigateToThemeSettings()
}
resources.getString(pref_key_privacy_policy) -> {
requireContext().apply {
val intent = SupportUtils.createCustomTabIntent(this, SupportUtils.PRIVACY_NOTICE_URL)
startActivity(intent)
}
}
}
return super.onPreferenceTreeClick(preference)
}

1
app/src/main/res/values/preference_keys.xml
View File

@ -16,6 +16,7 @@
<string name="pref_key_rate" translatable="false">pref_key_rate</string>
<string name="pref_key_feedback" translatable="false">pref_key_feedback</string>
<string name="pref_key_about" translatable="false">pref_key_about</string>
<string name="pref_key_privacy_policy" translatable="false">pref_key_privacy_policy</string>
<string name="pref_key_account" translatable="false">pref_key_account</string>
<string name="pref_key_sign_in" translatable="false">pref_key_sign_in</string>
<string name="pref_key_private_mode" translatable="false">pref_key_private_mode</string>

2
app/src/main/res/values/strings.xml
View File

@ -101,6 +101,8 @@
<!-- Preference linking to about page for Fenix
The first parameter is the name of the app defined in app_name (for example: Fenix) -->
<string name="preferences_about">About %1$s</string>
<!-- Preference linking to the privacy policy -->
<string name="preferences_privacy_policy">Privacy Policy</string>
<!-- Preference for settings related to saved passwords -->
<string name="preferences_passwords">Passwords</string>
<!-- Preference for settings related to saved credit cards and addresses -->

4
app/src/main/res/xml/preferences.xml
View File

@ -96,5 +96,9 @@
android:icon="@drawable/ic_info"
android:key="@string/pref_key_about"
android:title="@string/preferences_about" />
<androidx.preference.Preference
android:icon="@drawable/ic_info"
android:key="@string/pref_key_privacy_policy"
android:title="@string/preferences_privacy_policy" />
</androidx.preference.PreferenceCategory>
</androidx.preference.PreferenceScreen>