1
0
Fork 0

Closes #2699 - Removes Feedback from Settings

master
Emily Kager 2019-05-21 13:07:24 -07:00 committed by Jeff Boek
parent 22ca1b88a0
commit c2339e9669
3 changed files with 0 additions and 13 deletions

View File

@ -33,7 +33,6 @@ import org.mozilla.fenix.R.string.pref_key_accessibility
import org.mozilla.fenix.R.string.pref_key_account
import org.mozilla.fenix.R.string.pref_key_account_category
import org.mozilla.fenix.R.string.pref_key_data_choices
import org.mozilla.fenix.R.string.pref_key_feedback
import org.mozilla.fenix.R.string.pref_key_help
import org.mozilla.fenix.R.string.pref_key_language
import org.mozilla.fenix.R.string.pref_key_leakcanary
@ -152,13 +151,6 @@ class SettingsFragment : PreferenceFragmentCompat(), CoroutineScope, AccountObse
resources.getString(pref_key_rate) -> {
startActivity(Intent(Intent.ACTION_VIEW, Uri.parse(SupportUtils.RATE_APP_URL)))
}
resources.getString(pref_key_feedback) -> {
(activity as HomeActivity).openToBrowserAndLoad(
searchTermOrURL = SupportUtils.FEEDBACK_URL,
newTab = true,
from = BrowserDirection.FromSettings
)
}
resources.getString(pref_key_about) -> {
navigateToAbout()
}

View File

@ -15,7 +15,6 @@ import java.net.URLEncoder
import java.util.Locale
object SupportUtils {
const val FEEDBACK_URL = "https://input.mozilla.org"
const val RATE_APP_URL = "market://details?id=" + BuildConfig.APPLICATION_ID
const val MOZILLA_MANIFESTO_URL = "https://www.mozilla.org/en-GB/about/manifesto/"
val PRIVACY_NOTICE_URL: String

View File

@ -92,10 +92,6 @@
android:icon="@drawable/ic_bookmark_outline"
android:key="@string/pref_key_rate"
android:title="@string/preferences_rate" />
<androidx.preference.Preference
android:icon="@drawable/ic_notification"
android:key="@string/pref_key_feedback"
android:title="@string/preferences_feedback" />
<androidx.preference.Preference
android:icon="@drawable/ic_info"
android:key="@string/pref_key_about"