7ec714552f
Issue #5233 : Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "recommend private browing shortcut" dialog is displayed.
2019-10-14 11:20:17 -07:00
bb22fb3092
Merge #5507 #5846
...
5507: For #1383 Added tab title to close button content description r=ekager a=mcarare
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
5846: For #3604 Snackbar messages for closing tabs use closed instead of deleted r=sblatz a=mcarare
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-11 16:28:36 +00:00
8f0325c05b
For #3584 - Check if menu is open before showing a new one ( #5674 )
...
Could have implemented this check (if menu is showing) inside the show() method
of BrowserMenu but this would mean the client (us) would go to the process of
building a new menu and then trying to have it displayed only for this to be
ignored by BrowserMenu in a somewhat opaque way.
Having this check done as soon as possible offers us full control and avoids
the unnecessary steps for building an already shown menu.
2019-10-10 06:37:47 -07:00
1c6aefd82b
For #3604 Snackbar messages for closing tabs use closed instead of deleted
2019-10-08 17:06:02 +03:00
f6285ad5f8
For #3846 - Pass in updated session icon to tabs
2019-10-07 09:38:43 -07:00
80a1e6dd2c
Fixes #5351 - listen to onIconChanged in HomeFragment
2019-10-06 10:41:34 -07:00
fe648a0b99
Fixes #5351 - use session icon in tab view on home
2019-10-06 10:41:34 -07:00
40e6284aef
For #5442 - Show Delete Browsing Data on Quit option in home menu
2019-10-04 09:26:59 -07:00
785b8b9519
For #5567 : Removes search shortcuts button ( #5739 )
...
* For #5567 : Removes search shortcut button
* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
88aa519210
Closes #4711 - Extract VoiceSearchActivity ( #5502 )
2019-09-27 07:54:29 -07:00
0b01635ce0
For #2874 , #5375 , #5131 - submitList workaround for Android 5 + 6
2019-09-25 19:59:07 -07:00
b6e6e36ccd
For #561 : Fix stutter of search icon & text when animating
2019-09-25 10:06:38 -07:00
c592a69aad
For #561 - Fixes snackbar placement on homeview
2019-09-25 10:06:38 -07:00
5c092c1ef1
For #561 - Adds shadow/highlightto the bottom bar
2019-09-25 10:06:38 -07:00
00d1be97ac
For #561 - Wires up add tab button inside the bottom bar
2019-09-25 10:06:38 -07:00
b16754d78a
For #561 - Adds add tab and menu button to bottom bar
...
- Adds space between wordmark and session control component
2019-09-25 10:06:38 -07:00
abbb310ce3
For #561 - Removes the toolbar from the home screen
...
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
2019-09-25 10:06:38 -07:00
bfe8bf4663
For #1383 Added tab title to close button content description
2019-09-25 10:34:02 +03:00
c7c752cabb
For #5356 Improves private browsing "common myths" link accessibility ( #5479 )
...
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
2019-09-24 10:46:34 -07:00
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
cb7701584f
No issue: Extract home fragment mode ( #5343 )
2019-09-23 09:33:55 -07:00
4a6e647167
For #5197 : Adds telemetry for media controls ( #5266 )
2019-09-20 14:49:27 -07:00
a1c8fc0698
For #3731 Improved UX for opening tabs from a Collection ( #5427 )
...
* For #3731 Changed order of items for a collection's overflow menu
* For #3731 Changed the order tabs open to keep same order from collections
2019-09-20 06:41:04 -07:00
106458c2c9
For #3440 - Reduce HomeFragment require calls
2019-09-18 17:25:44 -07:00
065ce13999
Pass color resource for what's new menu item by id
2019-09-18 16:41:03 -07:00
ddc1b2e648
For #4658 : Add private browsing mode shortcut telemetry
2019-09-11 16:03:22 -07:00
999d3cb963
For #1114 : Show playing tab
2019-09-11 15:45:22 -07:00
2e2bac4ccd
For #419 : Create launch icon for private browsing ( #4948 )
2019-09-11 10:52:33 -07:00
53b3f105ca
For #4155 : Sets pastedText default value
2019-09-11 09:03:17 -07:00
fdd2b59fb8
For #4155 : Adds popup menu for browser toolbar
2019-09-11 09:03:17 -07:00
f7dde41b3b
For #5021 : Adds telemetry for what's new button
2019-09-10 14:15:34 -07:00
b77c4d2e2e
Clean up SupportUtils
2019-09-10 10:16:04 -07:00
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
ed0b6bd5ef
For #4193 - Makes close button for tabs more accessible ( #4442 )
...
* fixes #4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
2019-09-06 10:33:55 -07:00
3a35233ac0
Remove ThumbnailsFeature. ( #5127 )
...
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
231924f5eb
Fix breaking services APIs changes
2019-09-05 13:38:15 +02:00
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
f7087e46e3
Fix #5067 - Refactor ShareController to use SendTabUseCases
...
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
2019-09-03 12:01:26 -07:00
4cf03be236
For #2088 : Use new async API to load default search engine in HomeFragment
2019-08-30 17:56:18 -04:00
5e78420cce
Fixes #3602:navigate to top of home screen after tapping "start browsing"
...
After onboarding.finish(), scrolled homeLayout to top
2019-08-29 07:45:04 -07:00
d87b8a8a5c
For #4658 : Add some private browsing mode telemetry ( #4968 )
2019-08-28 14:41:37 -07:00
cc5408d717
For #2053 : Add persistent notification to close all private browsing tabs ( #4913 )
2019-08-28 12:55:24 -07:00
d1964d6536
Fixes #4771 - Add method for sessions of type ( #4782 )
...
Fixes share tabs to use the new method
2019-08-27 13:04:03 -07:00
b9f6f7fa93
For #4779 : Don't double navigate with global directions in HomeActivity
2019-08-23 12:01:28 -04:00
84b0693fd2
For #4652 : Use workaround for HomeScreenViewModel ( #4887 )
2019-08-22 13:35:51 -05:00
9f154dc3a0
Extract intent processors from HomeActivity ( #4884 )
2019-08-22 13:31:40 -05:00
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
6f899c7fb5
For #2834 : Delete all Private Tabs redesign ( #4787 )
2019-08-20 13:10:08 -07:00
c076cc85f9
For #4436 : Dismiss onboarding before navigating away from home ( #4801 )
2019-08-20 10:56:28 -07:00
33f3b14c29
Adds setters and property delegates in `Settings` ( #4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
ac6c1ec2ee
Closes #2690 - Clean up CreateCollection viewmodel ( #4731 )
2019-08-20 10:45:41 -07:00
ad98b2f3ea
For #4744 - Extract private browsing button ( #4813 )
2019-08-20 10:41:18 -07:00
ab6e7dc52b
Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
2019-08-20 13:45:55 +02:00
b8c93107c0
For #4744 - Extract TransitionPreDrawListener ( #4812 )
2019-08-19 16:27:43 -07:00
a632d8f1dc
For #4744 - Move search bar icon padding to dimens ( #4814 )
2019-08-19 16:22:51 -07:00
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
f71106cb51
Closes #3860 - Update description text for collections
2019-08-14 17:13:52 -04:00
42e3b2771e
fix #4633 : show toast only on first login ( #4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
2019-08-13 16:28:34 -05:00
5aac05859d
Fix #4436 : hide onboarding before navigating to settings ( #4675 )
...
* Fix #4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
2019-08-13 15:49:42 -05:00
0c8bcd39be
For #4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
2019-08-12 15:51:49 -04:00
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
ef97173cd9
For #4529 , #4427 : Resuming after restoring instance state breaks UI ( #4571 )
...
* For #4529 , #4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
2019-08-08 11:05:01 -05:00
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
4566bd6fba
Fixes feedback
2019-08-07 16:41:29 -07:00
9d65e665e5
No issue: Removes deprecated usage of ViewModelProviders
2019-08-07 19:21:41 -04:00
969d17b4a9
For #969 : Adds more telemetry for collections ( #4539 )
2019-08-07 16:05:20 -07:00
d0071d0177
For #4495 - Clean up homescreen toolbar focus and content descriptions
2019-08-05 08:58:03 -07:00
015922ddd2
No issue: Fix Crash lower API by setting gradient drawables in onBind
2019-08-02 16:18:34 -07:00
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
da59e36c1b
Fixes #4410 : Modified visibility of 'Add Tab' button.
...
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
2019-08-02 08:49:50 -07:00
ae33234bbc
Closes #2593 : FxA automatic sign-in integration
2019-08-01 17:03:45 -07:00
2e7a61860a
For #969 : Adds more telemetry for collections ( #4358 )
2019-07-31 17:07:41 -07:00
87d8f3b037
Remove redundant super calls
2019-07-29 10:22:53 -07:00
88c05a5f43
Use glide-like image loading function
2019-07-29 10:22:23 -07:00
ccfaa3826b
For #2142 : Added accessibility focus
2019-07-29 09:26:33 -07:00
d5eeadda66
Closes #2142 : Enable private browsing button is focused instead of Search or address
2019-07-29 09:26:33 -07:00
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
c74cb61455
fixes #4176 ( #4175 )
...
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
2019-07-19 14:23:10 -05:00
13198f56df
For #969 : Adds telemetry for collections ( #3935 )
2019-07-18 16:05:42 -07:00
6da6ddb095
Use StateListDrawable & resources w/ TabCollection
2019-07-18 15:29:06 -04:00
451093fd9e
Closes #2560 - Updates Private Browsing explanation string
2019-07-18 15:27:59 -04:00
447123367a
Remove unused sessions resources
2019-07-16 09:15:50 -07:00
f8ef0225e1
Use updated feature-tab-collections API. ( #4056 )
2019-07-15 09:58:33 -07:00
5de1678e65
No issue: Use putCompoundDrawables helper ( #3982 )
2019-07-15 08:24:59 -07:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
fe51bbcf7b
Update FxA integration to new APIs
2019-07-11 13:19:37 +02:00
c81dd0a4a8
For #3772 - Update FXA sign in UI ( #3933 )
2019-07-10 21:20:06 -05:00
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
2019-07-10 14:13:10 -04:00
5a204f0bbc
For #3818 : Handle crashes accessing view after onDestroyView ( #3942 )
2019-07-08 18:42:17 -05:00
9901514766
Replace deprecated pxToDp ( #3932 )
2019-07-08 14:45:07 -05:00
7a51ee3915
For #3734 - Don't SwipeToDelete RecyclerView without windowfocus ( #3839 )
2019-07-02 14:42:50 -07:00
99209aa9da
Closes #3268 - Change Tab Favicon Border Radius to 4 ( #3856 )
2019-07-02 14:42:20 -07:00
8cd1a0cb38
Move adapter Job setup code to helper class ( #3407 )
2019-07-01 13:34:25 -05:00
7e46e71d00
For #3005 : Closes tabs when saving to collection ( #3723 )
2019-07-01 11:39:48 -05:00
2d6ebb986d
Revert "For #3135 - Reduce swipe to delete sensitivity"
...
This reverts commit 94881f8241
2019-06-28 12:47:36 -07:00
f375eac6bd
For #3732 : Race Condition Crash in HomeFragment onPreDraw ( #3737 )
2019-06-27 20:33:21 -05:00
13df8d7ddd
For #3711 : Fixes save to collection from browser crash ( #3714 )
2019-06-27 11:29:00 -07:00
e8bd090a8e
No issue: Use ImageView rather than rebuilding drawable ( #3616 )
...
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
4994554576
No issue: Adds lint exception for when statement ( #3685 )
2019-06-26 15:52:24 -07:00
30930cdc88
Import variables referred to by path
2019-06-25 13:57:34 -07:00
d01bb8c442
Use lifecycleScope for collections fragments
2019-06-25 13:56:15 -07:00
ddebc98718
No issue: Follow up on optional filter style
2019-06-24 17:03:38 -07:00
718ac5612c
For #3593 For #3581 - Pass sessions to delete to delete all with undo ( #3594 )
2019-06-24 15:41:38 -07:00
07516f47c3
For #3215 : Adds collection restoration with unique IDs ( #3635 )
2019-06-24 14:12:51 -07:00
03a5cb2fb4
For #3620 - Adds automatic theme onboarding content description ( #3629 )
2019-06-24 13:15:38 -07:00
ab6101b0f4
Fixes #3539 - vectordrawablecompat for gradients ( #3541 )
2019-06-18 16:38:56 -07:00
ccc5b91992
Import PR 3500 from ekager
2019-06-14 18:52:27 -07:00
6e6e662c47
Update HomeFragment.kt
2019-06-14 18:34:58 -07:00
90bdbd04e0
No Issue - Capture session manager in scope before creating the delete operation
2019-06-14 18:34:58 -07:00
7ebdfcc87b
For #1116 - Uses alias link for help
2019-06-14 15:33:34 -07:00
5540230e3d
For #1116 - Changes help link ( #3491 )
2019-06-14 15:29:10 -05:00
f323c38be0
For #981 - Adds missing Leanplum events
2019-06-14 13:27:50 -07:00
d5c5587a0c
For #3209 : Disable shared element animations for crash temporarily ( #3482 )
2019-06-14 12:13:13 -05:00
041eaa2a5c
For #3275 : Cleans up feedback from James ( #3398 )
2019-06-14 08:59:57 -07:00
1f1320920f
For #3275 - Invoke pending single session delete job on close all ( #3438 )
2019-06-13 12:58:45 -05:00
510b6f7373
For #2899 - Improve collections scroll and highlight animations
2019-06-13 09:21:12 -07:00
186983b786
For #3275 - Adds PendingSessionDeletion data class to handle multiple emit session calls ( #3393 )
2019-06-12 10:49:20 -07:00
66a836cf3a
For #3314 : Toolbar and QAB unresponsive after Android 6 perms check ( #3373 )
2019-06-12 10:08:39 -05:00
f05eb032d4
For #2684 : Add an extension function Session.toTab to map Session to Tab and clean up their usage
2019-06-11 13:14:23 -07:00
82cf81242f
For #3331 - Delay restoring layout while list restores ( #3354 )
2019-06-11 12:27:32 -05:00
decacbfc97
For #3323 Runs PublicSuffixList synchronously
2019-06-11 09:19:51 -07:00
e57e7b50ee
For #2899 - Scroll to Collections on change, animate new collections ( #3279 )
...
* For #2899 - Scroll to Collections on change, animate new collections
* For #2899 - Scroll to tabs when tabs opened from collection
2019-06-11 09:01:00 -05:00
ab000d2e51
For #3280 : Revert "For #3215 : Restores collections properly" ( #3320 )
...
This reverts commit 3e9ee79c00f4a6b34af74ce7c179e0cbe37decf5.
2019-06-10 13:54:03 -07:00
5df726715f
Revert "For #3008 , For #2162 Add Simple Logic for Menu Orientation" ( #3310 )
...
#3114
2019-06-10 10:58:18 -05:00
054635735a
For #2750 : Removes unecessary invalidate CollectionViewHolder call ( #3264 )
2019-06-07 13:38:18 -07:00
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
2019-06-07 09:33:07 -07:00
7368a95d29
No issue: Sets up observers for tab collection changes ( #3248 )
2019-06-07 09:45:38 -05:00
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
acea0d5668
For #2785 - Adds back item animator session control ( #3233 )
2019-06-06 16:54:49 -05:00
8537ff10a8
For #3215 : Restores collections properly ( #3219 )
2019-06-06 14:26:05 -05:00
4954aadd84
For #3156 - If only one tab adding to collection make it selected ( #3222 )
2019-06-06 14:24:25 -05:00
704f1e6a3d
For #3004 - Restore MotionLayout on Home View only in onCreateView
2019-06-05 14:46:38 -07:00
14c581c012
For #3004 - Do not restore motionlayout state in ReloadData
2019-06-05 09:33:07 -07:00
94881f8241
For #3135 - Reduce swipe to delete sensitivity
2019-06-04 16:10:28 -07:00
87f6268816
For #3101 - Do not show tab selection screen for 1 tab
2019-06-04 10:08:43 -07:00
dc0d153580
For #3008 , For #2162 Add Simple Logic for Menu Orientation ( #3114 )
...
* For #3008 - Adjust orientation of collections menu based on view location
* For #2162 - Add simple menu orientation logic to bookmark menu
2019-06-04 10:37:57 -05:00
388581f76f
For #3056 - Filter sessions on invoke for pending delete all job
2019-05-31 18:52:02 -07:00
d5a9627273
For #2941 - Remove Delete Dialog, Theme Dialogs ( #3052 )
2019-05-31 16:26:34 -05:00
14f1d40e10
Fixes #3041 - Fixes the string that gets displayed in the FxA Onboarding card
2019-05-31 10:44:14 -07:00
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
8dbed67f7f
No issue: Simplify and speed up shared element transitions
2019-05-30 16:30:06 -07:00
4c970a545d
For #2230 - Fix theme selection radio button for Android 6 ( #3019 )
2019-05-30 17:06:46 -05:00
b8c04e02e9
For #2327 : Fixes nits
2019-05-30 11:45:39 -07:00
fe50e88fc8
For #2327 : Adds error state syncing
2019-05-30 11:45:39 -07:00
caa36c31cd
For #2979 - Prevent double navigation to Create Collection Fragment
2019-05-30 10:58:56 -07:00
5f42a65c2a
No issue: improve allowUndo
...
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on
New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
2019-05-30 10:48:59 -07:00
e61cebf38d
No issue: Check search engine icon exists before setting drawable
2019-05-30 08:33:30 -07:00
8bed44819d
Fixes #2254/#2709. Observe browser sessions changes on `HomeFragment`.
2019-05-29 15:13:15 -07:00
d6c1f65d72
Start MotionLayout animation to end while navigating to search fragment
2019-05-29 12:27:48 -07:00
dee3c059dc
Adds Shared Transition between Home and Search
2019-05-29 12:27:48 -07:00
6a53127ef9
For #2948 : Adds menu button add tab to collection
2019-05-29 09:08:11 -07:00
3da6cfd98a
For #2886 : Fix sending multiple tabs to another device ( #2923 )
...
* For #2886 : Fix sending multiple tabs to another device
* Update share methods to use new API
2019-05-28 15:05:16 -07:00
506f332b85
For #2919 - Invoke Pending Delete Jobs in onPause
2019-05-28 14:59:05 -07:00
7d65e21b83
For #2941 - Creates delete dialog style
2019-05-28 13:41:38 -07:00
250548a72f
For #2823 - Invoke pending jobs with context on switch to private mode
2019-05-28 12:48:02 -07:00
e3031378bc
For #225 - Address small nits, changes default color of ic_delete
2019-05-24 17:16:03 -07:00
01c9317be0
For #2843 - Improve Collections UI and UX ( #2851 )
2019-05-24 17:06:17 -07:00
207a8d6772
Use a ListAdapter for SessionControl
2019-05-24 13:13:52 -07:00
09588dfda6
For #2529 - Remove "Delete Collection" button from private browsing
2019-05-24 10:53:15 -07:00
4e13de3ffd
No issue: Register observers with owner view
2019-05-24 10:53:05 -07:00
0c8ad3ef6e
For #2721 - Reorder onboarding theme settings ( #2817 )
2019-05-23 23:34:11 -07:00
f51e221a99
Remove unused import
2019-05-23 13:41:00 -07:00
895ba021e7
Hide toolbar in activity and remove label from home fragment
2019-05-23 13:41:00 -07:00
c7af502db7
Restore progress
2019-05-23 13:41:00 -07:00
0e64ead75c
Try to pop up to home if it exists on stack from browserfragment
2019-05-23 13:41:00 -07:00
40f2fe5166
For #1287 - Create animation for opening and closing tab from home
2019-05-23 13:41:00 -07:00
832fd71afc
For #2784 : Removes undo from collection deletion ( #2786 )
2019-05-23 12:16:40 -07:00
eb7646f073
Add custom share sheet and send tab support ( #2757 )
...
* Closes #2751 : Add custom app share sheet
* Closes #2753 : Add send tab devices to share sheet
* Closes #2752 : Add build flag for send tab
* Replace Context.share with ShareFragment
2019-05-23 10:48:22 -07:00
bf28462c47
For #2717 - Hides onboarding card when signed into a firefox account
2019-05-23 10:26:55 -07:00
ab590df18b
For #2717 - Adds auto signed in state to the accounts onboarding card
2019-05-23 10:26:55 -07:00
f4f35bdde0
Closes #2713 : Weave in "onboarding state" and split adapter items accordingly
...
we're ensuring that it has been initialized.
I wonder if we could just make background services load eagerly (they're lazy init now), instead.
2019-05-23 10:26:55 -07:00
220a843534
For #2205 : Updates collection title constraints
2019-05-23 08:33:42 -07:00
a1d32127ab
For #2655 : Adds undo snackbar for closing all tabs
2019-05-23 07:26:00 -07:00
5ec783f6e5
For #2719 - Fixes crash by registering to observer with a lifecycle owner
2019-05-21 21:43:33 -07:00
e7ecd49353
For #1578 : Adds delete collection with undo
2019-05-21 14:02:56 -07:00
394a207fea
Revert "For #1578 : Adds delete collection with undo"
...
This reverts commit 63a4567521
2019-05-21 13:04:47 -07:00
63a4567521
For #1578 : Adds delete collection with undo
2019-05-21 11:03:44 -07:00
93d0982a6f
For #1576 : Adds tab collection renaming
2019-05-21 10:34:42 -07:00
f73bb22955
No issue: Removes usage of COLLECTIONS_ENABLED flag
2019-05-21 10:34:30 -07:00
0c022f6646
For #1826 - Create ViewModel for Restoring Home Scroll Position
2019-05-21 10:29:15 -07:00
4b186eb86d
No issue: Save/Restore State in HomeFragment
2019-05-21 10:29:15 -07:00
0080e7d701
For #2584 : Adds opening a single tab from tab collection
2019-05-21 09:42:40 -07:00
a3f25b9f77
For #2584 : Adds opening tab collections
2019-05-21 09:42:40 -07:00
afbe397f94
For #1575 : Enables adding tabs to existing collection
2019-05-21 09:39:55 -07:00
7e7edc8b7a
For #2377 : Adds share to tabs and tab collections
2019-05-21 09:37:04 -07:00
1cd50ba9cb
No Issue - Fixes nits in #2669
2019-05-20 23:32:58 -07:00
a041d9ef74
For #2391 - Dismiss tour when navigating to search or settings
2019-05-20 23:32:58 -07:00
479c00bc5f
No Issue - Always complete motionLayout transition on restore
2019-05-20 23:32:58 -07:00
692724be2f
For #2395 - Navigates to turn on sync on button press
2019-05-20 23:32:58 -07:00
9a76c11dae
For #2389 - Save state on homeview when switching themes
2019-05-20 23:32:58 -07:00
b3650cacff
For #2399 - Wires up tracking protection onboarding card
2019-05-20 23:32:58 -07:00
a2a4524e51
For #982 - Opens privacy policy in a custom tab
2019-05-20 23:32:58 -07:00
591f367806
For #2392 - Adds icon to private browsing onboarding card
2019-05-20 23:32:58 -07:00
2dc76dda6a
For #2392 - Centers private browsing icon
2019-05-20 23:32:58 -07:00
291df48c4e
Install the "icons" WebExtension to automatically load icons for every visited website.
2019-05-20 19:34:49 -07:00
ba790c5dd3
No issue: remove unused restore state code
2019-05-20 19:29:28 -07:00
ec1a0e6c34
Revert #2533 : Removes feature flag for tab collections
2019-05-20 15:22:45 -07:00
3619f1417d
For #1574 : Cleans up unused code and refactors
2019-05-20 14:31:17 -07:00
7861a80715
For #2205 : Truncates tab collection titles
2019-05-20 14:31:17 -07:00
4e6f9b9ef1
For #1574 : Displays previous tab collections when creating
2019-05-20 14:31:17 -07:00
30a643720f
For #1574 : Adds tab collection creation
2019-05-20 14:31:17 -07:00
d347f73e69
For #2389 - Create Theme Onboarding Card
2019-05-20 11:10:20 -07:00
72d29c2a43
For #2205 & #1578 : Integrates tab collection storage ( #2478 )
...
* For #2205 : Adds TabCollectionStorage
* For #1578 : Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
95af2ddcc6
For #2390 - Adds the start browser button
2019-05-15 23:18:37 -07:00
b2e6b59e91
For #2390 - Adds views for every onboarding card
2019-05-15 23:18:37 -07:00
8928b19079
For #2390 - Adds a theme picker card
...
- applies generic styling to cards
- adds margins to headers and onboarding cards
2019-05-15 23:18:37 -07:00
fe16810ddb
For #2390 - Adds onboarding section headers
2019-05-15 23:18:37 -07:00
dfe14e1751
For #2390 - Adds the onboarding welcome message
2019-05-15 23:18:37 -07:00
b14d0fa80c
For #2390 - Applies onboarding mode on start
2019-05-15 23:18:37 -07:00
b3a3c94169
Small refactor before we add onboarding cards ( #2541 )
...
* For #2390 - Cleans up the toAdapterList method before we add onboarding
* For #2514 - Hide tabs menu when no tabs are open
2019-05-15 17:06:49 -07:00
014de10b29
Fixes #2533 - Adds the feature flag to the menu item to create a collection
2019-05-15 13:32:37 -07:00
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
49ac62ab85
Fix ViewModel States ( #2457 )
...
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2019-05-14 13:49:02 -07:00
917399d897
For #2436 : TransactionTooLargeException saving many tabs ( #2453 )
2019-05-13 21:03:51 -05:00
155353f0ee
For #2449 : App crashes when switching themes ( #2450 )
2019-05-13 10:59:05 -05:00
4070941657
No issue: Refactor dialogs to use nav graph
2019-05-10 19:58:48 -07:00
cfccb997fd
For #1909 : Tabs disappear intermittently ( #2426 )
2019-05-10 15:20:45 -07:00
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
d64f5a2064
For #2205 : Modifies styling of collections and tabs ( #2328 )
...
* For #2205 : Modifies styling of collections and tabs
* Change bounding box
2019-05-08 11:12:41 -07:00
eb4e159101
For #2329 , For #2332 : Invoke pending delete session job on navigate ( #2333 )
2019-05-08 12:27:38 -05:00
37bae3bb38
For #2289 - Null out pending job on undo ( #2303 )
2019-05-06 16:38:53 -05:00
7d577e5953
For #2205 : Adds collections view to home fragment ( #2249 )
...
* For #1574 : Adds collections to home view
* Adds colored icons and expansion
* Adds state change
* Adds more styling
* Adds ItsNotBrokenSnacks
* Adds chevron
* Improves styling of swipe to delete and adds delete action
* Fix nits
* Try to add real saving
2019-05-06 11:20:19 -07:00
0000d6a782
For #2277 - Clean up threading for session control with undo ( #2281 )
2019-05-05 09:54:45 -05:00
e5e448ac8f
For #1694 - Show Snackbar with Undo When Tab is Closed ( #2246 )
2019-05-03 09:41:44 -05:00
73de0cd2e8
Closes #2239 - emit session changes in onstart ( #2240 )
2019-05-02 15:13:59 -05:00
8fd937669b
Closes #2182 - Do not invoke sessionmanager callbacks ( #2236 )
2019-05-02 14:35:38 -05:00
2953b54a84
For #1573 - Polish Collections UI Component ( #2212 )
...
* Adds Keyboard resuming, Snackbar verification, layout edits to collections
Adds Keyboard resuming, Snackbar verification, layout edits to collections
* Adds new strings for collections/tabs management
* Adds constraintsets, hides checkboxes, adds scrim
* Update strings to plurals
2019-05-02 10:53:40 -05:00
0bcff089d6
Feature #2088 : Async load the default search engine icon at startup ( #2113 )
2019-04-30 19:45:56 -05:00
70486039c0
Closes #2147 : Refactors usage of openToBrowserAndLoad
2019-04-29 15:49:22 -07:00
0e44921e08
For #1573 - Update tabs header menu ( #2141 )
2019-04-29 17:03:40 -05:00
1041500869
For #1573 - Long pressing tab selects that tab in save collections
2019-04-29 12:57:34 -07:00
46924544b6
For #1975 & #1627 : Refactors getSessionById in BrowserFragment
2019-04-25 16:51:03 -07:00
d39c15402e
For #1843 - Adds a better theme for the creation fragment
2019-04-24 14:29:23 -07:00
ba90b58d32
For #1843 - Displays tabs on the tab selection screen
2019-04-24 14:29:23 -07:00
63574cc359
For #1843 - Adds a create collections fragment and navigates to it
2019-04-24 14:29:23 -07:00
df6230182c
Closes #469 - Changes Library String
2019-04-23 17:41:38 -05:00
e2198f19ad
Fixes #1868 : Corrects private browsing myths link ( #1930 )
2019-04-23 14:26:56 -07:00
d0fb11a946
TabViewHolder: Remove unused parameter
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
753487b277
TabViewHolder: Remove useless lateinit
...
Fixes build-time warning: fenix/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabViewHolder.kt: (45, 13): Lateinit is unnecessary: definitely initialized in constructors
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
534d88f629
Closes #1894 - Fixes Help Page Navigation
2019-04-23 00:22:46 -05:00
ba690fde8e
Fixes tab sizing ( #1906 )
2019-04-22 14:50:22 -07:00
f19a773ab9
Merge pull request #1842 from boek/i1840-collections_featureflag
...
For #1840 - Adds a save tab group button and puts it behind a feature flag
2019-04-20 14:15:18 -07:00
4ea54252b0
For #1830 - Adds the ability to share a tab
2019-04-19 15:31:12 -07:00
774c5c0e0c
For #1830 - Updates the tab visual style
2019-04-19 15:31:12 -07:00
146492bd59
Fixes #1828 - Adds an empty tab state
2019-04-19 14:06:31 -07:00
0f367a018a
For #724 : Corrects colors for all themes
2019-04-19 13:46:43 -07:00
deb7c2d18c
Fix #1770 : Share icon from quick action bar poorly rasterized
2019-04-19 15:17:47 -05:00
d1c2ed2052
Closes #1803 : remove text for swipe delete
2019-04-19 13:32:32 -05:00
5ca9040702
For #1696 - Removes sessions from session control
2019-04-17 22:41:59 -07:00
6183e82264
For #1696 - Removes sessions from the bottomsheetfragment
2019-04-17 22:41:59 -07:00
29832c5e84
For #724 : Consolidates colors
2019-04-15 12:22:03 -05:00
bc1b7e0b43
For #1539 : Add bookmark multi-select features
2019-04-12 13:35:28 -05:00
2a19917619
For #538 - Reverse tabs in list
2019-04-12 10:05:52 -05:00
659386bd5e
For #176 - Start swipe to close gesture
2019-04-12 10:04:48 -05:00
e98db8bfb8
For #1430 - Adds a changelog entry
2019-04-10 09:58:00 -07:00
5acd386ecd
For #1430 - Handle more text in a more graceful way
2019-04-10 09:58:00 -07:00
b306bc502a
For #1430 - Adjust snackbar colors for darkmode
2019-04-10 09:58:00 -07:00
d402707531
Closes #1420 : Moves tab preview to top of page ( #1462 )
2019-04-10 06:52:49 -07:00
9434f01b42
Fixes #1204 - Fixes the home screen animation
2019-04-08 16:16:28 -05:00
8f6dca99dc
For #1456 - Fixes missing delete button
2019-04-08 10:24:47 -07:00
d346613733
Adds missing licenses
2019-04-06 12:38:46 -05:00
e34d163034
Combines the Tab and Session component
2019-04-06 12:38:46 -05:00
4a385068e0
Updates ConstraintLayout to alpha4
2019-04-05 10:09:02 -07:00
5d1738e011
For #208 - Dark Mode UX edits
2019-04-04 19:35:36 -07:00
fef5680068
Hide tabs list
2019-04-04 15:43:58 -05:00
1d032bbe53
Quantize and optimize images to save about 3MB in APK
2019-04-04 09:46:04 -05:00
a2200b6335
For #208 - Dark/Night Theme
2019-04-02 22:18:11 -05:00
b73a0600f6
No issue: Hook up share button on session item to action
2019-04-02 12:32:03 -05:00
756634bc6c
For #1181 - Use appName in string locations
2019-03-26 14:32:53 -07:00
786592e8d0
For #959 - Adds telemetry for when the search bar is tapped
2019-03-22 17:14:35 -07:00
df40ec970e
Simplify ItsNotBrokenSnack() and make resilient
...
Co-authored by: Emily Kager <ekager@mozilla.com>
2019-03-22 15:00:38 -05:00
4963f7ccdb
Add Snackbar to link testers to Github issue for features
2019-03-22 15:00:38 -05:00
52e9394324
Pass BrowserIcons instance to SessionSuggestionProvider and HistoryStorageSuggestionProvider.
2019-03-22 11:18:43 -05:00
18284bb442
Create global instance of BrowserIcons class.
2019-03-22 11:18:43 -05:00
7accf07d48
For #1072 : Fixes lint errors
2019-03-21 12:54:08 -05:00
994d88542e
For #1072 : Adds basic view
2019-03-21 12:54:08 -05:00
bb3ebbdbe2
Closes #932 - Home Page UI polish
2019-03-20 19:55:29 -05:00
0ac3e5369d
Fixes #1050 : Fenix sessions save and close upon opening
2019-03-18 08:21:30 -07:00
6e1655e935
Fix #1032 : Crash altering sessions DB on main thread
2019-03-15 10:41:02 -07:00
463ab8bf79
No issue: Fixes compilation errors with a-c 47.0
2019-03-14 09:49:35 -07:00
2fa25a86f0
Closes #1004 : Integrating ThumbnailsFeature.
2019-03-13 13:52:33 -07:00
7132229b16
SearchView: Replace deprecated calls with recommended method
...
Resources#getDrawable(int) has been deprecated in favour
of Resources#getDrawable(int, Theme). Make the suitable changes
in SearchView class to reflect this.
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-03-13 09:07:22 -07:00
8d442c062d
Closes #884 - Set and use default search engine
2019-03-12 11:11:24 -07:00
79395631d7
Fixes #870 - Fixes logic for the session bottom sheet fragment for private mode
...
Also fixes #871
2019-03-11 16:02:06 -07:00
b1d0233b04
Closes #814 : Scrolls to top after session restore
2019-03-08 12:55:52 -08:00
d6ebd88186
Closes #804 : Adds disable private browsing content description ( #851 )
2019-03-08 08:37:35 -08:00
d15e4bb3fa
Closes #877 - Add Search Engine Settings
2019-03-06 16:20:35 -08:00
a79134fdc3
Closes #823 & Closes #835 : Refactors openToBrowserAndLoad to include fromFragment ( #833 )
2019-03-06 14:53:49 -08:00
65fa904a21
No issue: remove breaking AC change params ( #878 )
2019-03-06 11:48:09 -08:00
58b32e944b
Revert "Closes #811 - Clear stack after switching to private browsing" ( #876 )
...
This reverts commit 8b793cd43e
2019-03-06 11:48:00 -08:00
8b793cd43e
Closes #811 - Clear stack after switching to private browsing
2019-03-05 14:34:56 -08:00
d413b7228f
Fixes compiler error for new version of A-C
2019-03-05 09:34:49 -08:00
9d3ef76929
For #747 : Fix memory leak with HomeMenu
2019-03-04 09:02:20 -08:00
c4fe44529a
No issue - Adds basic tab theming
2019-03-01 08:08:10 -06:00
27c5570b43
For #673 - Dismiss bottom sheet on archive. Remove boolean logic
2019-03-01 08:03:51 -06:00
e05f0894e8
For #673 - Modifies Session Bottom Sheet to work for current and archived sessions
2019-02-28 18:46:46 -06:00
22c915b5a4
For #673 - Trigger session overflow menu on session item menu
2019-02-28 18:46:46 -06:00
1aa3d7e1ad
For #673 - Pulls out the session overflow action
2019-02-28 18:46:46 -06:00
e9e74122b5
Closes #736 & Closes #722 : Adds delete session button to private browsing
2019-02-28 14:00:01 -08:00
bswe