1
0
Fork 0
 
 
 
 
 
 
Go to file
Mugurell 645674c9bd Closes #4396 - Add a Bookmarks Controller (#4593)
* For #4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For #4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For #4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
.github Release documentation (#4617) 2019-08-14 12:01:35 -05:00
app Closes #4396 - Add a Bookmarks Controller (#4593) 2019-08-19 08:34:57 -07:00
architecture For #4652: Crash "Can not perform this action after onSaveInstanceState" (#4654) 2019-08-09 14:46:40 -05:00
automation Bug 1573512 - rename codecov secret to something more generic for master and PR to reuse (#4705) 2019-08-13 14:14:08 -05:00
buildSrc Closes #4719: Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. (#4722) 2019-08-14 09:10:24 -05:00
certificates Adds certificates to repository 2019-05-20 19:35:29 -07:00
config No issue: Adds lint exception for when statement (#3685) 2019-06-26 15:52:24 -07:00
docs For #4421: Adds Leanplum events and attributes (#4626) 2019-08-14 13:48:45 -07:00
fastlane Adding l10n screenshot tests for Fenix (#3562) 2019-07-08 11:00:29 -05:00
gradle/wrapper Closes #2683. Update Gradle to `5.5` (#3929) 2019-07-08 11:14:13 -05:00
.adjust_token Fixes #675: Integrate Adjust SDK (for Greenfield flavor) 2019-03-01 12:57:59 -06:00
.gitattributes Adds a gitattribute file to manage changelog merges 2019-04-11 15:02:16 -05:00
.gitignore Add taskcluster job for UI tests (#4088) 2019-07-26 08:08:01 -07:00
.taskcluster.yml Revert "Temporarilly run raptor jobs on PRs" 2019-08-05 18:52:05 +02:00
CHANGELOG.md For #3424 - Make talkback ignore ImageButton in Collection Sele… (#3792) 2019-08-12 11:49:25 -04:00
CODE_OF_CONDUCT.md Add Mozilla Code of Conduct file 2019-03-31 10:29:27 -07:00
Gemfile Adding l10n screenshot tests for Fenix (#3562) 2019-07-08 11:00:29 -05:00
LICENSE Fixes #163: Add LICENSE 2019-01-16 11:26:46 -06:00
README.md No issue: fix README link to file security issues. 2019-08-01 22:22:21 -04:00
build.gradle For #4508: Treats warnings as errors (#4543) 2019-08-07 14:00:53 -07:00
codecov.yml No issue: Add threshold to codecov (#4751) 2019-08-15 10:40:05 -07:00
debug.keystore For #1601 - Bookmark icon should change visually if page is bookmarked 2019-04-25 17:29:27 -07:00
gradle.properties update docker image reference (#3412) 2019-06-27 18:56:23 -04:00
gradlew Initializes Android project 2018-12-07 15:25:38 -05:00
gradlew.bat Initializes Android project 2018-12-07 15:25:38 -05:00
l10n.toml Import strings from android-l10n 2019-07-30 15:35:41 +02:00
settings.gradle Remove misinformation from settings.gradle 2019-08-02 12:51:41 -07:00

README.md

Firefox Preview

Firefox Preview (internal code name: "Fenix") is an all-new browser for Android, based on GeckoView and Mozilla Android Components.

Getting Involved

We encourage you to participate in this open source project. We love Pull Requests, Bug Reports, ideas, (security) code reviews or any other kind of positive contribution.

Before you attempt to make a contribution please read the Community Participation Guidelines.

Beginners! - Watch out for Issues with the "Good First Issue" label. These are easy bugs that have been left for first timers to have a go, get involved and make a positive contribution to the project!

Build Instructions

  1. Clone or Download the repository:
git clone https://github.com/mozilla-mobile/fenix
  1. Import the project into Android Studio or build on the command line:
./gradlew clean app:assembleArmDebug
  1. Make sure to select the correct build variant in Android Studio: armDebug for ARM x86Debug for X86

Pre-push hooks

To reduce review turn-around time, we'd like all pushes to run tests locally. We'd recommend you use our provided pre-push hook in config/pre-push-recommended.sh. Using this hook will guarantee your hook gets updated as the repository changes. This hook tries to run as much as possible without taking too much time.

To add it on Mac/Linux, run this command from the project root:

ln -s ../../config/pre-push-recommended.sh .git/hooks/pre-push

or for Windows run this command using the Command Prompt with administrative privileges:

mklink .git\hooks\pre-push ..\..\config\pre-push-recommended.sh

or using PowerShell:

New-Item -ItemType SymbolicLink -Path .git\hooks\pre-push -Value (Resolve-Path config\pre-push-recommended.sh)

To push without running the pre-push hook (e.g. doc updates):

git push <remote> --no-verify

License

This Source Code Form is subject to the terms of the Mozilla Public
License, v. 2.0. If a copy of the MPL was not distributed with this
file, You can obtain one at http://mozilla.org/MPL/2.0/