blallo
/
fenix
1
0
Fork 0
Code Releases Activity
fenix/app/src/main/res/drawable
History
Severin Rudie 6909a76bcb
4281 remove qab (#6310) 
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
 		2019-11-11 17:10:14 -08:00
..
add_tabs_to_collection_background.xml For #1573 - Polish Collections UI Component (#2212) 2019-05-02 10:53:40 -05:00
bookmark_two_state.xml For #1601 - Bookmark icon should change visually if page is bookmarked 2019-04-25 17:29:27 -07:00
bookmarks_circle_background_filled.xml For #1601 - Bookmark icon should change visually if page is bookmarked 2019-04-25 17:29:27 -07:00
bookmarks_circle_background_outline.xml For #1601 - Bookmark icon should change visually if page is bookmarked 2019-04-25 17:29:27 -07:00
bottom_sheet_dialog_fragment_background.xml For #2754 Add tab cards to share sheet (#5493) 2019-09-26 14:25:34 -07:00
button_background.xml For #4262: Updates color and text of buttons (#4250) 2019-07-25 11:01:25 -07:00
collection_home_list_row_background.xml Use StateListDrawable & resources w/ TabCollection 2019-07-18 15:29:06 -04:00
crash_reporter_button.xml Minify drawable assets 2019-06-11 15:11:33 -07:00
device_background.xml Add custom share sheet and send tab support (#2757) 2019-05-23 10:48:22 -07:00
dialog_background.xml For #5047 - Creates dialog ui for naming a shortcut 2019-09-11 16:10:54 -07:00
dialog_button_background.xml For #2324 - Adds a drawable with the proper border radius 2019-06-03 19:08:26 -07:00
empty_session_control_background.xml Fixes #1828 - Adds an empty tab state 2019-04-19 14:06:31 -07:00
favicon_background.xml Fixes #916, fixes #917, fixes #920: Save, share, and delete bookmarks 2019-04-01 16:16:08 -05:00
fenix_snackbar_background.xml For #3439 - Clean up where accent colors didn't work with dark theming 2019-06-13 22:39:00 -07:00
fenix_snackbar_error_background.xml For 5092 - Show a Snackbar with retry option if sharing to devices fails (#5158) 2019-09-26 12:30:28 -07:00
home_bottom_bar_background.xml For #561 - Adds shadow/highlightto the bottom bar 2019-09-25 10:06:38 -07:00
home_header_shadow.xml For #1843 - Scaffolds MVI component for Collection Creation 2019-04-24 14:29:23 -07:00
home_search_background_dark.xml For #724: Corrects colors for all themes 2019-04-19 13:46:43 -07:00
home_search_background_dark_no_border.xml For #724: Corrects colors for all themes 2019-04-19 13:46:43 -07:00
home_search_background_normal.xml For #561 - Fixes visual inconsistencies with the search bar 2019-09-25 10:06:38 -07:00
ic_accessibility.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_account.xml For #3244: Updates account icon in settings (#3692) 2019-06-27 11:28:42 -07:00
ic_account_warning.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_add_to_homescreen.xml Closes #773 - Add shortcuts to homescreen (#4925) 2019-08-29 14:45:11 -05:00
ic_alert.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_app_links.xml 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
ic_arrowhead_right.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
ic_autoplay_enabled.xml For https://github.com/mozilla-mobile/fenix/issues/5474 - Adapt Autoplay icon to theme 2019-09-23 08:56:09 -07:00
ic_bookmark_filled.xml For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
ic_bookmark_outline.xml For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
ic_camera.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_camera_anim_disable.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_camera_anim_enable.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_camera_disabled.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_camera_enabled.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_chevron.xml Use StateListDrawable & resources w/ TabCollection 2019-07-18 15:29:06 -04:00
ic_chevron_down.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_chevron_up.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_clear.xml No issue: Missing clear button in edit bookmarks UI 2019-04-15 13:17:41 -05:00
ic_close.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_collections_circle_background.xml Closes #3454 - Update Collections Icon in Delete Browsing Data 2019-06-13 15:23:08 -07:00
ic_cookies.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
ic_copy.xml For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
ic_cryptominers.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
ic_customize.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_data_collection.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_delete.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_desktop.xml For #1071 Added Desktop Mode icon 2019-09-27 09:47:10 -07:00
ic_download.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_drawer_pull_tab.xml For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
ic_edit.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_energy.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_etp_artwork.xml For #6100: Mirror ETP graphic in RTL 2019-10-18 15:24:49 +03:00
ic_exit.xml For #3700 - Add Setting to Delete Data on "Quit" menu action 2019-09-11 16:06:18 -07:00
ic_fingerprinters.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
ic_folder_icon.xml Closes #3569 - Uses primary text attr for bookmark folder icon (#3675) 2019-06-26 15:29:21 -05:00
ic_folder_new.xml For #1968 - Adds menu option to add new folder in BookmarkFragment menu 2019-06-27 15:17:00 -07:00
ic_formfill.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_fx_accounts_avatar.xml Fixes #3539 - vectordrawablecompat for gradients (#3541) 2019-06-18 16:38:56 -07:00
ic_help.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_history.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_hollow_share.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_home.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_info.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
ic_internet.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_language.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_library.xml For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
ic_link.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_location.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_location_anim_disable.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_location_anim_enable.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_location_disabled.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_location_enabled.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_login.xml For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
ic_logo_widget.xml For #201: Search Widget 2019-08-02 11:26:48 -07:00
ic_menu.xml For #724: Fixes white color in dark mode and removes android:tint (#1641) 2019-04-15 13:14:49 -07:00
ic_microphone.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_microphone_anim_disable.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_microphone_anim_enable.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_microphone_disabled.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_microphone_enabled.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_microphone_widget.xml For #201: Search Widget 2019-08-02 11:26:48 -07:00
ic_new.xml For #724: Fixes white color in dark mode and removes android:tint (#1641) 2019-04-15 13:14:49 -07:00
ic_notifications.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_notifications_anim_disable.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_notifications_anim_enable.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_notifications_disabled.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_notifications_enabled.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_onboarding_avatar_anonymous.xml Fixes #3539 - vectordrawablecompat for gradients (#3541) 2019-06-18 16:38:56 -07:00
ic_onboarding_firefox_accounts.xml Fixes #3539 - vectordrawablecompat for gradients (#3541) 2019-06-18 16:38:56 -07:00
ic_onboarding_privacy_notice.xml Fixes #3539 - vectordrawablecompat for gradients (#3541) 2019-06-18 16:38:56 -07:00
ic_onboarding_private_browsing.xml Fixes #3539 - vectordrawablecompat for gradients (#3541) 2019-06-18 16:38:56 -07:00
ic_onboarding_tracking_protection.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_password_hide.xml For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
ic_password_reveal.xml For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
ic_pbm_notification.xml For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
ic_pbm_triangle.xml For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
ic_permission.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_private_browsing.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_qr.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_readermode.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_readermode_appearance.xml 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
ic_report_issues.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_scan.xml For #3772 - Update FXA sign in UI (#3933) 2019-07-10 21:20:06 -05:00
ic_screenshots.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_search.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_send.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_settings.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_shortcuts.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_sign_in.xml Initial view for the "Turn on Sync" fragment 2019-05-02 15:05:40 -07:00
ic_social_media_trackers.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
ic_static_shortcut_background.xml For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
ic_static_shortcut_private_tab.xml For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
ic_static_shortcut_private_tab_foreground.xml For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
ic_static_shortcut_tab.xml For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
ic_static_shortcut_tab_foreground.xml For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
ic_status_logo.xml Replace notification icon (#3395) 2019-06-12 14:07:20 -05:00
ic_tab_circle_background.xml Fixes #3538 - Fix ic_tabs icon path (#3540) 2019-06-18 16:38:42 -07:00
ic_tab_collection.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
ic_tabs.xml Fixes #3538 - Fix ic_tabs icon path (#3540) 2019-06-18 16:38:42 -07:00
ic_tracking_content.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
ic_tracking_protection.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_tracking_protection_anim_disable.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_tracking_protection_anim_enable.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_tracking_protection_disabled.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
ic_tracking_protection_enabled.xml Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
ic_triangle.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
ic_whats_new.xml For #4474: Adds what's new button to home screen menu (#5088) 2019-09-03 15:16:29 -05:00
ic_whats_new_notification.xml For #4474: Adds what's new button to home screen menu (#5088) 2019-09-03 15:16:29 -05:00
library_icon_app_links_circle_background.xml Closes AC#3695 - Add UI to open current page in external app 2019-07-18 15:33:31 -04:00
library_icon_downloads_circle_background.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
library_icon_history_circle_background.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
library_icon_reading_list_circle_background.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
library_icon_screenshots_circle_background.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
notification_indicator.xml For #911: Adds reader mode notification on first launch 2019-05-23 08:27:07 -07:00
onboarding_button_background.xml For #2390 - Adds the start browser button 2019-05-15 23:18:37 -07:00
onboarding_card_background_dark.xml For #2395 - Adds sign into sync card 2019-05-20 23:32:58 -07:00
onboarding_card_background_light.xml For #2395 - Adds sign into sync card 2019-05-20 23:32:58 -07:00
onboarding_popup_background.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
onboarding_rounded_bottom_corners_ripple.xml For #2395 - Adds sign into sync card 2019-05-20 23:32:58 -07:00
pause_with_background.xml For #1114: Show playing tab 2019-09-11 15:45:22 -07:00
pbm_shortcut_popup_background.xml For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
play_with_background.xml For #1114: Show playing tab 2019-09-11 15:45:22 -07:00
private_browsing_button.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
private_home_background_gradient.xml For #724: Corrects colors for all themes 2019-04-19 13:46:43 -07:00
private_home_bottom_bar_background_gradient.xml For #561 - Adds shadow/highlightto the bottom bar 2019-09-25 10:06:38 -07:00
progress_gradient.xml For #4039 - Set angle of progress bar gradient 2019-07-15 08:02:06 -07:00
quick_action_icon_appearance.xml Issue #910: Integrate feature-readerview component (#2269) 2019-05-03 21:01:45 +00:00
quick_action_icon_close.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
quick_action_icon_read.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
quick_action_icon_read_with_notification.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
quick_action_icon_share.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
reader_two_state.xml Issue #910: Integrate feature-readerview component (#2269) 2019-05-03 21:01:45 +00:00
reader_two_state_with_notification.xml For #911: Adds reader mode notification on first launch 2019-05-23 08:27:07 -07:00
rounded_all_corners.xml Use StateListDrawable & resources w/ TabCollection 2019-07-18 15:29:06 -04:00
rounded_bottom_corners.xml For #2205: Adds collections view to home fragment (#2249) 2019-05-06 11:20:19 -07:00
rounded_gray_corners.xml For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
rounded_ripple.xml For #2389 - Create Theme Onboarding Card 2019-05-20 11:10:20 -07:00
rounded_top_corners.xml Use StateListDrawable & resources w/ TabCollection 2019-07-18 15:29:06 -04:00
rounded_white_corners.xml For #201: Search Widget 2019-08-02 11:26:48 -07:00
scrim_background.xml For #1843 - Fixes color for dialog overlay 2019-04-24 14:29:23 -07:00
search_pill_background.xml For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
search_pill_background_unselected.xml For #724: Corrects colors for all themes 2019-04-19 13:46:43 -07:00
search_pill_drawable_button_background.xml For #208 - Dark Mode UX edits 2019-04-04 19:35:36 -07:00
search_url_background.xml For #2210: Improves UI of search fragment (#3773) 2019-06-28 19:03:04 -05:00
session_background.xml For #2205: Adds collections view to home fragment (#2249) 2019-05-06 11:20:19 -07:00
session_border.xml For #1944 & #1750: Updates private & night mode colors (#4232) 2019-07-23 09:35:24 -07:00
sign_in_preference_background.xml For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
sync_error_background_with_ripple.xml For #2203: Polishes BrowserToolbarMenu 2019-08-02 13:40:50 -04:00
tab_in_collection_last_swipe_background.xml For #2205: Adds collections view to home fragment (#2249) 2019-05-06 11:20:19 -07:00
tab_in_collection_swipe_background.xml For #2205: Adds collections view to home fragment (#2249) 2019-05-06 11:20:19 -07:00
toolbar_background.xml For #1750: Adds gradient to private BrowserToolbar (#4361) 2019-07-30 09:19:48 -07:00
url_background.xml For #724: Consolidates colors 2019-04-15 12:22:03 -05:00