1
0
Fork 0
Commit Graph

168 Commits (4ae60f2cce2c424033fc7ed1524161f5d4c43fe9)

Author SHA1 Message Date
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
ekager f49331de55 For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
mcarare 6b1bfcc079 For #6100: Mirror ETP graphic in RTL 2019-10-18 15:24:49 +03:00
mcarare 64923978e6 For #1071 Added Desktop Mode icon 2019-09-27 09:47:10 -07:00
Colin Lee de93b05cac For #2754 Add tab cards to share sheet (#5493)
* For #2754 Add tab cards to share sheet

* For #2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
2019-09-26 14:25:34 -07:00
Mugurell c5330c6880 For 5092 - Show a Snackbar with retry option if sharing to devices fails (#5158)
* For #5092 - Show a Snackbar with retry option if sharing to devices fails

ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.

* For #5092 - Refactor ShareControllerTest

* For #5092: Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
Jeff Boek 32c506121e For #561 - Fixes visual inconsistencies with the search bar 2019-09-25 10:06:38 -07:00
Jeff Boek 5c092c1ef1 For #561 - Adds shadow/highlightto the bottom bar 2019-09-25 10:06:38 -07:00
Nicholas 72eed21bfc For https://github.com/mozilla-mobile/fenix/issues/5474 - Adapt Autoplay icon to theme 2019-09-23 08:56:09 -07:00
Colin Lee 1aa4f5a519 For #255: Toggle Media Autoplay 2019-09-19 15:13:04 -07:00
Jeff Boek faff73b9b3 For #5047 - Creates dialog ui for naming a shortcut 2019-09-11 16:10:54 -07:00
Emily Kager e3209dcc84 For #3700 - Add Setting to Delete Data on "Quit" menu action 2019-09-11 16:06:18 -07:00
Sawyer Blatz 999d3cb963 For #1114: Show playing tab 2019-09-11 15:45:22 -07:00
Yeon Taek Jeong 2e2bac4ccd
For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
Emily Kager 4485b7f647 Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
Sawyer Blatz 09dcdb079d For #4474: Adds what's new button to home screen menu (#5088)
* For #4474: Adds what's new button to home screen menu

* For #4474: Adds tests for what's new button
2019-09-03 15:16:29 -05:00
Tiger Oakes f740d4382a Closes #773 - Add shortcuts to homescreen (#4925) 2019-08-29 14:45:11 -05:00
Yeon Taek Jeong cc5408d717
For #2053: Add persistent notification to close all private browsing tabs (#4913) 2019-08-28 12:55:24 -07:00
Yeon Taek Jeong 83ceec6289 For #201: Search Widget 2019-08-02 11:26:48 -07:00
Sawyer Blatz 29f089c414 For #2203: Polishes BrowserToolbarMenu 2019-08-02 13:40:50 -04:00
Tiger Oakes d1651ecf71 Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
Sawyer Blatz 437ecfbca8
For #1750: Adds gradient to private BrowserToolbar (#4361)
Also updates the color of quickActionSheet ot be "above" attribute
2019-07-30 09:19:48 -07:00
Sawyer Blatz 9db0d88346
For #4262: Updates color and text of buttons (#4250) 2019-07-25 11:01:25 -07:00
Sawyer Blatz 28eb5c541a
For #1944 & #1750: Updates private & night mode colors (#4232) 2019-07-23 09:35:24 -07:00
Sawyer Blatz becdb88f4b Revert "For #1944 & #1750: Updates private & night mode colors (#4162)"
This reverts commit 2c95bb614a.
2019-07-18 19:55:56 -04:00
James Hugman 62850430b7 Closes AC#3695 - Add UI to open current page in external app 2019-07-18 15:33:31 -04:00
Tiger Oakes 6da6ddb095 Use StateListDrawable & resources w/ TabCollection 2019-07-18 15:29:06 -04:00
Sawyer Blatz 2c95bb614a
For #1944 & #1750: Updates private & night mode colors (#4162) 2019-07-18 11:22:07 -07:00
Tiger Oakes 447123367a Remove unused sessions resources 2019-07-16 09:15:50 -07:00
ekager 89a500beaf For #4039 - Set angle of progress bar gradient 2019-07-15 08:02:06 -07:00
Emily Kager c81dd0a4a8 For #3772 - Update FXA sign in UI (#3933) 2019-07-10 21:20:06 -05:00
Sawyer Blatz 4ccd19a585 For #2210: Improves UI of search fragment (#3773) 2019-06-28 19:03:04 -05:00
Emily Kager 9142e2279c For #1968 - Adds menu option to add new folder in BookmarkFragment menu 2019-06-27 15:17:00 -07:00
Sawyer Blatz a36f2a7288
For #3244: Updates account icon in settings (#3692) 2019-06-27 11:28:42 -07:00
Emily Kager a1ddf17364 Closes #3569 - Uses primary text attr for bookmark folder icon (#3675) 2019-06-26 15:29:21 -05:00
Tiger Oakes ab6101b0f4 Fixes #3539 - vectordrawablecompat for gradients (#3541) 2019-06-18 16:38:56 -07:00
Tiger Oakes b70dced16e Fixes #3538 - Fix ic_tabs icon path (#3540) 2019-06-18 16:38:42 -07:00
Tiger Oakes f0f5374a57 Minify vector drawables 2019-06-14 09:37:35 -07:00
Emily Kager a941b875b4 For #3439 - Clean up where accent colors didn't work with dark theming 2019-06-13 22:39:00 -07:00
Sawyer Blatz c48d7fb0c3 For #3447: Fixes folder icon color 2019-06-13 16:40:42 -07:00
Emily Kager ce33054173 Closes #3454 - Update Collections Icon in Delete Browsing Data 2019-06-13 15:23:08 -07:00
Tiger Oakes 2868e376a6 Replace notification icon (#3395) 2019-06-12 14:07:20 -05:00
Tiger Oakes c73ba83f45 Minify drawable assets 2019-06-11 15:11:33 -07:00
vmbaicu a2f2a23a15 Fixes #3281 - Fix Report and onboarding lint errors and issues (#3339) 2019-06-11 12:33:12 -05:00
Tiger Oakes 64229f6f34 Minify launcher icon (#3309) 2019-06-10 09:10:29 -05:00
Tiger Oakes 2e27dc6a5e Redesign Report and Collection icons
Update icons to align with other Android icons by adjusting the weight.
2019-06-04 13:00:11 -07:00
Jeff Boek 47a59548cc For #2324 - Adds a drawable with the proper border radius 2019-06-03 19:08:26 -07:00
Jeff Boek ebe894801c For #3049 - Updates sign in card visual style 2019-05-31 13:53:15 -07:00
Sawyer Blatz b8c04e02e9 For #2327: Fixes nits 2019-05-30 11:45:39 -07:00
Sawyer Blatz fe50e88fc8 For #2327: Adds error state syncing 2019-05-30 11:45:39 -07:00