1
0
Fork 0
fenix/app/src/main/res/layout
Elise Richards 023a4983fa
For #10173: login duplicates and save (#11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
2020-07-16 17:08:04 -05:00
..
about_list_item.xml For #4776: Redesign and refactor the About Page 2019-12-12 11:34:10 +02:00
account_auth_error_preference.xml Use tools:text to avoid inflating strings twice (#3619) 2019-07-15 17:01:37 -05:00
account_preference.xml For #12107: Follow ux mock on Settings --> Account screen 2020-07-14 12:25:21 +03:00
account_share_list_item.xml For #4007 - Use camelCase for views referenced from code 2019-08-29 18:12:50 -07:00
activity_addons.xml Provide add-on support (#8064) 2020-02-04 01:41:51 -05:00
activity_home.xml For #7473, delay inflation of toolbar 2020-01-24 15:21:42 -08:00
activity_migration.xml For #11154: Fix button color on migration UI 2020-06-02 18:08:45 -07:00
app_share_list_item.xml For #4007 - Use camelCase for views referenced from code 2019-08-29 18:12:50 -07:00
browser_toolbar_popup_window.xml For #10577 - Adds elevation for the browser toolbar popup 2020-06-02 11:26:46 +03:00
button_tip_item.xml For #9208: Make slight modifications to tip layout 2020-04-30 11:57:43 -07:00
checkbox_left_preference.xml For #11665: Adjust visual design for delete browsing data screens. 2020-06-19 09:32:37 +03:00
checkbox_left_preference_etp.xml For #10656: Adjust etp checkbox dimensions for a11y. 2020-05-15 17:39:51 +03:00
checkbox_left_sub_preference.xml For #12007: Follow ux mock on Settings --> Search screen (#12177) 2020-07-02 00:48:31 -07:00
collection_header.xml Polish homescreen (#11065) 2020-05-29 17:09:12 -05:00
collection_home_list_row.xml For #9496: Vertically align collection name and icons to collection icon 2020-03-30 08:30:06 -07:00
collection_tab_list_row.xml For #11139:Constrain title to start of checkbox and ellipsize. 2020-06-02 12:08:05 -04:00
collections_list_item.xml For issue #11835 - Update text fonts 2020-06-26 23:18:52 -04:00
component_bookmark.xml For #2165 - Add swipe to refresh gesture to bookmarks view. 2020-06-25 14:50:24 -07:00
component_bottom_browser_toolbar.xml For #5694 & #6054: Allows users to change toolbar position (#6608) 2019-11-25 16:43:32 -08:00
component_browser_top_toolbar.xml For #6940: Fixes top dynamic toolbar behavior (#9900) 2020-04-17 13:32:20 -07:00
component_collection_creation.xml For issue #11835 - Update text fonts 2020-06-26 23:18:52 -04:00
component_collection_creation_name_collection.xml Issue 5366 Vector Drawable Compat (#6904) 2019-12-05 19:54:32 -08:00
component_collection_creation_select_collection.xml For issue #11835 - Update text fonts 2020-06-26 23:18:52 -04:00
component_exceptions.xml For #10285: Swap TextView for a LinkTextView to improve links a11y 2020-06-26 18:11:11 +03:00
component_history.xml For #2165 - Implement pull-to-refresh gesture to sync history. 2020-06-11 10:23:27 -07:00
component_locale_settings.xml For #12078: Follow ux mock on Settings --> Language screen 2020-07-06 15:47:42 -04:00
component_permissions_blocked_by_android.xml For #9857: Create button style (#9858) 2020-04-15 15:49:02 -07:00
component_saved_logins.xml For #10285: Swap TextView for a LinkTextView to improve links a11y 2020-06-26 18:11:11 +03:00
component_session_control.xml For #3574 Allow all screen readers to read onboarding items one-by one (#7292) 2019-12-19 09:53:53 -05:00
component_sync_tabs.xml For #11641: Update synced tabs view 2020-06-26 18:11:13 -04:00
component_tabstray.xml Closes #11873 - Add scrollbar in tabs tray 2020-07-07 17:50:56 -04:00
component_tabstray_fab.xml Implement tab tray design improvements and fix close functionality. 2020-06-02 15:03:58 -05:00
component_top_sites.xml For #10281: Change margin with padding to allow flexbox to stretch. 2020-06-12 09:31:23 -04:00
component_tracking_protection_panel.xml Tests and cleanup for tracking protection 2020-06-01 22:08:52 -04:00
custom_search_engine.xml For #9775: Increase touch target of elements in add search engine screen 2020-07-06 15:47:25 -04:00
custom_search_engine_radio_button.xml For #12007: Fix add search engine items using wrap content for height 2020-07-06 15:37:28 -04:00
delete_browsing_data_item.xml For #11665: Adjust visual design for delete browsing data screens. 2020-06-19 09:32:37 +03:00
delete_exceptions_button.xml For #9857: Create button style (#9858) 2020-04-15 15:49:02 -07:00
delete_logins_exceptions_button.xml For #7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00
download_dialog_layout.xml For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view 2020-05-21 10:02:51 -04:00
dropdown_preference_etp.xml For #6479: Add granular ETP settings 2020-02-18 09:32:43 -08:00
etp_dropdown_item.xml For #6479: Add granular ETP settings 2020-02-18 09:32:43 -08:00
exception_item.xml Fixes #9504: Edit logins (#9693) 2020-05-12 17:32:01 -05:00
exceptions_description.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
fenix_snackbar.xml For #9594: Increase touch target for snackbar action button button. 2020-05-28 19:41:28 -07:00
fragment_about.xml For #9712 - show "AC: " before AC version on "About" screen 2020-06-16 15:29:00 -04:00
fragment_add_new_device.xml For #9857: Create button style (#9858) 2020-04-15 15:49:02 -07:00
fragment_add_on_details.xml For #11456: AddonDetailsFragment should use ConstraintLayout, not RelativeLayout 2020-06-17 15:51:29 -04:00
fragment_add_on_internal_settings.xml Provide add-on support (#8064) 2020-02-04 01:41:51 -05:00
fragment_add_on_permissions.xml For issue #8520: Polish Add-on manager UIs 2020-03-31 17:20:20 -04:00
fragment_add_ons_management.xml For issue #8520: Improve add-ons UI 2020-04-13 19:01:58 -04:00
fragment_add_search_engine.xml Adds custom search engines (#6551) 2019-11-19 16:30:56 -08:00
fragment_bookmark.xml For #8649: No bookmarks here strings are close to the top 2020-06-22 16:04:20 -04:00
fragment_browser.xml For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view 2020-05-21 10:02:51 -04:00
fragment_crash_reporter.xml For #7752, #7753: Adjust touch targets for elements in crash reporter. 2020-06-05 12:04:58 +03:00
fragment_create_collection.xml #4596 migrate collections (#5911) 2019-10-22 17:33:54 -07:00
fragment_create_shortcut.xml For #9435: Adjust margins and paddings to mirror correctly in RTL 2020-03-27 14:45:47 -07:00
fragment_delete_browsing_data.xml For #10706: Update copy of deleting open tabs preference. 2020-05-25 17:37:29 -04:00
fragment_edit_bookmark.xml Fix: Set correct height for EditText (#10014) 2020-04-16 20:31:25 -07:00
fragment_edit_custom_search_engine.xml Adds custom search engines (#6551) 2019-11-19 16:30:56 -08:00
fragment_edit_login.xml For #10173: login duplicates and save (#11208) 2020-07-16 17:08:04 -05:00
fragment_exceptions.xml For #7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00
fragment_history.xml For #8651 - Ensure FenixSnackbar has a proper root for inflating into 2020-03-27 15:53:31 -07:00
fragment_home.xml For #10281: Reduce logo margin to compensate top site padding increase. 2020-06-12 09:31:23 -04:00
fragment_installed_add_on_details.xml For #10552: Set initial add-on details fragment visibility to false (#10565) 2020-05-11 12:44:18 -04:00
fragment_locale_settings.xml For #12078: Follow ux mock on Settings --> Language screen 2020-07-06 15:47:42 -04:00
fragment_login_detail.xml For #11303 - Change copy login origin to open in browser 2020-07-09 18:09:41 -04:00
fragment_manage_site_permissions_exceptions_feature_phone.xml Issue 5366 Vector Drawable Compat (#6904) 2019-12-05 19:54:32 -08:00
fragment_manage_site_permissions_feature_phone.xml 8017 advanced autoplay controls. (#8978) 2020-03-20 12:10:42 -07:00
fragment_not_yet_supported_addons.xml Update NotYetSupported add-ons copy 2020-03-30 10:36:49 -04:00
fragment_pair.xml For #6198: Update copy and position of pair QR code scan message. 2020-05-25 17:53:20 -04:00
fragment_pwa_first_time.xml For #768: Add first time PWA dialog (#9308) 2020-04-01 22:56:12 -04:00
fragment_quick_settings_dialog_sheet.xml For #8591: Allow items in quick_action_sheet to be read by a11y services 2020-03-19 15:18:40 +02:00
fragment_saved_logins.xml For #10173: login duplicates and save (#11208) 2020-07-16 17:08:04 -05:00
fragment_search.xml For #8795: remove redundant ConstraintLayout around BrowserToolbar. (#12014) 2020-06-26 21:31:02 -04:00
fragment_select_bookmark_folder.xml Closes #4540 - Set correct tint for select bookmark folder icon (#4541) 2019-08-05 14:54:39 -07:00
fragment_share.xml For #2754 Add tab cards to share sheet (#5493) 2019-09-26 14:25:34 -07:00
fragment_sign_out.xml For #10851: Add end constraint for text view. 2020-05-25 17:49:39 -04:00
fragment_site_permissions_exceptions.xml For #9857: Create button style (#9858) 2020-04-15 15:49:02 -07:00
fragment_site_permissions_exceptions_item.xml Issue 5366 Vector Drawable Compat (#6904) 2019-12-05 19:54:32 -08:00
fragment_synced_tabs.xml For #10834 - Adding Sync Tabs Feature in Fenix 2020-06-01 16:52:40 -04:00
fragment_tab_tray_dialog.xml For #11342 - Fixes missing space for the FAB 2020-06-11 18:25:57 -04:00
fragment_tracking_protection.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
fragment_tracking_protection_blocking.xml No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
fragment_turn_on_sync.xml For #9857: Create button style (#9858) 2020-04-15 15:49:02 -07:00
history_list_item.xml For issue #11835 - Update text fonts 2020-06-26 23:18:52 -04:00
layout_clear_permission_button.xml For #9857: Create button style (#9858) 2020-04-15 15:49:02 -07:00
layout_percentage_seek_bar.xml For #12105: Follow ux mock on Settings --> Accessibility screen 2020-07-16 10:37:20 -04:00
layout_url_background.xml Closes #6236: Fix padding lint issues (#6240) 2019-10-24 10:52:30 -07:00
library_site_item.xml For #8972 Replaced purple colors to match the rest of the app 2020-03-25 00:13:59 +02:00
list_element.xml Fixes #11134: Removes margin to allow collection title to expand 2020-06-19 17:27:57 +03:00
locale_settings_item.xml No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
logins_item.xml No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
migration_list_item.xml For #11004: Fix invisible text on migration UI 2020-05-28 15:48:42 -04:00
mozac_browser_menu_item_switch.xml For #1716 - Consolidate Switch Styles 2019-04-26 15:13:34 -07:00
mozac_ui_tabcounter_layout.xml For #5346 & For #8859: Fixes textSize & animation on TabCounter 2020-03-02 18:54:20 -08:00
navigation_toolbar.xml For #9505: Adds possibility to sort saved logins 2020-05-07 08:43:59 -07:00
no_collections_message.xml For issue #11835 - Update text fonts 2020-06-26 23:18:52 -04:00
onboarding_automatic_signin.xml Modified onboarding card colors according to design 2020-01-14 09:18:45 -08:00
onboarding_finish.xml For #9583: Increase touch targets for onboarding elements. 2020-06-02 09:26:38 -04:00
onboarding_header.xml No issue: Use ImageView rather than rebuilding drawable (#3616) 2019-06-26 16:03:06 -07:00
onboarding_manual_signin.xml For #9583: Increase touch targets for onboarding elements. 2020-06-02 09:26:38 -04:00
onboarding_privacy_notice.xml For #9583: Increase touch targets for onboarding elements. 2020-06-02 09:26:38 -04:00
onboarding_private_browsing.xml For #8643 and #7606 - Changed styles for most onboarding cards 2020-05-06 09:18:27 +03:00
onboarding_section_header.xml No issue: Use ImageView rather than rebuilding drawable (#3616) 2019-06-26 16:03:06 -07:00
onboarding_theme_picker.xml For #10501 - use theme instead of tint to support older APIs 2020-05-11 19:22:00 +03:00
onboarding_toolbar_position_picker.xml For #10501 - use theme instead of tint to support older APIs 2020-05-11 19:22:00 +03:00
onboarding_tracking_protection.xml For issue #10764 - Onboarding toggle color 2020-06-18 10:16:36 +03:00
onboarding_whats_new.xml For #10285: Swap TextView for a LinkTextView to improve links a11y 2020-06-26 18:11:11 +03:00
overlay_add_on_progress.xml Wire up UI to make add-on installation cancelable 2020-06-10 18:52:06 +03:00
pbm_shortcut_popup.xml For #10188: Fix layout constraints. 2020-04-24 13:28:53 -07:00
preference_cat_style.xml No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
preference_category_empty.xml For #11665: Adjust visual design for delete browsing data screens. 2020-06-19 09:32:37 +03:00
preference_default_browser.xml Close #420 - Default Browser Preference reacts to default browser status 2019-02-22 10:56:24 -08:00
preference_search_add_engine.xml For #12007: Follow ux mock on Settings --> Search screen (#12177) 2020-07-02 00:48:31 -07:00
preference_search_engine_chooser.xml Closes #877 - Add Search Engine Settings 2019-03-06 16:20:35 -08:00
preference_widget_radiobutton.xml No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
preference_widget_radiobutton_with_info.xml For #6180 - Set textAlignment to viewStart to fix RTL layouts. 2020-06-05 14:27:26 -04:00
private_browsing_description.xml For #10285: Swap TextView for a LinkTextView to improve a11y. 2020-06-26 09:15:44 +03:00
quicksettings_permissions.xml Closes #9529: changed styling for permissions dialog to set proper padding 2020-05-28 16:08:07 -07:00
quicksettings_tracking_protection.xml Bug 1643132 - Remove native "Report site issue" functionality. 2020-06-04 18:23:11 -04:00
quicksettings_website_info.xml For #6317 - Applies 3dot menuItem look to quickSettings and tracking panel 2020-03-23 12:26:52 -07:00
save_to_collection_button.xml For #9857: Create button style (#9858) 2020-04-15 15:49:02 -07:00
saved_logins_sort_items_toolbar_child.xml For #9505: Adds possibility to sort saved logins 2020-05-07 08:43:59 -07:00
search_engine_radio_button.xml For #12007: Follow ux mock on Settings --> Search screen (#12177) 2020-07-02 00:48:31 -07:00
search_suggestions_onboarding.xml For #10285: Swap TextView for a LinkTextView to improve links a11y 2020-06-26 18:11:11 +03:00
search_widget_cfr.xml For #9488: Add search widget CFR 2020-05-28 15:15:25 -07:00
search_widget_extra_small_v1.xml Issue #8277: Reuse app icon in widget layout. 2020-02-17 11:37:15 +01:00
search_widget_extra_small_v2.xml Issue #8277: Reuse app icon in widget layout. 2020-02-17 11:37:15 +01:00
search_widget_large.xml Fix ignored XML lint issues (#12094) 2020-06-29 16:36:52 -07:00
search_widget_medium.xml Fix ignored XML lint issues (#12094) 2020-06-29 16:36:52 -07:00
search_widget_small.xml For #8641 - Update addon text selector to use attr colors 2020-02-27 12:40:57 -08:00
search_widget_small_no_mic.xml Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944) 2019-08-29 12:55:51 -07:00
share_close.xml For #9545: Split button to allow distinct focus for a11y services. 2020-06-02 09:33:32 -04:00
share_tab_item.xml For #2754 Add tab cards to share sheet (#5493) 2019-09-26 14:25:34 -07:00
share_to_account_devices.xml For #4007 - Refactor AppShareView in standalone Share Views 2019-08-29 18:12:50 -07:00
share_to_apps.xml For #11177 - Load all share targets in the horizontal share menu 2020-06-11 15:08:36 +03:00
sign_in_preference.xml For #5497 Improve sync title/summary settings to support RTL 2019-10-24 10:32:59 -07:00
stub_find_in_page.xml For #4066: Provide lazy inflation of Find In Page View 2019-08-09 11:48:55 -04:00
switch_with_description.xml For #9805: Increase touch target for etp panel switch. 2020-06-02 09:25:51 -04:00
sync_tabs_list_item.xml For #11641: Update synced tabs view 2020-06-26 18:11:13 -04:00
tab_header.xml Issue 5366 Vector Drawable Compat (#6904) 2019-12-05 19:54:32 -08:00
tab_list_row.xml No issue - Add content descriptions when missing 2020-03-27 14:41:51 -07:00
tab_tray_item.xml For #12002: Show default tab background when thumbnail not available (#12041) 2020-06-26 20:46:23 -04:00
top_site_item.xml For #11666: TopSites layout from Constraint to Linear (#11669) 2020-06-17 19:18:14 -04:00
top_sites_header.xml For #9525 - Add bottom margin to top sites header 2020-03-30 14:48:45 -07:00
tracking_protection_category.xml No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
tracking_protection_learn_more_preference.xml For #6180 - Set textAlignment to viewStart to fix RTL layouts. 2020-06-05 14:27:26 -04:00
tracking_protection_onboarding_popup.xml For #11229: Update ETP cfr string and behaviour. 2020-06-05 14:18:25 -04:00
view_synced_tabs_group.xml For #12263 - Adds end margin to synced tabs header 2020-07-06 15:37:53 -04:00