1
0
Fork 0
Commit Graph

88 Commits (f49331de55194a33c2ac1a317d9fc5abf880b6e0)

Author SHA1 Message Date
ekager f49331de55 For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
bswe 052695ffa1 Issue #5233: Minor modifications suggested in code review. 2019-10-14 11:20:18 -07:00
bswe 9913a024d8 Issue #5233: Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "add private browing shortcut" item is visible in the settings menu. 2019-10-14 11:20:17 -07:00
MozLando 8cf54f773b Merge #5882
5882: For #5873 Added on/off indicator for delete browsing data on exit pref r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-11 13:22:33 +00:00
Sawyer Blatz b0d796ccee
For #5898: Default browser toggle sends user to SUMO on Android 5&6 (#5918) 2019-10-10 11:16:21 -07:00
mcarare 788e52be0c For #5873 Added on/off indicator for delete browsing data on exit pref 2019-10-09 11:55:37 +03:00
mcarare 22eb207cef For #5784: Fix hiding default browser preference in sdk<=23 2019-10-04 12:41:12 -07:00
Sawyer Blatz 371e2ac3d8
For #514 & #5742: Updates "launch links in private tab" functionality (#5721)
* For #514 & #5742: Updates "launch links in private tab" functionality

* Fixes comments
2019-10-03 12:43:33 -07:00
Sawyer Blatz 2896b36d14
No issue: Updates naming of launch links privately var (#5701)
The previous name was pretty confusing
2019-10-02 12:11:21 -07:00
Sawyer Blatz eb3c9f86e2
No issue: Removes feature flags for delete data (#5738) 2019-10-02 10:43:37 -07:00
Tiger Oakes 8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Emily Kager 9d9ff959b5 For #5312 - Add Telemetry for Tracking Protection 2019-09-23 08:29:45 -07:00
Tiger Oakes 6c30a94081 Move settings classes to packages 2019-09-20 12:36:15 -07:00
Sawyer Blatz 6f3d7b4ee8 For #5396: Adds "always launch in private mode" to settings 2019-09-20 08:33:07 -07:00
Sawyer Blatz 50cd2920d3
For #5371: Updates search engine settings string (#5393) 2019-09-18 11:26:44 -07:00
Emily Kager e3209dcc84 For #3700 - Add Setting to Delete Data on "Quit" menu action 2019-09-11 16:06:18 -07:00
Yeon Taek Jeong ddc1b2e648 For #4658: Add private browsing mode shortcut telemetry 2019-09-11 16:03:22 -07:00
Yeon Taek Jeong 2e2bac4ccd
For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
Tiger Oakes b77c4d2e2e Clean up SupportUtils 2019-09-10 10:16:04 -07:00
Mihai Adrian a31eb1f371 Code Health #4883: Refactored accessing settings by using Context extensions (#4973) 2019-09-10 10:11:58 -07:00
Grisha Kruglov 231924f5eb Fix breaking services APIs changes 2019-09-05 13:38:15 +02:00
Tiger Oakes aab357845b No issue: Clean up preferences code (#4699) 2019-08-21 08:38:14 -07:00
Jonathan Almeida ec96d134ff No issue: Fix breaking AccountObserver API 2019-08-02 13:40:50 -04:00
Colin Lee 3dc20543e3
For #4128: Migrate Bookmarks to LibState (#4254) 2019-07-25 21:55:51 -05:00
Grisha Kruglov fe51bbcf7b Update FxA integration to new APIs 2019-07-11 13:19:37 +02:00
Emily Kager c81dd0a4a8 For #3772 - Update FXA sign in UI (#3933) 2019-07-10 21:20:06 -05:00
afr30010 c92eabdd64 Modify the order of Privacy Policy and About in Settings (#2760) 2019-07-08 12:16:18 -05:00
Tiger Oakes 30930cdc88 Import variables referred to by path 2019-06-25 13:57:34 -07:00
Tiger Oakes 55f5c5d049 Use lifecycleScope for settings fragments 2019-06-25 13:56:33 -07:00
Jeff Boek 7ebdfcc87b For #1116 - Uses alias link for help 2019-06-14 15:33:34 -07:00
Jeff Boek 5540230e3d For #1116 - Changes help link (#3491) 2019-06-14 15:29:10 -05:00
Jeff Boek 227a80957e For #382 - Include Marshmellow in the guard.. 2019-06-12 15:45:58 -07:00
Jeff Boek dad671ca3c For #382 - Hides default browser switch for older versions of Android 2019-06-12 15:07:58 -07:00
Grisha Kruglov fe3c163a20 Fix how we reflect FxA state in preference
This cleans up how we're displaying account state in the main preference UI.
Before when it worked, it worked mostly accidentally.
'launch' wrapper around "update ui" methods would trigger a race condition
between binding the account pref view holder and actually updating that view
with values. Sometimes the "update view with values" would happen after view
was bound, and the UI will be correct. Most of the time it would happen before,
and so there will be nothing to update and we'd get into an inconsistent state.

This also splits up the "accountpreference" into two: account is good,
and account needs re-auth. This greatly simplifies their management.
2019-06-05 14:38:06 -07:00
Sawyer Blatz c4c5d44430 For #975: Updates telemetry for settings (#3171) 2019-06-05 13:34:42 -05:00
Sawyer Blatz 5e0771a6f0 For #2327: Fix early return from displayAccountError 2019-05-30 13:45:56 -07:00
Sawyer Blatz b8c04e02e9 For #2327: Fixes nits 2019-05-30 11:45:39 -07:00
Sawyer Blatz fe50e88fc8 For #2327: Adds error state syncing 2019-05-30 11:45:39 -07:00
Arturo Mejia b2e27d26dc Closes #2903: Fixed crash when trying to rate the app on a devices without
the play store app.
2019-05-28 15:14:56 -07:00
Sawyer Blatz 9aa4f48e77 For #1190: Adds additional telemetry for FxA login 2019-05-24 17:39:19 -07:00
Sawyer Blatz 62bed0cd06 For #1190: Adds telemetry for FxA login 2019-05-24 17:39:19 -07:00
Jeff Boek 182bbdf359 For #225 - Adds delete browsing data fragment 2019-05-24 17:16:03 -07:00
Sawyer Blatz 36f4b97712 For #658: Adds your rights page link 2019-05-24 11:32:27 -07:00
Emily Kager 7951a5f5df No issue: Update Account UI and visibility in onCreate so it doesn't flash (#2804) 2019-05-23 16:52:31 -07:00
Denys M 6b8938e47e Fixes #2739. Update sign-in preference visibility when screen is resumed. 2019-05-23 15:34:29 -07:00
Jeff Boek 16b3309053 For #2531 - Adds privacy notice to settings 2019-05-21 21:34:06 -07:00
Emily Kager c2339e9669 Closes #2699 - Removes Feedback from Settings 2019-05-21 13:37:00 -07:00
ekager 42d1491976 Closes #2635 - Save settings changes to new Shared Preferences file 2019-05-20 08:58:45 -07:00
Vlad Filippov 66a0cd5f9c Add FxA Pairing feature to "Turn On Sync" 2019-05-14 22:48:40 -07:00
Jeff Boek 27d8c09def
Fixes #1735 - adds the ability to write code against the build channel (#2388) 2019-05-09 22:05:49 +00:00