ab6e7dc52b
Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
2019-08-20 13:45:55 +02:00
b8c93107c0
For #4744 - Extract TransitionPreDrawListener ( #4812 )
2019-08-19 16:27:43 -07:00
a632d8f1dc
For #4744 - Move search bar icon padding to dimens ( #4814 )
2019-08-19 16:22:51 -07:00
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
f71106cb51
Closes #3860 - Update description text for collections
2019-08-14 17:13:52 -04:00
42e3b2771e
fix #4633 : show toast only on first login ( #4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
2019-08-13 16:28:34 -05:00
5aac05859d
Fix #4436 : hide onboarding before navigating to settings ( #4675 )
...
* Fix #4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
2019-08-13 15:49:42 -05:00
0c8bcd39be
For #4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
2019-08-12 15:51:49 -04:00
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
ef97173cd9
For #4529 , #4427 : Resuming after restoring instance state breaks UI ( #4571 )
...
* For #4529 , #4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
2019-08-08 11:05:01 -05:00
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
4566bd6fba
Fixes feedback
2019-08-07 16:41:29 -07:00
9d65e665e5
No issue: Removes deprecated usage of ViewModelProviders
2019-08-07 19:21:41 -04:00
969d17b4a9
For #969 : Adds more telemetry for collections ( #4539 )
2019-08-07 16:05:20 -07:00
d0071d0177
For #4495 - Clean up homescreen toolbar focus and content descriptions
2019-08-05 08:58:03 -07:00
015922ddd2
No issue: Fix Crash lower API by setting gradient drawables in onBind
2019-08-02 16:18:34 -07:00
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
da59e36c1b
Fixes #4410 : Modified visibility of 'Add Tab' button.
...
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
2019-08-02 08:49:50 -07:00
ae33234bbc
Closes #2593 : FxA automatic sign-in integration
2019-08-01 17:03:45 -07:00
2e7a61860a
For #969 : Adds more telemetry for collections ( #4358 )
2019-07-31 17:07:41 -07:00
87d8f3b037
Remove redundant super calls
2019-07-29 10:22:53 -07:00
88c05a5f43
Use glide-like image loading function
2019-07-29 10:22:23 -07:00
ccfaa3826b
For #2142 : Added accessibility focus
2019-07-29 09:26:33 -07:00
d5eeadda66
Closes #2142 : Enable private browsing button is focused instead of Search or address
2019-07-29 09:26:33 -07:00
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
c74cb61455
fixes #4176 ( #4175 )
...
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
2019-07-19 14:23:10 -05:00
13198f56df
For #969 : Adds telemetry for collections ( #3935 )
2019-07-18 16:05:42 -07:00
6da6ddb095
Use StateListDrawable & resources w/ TabCollection
2019-07-18 15:29:06 -04:00
451093fd9e
Closes #2560 - Updates Private Browsing explanation string
2019-07-18 15:27:59 -04:00
447123367a
Remove unused sessions resources
2019-07-16 09:15:50 -07:00
f8ef0225e1
Use updated feature-tab-collections API. ( #4056 )
2019-07-15 09:58:33 -07:00
5de1678e65
No issue: Use putCompoundDrawables helper ( #3982 )
2019-07-15 08:24:59 -07:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
fe51bbcf7b
Update FxA integration to new APIs
2019-07-11 13:19:37 +02:00
c81dd0a4a8
For #3772 - Update FXA sign in UI ( #3933 )
2019-07-10 21:20:06 -05:00
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
2019-07-10 14:13:10 -04:00
5a204f0bbc
For #3818 : Handle crashes accessing view after onDestroyView ( #3942 )
2019-07-08 18:42:17 -05:00
9901514766
Replace deprecated pxToDp ( #3932 )
2019-07-08 14:45:07 -05:00
7a51ee3915
For #3734 - Don't SwipeToDelete RecyclerView without windowfocus ( #3839 )
2019-07-02 14:42:50 -07:00
99209aa9da
Closes #3268 - Change Tab Favicon Border Radius to 4 ( #3856 )
2019-07-02 14:42:20 -07:00
8cd1a0cb38
Move adapter Job setup code to helper class ( #3407 )
2019-07-01 13:34:25 -05:00
7e46e71d00
For #3005 : Closes tabs when saving to collection ( #3723 )
2019-07-01 11:39:48 -05:00
2d6ebb986d
Revert "For #3135 - Reduce swipe to delete sensitivity"
...
This reverts commit 94881f8241
2019-06-28 12:47:36 -07:00
f375eac6bd
For #3732 : Race Condition Crash in HomeFragment onPreDraw ( #3737 )
2019-06-27 20:33:21 -05:00
13df8d7ddd
For #3711 : Fixes save to collection from browser crash ( #3714 )
2019-06-27 11:29:00 -07:00
e8bd090a8e
No issue: Use ImageView rather than rebuilding drawable ( #3616 )
...
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
4994554576
No issue: Adds lint exception for when statement ( #3685 )
2019-06-26 15:52:24 -07:00
30930cdc88
Import variables referred to by path
2019-06-25 13:57:34 -07:00
d01bb8c442
Use lifecycleScope for collections fragments
2019-06-25 13:56:15 -07:00
ddebc98718
No issue: Follow up on optional filter style
2019-06-24 17:03:38 -07:00
718ac5612c
For #3593 For #3581 - Pass sessions to delete to delete all with undo ( #3594 )
2019-06-24 15:41:38 -07:00
07516f47c3
For #3215 : Adds collection restoration with unique IDs ( #3635 )
2019-06-24 14:12:51 -07:00
03a5cb2fb4
For #3620 - Adds automatic theme onboarding content description ( #3629 )
2019-06-24 13:15:38 -07:00
ab6101b0f4
Fixes #3539 - vectordrawablecompat for gradients ( #3541 )
2019-06-18 16:38:56 -07:00
ccc5b91992
Import PR 3500 from ekager
2019-06-14 18:52:27 -07:00
6e6e662c47
Update HomeFragment.kt
2019-06-14 18:34:58 -07:00
90bdbd04e0
No Issue - Capture session manager in scope before creating the delete operation
2019-06-14 18:34:58 -07:00
7ebdfcc87b
For #1116 - Uses alias link for help
2019-06-14 15:33:34 -07:00
5540230e3d
For #1116 - Changes help link ( #3491 )
2019-06-14 15:29:10 -05:00
f323c38be0
For #981 - Adds missing Leanplum events
2019-06-14 13:27:50 -07:00
d5c5587a0c
For #3209 : Disable shared element animations for crash temporarily ( #3482 )
2019-06-14 12:13:13 -05:00
041eaa2a5c
For #3275 : Cleans up feedback from James ( #3398 )
2019-06-14 08:59:57 -07:00
1f1320920f
For #3275 - Invoke pending single session delete job on close all ( #3438 )
2019-06-13 12:58:45 -05:00
510b6f7373
For #2899 - Improve collections scroll and highlight animations
2019-06-13 09:21:12 -07:00
186983b786
For #3275 - Adds PendingSessionDeletion data class to handle multiple emit session calls ( #3393 )
2019-06-12 10:49:20 -07:00
66a836cf3a
For #3314 : Toolbar and QAB unresponsive after Android 6 perms check ( #3373 )
2019-06-12 10:08:39 -05:00
f05eb032d4
For #2684 : Add an extension function Session.toTab to map Session to Tab and clean up their usage
2019-06-11 13:14:23 -07:00
82cf81242f
For #3331 - Delay restoring layout while list restores ( #3354 )
2019-06-11 12:27:32 -05:00
decacbfc97
For #3323 Runs PublicSuffixList synchronously
2019-06-11 09:19:51 -07:00
e57e7b50ee
For #2899 - Scroll to Collections on change, animate new collections ( #3279 )
...
* For #2899 - Scroll to Collections on change, animate new collections
* For #2899 - Scroll to tabs when tabs opened from collection
2019-06-11 09:01:00 -05:00
ab000d2e51
For #3280 : Revert "For #3215 : Restores collections properly" ( #3320 )
...
This reverts commit 3e9ee79c00f4a6b34af74ce7c179e0cbe37decf5.
2019-06-10 13:54:03 -07:00
5df726715f
Revert "For #3008 , For #2162 Add Simple Logic for Menu Orientation" ( #3310 )
...
#3114
2019-06-10 10:58:18 -05:00
054635735a
For #2750 : Removes unecessary invalidate CollectionViewHolder call ( #3264 )
2019-06-07 13:38:18 -07:00
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
2019-06-07 09:33:07 -07:00
7368a95d29
No issue: Sets up observers for tab collection changes ( #3248 )
2019-06-07 09:45:38 -05:00
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
acea0d5668
For #2785 - Adds back item animator session control ( #3233 )
2019-06-06 16:54:49 -05:00
8537ff10a8
For #3215 : Restores collections properly ( #3219 )
2019-06-06 14:26:05 -05:00
4954aadd84
For #3156 - If only one tab adding to collection make it selected ( #3222 )
2019-06-06 14:24:25 -05:00
704f1e6a3d
For #3004 - Restore MotionLayout on Home View only in onCreateView
2019-06-05 14:46:38 -07:00
14c581c012
For #3004 - Do not restore motionlayout state in ReloadData
2019-06-05 09:33:07 -07:00
94881f8241
For #3135 - Reduce swipe to delete sensitivity
2019-06-04 16:10:28 -07:00
87f6268816
For #3101 - Do not show tab selection screen for 1 tab
2019-06-04 10:08:43 -07:00
dc0d153580
For #3008 , For #2162 Add Simple Logic for Menu Orientation ( #3114 )
...
* For #3008 - Adjust orientation of collections menu based on view location
* For #2162 - Add simple menu orientation logic to bookmark menu
2019-06-04 10:37:57 -05:00
388581f76f
For #3056 - Filter sessions on invoke for pending delete all job
2019-05-31 18:52:02 -07:00
d5a9627273
For #2941 - Remove Delete Dialog, Theme Dialogs ( #3052 )
2019-05-31 16:26:34 -05:00
14f1d40e10
Fixes #3041 - Fixes the string that gets displayed in the FxA Onboarding card
2019-05-31 10:44:14 -07:00
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
8dbed67f7f
No issue: Simplify and speed up shared element transitions
2019-05-30 16:30:06 -07:00
4c970a545d
For #2230 - Fix theme selection radio button for Android 6 ( #3019 )
2019-05-30 17:06:46 -05:00
b8c04e02e9
For #2327 : Fixes nits
2019-05-30 11:45:39 -07:00
fe50e88fc8
For #2327 : Adds error state syncing
2019-05-30 11:45:39 -07:00
caa36c31cd
For #2979 - Prevent double navigation to Create Collection Fragment
2019-05-30 10:58:56 -07:00
5f42a65c2a
No issue: improve allowUndo
...
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on
New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
2019-05-30 10:48:59 -07:00
e61cebf38d
No issue: Check search engine icon exists before setting drawable
2019-05-30 08:33:30 -07:00
8bed44819d
Fixes #2254/#2709. Observe browser sessions changes on `HomeFragment`.
2019-05-29 15:13:15 -07:00
d6c1f65d72
Start MotionLayout animation to end while navigating to search fragment
2019-05-29 12:27:48 -07:00
dee3c059dc
Adds Shared Transition between Home and Search
2019-05-29 12:27:48 -07:00
6a53127ef9
For #2948 : Adds menu button add tab to collection
2019-05-29 09:08:11 -07:00
3da6cfd98a
For #2886 : Fix sending multiple tabs to another device ( #2923 )
...
* For #2886 : Fix sending multiple tabs to another device
* Update share methods to use new API
2019-05-28 15:05:16 -07:00
506f332b85
For #2919 - Invoke Pending Delete Jobs in onPause
2019-05-28 14:59:05 -07:00
7d65e21b83
For #2941 - Creates delete dialog style
2019-05-28 13:41:38 -07:00
250548a72f
For #2823 - Invoke pending jobs with context on switch to private mode
2019-05-28 12:48:02 -07:00
e3031378bc
For #225 - Address small nits, changes default color of ic_delete
2019-05-24 17:16:03 -07:00
01c9317be0
For #2843 - Improve Collections UI and UX ( #2851 )
2019-05-24 17:06:17 -07:00
207a8d6772
Use a ListAdapter for SessionControl
2019-05-24 13:13:52 -07:00
09588dfda6
For #2529 - Remove "Delete Collection" button from private browsing
2019-05-24 10:53:15 -07:00
4e13de3ffd
No issue: Register observers with owner view
2019-05-24 10:53:05 -07:00
0c8ad3ef6e
For #2721 - Reorder onboarding theme settings ( #2817 )
2019-05-23 23:34:11 -07:00
f51e221a99
Remove unused import
2019-05-23 13:41:00 -07:00
895ba021e7
Hide toolbar in activity and remove label from home fragment
2019-05-23 13:41:00 -07:00
c7af502db7
Restore progress
2019-05-23 13:41:00 -07:00
0e64ead75c
Try to pop up to home if it exists on stack from browserfragment
2019-05-23 13:41:00 -07:00
40f2fe5166
For #1287 - Create animation for opening and closing tab from home
2019-05-23 13:41:00 -07:00
832fd71afc
For #2784 : Removes undo from collection deletion ( #2786 )
2019-05-23 12:16:40 -07:00
eb7646f073
Add custom share sheet and send tab support ( #2757 )
...
* Closes #2751 : Add custom app share sheet
* Closes #2753 : Add send tab devices to share sheet
* Closes #2752 : Add build flag for send tab
* Replace Context.share with ShareFragment
2019-05-23 10:48:22 -07:00
bf28462c47
For #2717 - Hides onboarding card when signed into a firefox account
2019-05-23 10:26:55 -07:00
ab590df18b
For #2717 - Adds auto signed in state to the accounts onboarding card
2019-05-23 10:26:55 -07:00
f4f35bdde0
Closes #2713 : Weave in "onboarding state" and split adapter items accordingly
...
we're ensuring that it has been initialized.
I wonder if we could just make background services load eagerly (they're lazy init now), instead.
2019-05-23 10:26:55 -07:00
220a843534
For #2205 : Updates collection title constraints
2019-05-23 08:33:42 -07:00
a1d32127ab
For #2655 : Adds undo snackbar for closing all tabs
2019-05-23 07:26:00 -07:00
5ec783f6e5
For #2719 - Fixes crash by registering to observer with a lifecycle owner
2019-05-21 21:43:33 -07:00
e7ecd49353
For #1578 : Adds delete collection with undo
2019-05-21 14:02:56 -07:00
394a207fea
Revert "For #1578 : Adds delete collection with undo"
...
This reverts commit 63a4567521
2019-05-21 13:04:47 -07:00
63a4567521
For #1578 : Adds delete collection with undo
2019-05-21 11:03:44 -07:00
93d0982a6f
For #1576 : Adds tab collection renaming
2019-05-21 10:34:42 -07:00
f73bb22955
No issue: Removes usage of COLLECTIONS_ENABLED flag
2019-05-21 10:34:30 -07:00
0c022f6646
For #1826 - Create ViewModel for Restoring Home Scroll Position
2019-05-21 10:29:15 -07:00
4b186eb86d
No issue: Save/Restore State in HomeFragment
2019-05-21 10:29:15 -07:00
0080e7d701
For #2584 : Adds opening a single tab from tab collection
2019-05-21 09:42:40 -07:00
a3f25b9f77
For #2584 : Adds opening tab collections
2019-05-21 09:42:40 -07:00
afbe397f94
For #1575 : Enables adding tabs to existing collection
2019-05-21 09:39:55 -07:00
7e7edc8b7a
For #2377 : Adds share to tabs and tab collections
2019-05-21 09:37:04 -07:00
1cd50ba9cb
No Issue - Fixes nits in #2669
2019-05-20 23:32:58 -07:00
a041d9ef74
For #2391 - Dismiss tour when navigating to search or settings
2019-05-20 23:32:58 -07:00
479c00bc5f
No Issue - Always complete motionLayout transition on restore
2019-05-20 23:32:58 -07:00
692724be2f
For #2395 - Navigates to turn on sync on button press
2019-05-20 23:32:58 -07:00
9a76c11dae
For #2389 - Save state on homeview when switching themes
2019-05-20 23:32:58 -07:00
b3650cacff
For #2399 - Wires up tracking protection onboarding card
2019-05-20 23:32:58 -07:00
a2a4524e51
For #982 - Opens privacy policy in a custom tab
2019-05-20 23:32:58 -07:00
591f367806
For #2392 - Adds icon to private browsing onboarding card
2019-05-20 23:32:58 -07:00
2dc76dda6a
For #2392 - Centers private browsing icon
2019-05-20 23:32:58 -07:00
291df48c4e
Install the "icons" WebExtension to automatically load icons for every visited website.
2019-05-20 19:34:49 -07:00
ba790c5dd3
No issue: remove unused restore state code
2019-05-20 19:29:28 -07:00
ec1a0e6c34
Revert #2533 : Removes feature flag for tab collections
2019-05-20 15:22:45 -07:00
3619f1417d
For #1574 : Cleans up unused code and refactors
2019-05-20 14:31:17 -07:00
7861a80715
For #2205 : Truncates tab collection titles
2019-05-20 14:31:17 -07:00
4e6f9b9ef1
For #1574 : Displays previous tab collections when creating
2019-05-20 14:31:17 -07:00
30a643720f
For #1574 : Adds tab collection creation
2019-05-20 14:31:17 -07:00
d347f73e69
For #2389 - Create Theme Onboarding Card
2019-05-20 11:10:20 -07:00
Mugurell